B7ET73N2K
2017-10-07 11:21:14
[cucumber/cucumber-jvm] mpkorstanje requested changes to #1238: optimized MethodScanner.scan method to not unnecessarily check for all cucumber annotations
<p>Might be even more efficient to use Method.getAnnotation(Class<T> annotationClass) rather then checking all annotations. Then we can replace this for loop with two null checks.</p>
B7ET73N2K
2017-10-09 00:53:18
[cucumber/cucumber-jvm] lsuski commented on #1238: optimized MethodScanner.scan method to not unnecessarily check for all cucumber annotations
<p>I'm not sure about it. Could you clarify? Based on previous logic one method can be annotated with Before/After and any number of step annotations - we can't achieve it without loop. Second thing is that we are not able to get step annotation e.g. <code>@Given</code> using <code>Method.getAnnotation(Class annotationClass)</code> because we don't know what annotation is used (actually cucumber does not care if it is <code>@Given</code> or <code>@Then</code> it just should be annotation that itself is annotated with <code>@StepDefAnnotation</code> ), eventually this code won't work: <code>method.getAnnotation(StepDefAnnotation.class)</code></p>
B7ET73N2K
2017-10-13 08:40:20
[cucumber/cucumber-jvm] aslakhellesoy commented on #1248: [WIP] Cucumber expressions
<p>You don't need a capture group here. Only use capture group if you want to capture more than one thing.</p>
B7ET73N2K
2017-10-14 05:29:14
B7ET73N2K
2017-10-26 11:49:21
B7ET73N2K
2017-10-26 12:00:30
[cucumber/cucumber-jvm] mpkorstanje commented on #1272: Add supported JUnit annotations to javadoc
<p>I think this should be rephrased to: "Cucumber supports the {@link ClassRule}, {@link BeforeClass} and {@link AfterClass} annotations." and moved to the end of the java doc.</p>
<p>In this instance I think it should be "should not" </p>
B7ET73N2K
2017-12-06 12:10:24
[cucumber/cucumber-jvm] mpkorstanje commented on #1289: cache matched steps definitions in RuntimeGlue
<p>So rather then invalidating the cache entry when dealing with a duplicate step it might be better to store a list of cache entries. When upon fetching the list from the cache, the list contains multiple entries we can throw the <code>AmbiguousStepDefinitionsException</code>.</p>
B7ET73N2K
2017-12-07 10:05:26
[cucumber/cucumber-jvm] mpkorstanje requested changes to #1289: cache matched steps definitions in RuntimeGlue
<p>To stay consistent with the rest of this method it would be preferable to remove the else clause and simply throw the exception as the last statement in the method.</p>
<p>Please remove.</p>
<p>This should be a name that describes what the test is testing. This may require splitting up this test case into separate smaller test cases.</p>
B7ET73N2K
2017-12-08 18:30:24
B7ET73N2K
2017-12-08 18:31:17
B7ET73N2K
2017-12-08 18:32:17
B7ET73N2K
2017-12-08 18:32:17
B7ET73N2K
2017-12-08 18:33:19
B7ET73N2K
2017-12-08 18:34:20
B7ET73N2K
2017-12-11 18:46:21
[cucumber/cucumber-jvm] mpkorstanje requested changes to #1298: Add detail to DataTable hint in JavaSnippet and update test
<p>I think 'The field names of YourType must match the column names' is better.</p>
<p>Field names instead of variables. The latter exists only in a function. The former is part of a type.</p>
<p>And must instead of make sure because of the rfc.</p>
<p>Not sure about the subject and object. Swapping might be better (if only someone told me learning grammar would allow me to discuss the use of language :) ). </p>
B7ET73N2K
2017-12-15 17:09:18
[cucumber/cucumber-jvm] mpkorstanje commented on #1298: Add detail to DataTable hint in JavaSnippet and update test
<p>I found some code that suggests the field name don't need to be an exact match.</p>
<p><code>My Field</code>, <code>MyField</code>, <code>myField</code> will all match <code>myField</code>.</p>
B7ET73N2K
2017-12-27 01:15:28
[cucumber/cucumber-jvm] mlvandijk commented on #1306: Add readme to cucumber-junit
<p>See above. If any changes are made based on those comments, please update accordingly also here.</p>
<p>[text edit suggestion] "This will execute all scenarios in the <em>same</em> package <em>as</em> the runner; by default glue code is assumed to be in the same package."</p>
<p>[suggestion] Add an example of how to use the '@CucumberOptions'?</p>
<p>This paragraph might not be clear Cucumber users who are not full-on software developers (yet). </p>
<p>Particularly:</p>
<p>"Cucumber supports JUnits <code>@ClassRule</code>, <code>@BeforeClass</code> and <code>@AfterClass</code> annotations. These will be invoked around the
+suite of features. " => what does it mean to run 'around the suite of features'? Is this like a BeforeAll/AfterAll?</p>
<p>"Using these is not recommended as it limits the portability between different runners. " => what is 'portability between different runners'? Why is limiting this a bad thing?</p>
<p>"Instead it is
+recommended to use Cucumbers <code>Before</code> and <code>After</code> hooks to setup scaffolding." => How to use 'Before' and 'After' hooks? What is 'setup scaffolding'?</p>
<p>Maybe this is not the place to answer all of these questions, but I think this could be clarified a little to be clearer to a wider audience.</p>
B7ET73N2K
2017-12-27 06:47:24
B7ET73N2K
2017-12-27 06:49:20
B7ET73N2K
2017-12-27 11:56:22
B7ET73N2K
2017-12-27 12:03:23
B7ET73N2K
2018-01-07 08:26:23
B7ET73N2K
2018-01-07 08:26:23
B7ET73N2K
2018-01-07 08:27:26
B7ET73N2K
2018-01-07 08:27:26
B7ET73N2K
2018-01-07 08:27:26
B7ET73N2K
2018-01-29 19:59:21
[cucumber/cucumber-jvm] mlvandijk commented on #1094: Android: Fix Cucumber execution on Gradle
<p>Should be added to the android README instead of in comments here?</p>
<p>Should this be done? (or remove "TODO"). In general, PR contains a several comments that should possible either be javadoc or be removed.</p>
B7ET73N2K
2018-01-29 23:33:18
[cucumber/cucumber-jvm] cgnuechtel commented on #1094: Android: Fix Cucumber execution on Gradle
<p>@mlvandijk Thanks for your feedback</p>
<p>Please look at the end of </cgnuechtel/cucumber-jvm/tree/master/examples/android/android-studio/Cukeulator/README.md|README.md></p>
<p>There is a reference to build.gradle. I think it is better to leave the technical details in build.gradle since it does not affect most users.</p>
B7ET73N2K
2018-01-30 01:48:20
[cucumber/cucumber-jvm] cgnuechtel commented on #1094: Android: Fix Cucumber execution on Gradle
<p>@mlvandijk Thanks again for your feedback</p>
<p>I removed the TODO comment, added/improved comments and hopefully made the test method more readable</p>
B7ET73N2K
2018-02-04 12:48:19
[cucumber/cucumber-jvm] brasmusson requested changes to #1094: Android: Fix Cucumber execution on Gradle
<p>What we want to do here is to calculate the unique name for the current test case, to divide this into two methods which are dependent and need to be called in order i s IMHO not the right solution (if this is driven from "command query separation", I do not think it is the right place for it). I think <code>getUniqueTestName</code> (maybe renamed <code>calculateUniqueTestName</code> to indicate that it is not just a getter) should both do the work and return the result.</p>
<p>Currently, the behavior tested is performed by <code>ensureUniqueTestName</code> (but I'm suggesting to change that).</p>
<p>I'm a big fan of "Test method names should be sentences (that specify/document the item under test)" (see <a href="https://dannorth.net/introducing-bdd/">https://dannorth.net/introducing-bdd/</a>), so I do not think this test is okay. The interesting behavior that should be specified/documented in test method names includes:
• test case names are made unique with numbered suffices
• the numbered suffices do not include blanks when test case names do not include blanks
• out of order identical test case names are also made unique
• running a test case several times will use the same name each time
• identical test case names in different feature will not be changed</p>
<p>This indicate the need to make a check for <code>null</code> when calling <code>getUniqueTestName</code> but it should not be used in such a way that will happen. For me it is another reason why <code>getUniqueTestName</code> and <code>ensureUniqueTestName</code> should be made into one method.</p>
<p>If this method did all the work I could be okay with it being package private and all details of its behavior tested by direct calls from the test class. Currently when its only use in test is to fetch data after <code>startTestCase</code> has been executed from the tests, I think it should be made private and the tests get the test names from the instrumentation (<a href="https://github.com/cucumber/cucumber-jvm/blob/master/android/src/test/java/cucumber/runtime/formatter/AndroidInstrumentationReporterTest.java#L141">like in this test</a>)</p>
B7ET73N2K
2018-02-05 03:00:30
[cucumber/cucumber-jvm] cgnuechtel commented on #1094: Android: Fix Cucumber execution on Gradle
<p>@brasmusson Thanks for your review. It was very helpful</p>
<p>I agree with your point, that my tests are too low-level, will correct it later</p>
B7ET73N2K
2018-02-14 12:16:29
B7ET73N2K
2018-02-14 12:48:27
[cucumber/cucumber-jvm] mpkorstanje commented on #1323: Adding AfterStep hook feature
<p>This also affects the <code>JSONFormatter</code>. Currently it assumes all hooks are either before or after hooks. Using after step hooks will have undefined results.</p>
B7ET73N2K
2018-02-14 12:50:28
[cucumber/cucumber-jvm] mpkorstanje commented on #1323: Adding AfterStep hook feature
<p>@brasmusson where do you think the <code>TestStepStarted</code> events for step hooks should go in the json? I am thinking they should go into the same list as the the test steps themselves.</p>
B7ET73N2K
2018-02-14 18:21:23
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>@mpkorstanje , I can see afterstep being reported properly in json report. Could you please let me know what exactly is the issue?</p>
B7ET73N2K
2018-02-14 23:19:22
B7ET73N2K
2018-02-14 23:20:23
B7ET73N2K
2018-02-15 00:17:24
B7ET73N2K
2018-02-15 00:19:23
B7ET73N2K
2018-02-15 01:27:23
B7ET73N2K
2018-02-15 01:30:26
B7ET73N2K
2018-02-15 01:31:24
B7ET73N2K
2018-02-15 02:06:22
[cucumber/cucumber-jvm] mpkorstanje commented on #1323: Adding AfterStep hook feature
<p>Right now cucumber represents execution as a series of steps. For completeness I'll assume there is also a before step hook. It might look like this:</p>
<p>```before hook
beforeStep hook
step1
afterStep hook
beforeStep hook
step2
afterStep hook
after hook</p>
<pre><code>
What it should try to achieve is:
```js
executeScenario(){
executeBeforeHooks()
executeSteps()
executeAfterHooks()
}
executeSteps(){
skipNextStep = false;
```for step in steps
skip = skipNextStep
beforeStepHook(skip)
skipNextStep = step(skip)
afterStepHook(skip)
skip = skipNextSte
</code></pre>
<p>}</p>
<pre><code>
What it currently does in TestCase:
```executeSteps(){
skipNextStep = false;
```for step in steps
skipNextStep = step(skipNextStep
</code></pre>
<p>}
```</p>
<p>So not only should after step hooks be skipabble, they should also only be skipped when their step was skipped.</p>
B7ET73N2K
2018-02-15 02:27:24
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>I got your point. Reason for not implementing BeforeStep is I do not see any use case for the same. If you see previous step-hook requests, they all requested for AfterStep hook which I also feel is useful in many scenarios.
I do not have an issue implementing BeforeStep, my only point is it should not be implemented just because we are implementing AfterStep</p>
<p>Coming to skipable hook, currently all Hooks are of class <em>UnskipableStep</em>, if I workaround that, it defeats the purpose of UnskipableStep class. Other option is to have class called <em>SkipableHookStep</em> for AfterStep (and if required, BeforeStep) hooks.</p>
<p>The logic you mentioned for skipping has a catch, Any failed step will set skipNextStep to true, But failed step should not skip its AfterStep. AfterStep should only be skipped for skipped Steps, not failed Step. I can see how that can be done.</p>
<p>Any thoughts on having a new Class <em>SkipableHookStep</em> for AfterStep/BeforeStep?</p>
B7ET73N2K
2018-02-15 02:45:26
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>Another option is to rename class <strong>UnskipableStep</strong> to <strong>HookStep</strong> and then internally handle whether to execute hook step or not in <strong>execute()</strong> method</p>
B7ET73N2K
2018-02-15 11:36:25
[cucumber/cucumber-jvm] brasmusson commented on #1323: Adding AfterStep hook feature
<p>Cucumber-Ruby does add AfterStep hooks as ordinary steps, so the AfterStep hooks for failed steps are skipped. This may not be ideal, but on the other hand inconsistency between Cucumber implementation is not ideal either, so we should try to get a common vision on where all the Cucumber implementation are heading.</p>
B7ET73N2K
2018-02-15 11:46:26
[cucumber/cucumber-jvm] brasmusson commented on #1323: Adding AfterStep hook feature
<p>> I can see afterstep being reported properly in json report
I do not see any test case that specify how after steps hooks are reported in the json report, so I think such a comment is premature.</p>
<p>In Cucumber-Ruby the AfterStep hooks are included in the json report in the "after" entry of each step, see <a href="https://github.com/cucumber/cucumber-ruby/blob/master/spec/cucumber/formatter/json_spec.rb#L671-L683">https://github.com/cucumber/cucumber-ruby/blob/master/spec/cucumber/formatter/json_spec.rb#L671-L683</a></p>
B7ET73N2K
2018-02-15 12:31:25
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>I will update the class to HookStep instead of Unskipable step and handle the logic of skipping AfterStep for a failed/skipped step. This will be in sync with ruby.</p>
<p>Let me know if that should be ok</p>
B7ET73N2K
2018-02-15 12:33:25
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>I will have to do some changes for JSONFormatter as there is some incosistency when compared with Ruby Json report. Will add a test for same</p>
B7ET73N2K
2018-02-17 22:54:19
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>@mpkorstanje , @brasmusson , I have implemented logic of skipping AfterStep in case of failed or skipped Step and also tests for JSON formatter showing AfterSteps JSON arry node should belong to it's respective step node.</p>
<p>Would you mind reviewing the changes?</p>
B7ET73N2K
2018-02-18 11:49:19
B7ET73N2K
2018-02-19 08:25:26
B7ET73N2K
2018-02-25 11:13:21
[cucumber/cucumber-jvm] brasmusson requested changes to #1323: Adding AfterStep hook feature
<p>Do not use wildcard imports, see <a href="https://github.com/cucumber/cucumber-jvm/blob/master/CONTRIBUTING.md#contributing">https://github.com/cucumber/cucumber-jvm/blob/master/CONTRIBUTING.md#contributing</a>.</p>
<p>The current convention in the code base is to use "<code>if (</code>" rather than "<code>if(</code>" (and "<code>switch (</code>" rather than "<code>switch(</code>"), so for the sake of consistency this convention should be followed in this PR too.</p>
<p>This test is confusing, it looks like it verifies that the after step hook is executed twice after step2 has been executed, but the expected behavior is that the hook is executed once in between step1 and step2 and once after step2. Can this test be change to better specify the expected behavior (and not look like it verifies the wrong behavior)?</p>
<p>As the intention is to move away from the Cucumber-HTML-project (see <a href="https://github.com/cucumber/cucumber-html/pull/44">https://github.com/cucumber/cucumber-html/pull/44</a>), I'm thinking about exploring the use of "<code>formatter.after</code>" also for after step hooks, instead of coupling this PR to a required change in the Cucumber-HTML (I'm not sure we want to open that Box of Pandora at this time).</p>
<p>The Json key should be "after" also for after step hooks, so that "before" and "after" are the Json key used for hooks both on the scenario level and the step level (see the Cucumber-Ruby spec <a href="https://github.com/cucumber/cucumber-ruby/blob/master/spec/cucumber/formatter/json_spec.rb#L677">https://github.com/cucumber/cucumber-ruby/blob/master/spec/cucumber/formatter/json_spec.rb#L677</a>).</p>
B7ET73N2K
2018-02-25 23:51:23
B7ET73N2K
2018-02-25 23:52:21
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>Yes, will fix this one. I think it happened due to Intellij formatting it to .** in case all the classes are being used and imported from package</p>
B7ET73N2K
2018-02-26 00:00:33
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>yes, I saw that in ruby but there is a small catch here. In the code every where I have used string representation of HookType enum , for eg <code>mapToAddTo.put(hookType.toString(), new ArrayList&lt;Map&lt;String, Object&gt;&gt;());</code>
So in this case I will have to explicitly handle the AfterStep case to report it as After</p>
B7ET73N2K
2018-02-26 00:01:29
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>This test was commented and was supposed to be removed as this behaviour is verified in other test. I will check once again and remove this test</p>
B7ET73N2K
2018-02-26 01:51:22
B7ET73N2K
2018-03-04 12:03:22
B7ET73N2K
2018-03-04 16:01:24
[cucumber/cucumber-jvm] mpkorstanje commented on #1323: Adding AfterStep hook feature
<p>I find it a bit hard to qualify why but the concept underlying this solution feels wrong. TestStep is leaking information into TestCase as to how the test should proceed. It shouldn't have to.</p>
<p>I think this is caused by trying to represent the test execution as a list of steps rather then the tree that it is (it may help to imagine the existence of a before step hook).</p>
B7ET73N2K
2018-03-04 16:43:23
[cucumber/cucumber-jvm] coding-yogi commented on #1323: Adding AfterStep hook feature
<p>I have one suggestion, why can't we have skipStep as binary bit flags, or bit array or a map for eg <code>{"skipBeforeStep": false, "skipGherkingStep": false, "skipAfterStep": false}</code></p>
<p>when step fails set <strong>skipGherkingStep</strong> to <strong>true</strong> but <strong>skipAfterStep</strong> still remains <strong>false</strong> and executes the afterStep. After execution of afterStep, if <strong>skipGherkingStep</strong> is true , set <strong>skipAfterStep</strong> to <strong>true</strong> so that none of the next afterStep executes</p>
B7ET73N2K
2018-03-05 18:59:20
[cucumber/cucumber-jvm] davidyscott commented on #1010: Allow global registration of custom XStream converters.
<p>I just came across this in attempting to use this feature (which is excellent!) It looks like <code>SingleValueConverter</code>s are treated separately from other <code>Converters</code> and are not type-compatible, so in order to properly use <code>SingleValueConverter</code>s with the global registration, there would need to be a second if statement here to handle them.</p>
B7ET73N2K
2018-03-07 12:08:25
[cucumber/cucumber-jvm] brasmusson commented on #1323: Adding AfterStep hook feature
<p><code>Ambiguous</code> and <code>Failed</code> both unconditionally make the exit code non-zero, but <code>Undefined</code> does not, so <code>Undefined</code> must be less severe than <code>Ambiguous</code>.</p>
B7ET73N2K
2018-03-07 12:31:22
B7ET73N2K
2018-03-12 10:54:27
[cucumber/cucumber-jvm] mpkorstanje commented on #1323: [Core] Add Before and AfterStep hooks
<p>I think it'd be better to explicitly check the hook type. <code>if (hookType == HookType.AfterStep || hookType == HookType.BeforeStep)</code> and flatten the nested if statement into <code>else if</code>.</p>
B7ET73N2K
2018-03-12 10:56:25
B7ET73N2K
2018-03-12 23:39:21
[cucumber/cucumber-jvm] coding-yogi commented on #1323: [Core] Add Before and AfterStep hooks
<p>This method call should also accept param <code>skipNextStep</code> instead of <code>skipSteps</code>. Currently if <code>skipNextStep</code> evaluates to <code>true</code> after a failed <code>BeforeStep</code>, the <code>step</code> is skipped but <code>AfterStep</code> still executes</p>
B7ET73N2K
2018-03-14 12:10:26
[cucumber/cucumber-jvm] mpkorstanje commented on #1323: [Core] Add Before and AfterStep hooks
<p>Why did you make this change? I would always expect an after step hook to run so it can clean up anything setup by a before step.</p>
B7ET73N2K
2018-03-14 12:40:27
B7ET73N2K
2018-03-14 16:01:25
[cucumber/cucumber-jvm] coding-yogi commented on #1323: [Core] Add Before and AfterStep hooks
<p>@mpkorstanje, if beforeStep fails, step is skipped but afterStep runs, is that a correct behaviour? for eg, I was taking a snapshot in after step and it appeared in the report even if the actual step was skipped from executing</p>
B7ET73N2K
2018-03-14 17:34:22
[cucumber/cucumber-jvm] mpkorstanje commented on #1323: [Core] Add Before and AfterStep hooks
<p>Yes. There may be multiple before steps. If a step other then the failing one allocates some resource then it should be deallocated in an after step. Skipping the after step execution will leave that resource allocated and may cause a leak.</p>
B7ET73N2K
2018-03-17 12:35:21
[cucumber/cucumber-jvm] brasmusson commented on #1323: [Core] Add Before and AfterStep hooks
<p>I think <code>Step</code>should be reserved for gherkin steps (<code>gherkin.ast.Step</code>) and use <code>cucumber.runner.TestStep</code> (the same pattern as <code>cucumber.api.HookTestStep</code> and <code>cucumber.runner.HookTestStep</code>)</p>
B7ET73N2K
2018-03-17 12:39:19
[cucumber/cucumber-jvm] brasmusson commented on #1323: [Core] Add Before and AfterStep hooks
<p>I'm not sure about <code>PickleTestStep</code>. Is it a test step of a pickle? No pickles does not contain test steps but pickle steps. Is it a test step created from a pickle? No it is a test case that is created from a pickle. I'm considering <code>PickleStepTestStep</code>, maybe a bit cumbersome but clear on that it is a test steps created from a pickle step.</p>
B7ET73N2K
2018-03-17 14:01:22
B7ET73N2K
2018-03-17 14:06:22
[cucumber/cucumber-jvm] mpkorstanje commented on #1323: [Core] Add Before and AfterStep hooks
<p>I've renamed it to <code>PickleStepTestStep</code>. I'm generally not enamored by the <code>ClassNameParentClassName</code> pattern for the exact reasons you mentioned but anything else leads to clashes with the Gherkin namespace.</p>
B7ET73N2K
2018-04-07 13:42:22
[cucumber/cucumber-jvm] mpkorstanje requested changes to #1342: [Core Bug Fix] Fixed runtime exit status for ambiguous scenarios
<p>Looking at <a href="https://github.com/cucumber/cucumber-jvm/pull/1342/files#diff-9c2af73a8f4e34a02a035f2709e487d5R157">printNonZeroResultScenarios</a> I think <code>ambiguousScenarios</code> should be treated the same as <code>failedScenarios</code> and always return a non zero exit status. </p>
<p>@brasmusson This section feels like it's duplicating some functionality we have elsewhere already. I think we can improve this by using <a href="https://github.com/cucumber/cucumber-jvm/pull/1323/files#diff-9d1a886ccf16aa0bf49cc278dd2604d0R9">Result.SEVERITY</a> from #1323 to find the worst the results and use <a href="https://github.com/cucumber/cucumber-jvm/pull/1323/files#diff-9d1a886ccf16aa0bf49cc278dd2604d0R80">Result.isOk(strict)</a> to determine the exit code status.</p>
B7ET73N2K
2018-04-08 11:15:26
[cucumber/cucumber-jvm] brasmusson commented on #1342: [Core Bug Fix] Fixed runtime exit status for ambiguous scenarios
<p>Yes, it sure feels as duplication. Somehow, both here and in <code>printNonZeroResultScenarios</code>, <code>Result.isOk</code> should be used (instead of duplicating its logic). </p>
B7ET73N2K
2018-04-13 10:06:28
[cucumber/cucumber-jvm] mpkorstanje commented on #1345: Tycho surefire
<p>What is the purpose of this file? Is it required?</p>
<p>By convention all classes intended for use by the end user go into a sub package of <code>cucumber.api</code>. For example <code>cucumber.api.junit.Cucumber</code>.</p>
<p>This also looks rather fragile.</p>
<p>What is the purpose of this file?</p>
<p>This is rather fragile. I'd rather not maintain a list of manual dependencies. Please try to find a maven plug-in that can use the project dependencies to generate this.</p>
B7ET73N2K
2018-04-13 10:07:33
[cucumber/cucumber-jvm] mpkorstanje commented on #1345: Tycho surefire
B7ET73N2K
2018-04-13 13:22:26
[cucumber/cucumber-jvm] rjking99 commented on #1345: Tycho surefire
<p>OK, I'll move it to <code>cucumber.api.osgi.CucumberOSGi</code>.</p>
B7ET73N2K
2018-04-13 13:22:26
[cucumber/cucumber-jvm] rjking99 commented on #1345: Tycho surefire
<p>OK, I'll move it to <code>cucumber.api.osgi.CucumberOSGi</code>.</p>
B7ET73N2K
2018-04-13 13:25:27
[cucumber/cucumber-jvm] rjking99 commented on #1345: Tycho surefire
<p>I changed it to protected not for testing purposes (my tests only call the public method), but to allow the class to be extended for any future OSGi containers that may come along and need some slightly different functionality to discover classes. In my actual project at work, I have a separate class that extends this, but because everything was private, I had to duplicate a ton of code in my new class.</p>
B7ET73N2K
2018-04-13 13:25:28
[cucumber/cucumber-jvm] rjking99 commented on #1345: Tycho surefire
<p>I changed it to protected not for testing purposes (my tests only call the public method), but to allow the class to be extended for any future OSGi containers that may come along and need some slightly different functionality to discover classes. In my actual project at work, I have a separate class that extends this, but because everything was private, I had to duplicate a ton of code in my new class.</p>
B7ET73N2K
2018-04-13 13:26:24
[cucumber/cucumber-jvm] rjking99 commented on #1345: Tycho surefire
<p>I'm not sure I understand the question? My instinct is to say that if the presence of the container was transparent, that I would't have had to jump through all these hoops in the first place.</p>
B7ET73N2K
2018-04-13 13:28:26
[cucumber/cucumber-jvm] rjking99 commented on #1345: Tycho surefire
<p>Yes, all end users have to do this, and yes, it kind of sucks. My example is only extracting the English ones because the example feature file is written in English.</p>
<p>I'll add comments to the file explaining about needing to extract the classes for the actual language of the feature files.</p>
B7ET73N2K
2018-04-13 13:28:26
[cucumber/cucumber-jvm] rjking99 commented on #1345: Tycho surefire
<p>Yes, all end users have to do this, and yes, it kind of sucks. My example is only extracting the English ones because the example feature file is written in English.</p>
<p>I'll add comments to the file explaining about needing to extract the classes for the actual language of the feature files.</p>
B7ET73N2K
2018-04-13 13:30:30
[cucumber/cucumber-jvm] rjking99 commented on #1345: Tycho surefire
<p>Yeah, I know an empty file looks wrong, but unfortunately, it's presence is a key part of the Eclipse plugin project structure.</p>
B7ET73N2K
2018-04-13 13:35:27
[cucumber/cucumber-jvm] mpkorstanje commented on #1345: Tycho surefire
<p>Okay fair enough. :D</p>
<p>I don't understand why you're loading up a dummy backend when there is no container. I guess now it no longer fails, but isn't that meaningless? Why not use a real backend?. </p>
B7ET73N2K
2018-04-14 11:48:24
[cucumber/cucumber-jvm] mpkorstanje commented on #1345: Tycho surefire
<p>Inheritance shouldn't be used to reuse code without also adhering to the LSP. It'd be better to use composition to solve this. </p>
B7ET73N2K
2018-06-02 05:05:27
[cucumber/cucumber-jvm] aslakhellesoy requested changes to #1380: [WIP] Add --wip option
<p>Why static state? Please change to instance state.</p>
<p>Why not?</p>
B7ET73N2K
2018-06-02 05:53:25
[cucumber/cucumber-jvm] Heziode commented on #1380: [WIP] Add --wip option
<p>> Need code review, especialy for the use of static attribute for wip.
I have do that because it is dificult to access RuntimeOption instance in Result.</p>
<p>I will find anthor way to access it.</p>
B7ET73N2K
2018-06-02 05:53:25
[cucumber/cucumber-jvm] Heziode commented on #1380: [WIP] Add --wip option
<p>It is based on <a href="https://github.com/cucumber/cucumber-ruby/blob/debe5d3b419774cd3514222b4500f6bedca61611/lib/cucumber/cli/configuration.rb#L30">Cucumber-Ruby</a></p>
B7ET73N2K
2018-06-02 06:25:31
[cucumber/cucumber-jvm] aslakhellesoy commented on #1380: [WIP] Add --wip option
<p>The corresponding Ruby code is 9 years old <a href="https://github.com/cucumber/cucumber-ruby/commit/74708c8893af29a473b49525f20e4377ab5898d1">https://github.com/cucumber/cucumber-ruby/commit/74708c8893af29a473b49525f20e4377ab5898d1</a> and I must admit I don't remember why we did it that way.</p>
<p>Unless someone can think of a good reason to add this constraint I suggest we leave it out.</p>
B7ET73N2K
2018-06-02 06:29:24
[cucumber/cucumber-jvm] Heziode commented on #1380: [WIP] Add --wip option
B7ET73N2K
2018-06-02 08:26:26
[cucumber/cucumber-jvm] mpkorstanje commented on #1381: Add --wip option
B7ET73N2K
2018-06-02 08:41:26
[cucumber/cucumber-jvm] mpkorstanje commented on #1381: Add --wip option
<p>I don't think this method is needed. </p>
<p>When using <code>--wip</code> the build should fail when there are any passing results (when result.isOk(true/false) return true).</p>
<p>It's okay to use if statements here and use <a href="https://refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.html">a guard clause</a> to handle the empty case.</p>
<p>I also think this will fail when there is one test case that passes and one test case that failed.</p>
B7ET73N2K
2018-06-02 08:41:26
[cucumber/cucumber-jvm] mpkorstanje commented on #1381: Add --wip option
B7ET73N2K
2018-06-02 09:16:24
[cucumber/cucumber-jvm] Heziode commented on #1381: Add --wip option
<p>> When using --wip the build should fail when there are any passing results (when result.isOk(true/false) return true).
Are you sure ?
Because if I do this, when it return false for undefined in strict mode I attempt to get result 1 but I get 0 (with my current code, that are not currently pushed)</p>
B7ET73N2K
2018-06-02 12:35:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1381: Add --wip option
B7ET73N2K
2018-06-02 15:37:23
[cucumber/cucumber-jvm] Heziode commented on #1381: Add --wip option
<p>@mpkorstanje If I only use isOk, and I do what you tell, I obtain an unexpected behaviour with strict mode.</p>
<p>With wip and strict, if I have an undefined step, the result is 0 instead of 1.</p>
B7ET73N2K
2018-06-02 17:21:24
[cucumber/cucumber-jvm] mpkorstanje commented on #1381: Add --wip option
<p>I thought it wasn't possible to use wip and strict in together. But if it is, that makes sense. An undefined result in strict mode makes the test fail. So when running with wip and strict it should pass. That is what I get from reading <a href="https://github.com/cucumber/cucumber-ruby/blob/d73e337a5d347313984f811e8c9b139e74c06551/features/docs/work_in_progress.feature">work<em>in</em>progress.feature</a>:</p>
<p><code>In order to ensure that feature scenarios do not pass until they are expected to
Developers should be able to run cucumber in a mode that
- will fail if any scenario passes completely
- will not fail otherwise
</code></p>
B7ET73N2K
2018-06-03 04:43:22
[cucumber/cucumber-jvm] mpkorstanje commented on #1381: Add --wip option
B7ET73N2K
2018-06-03 06:46:25
[cucumber/cucumber-jvm] aslakhellesoy commented on #1381: Add --wip option
<p>I mentioned somewhere else that I couldn’t remember why we disallowe strict and wip at the same time.</p>
<p>If we can’t think of a good reason for it (I can’t) we should allow it.</p>
B7ET73N2K
2018-06-03 06:56:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1381: Add --wip option
<p>I am thinking the same thing. But I am trying to work out why Heziode thinks the result of combining wip and strict with an undefined result is unexpected. </p>
B7ET73N2K
2018-06-03 10:59:24
[cucumber/cucumber-jvm] Heziode commented on #1381: Add --wip option
<p>Here is a result I want expect:</p>
<p>• <code>--wip</code>: Test fail only if one or more scenario have status <code>PASSED</code>
• <code>--wip</code> + <code>--strict</code>: Test fail if one or more scenario have status <code>PASSED</code>, <code>UNDEFINED</code>, <code>SKIPPED</code></p>
<p>What do you think about this ?</p>
B7ET73N2K
2018-06-09 14:19:22
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>> There is one new test cucumber.runtime.junit.CucumberTest#cucumber<em>can</em>run<em>pickles</em>in_parallel which is now failing. I don't quite understand the problem at the moment - could look at this another day but think you know this better than I
I reckon this has something to do with it. </p>
B7ET73N2K
2018-06-09 14:31:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 14:36:23
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>OK, but I had to get rid of that in the call, as from certain tests I had to pass in a test specific EventBus so that the time on the stopwatch was incremented upon each <code>TestStepStarted</code> event</p>
B7ET73N2K
2018-06-09 14:37:22
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>well I deliberately check to see if there are any features to be run, before running them.</p>
<p>it seemed strange to try and loop over something that could be empty, only a few lines above my check</p>
B7ET73N2K
2018-06-09 14:41:28
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>Oh and I debugged <code>BatchedEventBus</code> and the <code>super.send()</code> indeed did nothing as that bus itself had no listeners registered - but it's parent (delegate) did</p>
<p>So i'd be surprised if this was the culprit, but am happy(ish 😉 ) to be wrong</p>
B7ET73N2K
2018-06-09 14:41:28
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 14:41:28
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 14:48:25
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 14:48:25
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 14:55:27
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>OK, I just generally go with the tactic of hiding construction of complex classes behind builders - not a problem not hiding though</p>
B7ET73N2K
2018-06-09 14:58:24
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 14:59:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 15:01:24
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>Within this repo - nothing</p>
<p>Just wasn't sure of any other cucumber projects utilising <code>Runtime</code>s constructor and wanted to play it safe by not introducing a breaking change</p>
B7ET73N2K
2018-06-09 15:03:24
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>well all the existing tests passed, and that event won't be queued up, so it should be a problem.</p>
<p>if you have concerns though I'll move it back</p>
B7ET73N2K
2018-06-09 15:17:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 15:20:20
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>This is a cool pattern but was only introduced in 1.8. We're still compiling against 1.7 unfortunately.</p>
B7ET73N2K
2018-06-09 15:28:21
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>But it’s in the <a href="https://docs.oracle.com/javase/7/docs/api/java/lang/ThreadLocal.html#initialValue">Java 7 Docs</a> also could’ve sworn I’d seen it being used elsewhere in the project</p>
B7ET73N2K
2018-06-09 15:51:27
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Can you explain why you are executing features in parallel and not pickles? This adds allot of complexity which could be naively be done by:</p>
<p><code>for (CucumberFeature feature : features) {
for (final PickleEvent pickleEvent : compiler.compileFeature(feature)) {
if (filters.matchesFilters(pickleEvent)) {
executor.submit(new Runnable() {
@Override
public void run() {
runnerSupplier.get().runPickle(pickleEvent);
}
});
}
}
}
</code></p>
<p>(this doesn't await completion, but that is easy to fix)</p>
B7ET73N2K
2018-06-09 15:56:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 15:59:24
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 15:59:24
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>I wanted to create a callable to do the work e.g. pulling the test feature to be run from the queue.</p>
<p>Didn’t think about breaking it down into pickle level (individual scenario right?) but could be done I suppose as it increases the benefits if a feature has many scenarios but another only has 1</p>
<p>Waiting for the result could be done by submitting a Future instead</p>
<p>Again I was just trying to keep each class doing one thing, hence extracting the classes and working with the features as in parallel as opposed to pickles</p>
<p>I’ll have a play with this and come back</p>
B7ET73N2K
2018-06-09 16:02:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Can you split this into a <code>TestCaseEventBus</code> that queues up <code>TestCase</code> events and a <code>SynchronizedEventBus</code> that ensures only one thread can send events at the same time. This may require adding the <code>sendAll</code> method to the <code>SynchronizedEventBus</code>.</p>
B7ET73N2K
2018-06-09 16:06:22
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Global locks are bad for performance. For example if we create two instances of Runtime and execute them on different threads both will have to contented to lock this guard. This isn't needed as neither Runtime should share any objects.</p>
<p>This can be avoided by implementing the <code>SynchronizedEventBus</code>. As it will allow us to lock on a instance of the bus associated with the <code>Runtime</code>.</p>
B7ET73N2K
2018-06-09 16:06:22
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>Again it’s in javadocs earlier than 1.8, plus IntelliJ isn’t moaning and it has done so when i’ve to use methods / syntax from later than 1.7</p>
<p>I’ll just change it back anyway</p>
B7ET73N2K
2018-06-09 16:08:22
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>I mean to remove that, as originally in the code each RunnerSupplier was creating it’s own eventbus wrapper and they were flushing at the same time and causing formatters to receive events out of sync (separate tests)</p>
<p>Meant to remove it now that only one instance will be used</p>
B7ET73N2K
2018-06-09 16:11:22
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Then we can make it private. </p>
<p>• Breaking changes are allowed on majors.
• I already broke the whole Runtime with my re-factoring
• We're only applying semantic versioning to the api packages anyway.</p>
B7ET73N2K
2018-06-09 16:18:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>> I had to get rid of that in the call, as from certain tests I had to pass in a test specific EventBus so that the time on the stopwatch was incremented upon each TestStepStarted event
That is why the <code>TestHelper</code> was using a different setup. </p>
B7ET73N2K
2018-06-09 16:30:25
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>You may notice that the formatters will break because they expect the <code>TestCase**</code> events from a the scenarios in a feature to be in order.</p>
<p>I think we can add another event bus for that, one which sorts the sets of TestCaseEvents by their Uri's.</p>
B7ET73N2K
2018-06-09 16:33:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>> Waiting for the result could be done by submitting a Future instead
If the nested for loops adds the Runnables to a list instead you could call <code>executor.invokeAll(tasks)</code>. </p>
B7ET73N2K
2018-06-09 16:34:19
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 16:37:20
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 16:37:20
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-09 16:49:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>> So i'd be surprised if this was the culprit, but am happy(ish wink ) to be wrong
So what happens:</p>
<p>We use JUnits ParallelComputer to run two features in parallel. For each features we connect the event bus to the JUnits RunNotifier. </p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/master/junit/src/main/java/cucumber/runtime/junit/PickleRunners.java#L147">https://github.com/cucumber/cucumber-jvm/blob/master/junit/src/main/java/cucumber/runtime/junit/PickleRunners.java#L147</a></p>
<p>Because the bus is now shared between threads, all notifiers listen to the same bus and will not only receive events from the execution of their own feature, but also from the other feature. These notifiers send their events up the chain of notifiers, which results in one event being reported multiple times (and/or other concurrent shenanigans).</p>
B7ET73N2K
2018-06-09 16:51:16
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>So each runner should have it's own event bus. Like so:</p>
<p><code>Junit ---listens to---&gt; [TestCase EventBus for Runner 1] ---sends batches of events to--&gt; [Synchronized EventBus] &lt;---listens too--- HTML formatter
Junit ---listens to---&gt; [TestCase EventBus for Runner 2] ---sends batches of events to--&gt; [Synchronized EventBus] &lt;---listens too--- HTML formatter
</code></p>
B7ET73N2K
2018-06-10 00:29:19
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>Have made the changes so that <code>PickleEvents</code> are now run in parallel.</p>
<p>The <code>Formatter</code>s, well their tests, appear to be OK. Though they're not running in parallel. When I had done this before the tests didn't always pass in Travis.</p>
<p>The events are still being sent in the correct order and synchronized accordingly
• <code>TestCaseStarted</code>
• <code>TestStepStarted</code>
• <code>EmbedEvent</code>
• <code>WriteEvent</code>
• <code>TestStepFinished</code>
• <code>TestCaseFinished</code></p>
B7ET73N2K
2018-06-10 02:00:28
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p><code>So each runner should have it's own event bus. Like so:</code></p>
<p>ah yes, sorry you explained that before and I'd forgotten.</p>
<p>Have just fixed the test and pushed</p>
B7ET73N2K
2018-06-10 03:30:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>> A SynchronizedEventBus wasn't required as a delegate as each thread has it's own list of Formatters to notify of the queued events for the current thread
How does that work? We run cucumber with 5 runners, each on their own thread, how do we end up with a single json or html file?</p>
B7ET73N2K
2018-06-10 06:20:22
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>Hmm, sounds like there is a problem with the test in that there aren’t an plugins being verified.</p>
<p>It could be that even though the test passes (haven’t changed it) that it isn’t correctly asserting/verifying what should be happening, and thus it is now not producing the desired outcome</p>
<p>Will check this out, but probably not until tomorrow now.</p>
B7ET73N2K
2018-06-10 06:51:24
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 06:52:22
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 06:56:20
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 06:57:20
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 06:58:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 06:58:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 06:59:20
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>We know these busses will be called from different threads so synchronizing them in the supplier that creates them keeps these concerns together. Single threaded implementations can use a different supplier.</p>
B7ET73N2K
2018-06-10 07:00:27
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 07:06:22
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Because we're mocking the time stamps here the bus has to be passed directly into the runner (there can't be a hierarchy of bussses here). This can't be done in a pretty way by the builder. </p>
<p>That said, the callers of this method could stand to have a stern looking at. There is too much setup cruft in those tests.</p>
B7ET73N2K
2018-06-10 07:07:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 07:08:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Replacement for the default event bus. This is actually the only event bus that can be created without needing another event bus.</p>
B7ET73N2K
2018-06-10 09:00:27
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>Fair enough, I was just trying to reduce the cyclomatic complexity of the class. Also by <code>invokeAll</code> it allowed me to easily wrap the <code>InterruptedException</code> into a <code>CucumberException</code></p>
B7ET73N2K
2018-06-10 09:01:24
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>But for some tests, cannot remember which, I needed to specifically pass in the test <code>EventBus</code> implementation and it had registrations for <code>TestStepStarted</code> that needed to be sent, not queued, but your calls to <code>parent.send</code> or <code>super.send</code> may also resolved. Can’t quite tell as am reviewing on web page rather than in IDE</p>
B7ET73N2K
2018-06-10 09:07:22
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>Yeah I find a lot of tests being confusing, mainly in how they are setting things up e.g. glue, hooks etc.... plus soooo many overloads to call into actually running the code.</p>
<p>Some of the asserting is a little messy, would like to use assertJ core and a nice json assert library, which would make things more readable.</p>
B7ET73N2K
2018-06-10 09:28:22
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>could extends <code>AbstractExecutorService</code> would reduce the number of methods to implement without change to what you need, other than the other <code>submit</code> and <code>invoke</code> methods being pre-supported</p>
B7ET73N2K
2018-06-10 09:48:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Given how often I am debugging tests it is not something to be sneezed at.</p>
<p>But it also makes debuging plugins easier because the events are provided as they are created rather then batched up.</p>
B7ET73N2K
2018-06-10 09:48:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 09:49:26
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-10 10:16:21
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>You are entirely right. The failing tests were the formatter tests, specifically the ones with timestamps.</p>
<p>I initially resolved that by not using the runtime builder and passing the event bus directly into the runner. I figured this was okay because we're testing the formatter, not the whole integration. The runtime was used to generate a series of events, nothing else. This means the bus doesn't need to be wrapped. There is no parallel execution.</p>
<p>Turns out this was rather useful so I changed the runtime builder to run on the main thread directly when threads were not needed. </p>
B7ET73N2K
2018-06-10 12:52:24
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>I wasn’t scoffing at the change at all. Just wonder if I’d missed something other than aiding in debugging tests - as I myself temporarily added it but didn’t commit it</p>
B7ET73N2K
2018-06-11 00:51:24
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>this won't work correctly e.g. for line 1, 9, 10 </p>
<p>```public static void main(String[] args) {
final List<String> uris = Arrays.asList("feature1.path:1", "feature1.path:9", "feature1.path:10");
System.out.println("pre-sort: " + uris);
Collections.sort(uris);
System.out.println("post-sort: " + uris);
}</p>
<pre><code>pre-sort: [feature1.path:1, feature1.path:9, feature1.path:10]
post_sort: [feature1.path:1, feature1.path:10, feature1.path:9]
</code></pre>
<p>```</p>
B7ET73N2K
2018-06-11 01:02:27
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>This will not work, you cannot have multiple instances of the class and just use the <code>synchronized</code> keyword on the method. The keyword on the method only effects the instance, not all instances - this is why I used a static sync object before</p>
<p>Example
```public static void main(String[] args) throws InterruptedException {
final ExecutorService executorService = Executors.newFixedThreadPool(2);
executorService.submit(new SynMethod());
Thread.sleep(100L);
executorService.submit(new SynMethod());
}
private static class SynMethod implements Runnable {
synchronized void doSomething() {
DateFormat df = new SimpleDateFormat("hh:MM:ss.SSS");
System.out.println(Thread.currentThread().getId() + " - hey there " + df.format(new Date()))
try {
Thread.sleep(3000L);
}
catch (InterruptedException e) {
e.printStackTrace();
}
System.out.println(Thread.currentThread().getId() + " - all done " + df.format(new Date()));
}
@Override
public void run() {
doSomething();
}
}</p>
<pre><code>```11 - hey there 09:06:11.221
12 - hey there 09:06:11.298
11 - all done 09:06:14.227
12 - all done 09:06:14.298
</code></pre>
B7ET73N2K
2018-06-11 02:07:28
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Yup. That's why this is in the wrong spot:</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/pull/1389/files#diff-6ec644ece6e92b60fe39b4cceef33c08R199">https://github.com/cucumber/cucumber-jvm/pull/1389/files#diff-6ec644ece6e92b60fe39b4cceef33c08R199</a></p>
B7ET73N2K
2018-06-11 02:28:27
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-12 11:59:29
[cucumber/cucumber-jvm] mpkorstanje requested changes to #1394: Simplify Gradle example
B7ET73N2K
2018-06-15 03:55:28
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>On receiving <code>TestRunFinished</code> we could check to see if anything remains in the queue and if so then throw a <code>CucumberException</code> as it should be empty at this point</p>
B7ET73N2K
2018-06-15 04:25:25
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>This won't work in JUnit and TestNG. Cucumber filters pickles, then JUnit filters test cases created from those pickles. </p>
B7ET73N2K
2018-06-15 04:32:26
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
B7ET73N2K
2018-06-15 05:01:26
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Makes sense. I think that for the total ordering it may be beneficial to turn this into a PickleLocation, or if the PickleLocation is not comparable, our own Location implementation that is. It would make the TreeMap used elsewhere a bit simpler too.</p>
B7ET73N2K
2018-06-15 07:03:26
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>JUnit and TestNG call through <code>cucumber.runner.Runner#runPickle</code> not <code>cucumber.runtime.Runtime#run</code></p>
<p>Only <code>Main</code> calls into <code>cucumber.runtime.Runtime#run</code></p>
B7ET73N2K
2018-06-15 07:06:25
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>I reviewed what was available to all of the calling methods/classes.</p>
<p>I went with this, as not everything had access to a <code>TestCase</code> or <code>PickleLocation</code> and as I was going to encapsulate getting the values anyway it became cleaner to inject only the URI and line number.</p>
B7ET73N2K
2018-06-15 07:10:27
[cucumber/cucumber-jvm] aslakhellesoy commented on #1389: Parallel cukes
B7ET73N2K
2018-06-15 07:10:27
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>> they also do not use OrderedTestRunEventBus
Mmh. Formatters can also listen to JUnit and TestNG so they should be using OrderedTestRunEventBus. Must have missed it when adding the bus.</p>
B7ET73N2K
2018-06-15 07:14:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>It smells like primitive obsession. But maybe we can hide it later with the comparator/comparable implementation.</p>
B7ET73N2K
2018-06-15 07:30:29
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>You could argue that, but like I said all I needed was URI and line number to be able to locate the parent feature and sort the test case. Hence I added these methods to the API, having the separate methods would reduce method chaining and stop the usages of the Events knowing too much about implementation detail.</p>
<p>How the implementation is done e.g. String + int or TestCase is an implementation detail. All of the calls already had knowledge of the URI and line number, whereas only a few had access to something like <code>TestCase</code> - which is what we originally discussed as this is already in the <code>TestCaseStarted</code> and <code>TestCaseFinished</code> events</p>
<p>I did originally pass in <code>TestCase</code> but this resulted in a lot more classes have to change along with some public method signatures.</p>
B7ET73N2K
2018-06-15 07:36:25
[cucumber/cucumber-jvm] boaty82 commented on #1389: Parallel cukes
<p>Listen or register? Doesn't that contradict your earlier comment/feedback</p>
<p><code>Junit Thread 1 ---listens to---&gt; [TestCase EventBus for Runner 1] ---sends batches of events to--&gt; [Synchronized EventBus] &lt;---listens too--- HTML formatter
Junit Thread 2 ---listens to---&gt; [TestCase EventBus for Runner 2] ---sends batches of events to--&gt; |
</code></p>
B7ET73N2K
2018-06-15 09:15:30
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: Parallel cukes
<p>Sorry. Being sloppy with my language. Formatters also subscribe to the event bus during a JUnit/TestNG execution of cucumber. These may also execute pickles in any order. </p>
<p>Currently the <code>OrderedTestRunEventBus</code> comes after the synchronized bus. Like so:</p>
<p>```Junit Thread 1 ---listens to---> [TestCase EventBus for Runner 1] ---sends batches of events to--> [Synchronized EventBus] --Sends events to--> [OrderedTestRunEventBus] <---listens too batches --- HTML formatter
Junit Thread 2 ---listens to---> [TestCase EventBus for Runner 2] ---sends batches of events to--> |</p>
<pre><code>
Where I want to go is:
```Junit Thread 1 ---listens to---&gt; [TestCase EventBus for Runner 1] ---sends events to--&gt; [Synchronized EventBus] &lt;---listens too--- HTML formatter
Junit Thread 2 ---listens to---&gt; [TestCase EventBus for Runner 2] ---sends events to--&gt; |
</code></pre>
<p>The TestCase EventBus no longer sends batches but passes events to it's listeners and parent directly. The HTML formatter gets them as we go along. It is then the HTML formatters responsibility to handle events from parallel execution correctly. We can however make this easier by providing a comparator or implement comparable as part of the public api.</p>
B7ET73N2K
2018-06-19 03:23:24
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
B7ET73N2K
2018-06-19 03:24:20
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
B7ET73N2K
2018-06-19 03:27:22
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
<p>If we are going to indeed queue all events until the end of then run then you probably shouldn't use <code>ArrayList</code> but something like <code>LinkedList</code> instead</p>
B7ET73N2K
2018-06-19 03:32:24
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
B7ET73N2K
2018-06-19 03:38:23
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
<p>this will probably need to implement <code>ConcurrentEventListener</code> otherwise all the Thread Ids will be the same (main thread) and the start/end times will be incorrect as they will be when the events are flushed rather than when initially published</p>
<p>note: cannot use the time of the event is nano time but the render of the report requires millis</p>
B7ET73N2K
2018-06-19 11:12:27
B7ET73N2K
2018-06-19 11:15:31
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: [Core] Parallel cukes
<p>That would bring back the JUnit problem. The bus returned by <code>Runner.getBus</code> should only broadcast the events produced by that runner. Sharing one bus between runners makes this impossible possible.</p>
B7ET73N2K
2018-06-19 11:22:28
B7ET73N2K
2018-06-19 11:22:28
B7ET73N2K
2018-06-19 11:23:26
B7ET73N2K
2018-06-19 12:55:29
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
B7ET73N2K
2018-06-19 12:55:29
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
B7ET73N2K
2018-06-19 12:56:26
B7ET73N2K
2018-06-19 12:56:26
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
B7ET73N2K
2018-06-19 13:03:29
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: [Core] Parallel cukes
<p>Please go ahead. I've changed the <code>Formatter</code> interface to <code>ConcurrentEventListener</code> and <code>Plugin</code>. I would like to eventually deprecate the <code>Formatter</code> interface but that will happen on another PR.</p>
B7ET73N2K
2018-06-19 13:09:30
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
B7ET73N2K
2018-06-19 13:10:31
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
B7ET73N2K
2018-06-19 13:38:24
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: [Core] Parallel cukes
<p>Sorting an unsorted list of n elements and inserting n elements into a treeset are both <code>O(n log(n))</code> operations. But the overhead on sorting a (partially sorted) list is probably lower.</p>
B7ET73N2K
2018-06-19 14:12:27
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: [Core] Parallel cukes
<p>Maybe rename this to <code>ConcurrentEventAware</code> to match the <code>ColorAware</code> and <code>StrictAware</code> pattern?</p>
B7ET73N2K
2018-06-19 23:48:24
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
<p>This needs more consideration</p>
<p>As should check the performance of sorting a LinkedList (if indeed it was used) as accessing elements within it is much less performant than an ArrayList.</p>
B7ET73N2K
2018-06-20 00:35:24
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: [Core] Parallel cukes
<p>The linked list is also sorted in n log n. The impl turns it into an array firdt. There is a bit more overhead compared to arraylist but it is efficient. Feel free to bench mark it though.</p>
B7ET73N2K
2018-06-20 00:44:23
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
<p>Depends how long <code>EventListener</code> is going to be around. But I can see arguments both for keeping it inline with the other "Aware" interfaces, but also to name it similarly to the existing listener</p>
B7ET73N2K
2018-06-21 00:29:23
[cucumber/cucumber-jvm] mpkorstanje commented on #1399: Use fully classified name for DataTable (Fixes #1383)
<p>Yes. But you don't have to share that opinion. </p>
<p>I reckon it will be nice for the same reason the data table import is nice. It does make snippets more verbose.</p>
<p>Have you tried to see which gives you the best experience?</p>
B7ET73N2K
2018-06-22 07:13:26
[cucumber/cucumber-jvm] mlvandijk commented on #1399: Use fully classified name for DataTable (Fixes #1383)
<p>Personally, I don't like the fully qualified names; I think it's ugly. And tbh I have no problem just importing PendingException and DataTable.
But if it makes it easier for people to use Cucumber, I don't mind having fqns. Although I'd prefer to have them only when really needed.</p>
B7ET73N2K
2018-06-22 07:19:25
[cucumber/cucumber-jvm] aslakhellesoy commented on #1399: Use fully classified name for DataTable (Fixes #1383)
<p>Some context: We train people in Cucumber using <a href="http://www.cyber-dojo.org/">Cyber-Dojo</a> - an online coding environment for TDD and kata practices.</p>
<p>It doesn't add import statements automatically like an IDE does. So I thought it would be easier for people if class names were FQN.</p>
<p>Under normal circumstances I think FQN would drive me nuts.</p>
<p>So I think we should make it configurable. I'm wary of the inflation of command line options (annotation options), but that's probably the right way to do it.</p>
<p>When we integrate <a href="https://github.com/cucumber/cucumber/tree/master/config">config</a> people can change this setting in a file.</p>
B7ET73N2K
2018-06-22 07:31:27
[cucumber/cucumber-jvm] mlvandijk commented on #1399: Use fully classified name for DataTable (Fixes #1383)
<p>@aslakhellesoy Thanks, that does clarify the need for me ;) Making it configurable will be a lot more work though.</p>
B7ET73N2K
2018-06-22 07:45:35
[cucumber/cucumber-jvm] aslakhellesoy commented on #1399: Use fully classified name for DataTable (Fixes #1383)
<p>Yes, and it <em>shouldn't</em> be a lot of work. Let's postpone this until we're using <code>config</code>, which takes care of the hard work. With that in place it should be easy. </p>
B7ET73N2K
2018-06-22 08:53:28
[cucumber/cucumber-jvm] mpkorstanje commented on #1399: Use fully classified name for DataTable (Fixes #1383)
<p>I don't think the the problem will be in the config.</p>
<p>It will be quite cumbersome to get the config information to where it is needed. The snippet generator is currently created in the backend.</p>
<p>It might be useful to start looking at some DI solution to create the backends. </p>
B7ET73N2K
2018-06-23 14:10:25
B7ET73N2K
2018-06-24 00:43:21
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
<p>Thanks. Still not brilliant. The class still has a lot going on as there are so many permutations to handle, it just seemed the best fit. </p>
<p>Could now break down the class more into constituent parts, if desired, but will do for now</p>
B7ET73N2K
2018-06-24 00:47:21
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
<p>Unfortunately my commit had a lot of formatting changes 😱</p>
<p>I really need to change my IntelliJ settings to only format changed lines 🤗</p>
B7ET73N2K
2018-06-24 01:22:20
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
<p>Plus, it still doesn't solve the issues of all the "setup cruft" in each test method/class. Was thinking it would be good to have a test "library" class where pre-prepared scenarios are held and then each test can make use of them. If they need something slightly different then that can be looked at - but this would take some time to analyse - I will have a little play but it all depends on how much time there is before the PR is, hopefully, merged</p>
<p>at least now the TestHelper is easier to use/deal with</p>
B7ET73N2K
2018-06-29 09:16:35
[cucumber/cucumber-jvm] mpkorstanje commented on #1407: Deprecate Formatter interface (Fixes #1401)
<p>I think this if statement can be removed. It connects to the null formatter. Before we were using events the null formatter was required because we had to call a method on some object. Now I believe this is no longer required.</p>
<p>See the <a href="https://en.wikipedia.org/wiki/Null_object_pattern">Null<em>object</em>pattern</a>.</p>
<p>Can you check if this is right?</p>
<p>Is this "or" or "and"?</p>
<p>Nice!</p>
B7ET73N2K
2018-06-29 09:57:28
[cucumber/cucumber-jvm] mpkorstanje commented on #1389: [Core] Parallel cukes
<p>@mlvandijk is working on #1401 so I made ConcurrentFormatter extend the Formatter. This avoids changes to the PluginFactory.</p>
<p>I've removed this and replaced it with a interface based guarantee that <code>Thread.currentThread()</code> will return something useful when used in a formatter.</p>
<p>The reason being that the grantee is needed for some tooling that uses thread-local internally to track concurrent execution.</p>
<p>Not long at all. I want to deprecate it in the same release as parallel cukes. People will have to update their formatters, might as well do it properly.</p>
<p>Prepared scenarios are bad. They make it harder to see what is being tested. </p>
<p>Making it easy to setup each test is the way to go. The builder will help there I think.</p>
B7ET73N2K
2018-06-29 13:43:29
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
<p>Fair enough. As long as the correct data is still being output I really don’t mind. </p>
<p>Have you ran a set of features multi threaded to ensure there are still multiple groups in the output? This is something I cannot put in the test as last time they kept failing in Travis as it wasn’t running with multiple threads</p>
B7ET73N2K
2018-06-30 00:16:29
[cucumber/cucumber-jvm] mlvandijk commented on #1405: [Spring] Add documentation for spring object factory
<p>Does this need still to be updated? I'm open to improvements, but figured <em>some</em> docs are better than <em>no</em> docs ;) (unless blatantly incorrect)</p>
B7ET73N2K
2018-06-30 00:23:25
B7ET73N2K
2018-06-30 00:37:21
B7ET73N2K
2018-06-30 00:38:26
B7ET73N2K
2018-06-30 00:38:26
B7ET73N2K
2018-06-30 01:08:25
B7ET73N2K
2018-06-30 02:55:29
[cucumber/cucumber-jvm] boaty82 commented on #1389: [Core] Parallel cukes
B7ET73N2K
2018-06-30 22:02:26
[cucumber/cucumber-jvm] mlvandijk commented on #1407: [Core] Deprecate Formatter interface
<p>EventListener is not a marker interface; it has a method: <code>void setEventPublisher(EventPublisher publisher);</code></p>
B7ET73N2K
2018-07-01 06:56:26
B7ET73N2K
2018-07-01 20:53:28
GitHub
2021-04-15 13:48:49
[cucumber/cucumber-android] Issue opened by gabrielglbh
<p>I have performed all steps carefully for setting up my android project in order to use cucumber to perform some unit tests in my app.</p>
<p>My app module <code>build.gradle</code> has the following dependencies:</p>
<pre><code>testImplementation 'junit:junit:4.13.2'
testImplementation "io.cucumber:cucumber_java:6.10.2"
testImplementation "io.cucumber:cucumber_junit:6.10.2"
testImplementation "io.cucumber:cucumber_android:4.8.3"
</code></pre>
<p>And the <code>testInstrumentatorRunner</code> is set to my custom runner class which is <code>com.my.android.app.RunCucumberTest</code>:</p>
<pre><code>@RunWith(Cucumber::class)
@CucumberOptions(
features = ["src/test/assets/features"],
glue = ["<a href="http://com.my.android.app">com.my.android.app</a>"],
plugin = ["pretty"]
)
class RunCucumberTest : CucumberAndroidJUnitRunner()
</code></pre>
<p>I define my Scenarios under <code>src/test/assets/features</code>:</p>
<pre><code>Feature: Create User
Scenario Outline: Criteria 1
Given the user that enters its username "&lt;name&gt;"
When the user validates its username
Then the username length must be less or equal than 32
Examples:
| name |
| Gabriel |
</code></pre>
<p>And my steps under <code>src/test</code> included in the package <code><a href="http://com.my.android.app">com.my.android.app</a></code>:</p>
<pre><code>class CreateGroupSteps {
private lateinit var groupName: String
private var validGroupName = true
init {
@Given("the user that enters its group name {string}")
fun user_enters_group_name (groupName: String) {
this.groupName = groupName
}
@When("the user validates its group name")
fun user_validates_group_name () {
validGroupName = groupName.matches(Regex(GROUP_NAME_VALIDATOR))
}
@Then("the group name length must be less or equal than 32")
fun group_name_length_less_or_equal_than_32 () {
assertTrue(groupName.length &lt;= 32 &amp;&amp; validGroupName)
}
}
}
</code></pre>
<p>Now, something strange happens: either when I run in the console <code>gradle test</code> or when I am in the <code>RunCucumberTest</code> class and I run it, all Scenarios are present and recognized but they end in failure because the Steps are not defined. Basically throwing a <code>io.cucumber.junit.UndefinedStepException</code>.</p>
<p>I thought that there was something wrong with the <code>glue</code> option in the <code>@CucumberOptions</code>. So I change it and run the task again: same result. I even removed the parameter and again, the same result.</p>
<p>It seems the <code>glue</code> option is completely ignored when running the <code>gradle test</code> task and therefore the Steps are not being recognized.</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-04-15 23:31:41
[cucumber/cucumber-android] Issue closed by lsuski
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-04-19 01:50:01
[cucumber/cucumber-jvm] Issue opened by aslakhellesoy
<p>We should allow users behind a HTTP(S) proxy to publish results. See <a href="https://docs.oracle.com/javase/8/docs/api/java/net/doc-files/net-properties.html">https://docs.oracle.com/javase/8/docs/api/java/net/doc-files/net-properties.html</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 01:54:24
[cucumber/cucumber-jvm] Comment on #2285
We should make sure all implementations use the same environment variables to configure proxy settings.
• <a href="https://github.com/cucumber/cucumber-ruby/issues/1526">cucumber/cucumber-ruby#1526</a>
• <a href="https://github.com/cucumber/cucumber-js/issues/1644">cucumber/cucumber-js#1644</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 04:14:40
[cucumber/cucumber-jvm] Comment on #2285
At this point it would be prudent to replace the `HttpURLConnection` with a proper shaded http client. When using the `http.*` properties will affect all components in `<a href="http://java.net">java.net</a>` including those of the system under tests. So this may not be feasible. Especially in more complicated setups.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 04:17:31
[cucumber/cucumber-jvm] Comment on #2285
Java 11 does come with a `HttpClient` that is an overall improvement over the `HttpURLConnection`, but as Cucumber is currently still on Java 8 we can not use this yet. We do have a major version in the works that would allow us to increase the minimum version of the JRE on which Cucumber is ran.
<a href="https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html">https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 05:10:46
[cucumber/cucumber-jvm] Comment on #2143
> Generally speaking we try to discourage scoping steps to keywords. It tends to lead to ambiguous language. This seems to veer into the same direction. Without further explanation I don't think I'd consider this acceptable.
Our specific use case is as follows:
• we have a revisioning system (envers) in place that increments the revision number of an entity on each change
• depending on the changes in the revision, we do some extra post processing (eg: sending out events)
• we have scenario's in which we want to test whether or not the extra processing occurs
• unfortunately, changes made during execution of our "given" statements also trigger the revisioning system
• grouping all relevant properties into a single "given" statement would render the scenario unreadable
• therefore we have multiple "given" steps to set up the entity under test
• in order for us to be able to check if the post processing was triggered during a"given" or the "when" statement, we need to know the last revision number before the actual "when" statement
• therefore, we'd like to keep track of the last revision number after each "given" statement
• at the moment, we're making use of a "dummy" statement that retrieves and stores the current revision number in our state before the relevant "when" statement is executed
• this however makes the scenario less readable
• and it exposes the fact that we're working with revisions, which business should not be concerned with
So we basically want to do some "implicit state housekeeping" in between steps, and therefore need to distinguish between the actual keywords used for that step.
Another thing to note is that we use Cucumber on an "integration test" level in which we start our full Spring application, while stubbing/mocking external interfaces. We are not able to stub/disable the revisioning system in our tests.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 05:54:37
[cucumber/cucumber-jvm] Comment on #2143
> Cucumber is organized such that a user implementing step definitions with Cucumber Java never has to interact with the core directly. This makes change and estimating the impact of it easier. So the api for a user writing step definitions is `cucumber-java`, not `cucumber-core` nor `cucumber-plugin`.
Am I correct to say that importing and/or exposing the `io.cucumber.plugin.event` classes in `JavaHookDefinition` is to be avoided? So the main issue is in my change in the JavaHookDefinition class?
> Currently by having `io.cucumber.java.step` implement `io.cucumber.plugin.event.Step` the `io.cucumber.plugin.event.StepArgument` and `io.cucumber.plugin.event.Location` as well as `io.cucumber.plugin.event.Step` itself are exposed to the user.
This part is confusing, as I don't have anything implementing that `io.cucumber.plugin.event.Step` class. Are you sure you've looked at my latest commit? I did squash all commits, maybe a bit prematurely?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 09:43:59
[cucumber/cucumber-jvm] Comment on #2285
Can't we just use a `java.net.Proxy` object and take the configuration from cucumber-specific environment variables? For example:
• `CUCUMBER_PUBLISH_HTTP_PROXY_HOST`
• `CUCUMBER_PUBLISH_HTTP_PROXY_PORT`
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 09:59:52
[cucumber/cucumber-jvm] Comment on #2285
Not on a `HttpURLConnection`, you could create a `URL` instance with a custom implementation of `URLStreamHandler` but that's all sorts painful.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 12:49:20
[cucumber/cucumber-jvm] Comment on #2285
> Not on a `HttpURLConnection`, you could create a `URL` instance with a custom implementation of `URLStreamHandler` but that's all sorts painful.
Why not?
At
<a href="https://github.com/cucumber/cucumber-jvm/blob/0a101a30464e9ba68432dd21d67e426aeb2d01bb/core/src/main/java/io/cucumber/core/plugin/UrlOutputStream.java#L72">cucumber-jvm/core/src/main/java/io/cucumber/core/plugin/UrlOutputStream.java</a>
Line 72 in </cucumber/cucumber-jvm/commit/0a101a30464e9ba68432dd21d67e426aeb2d01bb|0a101a3>
we could pass in a proxy object. See <https://docs.oracle.com/javase/7/docs/api/java/net/URL.html#openConnection%28java.net.Proxy%29|https://docs.oracle.com/javase/7/docs/api/java/net/URL.html#openConnection%28java.net.Proxy%29>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 14:44:59
[cucumber/cucumber-jvm] Comment on #2285
Didn't even know you could do that.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 14:57:50
[cucumber/cucumber-jvm] Comment on #2285
We can probably extend the curl option syntax with the curl option for proxy:
```
curl <https://example.com> -x http://<proxy>:<port>
```
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 14:58:48
[cucumber/cucumber-jvm] Comment on #2285
> We can probably extend the curl option syntax with the curl option for proxy
Ooo nice idea!!!
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 15:00:27
[cucumber/cucumber-jvm] Comment on #2285
And if we could use `PluginOption.forClass` with a curl option as an argument this would also be a bit simpler:
```
private List<Plugin> getPublishPlugin() {
if (!enablePublishPlugin) {
return emptyList();
}
if (publishToken != null) {
return singletonList(PluginOption.forClass(PublishFormatter.class, publishToken));
}
if (publish) {
return singletonList(PluginOption.forClass(PublishFormatter.class));
}
if (publishQuiet) {
return emptyList();
}
return singletonList(PluginOption.forClass(NoPublishFormatter.class));
}
```
Esp because then we wouldn't need `CucumberProperties.create();` in `PublishFormatter` which doesn't look at at `junit-platform.properties`.
```
private static CurlOption createCurlOption(String token) {
Map<String, String> properties = CucumberProperties.create();
String url = properties.getOrDefault(PLUGIN_PUBLISH_URL_PROPERTY_NAME, DEFAULT_CUCUMBER_MESSAGE_STORE_URL);
if (token != null) {
url = url + String.format(" -H 'Authorization: Bearer %s'", token);
}
return CurlOption.parse(url);
}
```
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-19 19:20:52
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>👻 <strong>Immortal</strong>: This PR will be recreated if closed unmerged. Get <a href="https://togithub.com/renovatebot/renovate/discussions">config help</a> if that's undesired.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-21 01:15:10
[cucumber/cucumber-jvm] Comment on #1706
<a href="https://github.com/mpkorstanje">@mpkorstanje</a> I try to use surefire retry feature and it works pretty well. the only problem is, that the result cucumber.json contains only test which has been running as failed rerun. It would be great if Cucumber will be able to join prev cucumber.json with rerun json file. Honestly I am not able to do it. But it should be possible I mean. Test sometimes crashes not because of wrong pattern but because of unexpected issues on the network.
Thank you.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-22 00:43:34
[cucumber/cucumber-jvm] Issue opened by LiyakathPandu
<p><strong>Describe the bug</strong><br />
Getting below error while using cucumber testng parallel execution</p>
<p>[ERROR] ParallelRunner>AbstractTestNGCucumberTests.tearDownClass:53</p>
<p>ParallelRunner --> This is my parallel execution runner class. Below is the snippet</p>
<pre><code>import org.testng.annotations.DataProvider;
import io.cucumber.testng.AbstractTestNGCucumberTests;
import io.cucumber.testng.CucumberOptions;
@CucumberOptions(plugin = { "com.aventstack.extentreports.cucumber.adapter.ExtentCucumberAdapter:",
"json:target/cucumber/Cucumber.json",
"rerun:reports/rerun.txt" }, features = "src/test/resources", glue = "com.stepdefinitions", tags = "@Different")
public class ParallelRunner extends AbstractTestNGCucumberTests {
@Override
@DataProvider(parallel = true)
public Object[][] scenarios() {
return super.scenarios();
}
}
</code></pre>
<p><strong>To Reproduce</strong><br />
Every time I am not getting that error. It's kind of an intermittent issue not sure how to reproduce it.</p>
<p><strong>Expected behavior</strong><br />
At the end of execution as I mentioned my snipped it should generate Cucumber.json and rerun.txt file. Because of that error, both files are generating as null.</p>
<p><strong>Context & Motivation</strong></p>
<ol><li>Using the Cucumber.json I am generating a cucumber report in Jenkins because of the empty file report generation is failing.</li><li>Using the rerun.txt file I am trying to rerun the failed scenarios in the Jenkins to reduce the failures of scenarios.</li>
</ol>
<p><strong>Screenshots</strong><br />
[ERROR] ParallelRunner>AbstractTestNGCucumberTests.tearDownClass:53 » ClassCast io.cuc...</p>
<p>This is the error getting in the Jenkins console. It is not printing a complete error.</p>
<p><strong>Your Environment</strong></p>
<p>• Versions used - [6.10.2]
• Build tool [Maven and Jenkins]</p>
<p><strong>Additional context</strong><br />
Scenarios are running but because of that error JSON,rerun.txt and HTML file also not generating.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-22 01:44:42
[cucumber/cucumber-jvm] Comment on #2287
ParallelRunner>AbstractTestNGCucumberTests.tearDownClass:53 » NullPointer
I have observed one more error causing the same issue
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-22 01:45:11
[cucumber/cucumber-jvm] Comment on #2287
> This is the error getting in the Jenkins console. It is not printing a complete error.
Without a full stack trace there is little anyone can do to help you.
However `ClassCast io.cuc...` suggests that there is a problem casting one class to another, typically this is caused by incompatible dependencies. You do happen to be using
```
plugin = { "com.aventstack.extentreports.cucumber.adapter.ExtentCucumberAdapter:",
```
So that would be first place to look. You can also use maven to display your dependencies and transitive dependencies.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-22 01:45:12
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-22 21:43:40
[cucumber/cucumber-jvm] Issue opened by Liyakath2704
<p><strong>Describe the bug</strong><br />
Getting below error while using cucumber TestNG parallel execution</p>
<p>[ERROR] tearDownClass(com.testrunners.ParallelRunner) Time elapsed: 362.452 s <<< FAILURE!<br />
java.lang.ClassCastException: io.cucumber.messages.Messages$GherkinDocument$Feature$TableRow cannot be cast to io.cucumber.messages.Messages$GherkinDocument$Feature$Step</p>
<p>ParallelRunner --> This is my parallel execution runner class. Below is the snippet</p>
<pre><code>import org.testng.annotations.DataProvider;
import io.cucumber.testng.AbstractTestNGCucumberTests;
import io.cucumber.testng.CucumberOptions;
@CucumberOptions(plugin = { "json:target/cucumber/Cucumber.json",
"rerun:reports/rerun.txt" }, features = "src/test/resources", glue = "com.stepdefinitions", tags = "@Different")
public class ParallelRunner extends AbstractTestNGCucumberTests {
@Override
@DataProvider(parallel = true)
public Object[][] scenarios() {
return super.scenarios();
}
}
</code></pre>
<p><strong>To Reproduce</strong><br />
Every time I am not getting that error. It's kind of an intermittent issue not sure how to reproduce it. I have more than 10 jobs with different Tags and not every time I am getting this error in same job.</p>
<p><strong>Expected behavior</strong><br />
At the end of execution as I mentioned my snipped it should generate Cucumber.json and rerun.txt file. Because of that error, both files are generating as null.</p>
<p><strong>Context & Motivation</strong></p>
<ol><li>Using the Cucumber.json I am generating a cucumber report in Jenkins because of the empty file report generation is failing.</li><li>Using the rerun.txt file I am trying to rerun the failed scenarios in the Jenkins to reduce the failures of scenarios.</li>
</ol>
<p><strong>StackTrace</strong></p>
<p>ERROR-1:</p>
<pre><code>AbstractTestNGCucumberTests.tearDownClass:53
[ERROR] tearDownClass(com.testrunners.ParallelRunner) Time elapsed: 362.452 s &lt;&lt;&lt; FAILURE!
java.lang.ClassCastException: io.cucumber.messages.Messages$GherkinDocument$Feature$TableRow cannot be cast to io.cucumber.messages.Messages$GherkinDocument$Feature$Step
</code></pre>
<p>ERROR-2:</p>
<pre><code>AbstractTestNGCucumberTests.tearDownClass:53 » NullPointer
[ERROR] tearDownClass(com.testrunners.ParallelRunner) Time elapsed: 302.141 s &lt;&lt;&lt; FAILURE!
java.lang.NullPointerException
</code></pre>
<p>Note:<br />
These 2 errors I am getting intermittently for different runs in jenkins.</p>
<p><strong>Your Environment</strong></p>
<p>• Versions used - [6.10.2]
• Build tool [Maven and Jenkins]</p>
<p><strong>Additional context</strong><br />
<a href="https://github.com/cucumber/cucumber-jvm/issues/2287">#2287</a> Earlier raised the request since it was closed I am raising it again with a full stack trace and removed the<br />
<code>plugin = { "com.aventstack.extentreports.cucumber.adapter.ExtentCucumberAdapter:",</code><br />
even after removing it I am facing same issue.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-23 08:35:19
[cucumber/cucumber-jvm] Comment on #2288
Not to get repetitive but without a full stack trace there is little anyone can do to help you.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-23 08:38:26
[cucumber/cucumber-jvm] Comment on #2288
Maybe <a href="https://stackoverflow.com/questions/2928548/make-mavens-surefire-show-stacktrace-in-console">https://stackoverflow.com/questions/2928548/make-mavens-surefire-show-stacktrace-in-console</a> can help you to get full traces?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-24 02:00:53
[cucumber/cucumber-jvm] Comment on #2288
Apologies for not providing the complete stack trace. Thanks, <a href="https://github.com/laeubi">@laeubi</a> Next time when I get the error will try to provide the complete stack trace. Can anyone please help with this error
`java.lang.ClassCastException: io.cucumber.messages.Messages$GherkinDocument$Feature$TableRow cannot be cast to io.cucumber.messages.Messages$GherkinDocument$Feature$Step`
What are the cases that might I get this error. I tried to look at all the feature files everything looks good. can anyone please help me with this error?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-26 07:21:07
[cucumber/cucumber-jvm] Comment on #2239
As <a href="https://github.com/mpkorstanje">@mpkorstanje</a> said, this is a lot of work, and not something we want to prioritize
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-26 07:21:07
[cucumber/cucumber-jvm] Issue closed by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-27 00:57:54
[cucumber/cucumber-android] Issue opened by anas-baadshah
<p>Do we have any mechanism to skip a test in the middle of execution based on some conditions?<br />
For example,</p>
<pre><code>@myTest
Scenario Outline: Sample scenerio
Given I am on main screen
When I select visible buttin
And I select white screen
And skip if the condition met
And continue with the black board
And force to go to next screen
</code></pre>
<p>Here on step <code>skip if the condition met</code> can I skip the test and make the scenario passed with a reason?<br />
<code>Assume</code> in JUnit is an option but it's not working with Cucumber-android, Any helps??</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-04-27 05:28:37
[cucumber/cucumber-android] Issue closed by anas-baadshah
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-04-27 09:14:21
[cucumber/cucumber-android] Issue opened by cody1024d
<p>Let me start off by thanking ya'll for maintaining this!</p>
<p>I think I've found a use-case that the current solution cannot handle, but perhaps I have missed it.</p>
<p>I am creating an internal Framework that wraps around cucumber-android to provide to our developers to allow them to write BDT tests. Because of this, I was hoping to encompass the CucumberOptions annotation within the framework, to enforce particular directories/conventions to ensure consistency across our multiple libraries.</p>
<p>As of right now, I don't believe this is possible, because the CucumberJUnitRunner looks for classes only within the context package, which in my above case would not work.</p>
<p>Is there any other way to provide the location of the CucumberOptions to the framework? I believe I could probably write a custom <code>CucumberAndroidJUnitRunner</code> which then provides a custom <code>CucumberJUnitRunnerBuilder</code> but I'd rather avoid duplicating a lot of this boilerplate for one small extension.</p>
<p>Thanks,<br />
Cody</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-04-27 09:27:45
[cucumber/cucumber-jvm] Comment on #2254
<a href="https://github.com/mpkorstanje">@mpkorstanje</a> Bump, since it has been a while. Let me know if anything needs clarification!
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-27 09:36:37
[cucumber/cucumber-jvm] Comment on #2254
Currently short on time and prioritizing the release of v7.0.0. No need to bump.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-27 22:16:57
[cucumber/cucumber-jvm] Comment on #2288
```
[ERROR] tearDownClass(com.testrunners.ParallelRunner) Time elapsed: 794.135 s <<< FAILURE!
java.lang.ClassCastException: io.cucumber.messages.Messages$GherkinDocument$Feature$Scenario cannot be cast to io.cucumber.messages.Messages$GherkinDocument$Feature$Step
at io.cucumber.core.plugin.JsonFormatter.createTestStep(JsonFormatter.java:254)
at io.cucumber.core.plugin.JsonFormatter.handleTestStepStarted(JsonFormatter.java:113)
at io.cucumber.core.eventbus.AbstractEventPublisher.send(AbstractEventPublisher.java:51)
at io.cucumber.core.eventbus.AbstractEventPublisher.sendAll(AbstractEventPublisher.java:36)
at io.cucumber.core.plugin.CanonicalOrderEventPublisher.handle(CanonicalOrderEventPublisher.java:18)
at io.cucumber.core.eventbus.AbstractEventPublisher.send(AbstractEventPublisher.java:44)
at io.cucumber.core.eventbus.AbstractEventBus.send(AbstractEventBus.java:12)
at io.cucumber.core.runtime.CucumberExecutionContext.emitTestRunFinished(CucumberExecutionContext.java:93)
at io.cucumber.core.runtime.CucumberExecutionContext.finishTestRun(CucumberExecutionContext.java:74)
at io.cucumber.testng.TestNGCucumberRunner.finish(TestNGCucumberRunner.java:127)
at io.cucumber.testng.AbstractTestNGCucumberTests.tearDownClass(AbstractTestNGCucumberTests.java:53)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:133)
at org.testng.internal.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:62)
at org.testng.internal.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:385)
at org.testng.internal.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:321)
at org.testng.internal.TestMethodWorker.invokeAfterClassMethods(TestMethodWorker.java:217)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:130)
at java.util.ArrayList.forEach(ArrayList.java:1257)
at org.testng.TestRunner.privateRun(TestRunner.java:794)
at org.testng.TestRunner.run(TestRunner.java:596)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:377)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:371)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:332)
at org.testng.SuiteRunner.run(SuiteRunner.java:276)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1212)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1134)
at org.testng.TestNG.runSuites(TestNG.java:1063)
at org.testng.TestNG.run(TestNG.java:1031)
at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:135)
at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:112)
at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:99)
at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:146)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
```
<a href="https://github.com/mpkorstanje">@mpkorstanje</a> this is the stack trace I found....will this help?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-28 02:17:05
[cucumber/cucumber-jvm] Comment on #2288
ERROR - 2:
This is another type of error I am getting
`java.lang.NullPointerException at io.cucumber.core.plugin.JsonFormatter.addOutputToHookMap(JsonFormatter.java:332) at io.cucumber.core.plugin.JsonFormatter.handleWrite(JsonFormatter.java:135) at io.cucumber.core.eventbus.AbstractEventPublisher.send(AbstractEventPublisher.java:51) at io.cucumber.core.eventbus.AbstractEventPublisher.sendAll(AbstractEventPublisher.java:36) at io.cucumber.core.plugin.CanonicalOrderEventPublisher.handle(CanonicalOrderEventPublisher.java:18) at io.cucumber.core.eventbus.AbstractEventPublisher.send(AbstractEventPublisher.java:44) at io.cucumber.core.eventbus.AbstractEventBus.send(AbstractEventBus.java:12) at io.cucumber.core.runtime.CucumberExecutionContext.emitTestRunFinished(CucumberExecutionContext.java:93) at io.cucumber.core.runtime.CucumberExecutionContext.finishTestRun(CucumberExecutionContext.java:74) at io.cucumber.testng.TestNGCucumberRunner.finish(TestNGCucumberRunner.java:127) at io.cucumber.testng.AbstractTestNGCucumberTests.tearDownClass(AbstractTestNGCucumberTests.java:53) at java.util.ArrayList.forEach(ArrayList.java:1257)`
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-28 03:47:42
[cucumber/cucumber-jvm] Comment on #2288
This is interesting.
The first stacktrace suggests that the `TestStepStarted` event for a specific scenario was processed before the `TestCaseStarted` from that scenario. The second stack trace suggests that `WriteEvent` was handled before any `TestStepStarted` was used. This is all rather unexpected because we are passing through `CanonicalOrderEventPublisher` which sorts all the events in the right order. So it's reasonable to assume the backing linked list of events was concurrently modified by multiple threads and lost a few events.
Do you have any code which uses `Scenario.attach` or `Scenario.log` on a different thread then the one executing the test?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-28 04:01:52
[cucumber/cucumber-jvm] Comment on #2288
<a href="https://github.com/mpkorstanje">@mpkorstanje</a> Yes we are using `Scenario.attach` for each and every scenario at `@After` block if scenarios fail we are taking a screenshot. `Scenario.log` also we are using in all the scenarios where we are trying to log some important data for reporting purpose.
Both `Scenario.attach` and `Scenario.log` we are using in almost every scenario.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-28 04:41:34
[cucumber/cucumber-jvm] Comment on #2288
On which thread are they executed? Are you using any sort of async code to do the logging?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-28 05:35:16
[cucumber/cucumber-jvm] Comment on #2288
No, I'm not using any async code.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-28 06:53:53
[cucumber/cucumber-android] Pull request opened by cody1024d
<p>This should allow a user to create a InstrumentationRunner argument to customize the package location of the <code>CucumberOptions</code> annotation.</p>
<p>With this, I'd be able to simply extend the <code>CucumberAndroidJUnitRunner</code> and add the custom package as I'd like within my framework.</p>
<p>Fixes <a href="https://github.com/cucumber/cucumber-android/issues/74">#74</a></p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-04-28 15:30:53
[cucumber/cucumber-jvm] Comment on #2288
Could you try the following things independently from each other to help triangulate the problem:
a. Provide the full output of `mvn dependency:tree -Dverbose=true`.
b. Remove all usages of `Scenario.log` and `Scenario.attach` from your code while using `cucumber-testng`. This will make the problem smaller by ensuring that all events come from Cucumber.
c. Replace `cucumber-testng` with <a href="https://github.com/cucumber/cucumber-jvm/tree/main/junit-platform-engine">`cucumber-junit-platform-engine`</a> and execute your tests in parallel.
If none of this provides any hints I'm afraid you'll have to do the heavy work of removing everything that does not make the problem go away from your test suite (and really, this means every line of code, configuration, ect in your project no matter how silly you may think it is). Hopefully this provides a sufficiently reduced problem that you can share it as a reproducer in the form of a github repo.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 01:25:45
[cucumber/cucumber-jvm] Issue opened by aslansservant42
<p><strong>Summary</strong></p>
<p>Sonatype registers a High Vulnerability issue with io.cucumber : cucumber-core : 6.10.3</p>
<p><strong>Expected Behavior</strong></p>
<p>Threat Level 6, Problem Code <a href="https://github.com/advisories/GHSA-9mrv-456v-pf22">CVE-2020-28487</a><br />
Related to using vis-timeline before 7.4.4 library</p>
<p>See below for Sonatype's description of the error</p>
<p><strong>Possible Solution</strong></p>
<p>Upgrade vis-timeline to the latest and most secure version.</p>
<p><strong>Sonatype Documenation</strong>
<strong>DESCRIPTION FROM CVE</strong></p>
<p>This affects the package vis-timeline before 7.4.4. An attacker with the ability to control the items of a Timeline element can inject additional script code into the generated application.</p>
<p><strong>EXPLANATION</strong></p>
<p>The vis-timeline package is vulnerable to Cross-Site Scripting (XSS) attacks. The functions in the files listed below fail to sanitize certain user-supplied parameters before rendering their values in HTML. A remote attacker who can influence Timeline elements can exploit this vulnerability by crafting a request containing malicious JavaScript in any affected parameter. The attacker can then entice a victim into submitting the request or interacting with the injection if it is stored. This will result in script execution when the resulting response is rendered by the victim's browser.</p>
<p><strong>Vulnerable File(s) and Function(s):</strong></p>
<p>package/lib/shared/Configurator.js</p>
<p>_makeHeader()<br />
_makeLabel()<br />
_setupPopup()<br />
package/lib/shared/Popup.js</p>
<p>setText()<br />
package/lib/timeline/Timeline.js</p>
<p>constructor()<br />
package/lib/timeline/component/CustomTime.js</p>
<p>setCustomMarker()<br />
package/lib/timeline/component/DataAxis.js</p>
<p>_redrawLabel()<br />
_redrawTitle()<br />
package/lib/timeline/component/Group.js</p>
<p>setData()<br />
package/lib/timeline/component/Legend.js</p>
<p>function()<br />
package/lib/timeline/component/TimeAxis.js</p>
<p>_repaintMinorText()<br />
_repaintMajorText()<br />
package/lib/timeline/component/item/Item.js</p>
<p>_repaintOnItemUpdateTimeTooltip()<br />
_updateContents()<br />
package/dist/vis-timeline-graph2d.esm.js</p>
<p>package/esnext/esm/vis-timeline-graph2d.js</p>
<p>package/esnext/umd/vis-timeline-graph2d.js</p>
<p>package/peer/esm/vis-timeline-graph2d.js</p>
<p>package/peer/umd/vis-timeline-graph2d.js</p>
<p>package/standalone/esm/vis-timeline-graph2d.js</p>
<p>package/standalone/umd/vis-timeline-graph2d.js</p>
<p>package/dist/vis-timeline-graph2d.min.js</p>
<p>package/esnext/esm/vis-timeline-graph2d.min.js</p>
<p>package/esnext/umd/vis-timeline-graph2d.min.js</p>
<p>package/peer/esm/vis-timeline-graph2d.min.js</p>
<p>package/peer/umd/vis-timeline-graph2d.min.js</p>
<p>package/standalone/esm/vis-timeline-graph2d.min.js</p>
<p>package/standalone/umd/vis-timeline-graph2d.min.js</p>
<p><strong>DETECTION</strong></p>
<p>The application is vulnerable by using this component.</p>
<p><strong>RECOMMENDATION</strong></p>
<p>We recommend upgrading to a version of this component that is not vulnerable to this specific issue.</p>
<p>Note: If this component is included as a bundled/transitive dependency of another component, there may not be an upgrade path. In this instance, we recommend contacting the maintainers who included the vulnerable package. Alternatively, we recommend investigating alternative components or a potential mitigating control.</p>
<p><strong>ROOT CAUSE</strong></p>
<p>cucumber-core-6.10.3.jario/cucumber/core/plugin/timeline/vis.min.js[0.3.0, 5.0.0)<br />
ADVISORIES<br />
Project:<a href="https://github.com/<https://github.com/visjs/vis-timeline/issues/838%7Cvisjs/vis-timeline/issues/838">https://github.com/<https://github.com/visjs/vis-timeline/issues/838%7Cvisjs/vis-timeline/issues/838</a>><br />
Project:<a href="https://github.com/<https://github.com/visjs/vis-timeline/pull/840%7Cvisjs/vis-timeline/pull/840">https://github.com/<https://github.com/visjs/vis-timeline/pull/840%7Cvisjs/vis-timeline/pull/840</a>><br />
CVSS DETAILS<br />
CVE CVSS 3:6.8<br />
CVSS Vector:CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:H/I:L/A:L</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 01:28:41
[cucumber/cucumber-jvm] Comment on #2289
Thanks <a href="https://github.com/aslakhellesoy">@aslakhellesoy</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 01:30:50
[cucumber/cucumber-jvm] Comment on #2289
> I did not find any reference to vis-timeline in the repo
The issue was originally filed in the `cucumber/cucumber` repo. I moved it to `cucumber/cucumber-jvm`.
(The hint that this is related to cucumber-jvm is in the summary: `io.cucumber` is the Java package name used by Cucumber-JVM).
> We don't have a package, or gem, or anything which could match "cucumber-core : 6.10.3"
Yes we do:
<a href="https://github.com/cucumber/cucumber-jvm/blob/18db2f265fa2f0aaf1fa8c94e94ebbff0814fa74/core/pom.xml#L10">cucumber-jvm/core/pom.xml</a>
Line 10 in </cucumber/cucumber-jvm/commit/18db2f265fa2f0aaf1fa8c94e94ebbff0814fa74|18db2f2>
> Would you have more info please?
The files are here: <a href="https://github.com/cucumber/cucumber-jvm/tree/main/core/src/main/resources/io/cucumber/core/plugin/timeline">https://github.com/cucumber/cucumber-jvm/tree/main/core/src/main/resources/io/cucumber/core/plugin/timeline</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 01:36:20
[cucumber/cucumber-jvm] Comment on #2289
Related:
• <a href="https://github.com/cucumber/cucumber-jvm/issues/1759">#1759</a>
• <a href="https://github.com/cucumber/cucumber-jvm/pull/1769">#1769</a>
It was proposed to deprecate the timeline formatter, but as <a href="https://github.com/mpkorstanje">@mpkorstanje</a> pointed out we should have an alternative available before doing that. So I suggest:
1. Upgrade vis.js and jquery to the most recent releases (needs to be manually tested).
2. Add a replacement for the timeline formatter in `@cucumber/react` as suggested in <a href="https://github.com/cucumber/cucumber/issues/756">cucumber/cucumber#756</a>
3. Deprecate timeline formatter.
4. Eventually remove it.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 05:15:23
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled due to failing status checks.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 05:15:25
[cucumber/cucumber-jvm] Comment on #2290
*Branch automerge failure*
This PR was configured for branch automerge, however this is not possible so it has been raised as a PR instead.
* * *
• Branch has one or more failed status checks
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 05:15:26
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled due to failing status checks.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 05:15:27
[cucumber/cucumber-jvm] Comment on #2291
*Branch automerge failure*
This PR was configured for branch automerge, however this is not possible so it has been raised as a PR instead.
* * *
• Branch has one or more failed status checks
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 05:21:47
[cucumber/cucumber-jvm] Comment on #2290
*<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2290?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov> Report*
> Merging <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2290?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2290> (<a href="https://github.com/cucumber/cucumber-jvm/commit/7c367d5ecf877f7760dcf9e8e6028d66de3ecb91">7c367d5</a>) into <https://codecov.io/gh/cucumber/cucumber-jvm/commit/3eccf9510baf832620855bd297172fd38c64fd38?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main> (<a href="https://github.com/cucumber/cucumber-jvm/commit/3eccf9510baf832620855bd297172fd38c64fd38">3eccf95</a>) will *not change* coverage.
> The diff coverage is `n/a`.
<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Impacted file tree graph>
```
@@ Coverage Diff @@
## main #2290 +/- ##
=========================================
Coverage 83.36% 83.36%
Complexity 2320 2320
=========================================
Files 300 300
Lines 8273 8273
Branches 750 750
=========================================
Hits 6897 6897
Misses 1079 1079
Partials 297 297
```
* * *
<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2290?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.
> *Legend* - <https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Click here to learn more>
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2290?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov>. Last update <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2290?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|3eccf95...7c367d5>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|comment docs>.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 05:22:36
[cucumber/cucumber-jvm] Comment on #2291
*<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov> Report*
> Merging <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2291?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2291> (<a href="https://github.com/cucumber/cucumber-jvm/commit/8758fc203e08a446ee8fd1e07d5147a0af9be37f">8758fc2</a>) into <https://codecov.io/gh/cucumber/cucumber-jvm/commit/3eccf9510baf832620855bd297172fd38c64fd38?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main> (<a href="https://github.com/cucumber/cucumber-jvm/commit/3eccf9510baf832620855bd297172fd38c64fd38">3eccf95</a>) will *not change* coverage.
> The diff coverage is `n/a`.
<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Impacted file tree graph>
```
@@ Coverage Diff @@
## main #2291 +/- ##
=========================================
Coverage 83.36% 83.36%
Complexity 2320 2320
=========================================
Files 300 300
Lines 8273 8273
Branches 750 750
=========================================
Hits 6897 6897
Misses 1079 1079
Partials 297 297
```
* * *
<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2291?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.
> *Legend* - <https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Click here to learn more>
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2291?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov>. Last update <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2291?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|3eccf95...8758fc2>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|comment docs>.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 10:59:27
[cucumber/cucumber-jvm] Comment on #2230
<a href="https://github.com/mpkorstanje">@mpkorstanje</a> now the above junit PR has been merged can you give me pointers how I can solve this issue?
Thanks
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-29 12:13:04
[cucumber/cucumber-jvm] Comment on #2230
You'd annotate two classes with `@CucumberContextConfiguration` in different packages. Then you'd define two suits using the cucumber engine with different values for `cucumber.glue` property and different test selector annotations. Each one targeting a different set of features + glue.
I'm still waiting for GA to update the readme but feel free to send a PR to update it.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 00:17:45
[cucumber/cucumber-jvm] Issue opened by laeubi
<p>Currently one get the following message for a (failed) test<em>step</em>finished</p>
<pre><code>test_step_finished {
test_step_result {
status: FAILED
message: "org.opentest4j.AssertionFailedError: expected: &lt;8.0&gt; but was: &lt;3.0&gt;\n\tat org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)\n\tat org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)\n\tat org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)\n\tat org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)\n\tat org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1124)\n\tat io.cucumber.examples.java.RpnCalculatorSteps.the_result_is(io/cucumber/examples/java/basic_arithmetic.feature:27)\n"
duration {
nanos: 2984000
}
}
timestamp {
seconds: 1619766696
nanos: 398493000
}
test_step_id: "c2692c18-91e6-4a38-8cd8-c40ef71ca67e"
test_case_started_id: "22500d5c-fb17-464a-8f7e-8afa01342e58"
}
</code></pre>
<p>to prevent the consumer from parsing the message is would be good to have the 'expected: <8.0> but was: <3.0>' part split in different fields</p>
<p><strong>Describe the solution you'd like</strong></p>
<pre><code>test_step_finished {
test_step_result {
status: FAILED
expected: "&lt;8.0&gt;",
actual: "&lt;3.0&gt;",
message: "org.opentest4j.AssertionFailedError: expected: &lt;8.0&gt; but was: &lt;3.0&gt;\n\tat org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)\n\tat org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)\n\tat org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)\n\tat org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)\n\tat org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1124)\n\tat io.cucumber.examples.java.RpnCalculatorSteps.the_result_is(io/cucumber/examples/java/basic_arithmetic.feature:27)\n"
duration {
nanos: 2984000
}
}
timestamp {
seconds: 1619766696
nanos: 398493000
}
test_step_id: "c2692c18-91e6-4a38-8cd8-c40ef71ca67e"
test_case_started_id: "22500d5c-fb17-464a-8f7e-8afa01342e58"
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 01:01:59
[cucumber/cucumber-jvm] Comment on #2292
Moving this to the mono repo. For context:
This is a proposed change to the <a href="https://github.com/cucumber/cucumber/tree/master/messages">message protocol</a>. In Java, assertion libraries use the well known <a href="https://github.com/ota4j-team/opentest4j/blob/master/src/main/java/org/opentest4j/AssertionFailedError.java">`org.opentest4j.AssertionFailedError`</a> to communicate the expected and actual results in an assertion to various APIs. The proposal would add these well fields to the message protocol when available.
I've got no opinion on this. Just adding additional clarification.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 01:35:15
[cucumber/cucumber-jvm] Comment on #2288
Output for `mvn dependency:tree -Dverbose=true`
```
[INFO] +- org.apache.httpcomponents:httpclient:jar:4.5.13:compile
[INFO] | +- org.apache.httpcomponents:httpcore:jar:4.4.13:compile
[INFO] | +- commons-logging:commons_logging:jar:1.2:compile
[INFO] | \- commons-codec:commons_codec:jar:1.11:compile
[INFO] +- com.google.code.gson:gson:jar:2.8.6:compile
[INFO] +- org.jsoup:jsoup:jar:1.13.1:compile
[INFO] +- com.rationaleemotions:talk2grid:jar:1.2.0:compile
[INFO] | +- commons-io:commons_io:jar:2.4:compile
[INFO] | +- (org.apache.httpcomponents:httpclient:jar:4.5.2:compile - omitted for conflict with 4.5.13)
[INFO] | \- org.slf4j:slf4j_jdk14:jar:1.7.5:compile
[INFO] | \- (org.slf4j:slf4j_api:jar:1.7.5:compile - omitted for conflict with 1.7.25)
[INFO] +- org.seleniumhq.selenium:selenium_java:jar:3.141.59:compile
[INFO] | +- org.seleniumhq.selenium:selenium_api:jar:3.141.59:compile
[INFO] | +- org.seleniumhq.selenium:selenium_chrome_driver:jar:3.141.59:compile
[INFO] | | +- (org.seleniumhq.selenium:selenium_api:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (org.seleniumhq.selenium:selenium_remote_driver:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (net.bytebuddy:byte_buddy:jar:1.8.15:compile - omitted for duplicate)
[INFO] | | +- (org.apache.commons:commons_exec:jar:1.3:compile - omitted for duplicate)
[INFO] | | +- (com.google.guava:guava:jar:25.0_jre:compile - omitted for duplicate)
[INFO] | | +- (com.squareup.okhttp3:okhttp:jar:3.11.0:compile - omitted for duplicate)
[INFO] | | \- (com.squareup.okio:okio:jar:1.14.0:compile - omitted for duplicate)
[INFO] | +- org.seleniumhq.selenium:selenium_edge_driver:jar:3.141.59:compile
[INFO] | | +- (org.seleniumhq.selenium:selenium_api:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (org.seleniumhq.selenium:selenium_remote_driver:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (net.bytebuddy:byte_buddy:jar:1.8.15:compile - omitted for duplicate)
[INFO] | | +- (org.apache.commons:commons_exec:jar:1.3:compile - omitted for duplicate)
[INFO] | | +- (com.google.guava:guava:jar:25.0_jre:compile - omitted for duplicate)
[INFO] | | +- (com.squareup.okhttp3:okhttp:jar:3.11.0:compile - omitted for duplicate)
[INFO] | | \- (com.squareup.okio:okio:jar:1.14.0:compile - omitted for duplicate)
[INFO] | +- org.seleniumhq.selenium:selenium_firefox_driver:jar:3.141.59:compile
[INFO] | | +- (org.seleniumhq.selenium:selenium_api:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (org.seleniumhq.selenium:selenium_remote_driver:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (net.bytebuddy:byte_buddy:jar:1.8.15:compile - omitted for duplicate)
[INFO] | | +- (org.apache.commons:commons_exec:jar:1.3:compile - omitted for duplicate)
[INFO] | | +- (com.google.guava:guava:jar:25.0_jre:compile - omitted for duplicate)
[INFO] | | +- (com.squareup.okhttp3:okhttp:jar:3.11.0:compile - omitted for duplicate)
[INFO] | | \- (com.squareup.okio:okio:jar:1.14.0:compile - omitted for duplicate)
[INFO] | +- org.seleniumhq.selenium:selenium_ie_driver:jar:3.141.59:compile
[INFO] | | +- (org.seleniumhq.selenium:selenium_api:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (org.seleniumhq.selenium:selenium_remote_driver:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (net.bytebuddy:byte_buddy:jar:1.8.15:compile - omitted for duplicate)
[INFO] | | +- (org.apache.commons:commons_exec:jar:1.3:compile - omitted for duplicate)
[INFO] | | +- (com.google.guava:guava:jar:25.0_jre:compile - omitted for duplicate)
[INFO] | | +- (com.squareup.okhttp3:okhttp:jar:3.11.0:compile - omitted for duplicate)
[INFO] | | \- (com.squareup.okio:okio:jar:1.14.0:compile - omitted for duplicate)
[INFO] | +- org.seleniumhq.selenium:selenium_opera_driver:jar:3.141.59:compile
[INFO] | | +- (org.seleniumhq.selenium:selenium_api:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (org.seleniumhq.selenium:selenium_remote_driver:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (net.bytebuddy:byte_buddy:jar:1.8.15:compile - omitted for duplicate)
[INFO] | | +- (org.apache.commons:commons_exec:jar:1.3:compile - omitted for duplicate)
[INFO] | | +- (com.google.guava:guava:jar:25.0_jre:compile - omitted for duplicate)
[INFO] | | +- (com.squareup.okhttp3:okhttp:jar:3.11.0:compile - omitted for duplicate)
[INFO] | | \- (com.squareup.okio:okio:jar:1.14.0:compile - omitted for duplicate)
[INFO] | +- org.seleniumhq.selenium:selenium_remote_driver:jar:3.141.59:compile
[INFO] | | +- (org.seleniumhq.selenium:selenium_api:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (net.bytebuddy:byte_buddy:jar:1.8.15:compile - omitted for duplicate)
[INFO] | | +- (org.apache.commons:commons_exec:jar:1.3:compile - omitted for duplicate)
[INFO] | | +- (com.google.guava:guava:jar:25.0_jre:compile - omitted for duplicate)
[INFO] | | +- (com.squareup.okhttp3:okhttp:jar:3.11.0:compile - omitted for duplicate)
[INFO] | | \- (com.squareup.okio:okio:jar:1.14.0:compile - omitted for duplicate)
[INFO] | +- org.seleniumhq.selenium:selenium_safari_driver:jar:3.141.59:compile
[INFO] | | +- (org.seleniumhq.selenium:selenium_api:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (org.seleniumhq.selenium:selenium_remote_driver:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (net.bytebuddy:byte_buddy:jar:1.8.15:compile - omitted for duplicate)
[INFO] | | +- (org.apache.commons:commons_exec:jar:1.3:compile - omitted for duplicate)
[INFO] | | +- (com.google.guava:guava:jar:25.0_jre:compile - omitted for duplicate)
[INFO] | | +- (com.squareup.okhttp3:okhttp:jar:3.11.0:compile - omitted for duplicate)
[INFO] | | \- (com.squareup.okio:okio:jar:1.14.0:compile - omitted for duplicate)
[INFO] | +- org.seleniumhq.selenium:selenium_support:jar:3.141.59:compile
[INFO] | | +- (org.seleniumhq.selenium:selenium_api:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (org.seleniumhq.selenium:selenium_remote_driver:jar:3.141.59:compile - omitted for duplicate)
[INFO] | | +- (net.bytebuddy:byte_buddy:jar:1.8.15:compile - omitted for duplicate)
[INFO] | | +- (org.apache.commons:commons_exec:jar:1.3:compile - omitted for duplicate)
[INFO] | | +- (com.google.guava:guava:jar:25.0_jre:compile - omitted for duplicate)
[INFO] | | +- (com.squareup.okhttp3:okhttp:jar:3.11.0:compile - omitted for duplicate)
[INFO] | | \- (com.squareup.okio:okio:jar:1.14.0:compile - omitted for duplicate)
[INFO] | +- net.bytebuddy:byte_buddy:jar:1.8.15:compile
[INFO] | +- org.apache.commons:commons_exec:jar:1.3:compile
[INFO] | +- com.google.guava:guava:jar:25.0_jre:compile
[INFO] | | +- com.google.code.findbugs:jsr305:jar:1.3.9:compile
[INFO] | | +- org.checkerframework:checker_compat_qual:jar:2.0.0:compile
[INFO] | | +- com.google.errorprone:error_prone_annotations:jar:2.1.3:compile
[INFO] | | +- com.google.j2objc:j2objc_annotations:jar:1.1:compile
[INFO] | | \- org.codehaus.mojo:animal_sniffer_annotations:jar:1.14:compile
[INFO] | +- com.squareup.okhttp3:okhttp:jar:3.11.0:compile
[INFO] | | \- (com.squareup.okio:okio:jar:1.14.0:compile - omitted for duplicate)
[INFO] | \- com.squareup.okio:okio:jar:1.14.0:compile
[INFO] +- io.cucumber:cucumber_core:jar:6.10.2:compile
[INFO] | +- io.cucumber:cucumber_gherkin:jar:6.10.2:compile
[INFO] | | \- (io.cucumber:cucumber_plugin:jar:6.10.2:compile - omitted for duplicate)
[INFO] | +- io.cucumber:cucumber_gherkin_messages:jar:6.10.2:compile
[INFO] | | \- (io.cucumber:cucumber_gherkin:jar:6.10.2:compile - omitted for duplicate)
[INFO] | +- io.cucumber:messages:jar:14.0.1:compile
[INFO] | +- io.cucumber:tag_expressions:jar:3.0.0:compile
[INFO] | +- io.cucumber:cucumber_expressions:jar:10.3.0:compile
[INFO] | | \- (org.apiguardian:apiguardian_api:jar:1.1.0:compile - omitted for conflict with 1.1.1)
[INFO] | +- io.cucumber…
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 03:46:13
[cucumber/cucumber-jvm] Comment on #2288
Unfortunately your dependencies are in order. There are some irregularities but nothing that would explain the flaky tests.
I was wondering how you could use extent reports with Cucumber v6 because the official plug-in transitively pulls in v4. But that seems to have been solved by:
```
+- tech.grasshopper:extentreports_cucumber6_adapter:jar:2.7.0:compile
```
As you are using TestNG you can remove `cucumber-junit`:
```
+- io.cucumber:cucumber_junit:jar:6.10.2:compile
```
Also not relevant to your problem but you can remove this dependency. It is not used by Cucumber v6:
```
+- io.cucumber:cucumber_jvm_deps:jar:1.0.6:compile
```
And you don't need these as explicit dependencies, they're transitive:
```
+- io.cucumber:cucumber_html:jar:0.2.7:compile
+- io.cucumber:gherkin:jar:17.0.2:compile
+- io.cucumber:cucumber_core:jar:6.10.2:compile
```
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 03:49:23
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 04:12:16
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 06:20:52
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled due to failing status checks.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 06:20:53
[cucumber/cucumber-jvm] Comment on #2293
*Branch automerge failure*
This PR was configured for branch automerge, however this is not possible so it has been raised as a PR instead.
* * *
• Branch has one or more failed status checks
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 06:28:29
[cucumber/cucumber-jvm] Comment on #2293
*<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov> Report*
> Merging <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2293> (<a href="https://github.com/cucumber/cucumber-jvm/commit/46d207fa3a40f3cbfc54af822a435928ca297d3c">46d207f</a>) into <https://codecov.io/gh/cucumber/cucumber-jvm/commit/4bda4447a4cbf3a01b219b7fdae25f2db4b67cea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main> (<a href="https://github.com/cucumber/cucumber-jvm/commit/4bda4447a4cbf3a01b219b7fdae25f2db4b67cea">4bda444</a>) will *not change* coverage.
> The diff coverage is `n/a`.
<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Impacted file tree graph>
```
@@ Coverage Diff @@
## main #2293 +/- ##
=========================================
Coverage 83.36% 83.36%
Complexity 2320 2320
=========================================
Files 300 300
Lines 8273 8273
Branches 750 750
=========================================
Hits 6897 6897
Misses 1079 1079
Partials 297 297
```
* * *
<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.
> *Legend* - <https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Click here to learn more>
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov>. Last update <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|4bda444...46d207f>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|comment docs>.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-04-30 08:40:44
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-02 11:47:21
[cucumber/cucumber-jvm] Issue opened by Miles-Ahead-Digital
<p>Hi,<br />
I want to use a central module to create java cucumber java tests.<br />
The module imports import different micro services projects and I have to create different cucumber spring contexts für each service.<br />
The test cases (features, step functions,..) are split into separate packages corresponding to the referenced micro services projects.</p>
<p>But I get this error if from cucumber</p>
<p><code>io.cucumber.core.backend.CucumberBackendException: Glue class class milesahead.aal.customer.CucumberCustomerTest and class milesahead.aal.analyzer.CucumberAnalyzerTest are both annotated with @CucumberContextConfiguration. Please ensure only one class configures the spring context</code></p>
<p>QUESTION: Is it possible to use different spring contexts in one cucumber project? If so - could you provide a little example?</p>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> you posted the same question in gitmemory - any update from your side?</p>
<p>If this setup should work in general but you don't have the time to setup an example - I can try to create a (non-working) multimode example...</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-02 13:46:00
[cucumber/cucumber-jvm] Comment on #2294
In general: Yes, but you must execute cucumber multiple times. Once for each module, each time with a different glue path.
• If you are using the CLI (directly or through an IDE), provide the `--glue` argument for the module your features are in. Otherwise the CLI defaults to scanning the classpath root.
• If you are using `cucumber-junit` please read the java doc on <a href="https://github.com/cucumber/cucumber-jvm/blob/main/junit/src/main/java/io/cucumber/junit/Cucumber.java#L66-L71">`Cucumber.class`</a> and <a href="https://github.com/cucumber/cucumber-jvm/blob/main/junit/src/main/java/io/cucumber/junit/CucumberOptions.java#L46-L69">`CucumberOptions`</a>. In brief, move and duplicate the `@RunWith(Cucumber.class)` annotated class into the package of each module.
• If you are looking to use `cucumber-junit-platform-engine` then you can use <a href="https://github.com/junit-team/junit5/pull/2416">junit-team/junit5#2416</a> to declare multiple suites. Select the package using <a href="https://github.com/junit-team/junit5/blob/main/junit-platform-suite-api/src/main/java/org/junit/platform/suite/api/SelectClasspathResource.java">`@SelectClasspathResource`</a> and use <a href="https://github.com/junit-team/junit5/blob/main/junit-platform-suite-api/src/main/java/org/junit/platform/suite/api/ConfigurationParameter.java">`@ConfigurationParameter`</a> to set <a href="https://github.com/cucumber/cucumber-jvm/tree/main/junit-platform-engine#configuration-options">`cucumber.glue`</a> for each module.
Note: You'll find that this intentionally under documented. Until Cucumber JVM v7 and JUnit 5.8 are released `cucumber-junit-platform-engine` is not a feature complete replacement for `cucumber-junit`. Until then I am expecting that users have a good understanding of all parts involved. If this does not apply to you then you would be better of using `junit-vintage` in combination with `cucumber-junit`.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-02 13:52:39
[cucumber/cucumber-jvm] Comment on #2294
That said, the exception could be clearer and should explain that:
• Cucumber scans the glue path for context configuration
• Cucumber defaults to scanning the class path root unless glue is explicitly configured
• There can only be one context configuration per execution
• Generically direct users to the documentation for their runner (e.g. CLI, `cucumber-junit`, ect)
<a href="https://github.com/cucumber/cucumber-jvm/blob/main/spring/src/main/java/io/cucumber/spring/SpringFactory.java#L93-L94">https://github.com/cucumber/cucumber-jvm/blob/main/spring/src/main/java/io/cucumber/spring/SpringFactory.java#L93-L94</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-04 12:11:28
[cucumber/cucumber-jvm] Comment on #2294
Hi,
I created an example <a href="https://github.com/Miles-Ahead-Digital/cucumber-multimodule">repository</a> using JUnit5 and Spring Context. The "acceptance" module bundles the acceptance test for the module service1 and the module service2.
Please advise how to apply the solution mentioned above to the acceptance module
Thanks a lot in advance
Stefan
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-04 18:31:22
[cucumber/cucumber-jvm] Comment on #1706
Hi, I'd like to have a guidance on how to develop the retry I have the time to work on it and make a PR
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-04 18:31:47
[cucumber/cucumber-jvm] Comment on #2113
Hi, I'd like to have a guidance on how to develop the retry I have the time to work on it and make a PR
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-05 11:16:43
[cucumber/cucumber-jvm] Issue opened by anbajaj
<p><strong>Describe the bug</strong><br />
Multiple tags are not working</p>
<p><strong>To Reproduce</strong><br />
Steps to reproduce the behavior:</p>
<ol><li>Try passing multiple tags as <code>-Dcucumber.filter.tags="@TAG1and @TAG2"</code> in your maven goal</li>
</ol>
<p><strong>Expected behavior</strong><br />
Feature files with both the tags should be executed however the execution is failing with below exception:<br />
at java.base/java.util.ArrayList.forEach(ArrayList.java:1540)<br />
at org.testng.TestRunner.privateRun(TestRunner.java:766)<br />
at org.testng.TestRunner.run(TestRunner.java:587)<br />
at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)<br />
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)<br />
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)<br />
at org.testng.SuiteRunner.run(SuiteRunner.java:286)<br />
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)<br />
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)<br />
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1187)<br />
at org.testng.TestNG.runSuitesLocally(TestNG.java:1109)<br />
at org.testng.TestNG.runSuites(TestNG.java:1039)<br />
at org.testng.TestNG.run(TestNG.java:1007)<br />
at org.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:73)<br />
at org.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:123)</p>
<p>Please see below the dependencies & the version which we are using:<br />
<code>&lt;dependency&gt; &lt;groupId&gt;io.cucumber&lt;/groupId&gt; &lt;artifactId&gt;cucumber-java&lt;/artifactId&gt; &lt;version&gt;6.10.3&lt;/version&gt; &lt;/dependency&gt; &lt;dependency&gt; &lt;groupId&gt;io.cucumber&lt;/groupId&gt; &lt;artifactId&gt;cucumber-testng&lt;/artifactId&gt; &lt;version&gt;6.10.3&lt;/version&gt; &lt;/dependency&gt; &lt;dependency&gt; &lt;groupId&gt;io.cucumber&lt;/groupId&gt; &lt;artifactId&gt;cucumber-jvm&lt;/artifactId&gt; &lt;version&gt;6.10.3&lt;/version&gt; &lt;type&gt;pom&lt;/type&gt; &lt;/dependency&gt; &lt;dependency&gt; &lt;groupId&gt;tech.grasshopper&lt;/groupId&gt; &lt;artifactId&gt;extentreports-cucumber6-adapter&lt;/artifactId&gt; &lt;version&gt;2.8.0&lt;/version&gt; &lt;/dependency&gt;</code></p>
<p>Thank You.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-06 01:00:23
[cucumber/cucumber-jvm] Comment on #1706
My idea is the scenario should rerun immediately after it fails. Simple rerun it again. I dont know if is possible to catch JUnit result if it fails first time and replace it with rerurn result.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-06 09:33:41
[cucumber/cucumber-jvm] Issue opened by Miles-Ahead-Digital
<p>If I run my cucumber gradle task in project which references an (api) module. This Error is thrown:</p>
<pre><code>** What went wrong:
Execution failed for task ':micro:service1:cucumber'.
&gt; Could not resolve all files for configuration ':micro:service1:cucumberRuntime'.
&gt; Could not resolve project :api.
Required by:
project :micro:service1
&gt; Cannot choose between the following variants of project :api:
- productionRuntimeClasspath
- runtimeElements
All of them match the consumer attributes:
- Variant 'productionRuntimeClasspath' capability milesahead.aal:api:0.0.1-SNAPSHOT:
- Unmatched attributes:
- Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
- Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
- Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
- Variant 'runtimeElements' capability milesahead.aal:api:0.0.1-SNAPSHOT:
- Unmatched attributes:
- Provides org.gradle.category 'library' but the consumer didn't ask for it
- Provides org.gradle.dependency.bundling 'external' but the consumer didn't ask for it
- Provides org.gradle.jvm.version '16' but the consumer didn't ask for it
- Provides org.gradle.libraryelements 'jar' but the consumer didn't ask for it
- Provides org.gradle.usage 'java-runtime' but the consumer didn't ask for it
</code></pre>
<p>I created a test <a href="https://github.com/Miles-Ahead-Digital/cucumber-apidep#readme">repository</a> to demonstrate the Error. Please check the Readme.<br />
If there is no module reference the tasks works.</p>
<p>Please advice.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-06 11:11:47
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-06 11:11:47
[cucumber/cucumber-jvm] Comment on #2296
While you seem to use Cucumber in your project it is not readily apparent that this is a problem with Cucumber.
To report a bug you should at least be able to describe what gradle expects from Cucumber and how Cucumber currently behaves.
As such I believe this question may be more suited to StackOverflow.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-07 23:01:37
[cucumber/cucumber-jvm] Comment on #2296
Hi,
as described in the readme I defined the cucumber tasks in gradle which works with service2 (no api reference) but not with service1.
task cucumber() {
dependsOn assemble, testClasses
doLast {
javaexec {
main = "io.cucumber.core.cli.Main"
classpath = configurations.cucumberRuntime + sourceSets.main.output + sourceSets.test.output
args = ['--plugin', 'pretty', '--plugin', 'json:build/cucumber.json', '--plugin', 'html:build/cucumber-reports.html', '--glue', 'milesahead', 'src/test/resources']
}
}
}
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-08 03:53:26
[cucumber/cucumber-jvm] Comment on #2296
So you are unable to configure gradle correctly. This does not appear to be a problem with Cucumber.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-09 08:02:13
[cucumber/cucumber-jvm] Comment on #2295
You’re missing a space before the and.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-09 08:02:13
[cucumber/cucumber-jvm] Issue closed by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-09 08:07:54
[cucumber/cucumber-jvm] Issue opened by punkratz312
<p>please add the possibility to define hard coded execution oder as last workaround. its not hard to implement and wont break general approach that tests need to be independent 💯 right.</p>
<p>As always there might be an exception in case of an initial password change its mandatory that the update password scenario runs first. As otherwise all the other tests would need to deal with this situation too and thats not practicable.</p>
<p>Please implement the feature options they are interpreted all over the internet even tho it has not any effect at all, to define multiple feature blocks. Still the ugly number_prefix workaround must be used to workaround this special case...</p>
<p>Desired solution:</p>
<p><a href="https://user-images.githubusercontent.com/8830888/117272674-b3fea880-ae5b-11eb-92c6-6d2e0b0ad54b.png">image</a></p>
<p>Actual workaround:</p>
<p><a href="https://user-images.githubusercontent.com/8830888/117273272-469f4780-ae5c-11eb-8bd2-9c71bbf8b33f.png">image</a></p>
<p><a href="https://forum.katalon.com/t/how-to-run-multiple-feature-files-in-a-specific-sequence-using-cucumber-runner-class/24327">https://forum.katalon.com/t/how-to-run-multiple-feature-files-in-a-specific-sequence-using-cucumber-runner-class/24327</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-10 08:02:55
[cucumber/cucumber-jvm] Comment on #2295
It was just a typo I believe. It's not working even with a space i.e. `-Dcucumber.filter.tags="@TAG1 and @TAG2"`
<a href="https://github.com/aslakhellesoy">@aslakhellesoy</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-10 09:51:42
[cucumber/cucumber-jvm] Comment on #2295
Please include the full stack trace. It looks like you omitted the exception message.
I don’t see cucumber at all in the stack trace, which makes me wonder if this is related to Cucumber at all.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-10 09:51:42
[cucumber/cucumber-jvm] Issue reopened by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-10 10:10:24
[cucumber/cucumber-jvm] Comment on #2295
looks like there is no exception however the cucumber report shows: No match found for: "undefined" statement.
Below are the console logs at the end of the execution:
[INFO] Running TestSuite
<2021-05-10 12:07:18,601>
: setting environment properties..
┌──────────────────────────────────────────────────────────────────────────┐
│ View your Cucumber Report at: │
│ <a href="https://reports.cucumber.io/reports/74e4e6ff-7ebc-4039-a38d-61a2bac7769f">https://reports.cucumber.io/reports/74e4e6ff-7ebc-4039-a38d-61a2bac7769f</a> │
│ │
│ This report will self-destruct in 24h. │
│ Keep reports forever: <a href="https://reports.cucumber.io/profile">https://reports.cucumber.io/profile</a> │
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.582 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 08:01:35
[cucumber/cucumber-jvm] Comment on #2297
Given that <a href="https://github.com/punkratz312">@punkratz312</a> is using <a href="https://github.com/serenity-bdd/serenity-cucumber">cucumber-serenity</a> rather then `cucumber-jvm` I reckon this request is addressed to the wrong project.
I also don't think this feature is desirable. It will be rather complicated and counter-intuitive to explain and document how this order will be resolved. For example:
```
com/example/feature-001.feature
com/example/ <b>#contains</b> features 01-999
com/example/feature-099.feature
```
This creates the suggestion that feature 001 should go first and feature 099 last, and all other features 002-098, 100-999 in between. But because is 099 part of `com/example/` is clearly shouldn't go last.
Finally the use case for this feature also isn't something we're looking to support. The assumption is that scenarios are independent. The typical solution to the problem is to create a new account for each scenario -- preferably through an API to speed things up. When real world resources are involved it is not always possible to make scenarios truly independent but the complexity of dealing with that should be dealt with by the user rather then framework.
One approach here would be to bring the account in a usable state once before it is used.
```
static boolean passwordReset = false;
@Before
public void resetPassword(){
if(passwordReset){
return;
}
// reset password here
passwordReset = true;
}
```
And some of this complexity will go away once <a href="https://github.com/cucumber/cucumber-jvm/pull/1876">#1876</a> is released.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 08:01:35
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 08:23:29
[cucumber/cucumber-jvm] Comment on #2295
> looks like there is no exception however the cucumber report shows: No match found for: "undefined" statement.
This is a bit ugly but indicates that no scenarios were executed. <a href="https://github.com/cucumber/common/issues/1539">cucumber/common#1539</a>
> It was just a typo I believe. It's not working even with a space i.e. `-Dcucumber.filter.tags="@TAG1 and @TAG2"`
It's most likely that you do not have any features or scenarios tagged with both `@TAG1` and `@TAG2`. If you meant to run scenarios tagged with either `@TAG1` or `@TAG2` you should use `-Dcucumber.filter.tags="@TAG1 or @TAG2"`.
If this does not solve your problem please create a minimal reproducer using the <a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber-java-skeleton</a> and open a new issue.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 08:23:29
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 09:06:29
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>Fixes: <a href="https://github.com/cucumber/cucumber-jvm/issues/2289">#2289</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 09:13:31
[cucumber/cucumber-jvm] Comment on #2298
*<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2298?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov> Report*
> Merging <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2298?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2298> (<a href="https://github.com/cucumber/cucumber-jvm/commit/0ecc0a8a0ce13f394a13368f6535f91a22603047">0ecc0a8</a>) into <https://codecov.io/gh/cucumber/cucumber-jvm/commit/c274fdde66d83a476e69422b2b8f41866576df40?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main> (<a href="https://github.com/cucumber/cucumber-jvm/commit/c274fdde66d83a476e69422b2b8f41866576df40">c274fdd</a>) will *decrease* coverage by `0.00%`.
> The diff coverage is `n/a`.
> ❗ Current head <a href="https://github.com/cucumber/cucumber-jvm/commit/0ecc0a8a0ce13f394a13368f6535f91a22603047">0ecc0a8</a> differs from pull request most recent head <a href="https://github.com/cucumber/cucumber-jvm/commit/6f126b65b452fd07a5c8bb35d6aaee43de449800">6f126b6</a>. Consider uploading reports for the commit <a href="https://github.com/cucumber/cucumber-jvm/commit/6f126b65b452fd07a5c8bb35d6aaee43de449800">6f126b6</a> to get more accurate results
> <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Impacted file tree graph>
```
@@ Coverage Diff @@
## main #2298 +/- ##
============================================
- Coverage 83.36% 83.36% -0.01%
Complexity 2320 2320
============================================
Files 300 300
Lines 8273 8272 -1
Branches 750 750
============================================
- Hits 6897 6896 -1
Misses 1079 1079
Partials 297 297
```
* * *
<https://codecov.io/gh/cucumber/cucumber-jvm/pull/2298?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.
> *Legend* - <https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Click here to learn more>
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2298?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov>. Last update <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2298?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|c274fdd...6f126b6>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|comment docs>.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 09:14:55
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 09:14:55
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 11:03:07
[cucumber/cucumber-jvm] Comment on #2295
<a href="https://github.com/mpkorstanje">@mpkorstanje</a> It looks like the keyword (AND or OR ) was the issue. I tried with Dcucumber.filter.tags="<a href="https://github.com/tag1">@tag1</a> or <a href="https://github.com/tag2">@tag2</a>" & it worked perfectly fine. Thank you and it looks like you have already reported an issue in cucumber report file when where are are no matching tags.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-13 21:59:44
[cucumber/cucumber-jvm] Comment on #2297
Thanks for the suggestion I will give it a try
<#|…>
Sent from my iPhone
On 13. May 2021, at 17:02, M.P. Korstanje ***@***.***> wrote: Given that <a href="https://github.com/punkratz312">@punkratz312</a> is using cucumber-serenity rather then cucumber-jvm I reckon this request is addressed to the wrong project. I also don't think this feature is desirable. It will be rather complicated and counter-intuitive to explain and document how this order will be resolved. For example: com/example/feature-001.feature com/example/ <b>#contains</b> features 01-999 com/example/feature-099.feature This creates the suggestion that feature 001 should go first and feature 099 last, and all other features 002-098, 100-999 in between. But because is 099 part of com/example/ is clearly shouldn't go last. Finally the use case for this feature also isn't something we're looking to support. The assumption is that scenarios are independent. The typical solution to the problem is to create a new account for each scenario -- preferably through an API to speed things up. When real world resources are involved it is not always possible to make scenarios truly independent but the complexity of dealing with that should be dealt with by the user rather then framework. One approach here would be to bring the account in a usable state once before it is used. static boolean passwordReset = false; <a href="https://github.com/before">@before</a> public void resetPassword(){ if(passwordReset){ return; } // reset password here passwordReset = true; } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-15 11:39:19
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
cucumber/messages-java
<strong><a href="https://togithub.com/cucumber/messages-java/compare/v15.0.0...v16.0.0"><code>v16.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/messages-java/compare/v15.0.0...v16.0.0">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-15 12:00:21
[cucumber/cucumber-android] Issue opened by juanmendez
<p>Hi, I try to run the Cukeulator demo, and each time I for instance run <code>division.feature</code> I get this error<br />
I was hoping to know if anyone else has faced this issue. Thank you.</p>
<pre><code>java.lang.IllegalStateException: No instrumentation registered! Must run under a registering instrumentation.
at androidx.test.platform.app.InstrumentationRegistry.getInstrumentation(InstrumentationRegistry.java:45)
at androidx.test.rule.ActivityTestRule.&lt;init&gt;(ActivityTestRule.java:148)
at cucumber.cukeulator.test.CalculatorActivitySteps.&lt;init&gt;(CalculatorActivitySteps.java:39)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at org.picocontainer.injectors.AbstractInjector.newInstance(AbstractInjector.java:145)
at org.picocontainer.injectors.ConstructorInjector$1.run(ConstructorInjector.java:342)
at org.picocontainer.injectors.AbstractInjector$ThreadLocalCyclicDependencyGuard.observe(AbstractInjector.java:270)
at org.picocontainer.injectors.ConstructorInjector.getComponentInstance(ConstructorInjector.java:364)
at org.picocontainer.injectors.AbstractInjectionFactory$LifecycleAdapter.getComponentInstance(AbstractInjectionFactory.java:56)
at org.picocontainer.behaviors.AbstractBehavior.getComponentInstance(AbstractBehavior.java:64)
at org.picocontainer.behaviors.Stored.getComponentInstance(Stored.java:91)
at org.picocontainer.DefaultPicoContainer.getInstance(DefaultPicoContainer.java:699)
at org.picocontainer.DefaultPicoContainer.getComponent(DefaultPicoContainer.java:647)
at org.picocontainer.DefaultPicoContainer.getComponent(DefaultPicoContainer.java:678)
at io.cucumber.picocontainer.PicoFactory.getInstance(PicoFactory.java:42)
at cucumber.runtime.java.ObjectFactoryLoader$ObjectFactoryAdapter.getInstance(ObjectFactoryLoader.java:157)
at cucumber.runtime.java.JavaHookDefinition.execute(JavaHookDefinition.java:65)
at cucumber.runner.HookDefinitionMatch.runStep(HookDefinitionMatch.java:16)
at cucumber.runner.TestStep.executeStep(TestStep.java:65)
at cucumber.runner.TestStep.run(TestStep.java:50)
at cucumber.runner.TestCase.run(TestCase.java:50)
at cucumber.runner.Runner.runPickle(Runner.java:50)
at cucumber.runtime.Runtime$1.run(Runtime.java:104)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266)
at java.util.concurrent.FutureTask.run(FutureTask.java)
at cucumber.runtime.Runtime$SameThreadExecutorService.execute(Runtime.java:258)
at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:112)
at cucumber.runtime.Runtime.run(Runtime.java:101)
at io.cucumber.core.cli.Main.run(Main.java:43)
at io.cucumber.core.cli.Main.main(Main.java:14)
</code></pre>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-05-15 14:50:07
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
cucumber/gherkin-java
<strong><a href="https://togithub.com/cucumber/gherkin-java/compare/v18.1.1...v19.0.0"><code>v19.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-java/compare/v18.1.1...v19.0.0">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-16 01:56:30
[cucumber/cucumber-android] Issue closed by lsuski
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-05-16 15:22:29
[cucumber/cucumber-jvm] Issue opened by goblinhecker
<p>Hi.</p>
<p>We use Cucumber for our testing (java based development) and I had a question.</p>
<p>Is it possible to retrieve the tag(s) used when running the java command.</p>
<p>For example, if I run <code>./gradlew cucumber -Ptags="@smoke and @db2"</code> is it possible to get the tags <code>@smoke</code> and <code>@db2</code> ?</p>
<p>Similarly if I run <code>java -cp "**" io.cucumber.core.cli.Main **.feature --glue hellocucumber --tags "@regression and @aws"</code>, is it possible to get <code>@regression</code> and <code>@aws</code> from the code ?</p>
<p>I know there is getsourceTagNames which returns the scenario for the feature file, but I wanted the tags used to run the tests.</p>
<p>Thanks.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-16 20:29:21
[cucumber/cucumber-jvm] Comment on #2301
No. There is no such ability. But this question sounds very much like an example of the XY problem. What are you actually trying to do?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 04:33:31
[cucumber/cucumber-jvm] Issue opened by grandmaximum
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
At our workplace we have been using Cucumber for some while now due to its excellent readability and the possibility to involve colleagues without coding knowledge into our testing process. However, we're currently migrating our code to Quarkus since we're jumping into OpenShift. Since Cucumber is only supporting JUnit 4 and Quarkus doesn't, the Quarkus team said that implementing Cucumber into Quarkus is currently impossible.<br />
<a href="https://github.com/quarkusio/quarkus/issues/11045">quarkusio/quarkus#11045</a></p>
<p><strong>Describe the solution you'd like</strong><br />
For Cucumber to implement support for JUnit 5.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 05:14:58
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 06:37:59
[cucumber/cucumber-jvm] Comment on #2302
It is probably important to understand that Junit 5 isn't a monolith. Rather:
```
JUnit 5 = JUnit Platform + JUnit Jupiter + JUnit Vintage.
```
Cucumber currently supports JUnit 5 with the <a href="https://github.com/cucumber/cucumber-jvm/tree/main/junit-platform-engine">cucumber-junit-platform-engine</a>. Quarkus also supports JUnit 5 but as a JUnit Jupiter extension. While both JUnit 5, these are different things.
I can't verify this, but the solution suggested by <a href="https://github.com/panchitoboy">@panchitoboy</a> <a href="https://github.com/quarkusio/quarkus/issues/11045#issuecomment-825185972">quarkusio/quarkus#11045 (comment)</a> looks like the correct one.
So we can support Qaurkus if you are willing to provide a pull request with a module that implements an `ObjectFactory` for Qaurkus. This module should behave reasonably like the other object factories and come with a minimal amount of documentation that explains its use. For example see <a href="https://github.com/cucumber/cucumber-jvm/tree/main/spring">cucumber-spring</a>.
The <a href="https://github.com/panchitoboy/quarkus-cucumber/blob/quarkus-target/src/test/java/CdiObjectFactory.java">example provided by panchitoboy</a> looks usable as a starting point. Though you may want to move the starting of the application to the `start` method to ensure step definition instances are not shared between tests.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 06:46:50
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
cucumber/html-formatter-java
<strong><a href="https://togithub.com/cucumber/html-formatter-java/compare/v13.0.0...v14.0.0"><code>v14.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/html-formatter-java/compare/v13.0.0...v14.0.0">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 07:30:23
[cucumber/cucumber-jvm] Issue opened by ocherniavskyi-lohika-tix
<p><strong>Describe the bug</strong><br />
Seems spring aop doesnt work for classes loaded by cucumber Spring object factory</p>
<p><strong>To Reproduce</strong><br />
create aspect:</p>
<pre><code>package com.foo
import org.aspectj.lang.ProceedingJoinPoint
import org.aspectj.lang.annotation.Around
import org.aspectj.lang.annotation.Aspect
import org.aspectj.lang.annotation.Pointcut
import org.springframework.stereotype.Component
@Aspect
@Component
class CucumberAspects {
@Pointcut("@annotation(io.cucumber.java.DataTableType)")
fun transformTemplatesInDatatable() {
}
@Around("transformTemplatesInDatatable()")
fun doWrapDatatebleTranformers(pjp: ProceedingJoinPoint): Any {
println("This should wrap all DataTableType")
return pjp.proceed()
}
}
</code></pre>
<p>Add some @DataTableType methods<br />
execute cucumber test and check if "This should wrap all DataTableType" logged to console<br />
<strong>Expected behavior</strong><br />
AOP should work cos classes created by spring</p>
<p><strong>Context & Motivation</strong><br />
We need AOP in our test framework to reduce of code duplication</p>
<p><strong>Your Environment</strong></p>
<p>• Cucumber: 6.9.1
• SpingBoot: 2.4.2</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 08:12:19
[cucumber/cucumber-jvm] Comment on #2305
> AOP should work cos classes created by spring
So why doesn't it? Did you check to see if the aspect was registered in the right bean post processor? Did you check why the step definition beans were not post processed by this aspect? I think you might be missing `@ScenarioScope` to ensure the component is created in the same scope as the step definitions with the annotation but I don't know.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 08:20:17
[cucumber/cucumber-jvm] Comment on #2305
<a href="https://github.com/mpkorstanje">@mpkorstanje</a>
next class contains DataTableType methods:
```
@ScenarioScope
class DataTableTransformers @Autowired constructor(private val templateProcessor: TemplateProcessor) {
}
```
this class is a main configuration class:
```
@SpringBootTest(
classes = [TestingApplication::class])
@CucumberContextConfiguration
class CommonStepsDefinitions(
@Autowired private val vars: ContextVariables
) {}
```
test application:
```
@SpringBootApplication
@EnableConfigurationProperties(
PlatformProperties::class, WiremockProperties::class, UserProfiles::class, OAuth2ClientProperties::class
)
@ComponentScan(
"com.foo.*",
excludeFilters = [ComponentScan.Filter(
type = FilterType.REGEX,
pattern = ["com\\.foo\\.client\\..*"]
)]
)
class TestingApplication
```
we also had junit tests that works ok with AOP - with the same configuration
<a href="https://github.com/mpkorstanje">@mpkorstanje</a> did you ever tried AOP with cucumber?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 08:43:14
[cucumber/cucumber-jvm] Comment on #2305
> <a href="https://github.com/mpkorstanje">@mpkorstanje</a> did you ever tried AOP with cucumber?
Nope. But <a href="https://github.com/cucumber/cucumber-jvm/tree/main/spring">`cucumber-spring`</a> is using Springs `TestContextManager` framework so the delta with JUnit is quite small. And since you know how to use AOP I'm also expecting you to be familiar enough with Spring internals to debug this and provide a more detailed reason why it doesn't work.
> next class contains DataTableType methods:
I don't see any method that could be targeted by `@Pointcut("@annotation(io.cucumber.java.DataTableType)")`.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 09:13:33
[cucumber/cucumber-jvm] Comment on #2305
Gona create a dummy project
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 10:06:01
[cucumber/cucumber-jvm] Comment on #2305
That's a good start. It will make it easier to debug your problem! (For you to start with).
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 12:35:05
[cucumber/cucumber-jvm] Comment on #2301
Hi.
Our testing consists of testing different sources and target combination. Think <a href="https://debezium.io/">Debezium</a>. If you had to test end-to-end testing for Debezium you'd need to test replication works for all different sources and targets. i.e. replication between MySQL to Postgres, Postgres to Kafka, etc.
There are many possibilities.
One way to do this in feature files is have an example where you put the source and targets in data table and iterate over the combinations. That would work but if someone only wanted to test Debezium between MySQL to Kafka, they would have no way to specify this.
Another option would be to have a feature file and each example in the feature file is a different source - target combination. That is bad because it's just redundant lines of text.
So I thought of solving the problem by checking what tag was passed in the gradle or CLI.
Our data table would be
```
Tag | Source | Target
MySQL-PG | MySQL | PG
PG-Kafka | PG | Kafka
```
When iterating over the combination, I want to check if the tag passed in via command matches the `<Tag>` for the combination, if so run that combination. If not then skip it.
Let me know what you think of this.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 13:06:01
[cucumber/cucumber-jvm] Comment on #2301
Sounds like the source and target are not a relevant part of the feature. The behavior doesn't change.
So you could extract these out to an environment variable, configuration file, or a dependency profile and run multiple suites, one for each combination. Most ci-systems have a matrix build feature for this.
And to make it easy on yourself, if no variable is defined, a default is picked.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 18:04:40
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-17 18:04:40
[cucumber/cucumber-jvm] Comment on #2305
Just tried it. Got it to work almost instantly.
```
2021-05-18 03:02:32,167 [main] INFO i.c.e.s.a.CucumberTestContextConfiguration - Started CucumberTestContextConfiguration in 3.602 seconds (JVM running for 6.61)
This should wrap all DataTableType
This should wrap all DataTableType
This should wrap all DataTableType
```
You don't have any method could be targeted by `@Pointcut("@annotation(io.cucumber.java.DataTableType)")`. That's your only problem.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-18 12:23:43
[cucumber/cucumber-jvm] Comment on #2301
That sounds interesting. Can you provide more details please.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-18 13:04:33
[cucumber/cucumber-jvm] Comment on #2301
Not really. It's in essence the same as the mechanism by which you would select a browser and OS to run against in a build matrix.
<a href="https://stackoverflow.com/questions/66374086/is-there-a-way-to-use-a-single-example-file-for-all-cucumber-test">https://stackoverflow.com/questions/66374086/is-there-a-way-to-use-a-single-example-file-for-all-cucumber-test</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-18 13:04:34
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-18 17:01:09
[cucumber/cucumber-jvm] Issue opened by mpkorstanje
<p>When scanning inside a nested Spring Boot jar, cucumber will complain when trying to scan nested jars. Aside from unpacking the offending jars prior to starting the spring boot application, this exception can also be avoided by not scanning the nested parts jars by configuring the glue path.</p>
<pre><code>
private static CucumberException nestedJarEntriesAreUnsupported(URI uri) {
return new CucumberException("" +
"The resource '" + uri + "' is located in a nested jar.\n" +
"\n" +
"This typically happens when trying to run Cucumber inside a Spring Boot Executable Jar.\n" +
"Cucumber currently doesn't support classpath scanning in nested jars.\n" +
"Feel free to send a pull request to make this possible!\n" +
"\n" +
"You can avoid this error by unpacking your application before executing.");
}
</code></pre>
<p>This solution is described by <code>classPathScanningExplanation</code> and should be included in <code>nestedJarEntriesAreUnsupported</code>.</p>
<pre><code> public static String classPathScanningExplanation() {
return "By default Cucumber scans the entire classpath for step definitions.\n" +
"You can restrict this by configuring the glue path.\n" +
"\n" +
"Examples:\n" +
" - @CucumberOptions(glue = \"com.example.application\")\n" +
" - src/test/resources/junit-platform.properties cucumber.glue=com.example.application\n" +
" - src/test/resources/cucumber.properties cucumber.glue=com.example.application\n";
}
</code></pre>
<p>Context: <a href="https://stackoverflow.com/questions/67594892/spring-boot-unpack-application-before-executing/67595472#67595472">https://stackoverflow.com/questions/67594892/spring-boot-unpack-application-before-executing/67595472#67595472</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-20 06:28:30
[cucumber/cucumber-jvm] Comment on #1829
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-20 06:28:31
[cucumber/cucumber-jvm] Comment on #1931
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-20 06:28:32
[cucumber/cucumber-jvm] Comment on #1936
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-21 14:25:51
[cucumber/cucumber-android] Issue opened by mattwynne
<p>We've made a decision to do this on an organisation-wide basis. See <a href="https://github.com/cucumber/common/issues/1507">cucumber/common#1507</a> for details.</p>
<p>I've gone ahead and renamed the branch, as it looked as though it shouldn't break any of your CI automation. If it does, please shout and we can always revert and take a more patient go at it.</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-05-21 14:25:54
[cucumber/cucumber-android] Issue closed by mattwynne
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-05-24 07:58:41
[cucumber/cucumber-jvm] Issue opened by aslakhellesoy
<p>A user has reported the following stack trace when publishing reports:</p>
<pre><code>Exception in thread "main" java.lang.RuntimeException: javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
at io.cucumber.core.plugin.MessageFormatter.writeMessage(MessageFormatter.java:36)
at io.cucumber.core.eventbus.AbstractEventPublisher.send(AbstractEventPublisher.java:51)
at io.cucumber.core.eventbus.AbstractEventBus.send(AbstractEventBus.java:12)
at io.cucumber.core.runtime.CucumberExecutionContext.emitTestRunFinished(CucumberExecutionContext.java:102)
at io.cucumber.core.runtime.CucumberExecutionContext.finishTestRun(CucumberExecutionContext.java:74)
at io.cucumber.core.runtime.Runtime.run(Runtime.java:101)
at io.cucumber.core.cli.Main.run(Main.java:92)
at io.cucumber.core.cli.Main.main(Main.java:34)
Caused by: javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:131)
at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:369)
at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:312)
at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:307)
at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.checkServerCerts(CertificateMessage.java:1357)
at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.onConsumeCertificate(CertificateMessage.java:1232)
at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.consume(CertificateMessage.java:1175)
at java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:396)
at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:480)
at java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:458)
at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:199)
at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:171)
at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1497)
at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1403)
at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:441)
at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:412)
at java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:574)
at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:183)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream0(HttpURLConnection.java:1419)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream(HttpURLConnection.java:1390)
at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getOutputStream(HttpsURLConnectionImpl.java:220)
at io.cucumber.core.plugin.UrlOutputStream.sendRequest(UrlOutputStream.java:90)
at io.cucumber.core.plugin.UrlOutputStream.sendRequest(UrlOutputStream.java:86)
at io.cucumber.core.plugin.UrlOutputStream.close(UrlOutputStream.java:63)
at java.base/sun.nio.cs.StreamEncoder.implClose(StreamEncoder.java:353)
at java.base/sun.nio.cs.StreamEncoder.close(StreamEncoder.java:168)
at java.base/java.io.OutputStreamWriter.close(OutputStreamWriter.java:252)
at io.cucumber.core.plugin.MessageFormatter.writeMessage(MessageFormatter.java:33)
... 7 more
Caused by: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
at java.base/sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:439)
at java.base/sun.security.validator.PKIXValidator.engineValidate(PKIXValidator.java:306)
at java.base/sun.security.validator.Validator.validate(Validator.java:264)
at java.base/sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509TrustManagerImpl.java:231)
at java.base/sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(X509TrustManagerImpl.java:132)
at java.base/sun.security.ssl.CertificateMessage$T13CertificateConsumer.checkServerCerts(CertificateMessage.java:1341)
... 30 more
Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
at java.base/sun.security.provider.certpath.SunCertPathBuilder.build(SunCertPathBuilder.java:141)
at java.base/sun.security.provider.certpath.SunCertPathBuilder.engineBuild(SunCertPathBuilder.java:126)
at java.base/java.security.cert.CertPathBuilder.build(CertPathBuilder.java:297)
at java.base/sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:434)
</code></pre>
<p>They also told me that they are testing a beta site behind VPN and firewall, and it doesn't have a valid SSL cert.</p>
<p>My hypothesis is that they have defined some <code>javax.net.ssl.**</code> system properties in order to be able to access that beta site, and as a side effect of that, broken their ability to establish SSL connections anywhere else (such as Cucumber Reports).</p>
<p>My proposal is to print the values of all <code>javax.net.ssl.**</code> system properties when this exception occurs, so that this is easier to diagnose.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-24 12:34:14
[cucumber/cucumber-jvm] Comment on #2307
The error itself is pretty clear. It means that the trust store used by the JVM does not have a certificate for the target host.
So either the trust store is really old (it happens), or the trust store was replaced with one containing only the self signed certificate. Finally there is also the remote possibility that they are mitm their own connection and the host is not the host the jvm expects it to be.
What is actually the case should be known and discoverable by the people with the problem. They control the JVM and their own eco system.
So as with any other problem that is purely caused by a users specific needs and setup I don't see a reason to add any complexity to Cucumber to facilitate debugging this.
The cost of not following best practices should fall squarely on the those who don't follow the best practices.
Though what could be more clear is the inclusion of the target host in the exception rather the a plain runtime exception. E.g. "Cucumber couldn't upload a report to host-name".
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-24 21:11:39
[cucumber/cucumber-jvm] Comment on #2307
> diagnose
The usual ways to diagnose SSL problems is described here: <a href="https://docs.oracle.com/javase/7/docs/technotes/guides/security/jsse/ReadDebug.html">https://docs.oracle.com/javase/7/docs/technotes/guides/security/jsse/ReadDebug.html</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-25 11:48:04
[cucumber/cucumber-jvm] Issue opened by ocherniavskyi-lohika-tix
<p>Currently we are using Junit5 console launcher to execute cucumber tests.<br />
Now we want to rerun failed tests but the problem is - i dont know how to set rerun.txt file is income for test discovery</p>
<pre><code>tasks.register&lt;JavaExec&gt;("cucumber") {
outputs.upToDateWhen { false }
dependsOn("testClasses")
val reportsDir = rooJunitResultsFolder.resolve("cucumber")
outputs.dir(reportsDir)
classpath = sourceSets["test"].runtimeClasspath
jvmArgs(javaagent)
main = "org.junit.platform.console.ConsoleLauncher"
args("--select-directory", "$projectDir/src/test/resources")
args("--include-engine", "cucumber")
args("--details", "none")
args("--reports-dir", reportsDir)
}
</code></pre>
<p>i tried to change<br />
args("--select-directory", "$projectDir/src/test/resources")<br />
to<br />
args("--select-file", "$projectDir/rerun.txt")</p>
<p>but no tests executed and rerun.txt context erased</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-25 19:33:12
[cucumber/cucumber-jvm] Comment on #2285
Is there any progress?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-26 00:53:37
[cucumber/cucumber-jvm] Comment on #2285
Not yet. You could help by submitting a pull request.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-27 07:08:13
[cucumber/cucumber-jvm] Comment on #2308
When using JUnit 5 Cucumber is not in control of test execution or selection. JUnit 5 is. So the `cucumber-junit-platform-engine` can not support rerun files.
You can use the <a href="https://junit.org/junit5/docs/current/user-guide/#launcher-api-execution">JUnit Platform API</a> to run your tests. Then once completed you rerun the failed tests in the `TestExecutionSummary`.
You may also want to consider petitioning the JUnit 5 team to support rerunning failed tests through the `ConsoleLauncher`.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-27 07:22:54
[cucumber/cucumber-jvm] Comment on #2308
If some one wants to add an example snippet of how to use the JUnit Platform API to do this, please feel free to add it to the README.md
<a href="https://github.com/cucumber/cucumber-jvm/tree/main/junit-platform-engine">https://github.com/cucumber/cucumber-jvm/tree/main/junit-platform-engine</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-27 20:17:36
[cucumber/cucumber-jvm] Issue opened by dipakkumar1225
<p>Hi, I want to capture screenshots using EventListener.<br />
I know we can use EmbedEvent for this, but there how can i use Scenario.attach()?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-29 07:53:45
[cucumber/cucumber-jvm] Comment on #2309
You can only use `Scenario.attach` in your glue code. For example:
```
import io.cucumber.java.After;
import io.cucumber.java.Scenario;
public class Attachments {
@After
public void after(Scenario scenario) {
if (scenario.isFailed()) {
byte[] data = // get screenshot from somewhere
scenario.attach(data, "image/png", "My screenshot");
}
}
```
When used like this, after each failed scenario an `EmbedEvent` is emitted.
This is currently not documented in:
<a href="https://github.com/cucumber/cucumber-jvm/tree/main/java#hooks">https://github.com/cucumber/cucumber-jvm/tree/main/java#hooks</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-29 07:55:30
[cucumber/cucumber-jvm] Issue opened by mpkorstanje
<p>When using a <code>JavaHookDefinition</code> (@Before/After/BeforeStep/AfterStep`) Cucumber currently does not inform users that hook definitions probably should not be static. While the code itself is generic enough to correctly invoke a static hook definition <a href="https://stackoverflow.com/questions/67725726/how-to-use-autowired-in-beforestep-cucumber-step-definition?noredirect=1#comment119716508_67725726">it does seem to confuse novice users</a>.</p>
<p>So <code>createInvalidSignatureException</code> should be invoked when a hook is static.</p>
<pre><code> @After
public static void after() {
// declaring this should result in an exception
}
@After
public void after() {
// this is fine
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-29 10:25:39
[cucumber/cucumber-jvm] Comment on #2310
I don't see why this should throw an exception just for the sake that *spring*-users are confused when using DI in a wrong way ...
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-29 12:31:55
[cucumber/cucumber-jvm] Comment on #2310
Cucumber is used by people without a lot of programming experience. So the more Cucumber can explain to them what they are doing wrong, the better.
Anyway, do you have any concrete concerns? Will this impact some other use case in a bad way?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-29 19:44:55
[cucumber/cucumber-jvm] Comment on #2310
Hello, I would like to try this as a first issue, trying to contribute to OSS. Can you give me a starting point in code which will help me get started with this issue <a href="https://github.com/mpkorstanje">@mpkorstanje</a> ?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-29 21:45:32
[cucumber/cucumber-jvm] Comment on #2310
At least it will break existing codes without any value, to really help people (at least a basic understand of the used framework (spring here) should be assumed), the cucumber-spring injection-module might better be enhanced to issue a warning/error instead of cucumber-jvm itself.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-30 08:37:06
[cucumber/cucumber-jvm] Comment on #2310
<a href="https://github.com/laeubi">@laeubi</a> I'm looking for a scenario where it might be useful to have static hooks and step definitions -- regardless of the dependency injection container used. Something like <a href="https://github.com/cucumber/cucumber-jvm/issues/1950">#1950</a>, <a href="https://github.com/cucumber/cucumber-jvm/pull/1953">#1953</a>.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-30 10:17:38
[cucumber/cucumber-jvm] Comment on #2310
Maybe its more a style thing, but if a method do not reference any instance field I prefer to make it static and as it is already supported why remove this support for little gain?
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-30 12:16:21
[cucumber/cucumber-jvm] Comment on #2310
Fair enough. That makes sense.
<a href="https://github.com/kishore262">@kishore262</a> I'm afraid you'll have to look at any one of the other issues tagged as help wanted.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-05-30 12:16:22
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-01 09:03:40
[cucumber/cucumber-jvm] Comment on #2279
And looks like `cucumber-java` also doesn't work on Correto.
<a href="https://stackoverflow.com/questions/67787645/cucumber-kotlin-illegalstateexception-when-launching-test-via-intellij?r=SearchResults">https://stackoverflow.com/questions/67787645/cucumber-kotlin-illegalstateexception-when-launching-test-via-intellij?r=SearchResults</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-03 06:21:12
[cucumber/cucumber-jvm] Comment on #2309
Thanks for the reply, As per you feedback, now I am using as below.
<a href="https://github.com/after">@after</a>
public void after(Scenario scenario) {
if (scenario.isFailed()) {
byte[] data =((TakesScreenshot) appiumDriver).getScreenshotAs(OutputType.BYTES);
scenario.attach(data, "image/png", "My screenshot");
}
}
Is there any ways to attach image using custom plugin?
<a href="https://user-images.githubusercontent.com/46619348/120651575-904f7200-c49c-11eb-9b48-5c011512f949.png">image</a>
<a href="https://javadoc.io/doc/io.cucumber/cucumber-plugin/latest/io/cucumber/plugin/event/EventPublisher.html">https://javadoc.io/doc/io.cucumber/cucumber-plugin/latest/io/cucumber/plugin/event/EventPublisher.html</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-05 17:09:51
[cucumber/cucumber-jvm] Comment on #2183
Even with the use of version 4.8.1, is throwing this error.
package stepdefinitions;
import org.junit.Assert;
import io.cucumber.java.en.Given;
import io.cucumber.java.en.Then;
import io.cucumber.java.en.When;
public class BillingSteps {
```
double billingAmount;
double taxAmount;
double finalAmount;
```
<a href="https://github.com/given">@given</a>("user is on billing page")
public void user_is_on_billing_page() {
}
<a href="https://github.com/when">@when</a>("user enters billing amount {int}")
public void user_enters_billing_amount(Integer billingAmount) {
this.billingAmount = billingAmount;
}
<a href="https://github.com/when">@when</a>("user enters tax amount {double}")
public void user_enters_tax_amount(Double taxAmount) {
this.taxAmount = taxAmount;
}
<a href="https://github.com/when">@when</a>("user enters tax amount {int}")
public void user_enters_tax_amount(Integer taxAmount) {
this.taxAmount = taxAmount;
}
<a href="https://github.com/when">@when</a>("user clicks on calculate button")
public void user_clicks_on_calculate_button() {
}
<a href="https://github.com/then">@then</a>("it gives the final amount {int}")
public void it_gives_the_final_amount(Integer finalAmount) {
this.finalAmount = this.billingAmount + this.taxAmount ;
```
Assert.assertTrue(this.finalAmount == finalAmount);
```
}
<a href="https://github.com/then">@then</a>("it gives the final amount {double}")
public void it_gives_the_final_amount(Double finalAmount) {
this.finalAmount = finalAmount;
```
Assert.assertTrue(this.finalAmount == finalAmount);
}
```
}
Jun 06, 2021 12:56:32 AM cucumber.api.cli.Main run
WARNING: You are using deprecated Main class. Please use io.cucumber.core.cli.Main
Exception in thread "main" java.lang.NoClassDefFoundError: Scenario
at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3325)
at java.base/java.lang.Class.privateGetPublicMethods(Class.java:3350)
at java.base/java.lang.Class.getMethods(Class.java:1996)
at cucumber.runtime.java.MethodScanner.scan(MethodScanner.java:39)
at cucumber.runtime.java.JavaBackend.loadGlue(JavaBackend.java:111)
at cucumber.runner.Runner.(Runner.java:39)
at cucumber.runner.SingletonRunnerSupplier.createRunner(SingletonRunnerSupplier.java:38)
at cucumber.runner.SingletonRunnerSupplier.get(SingletonRunnerSupplier.java:32)
at cucumber.runtime.Runtime.run(Runtime.java:85)
at io.cucumber.core.cli.Main.run(Main.java:43)
at cucumber.api.cli.Main.run(Main.java:28)
at cucumber.api.cli.Main.main(Main.java:15)
Caused by: java.lang.ClassNotFoundException: Scenario
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:606)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:168)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
... 13 more
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-05 22:24:41
[cucumber/cucumber-jvm] Issue opened by martinschneider
<p><strong>Describe the bug</strong><br />
Parallel execution doesn't work with <code>junit-vintage-engine</code>. I looked into it and it appears to be an issue with surefire and failsafe rather than Cucumber. However, maybe we could clarify this in the [documentation] (<a href="https://cucumber.io/docs/guides/parallel-execution/">https://cucumber.io/docs/guides/parallel-execution/</a>).</p>
<p><strong>To Reproduce</strong><br />
See <a href="https://issues.apache.org/jira/browse/SUREFIRE-1918">https://issues.apache.org/jira/browse/SUREFIRE-1918</a>.</p>
<p><strong>Expected behavior</strong><br />
Tests being executed in parallel.</p>
<p><strong>Context & Motivation</strong><br />
Parallel execution is a critical feature for many Cucumber users. I want to use JUnit 5 assertions and Cucumber. This works by adding <code>junit-vintage-engine</code> as a runtime dependency. However, this breaks parallel execution of tests with both surefire and failsafe.<br />
From what I can tell this is <a href="https://issues.apache.org/jira/browse/SUREFIRE-1918">a bug in surefire</a> (or just a scenario that's not supported) but I think we could update the [documentation] (<a href="https://cucumber.io/docs/guides/parallel-execution/">https://cucumber.io/docs/guides/parallel-execution/</a>) to highlight that this will not work with JUnit5. Unless, of course, there is a workaround I'm missing.</p>
<p><strong>Screenshots</strong><br />
If applicable, add screenshots to help explain your problem.</p>
<p><strong>Your Environment</strong></p>
<p>• Versions used: 6.10.4
• Operating System and version: Ubuntu 20.04.2 LTS
• Build tool: Apache Maven 3.8.1</p>
<p><strong>Additional context</strong><br />
Add any other context about the problem here.<br />
<a href="https://issues.apache.org/jira/browse/SUREFIRE-1918">https://issues.apache.org/jira/browse/SUREFIRE-1918</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-10 07:49:23
[cucumber/cucumber-jvm] Issue opened by agustingonzalez93
<p>For example, I have a feature with 40 scenarios. I want to execute a method only the first time before scenario 1. This should be like this every time I run the automation.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-10 08:14:16
[cucumber/cucumber-jvm] Comment on #2312
A before hook and a static variable should do the trick.
See: <a href="https://github.com/cucumber/cucumber-jvm/issues/515">#515</a>
Better support will come with the next major version (release date very much on available time)
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-10 08:14:16
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-11 16:43:44
[cucumber/cucumber-jvm] Comment on #1711
The JUnit5 API is a nice API to copy. If you squint a bit you can already see that the `Runtime.Builder` has some aspects of it.
```
FeatureProvider featureProvider = ...;
GlueProvider glueProvider = ...;
Extension diProvider = ...;
Launcher launcher = create(builder()
.addFeatureProvider(featureProvider)
.addGlueProvider(glueProvider)
.addDependencyInjectionProvider(diProvider)
.build());
TestPlan testPlan = launcher.discover(request()
.configurationParameter("config.key", "value")
.filters(tagExpression("@gherkin and not @zukini"))
.selectors(selectPackage("com.example"))
.selectors(selectDirectory("com/example"))
.build());
launcher.execute(testPlan, listeners);
```
A few important points:
• Discovery and execution should be separated. In part to facilitate JUnit 5.
• The `Launcher` is stateless and only contains stateless providers.
• The `*Providers` are stateless services that can also be discovered via SPI.
• The `*Providers` will be given a request to do something and the request will also contain the configuration parameters
• Test discovery and execution are separated
• Listeners/Plugins are entirely external to the test execution and discovery lifecycle.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-11 16:58:28
[cucumber/cucumber-jvm] Comment on #1711
This API doesn't really facilitate IDEs yet:
IDE's would need to be able to:
• Implement their own glue provider that can work with the result of static analysis
• Given a step, discover which step definitions match it
• Be able to correlate step definitions back to a location in source
• Access the TreeRegex for that step definition
• Link parameters in a step definition to their definition
• Link arguments in a step definition to their definition, datatable type or docstring type
I think this mostly comes down to how the glue API and the Gherkin parser API are designed.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 02:47:01
[cucumber/cucumber-android] Issue opened by oradkovskyy-hungerstation
<p>With cloned unmodified repo, I'm not able to run tests using the UI (for example, by right clicking calculate.feature and clicking "Run Feature: calculate') - I'm getting "Undefined scenarios". My run/debug config looks like this:<br />
<a href="https://user-images.githubusercontent.com/70510642/122031861-c31c3300-cdd7-11eb-88c8-e7f1f3bd6d79.png">image</a></p>
<p>Studio version: 4.2.1 build AI-202.7660.**<br />
cucumber-java plugin version: cucumber-java-202.6397.59 (had to install manually, version from marketplace does not work, likely is not compatible with AS)</p>
<p>Answer to possible question re glue: when I just use package, Im always getting <code>No instrumentation registered! Must run under a registering instrumentation.</code></p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-06-15 03:03:57
[cucumber/cucumber-android] Issue closed by lsuski
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-06-15 06:45:11
[cucumber/cucumber-jvm] Issue opened by fslev
<p>Suppose we have the following feature:</p>
<pre><code>Feature: Test Login feature
Scenario Template: Call login API with invalid data &lt;request&gt; and check for correct error message
Then Login with requestBody=&lt;request&gt; and check response=&lt;response&gt;
Examples:
| request | response |
| { "email": "peter@klaven" } | {"status": 400, "body": {"error": "Missing password"}} |
| { "email": "peter", "password": "cityslicka" } | {"status": 400, "body": {"error": "user not found"}} |
Scenario: Create user with valid data and check for correct response from file
Same scenario as above, but define 'expectedCreateUserResponse' scenario property inside file
** load vars from dir "UserCreate/scene1"
When Login with email=eve.holt@reqres.in, password=cityslicka and check response={"status": 200, "body": {"token": "~[token]"}}
Then Create user with name=David Jones, job=pirate and check response=#[expectedCreateUserResponse]
</code></pre>
<p>After running the feature above via the Junit platform engine and Maven surefire plugin, I get the following Junit report:</p>
<pre><code>&lt;testsuite xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd" name="Test Login feature" time="2.021" tests="1" errors="0" skipped="0" failures="0"&gt;
&lt;testcase name="Example #2" classname="Examples" time="1.784"/&gt;
&lt;testcase name="Example #1" classname="Examples" time="1.784"/&gt;
&lt;testcase name="Create user with valid data and check for correct response from file" classname="Test Login feature" time="2.021"/&gt;
</code></pre>
<p>As you can see, the testcase generated from the simple scenario has the correct name. However the tests generated from the scenario template have names based on 'Example' and table row number. Which doesn't provide useful information</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 07:25:01
[cucumber/cucumber-jvm] Issue opened by MajinKLS
<p>Hello to all the community.</p>
<p>My name is Carlos and I'm working in Selenium automation solution using Java, TestNg, Selenium and Cucumber.</p>
<p>I have my own framework wich is suposed to run all testcases passed throught Java's cucumber.options property using the "--name" command. This property is filled automatically in runtime after getting all scenarios names from my test managment repository. My scenario names have identifiers like "PROJECT-TestCaseID" and I want to do an exact match, so I convert them to "^PROJECT-TestCaseID".</p>
<p>I tested this regex with some online interpeters and it worked like a charm but in my framework it matches similar ID's, not the exact one. I tested also adding a "$" anchor to the end of the ID but it does not work. Finally seems to work fine adding a non scaped minus sign at the end of the ID, for example "^PROJECT-TestCaseID-", but I don't understand why this works and I was unable to find any answers.</p>
<p>Can anybody help me to find an answer?<br />
Best regards.</p>
<p>PD: I'm not an expert on regex and everytime I need to work with them it give me headache.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 07:28:11
[cucumber/cucumber-jvm] Comment on #2313
This is a problem between Surefire and JUnit 5. Surefires XML report can not correctly represent the hierarchy in JUnit Nodes beyond what can be mapped to class/method structure. And while we could make this report clearer by including the scenario name, it would make other tools that do integrate properly with JUnit 5 worse.
As such consider petitioning the JUnit and Surefire teams to facilitate this better.
See also:
<a href="https://github.com/junit-team/junit5/issues/373">junit-team/junit5#373</a>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 07:28:11
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:01:21
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:01:25
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:01:26
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:01:28
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:01:57
[cucumber/cucumber-jvm] Comment on #2303
*Renovate Ignore Notification*
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for _any_ future 5.x releases. However, if you upgrade to 5.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:02:02
[cucumber/cucumber-jvm] Comment on #2300
*Renovate Ignore Notification*
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for _any_ future 19.x releases. However, if you upgrade to 19.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:02:05
[cucumber/cucumber-jvm] Comment on #2304
*Renovate Ignore Notification*
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for _any_ future 15.x releases. However, if you upgrade to 15.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:02:09
[cucumber/cucumber-jvm] Comment on #2299
*Renovate Ignore Notification*
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for _any_ future 16.x releases. However, if you upgrade to 16.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:28:06
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-15 13:28:06
[cucumber/cucumber-jvm] Comment on #2314
The `cucumber.options` property was very fragile and has been removed from the more recent versions of Cucumber. This means you are using an older version of Cucumber. This this an open source project ran by people in their spare time. So we don't take bug reports for older versions.
I couldn't reproduce the problem with the latest version. So try reproducing your problem with the <a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber-java-skeleton</a> first. You can find the replacements for `cucumber.options` in <a href="https://github.com/cucumber/cucumber-jvm/tree/main/core#properties-environment-variables-system-options">this list</a>.
If you can still reproduce the problem please feel free to create a new bug report, but do follow the instructions in the template.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 04:51:10
[cucumber/cucumber-jvm] Comment on #2315
(`ObjectMapper` outputs without whitespace or newlines by default.)
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 05:01:20
[cucumber/cucumber-jvm] Comment on #2315
There is a `JSON` object in `messasges` that wraps the `ObjectMapper` with the right settings.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 05:05:36
[cucumber/cucumber-jvm] Issue opened by boris779
<p><strong>Describe the bug</strong><br />
Always get an Exception when starting cucumber tests with a runConfig in IntelliJ or with java command line:</p>
<p>/home/boris/.jdks/openjdk-15.0.1/bin/java -javaagent:/home/boris/idea/lib/idea<em>rt.jar=32965:/home/boris/idea/bin -Dfile.encoding=UTF-8 -classpath /home/boris/repos --tags <a href="https://github.com/boris">@boris</a> --plugin json:target/cucumber-report/json/desktop.json --plugin html:target/cucumber-report/html/desktop-portal --glue at.xxxxxxx</em>webtest.step_definitions src/test/resources/features</p>
<p><code>OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended Jun 16, 2021 1:47:06 PM io.cucumber.core.runtime.Runtime run SEVERE: Exception while executing pickle java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Could resolve the return type of the lambda at CommonSteps.kt:15 at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191) at io.cucumber.core.runtime.Runtime.run(Runtime.java:93) at io.cucumber.core.cli.Main.run(Main.java:92) at io.cucumber.core.cli.Main.main(Main.java:34) Caused by: java.lang.IllegalStateException: Could resolve the return type of the lambda at CommonSteps.kt:15 at io.cucumber.java8.AbstractGlueDefinition.resolveRawArguments(AbstractGlueDefinition.java:80) at io.cucumber.java8.Java8StepDefinition.&lt;init&gt;(Java8StepDefinition.java:25) at io.cucumber.java8.Java8StepDefinition.create(Java8StepDefinition.java:40) at io.cucumber.java8.De.Dann(De.java:387) at at.xxxxxxxxx.step_definitions.CommonSteps.&lt;init&gt;(CommonSteps.kt:15) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:64) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481) at org.picocontainer.injectors.AbstractInjector.newInstance(AbstractInjector.java:145) at org.picocontainer.injectors.ConstructorInjector$1.run(ConstructorInjector.java:342) at org.picocontainer.injectors.AbstractInjector$ThreadLocalCyclicDependencyGuard.observe(AbstractInjector.java:270) at org.picocontainer.injectors.ConstructorInjector.getComponentInstance(ConstructorInjector.java:364) at org.picocontainer.injectors.AbstractInjectionFactory$LifecycleAdapter.getComponentInstance(AbstractInjectionFactory.java:56) at org.picocontainer.behaviors.AbstractBehavior.getComponentInstance(AbstractBehavior.java:64) at org.picocontainer.behaviors.Stored.getComponentInstance(Stored.java:91) at org.picocontainer.DefaultPicoContainer.getInstance(DefaultPicoContainer.java:699) at org.picocontainer.DefaultPicoContainer.getComponent(DefaultPicoContainer.java:647) at org.picocontainer.DefaultPicoContainer.getComponent(DefaultPicoContainer.java:678) at io.cucumber.picocontainer.PicoFactory.getInstance(PicoFactory.java:49) at io.cucumber.java8.Java8Backend.buildWorld(Java8Backend.java:64) at io.cucumber.core.runner.Runner.buildBackendWorlds(Runner.java:101) at io.cucumber.core.runner.Runner.runPickle(Runner.java:67) at io.cucumber.core.runtime.Runtime.lambda$execute$5(Runtime.java:110) at io.cucumber.core.runtime.CucumberExecutionContext.runTestCase(CucumberExecutionContext.java:117) at io.cucumber.core.runtime.Runtime.lambda$execute$6(Runtime.java:110) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java) at io.cucumber.core.runtime.Runtime$SameThreadExecutorService.execute(Runtime.java:233) at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:118) at io.cucumber.core.runtime.Runtime.lambda$run$2(Runtime.java:86) at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) at java.base/java.util.stream.SliceOps$1$1.accept(SliceOps.java:199) at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1602) at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:127) at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:502) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:488) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) at io.cucumber.core.runtime.Runtime.run(Runtime.java:87) ... 2 more</code></p>
<p><strong>To Reproduce</strong><br />
Steps to reproduce the behavior:</p>
<ol><li>Compile selenium/cucumber tests</li><li>See error</li>
</ol>
<p><strong>Expected behavior</strong><br />
It was running since 3 years, but since yesterday I have trouble to run it directly in IntelliJ as CucumberTest</p>
<p><strong>Your Environment</strong></p>
<p>• Versions used 6.10.4
• Operating System and version Ubuntu 20.10.
• Build tool mvn (IntelliJ 2021.1.2)
• Kotlin as Compiler</p>
<p><strong>Additional context</strong><br />
when running test from commandline via mvn, there is no error</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 05:12:28
[cucumber/cucumber-jvm] Comment on #2315
Fixed, thanks
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 05:58:13
[cucumber/cucumber-jvm] Issue opened by KrisztianZagonyiGrad
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
Do cucumber supports running the feature files parallel with Gradle by officially?<br />
I saw some old third party solutions, and I also saw the official documentation with maven, and it works perfect, but I would like to do it with Gradle.<br />
What is the newest and best and easiest way to do this?<br />
Thank you. :)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 06:15:15
[cucumber/cucumber-jvm] Comment on #2316
If you look at the code you can see that we are using <a href="https://github.com/jhalterman/typetools">typetools</a>.
<a href="https://github.com/cucumber/cucumber-jvm/blob/b73b38b5acea8db436b5ddcc41e82dc278087d3d/java8/src/main/java/io/cucumber/java8/AbstractGlueDefinition.java#L74-L83">cucumber-jvm/java8/src/main/java/io/cucumber/java8/AbstractGlueDefinition.java</a>
Lines 74 to 83 in </cucumber/cucumber-jvm/commit/b73b38b5acea8db436b5ddcc41e82dc278087d3d|b73b38b>
Typetools uses implementation details of the JDK to determine the types of lambda method. As such it is likely that you are using an exotic JDK. And because you are using IDEA you may be using IDEA's built-in compiler by mistake (see <a href="https://stackoverflow.com/a/67817085/3945473">https://stackoverflow.com/a/67817085/3945473</a>).
Your options are:
1 ) Ensure you are using a regular JDK
2) Debug typetools
3) Provide a fix to typetools to support IDEA's compiler
This is less then ideal and as such we are considering <a href="https://github.com/cucumber/cucumber-jvm/issues/2279">`cucumber-lambda`</a> as a replacement for `cucumber-java8`.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 06:21:47
[cucumber/cucumber-jvm] Comment on #2317
The answer is complicated and there are no ideal solutions yet. See:
• <a href="https://github.com/gradle/gradle/issues/15435">gradle/gradle#15435</a>
• <a href="https://github.com/gradle/gradle/issues/4773">gradle/gradle#4773</a>
Though using the <a href="https://github.com/cucumber/cucumber-jvm/tree/main/junit-platform-engine">`cucumber-junit-platform-engine`</a> might get you reasonably far. You can use the properties to control parallel execution. If this does not meet your needs, consider using it in combination with the <a href="https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher">JUnit Console Launcher</a> in a custom task.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 06:21:47
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 13:04:57
[cucumber/cucumber-jvm] Issue opened by y5v
<p>Please add retry support for failed scenarios as <code>--retry</code> in cucumber-ruby</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 14:06:30
[cucumber/cucumber-jvm] Comment on #2318
Cucumber JVM will not support retry.
There is no generalized case in which Cucumber can decide what the right way to rerun a failed scenario would be. Nor can we decide how to report it for that matter.
While it may seem fairly straightforward -- if a test fails retry it up to N times until passed -- in practice it has many complications.
For example, if a build fails more then 20% of the tests, there is a good chance that the entire build is broken and retrying all failed tests N times would be a waste of time. Dealing with this would then require a mechanism to abort early.
Or as another example, if a scenario fails with a certain exception it should be retried. But not with certain others. Which would lead to yet another option.
Or perhaps only scenarios with certain tags should be rerun. Yet another option.
Ect.
Ect.
And while we could make this infinitely configurable and extensible, this is a project mostly maintained by volunteers. As such the complexity cost simply isn't worth it.
Instead you may want to consider directing your energy towards either:
1. improving the reliability of your tests or;
2. implementing your own rerun strategy.
You can implement your own rerun strategy using the `--plugin rerun:out.txt` option and then passing the resulting `out.txt` to cucumber as if it was a feature file for up to N times until your tests pass. This isn't great, but it is fairly easy to script into your CI.
If you need something more advanced. JUnit 5 has <a href="https://junit.org/junit5/docs/current/user-guide/#launcher-api">an excellent API for selecting, running and potentially rerunning failed tests</a>. Cucumber integrates with JUnit 5 through the <a href="https://github.com/cucumber/cucumber-jvm/tree/main/junit-platform-engine">cucumber-junit-platform-engine</a>. I believe you'll be able to facilitate most of the examples I've given earlier with it.
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-16 14:06:33
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-18 00:09:52
[cucumber/cucumber-jvm] Comment on #2317
Thank you. :)
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-18 00:29:38
[cucumber/cucumber-android] Issue opened by michgauz
<p>Hello !<br />
Is it possible to run only one specific scenario from Android Studio, without tricks (add a tag for example for the one we wanna test), and without the command line interface ?<br />
I have only the right click option on the androidTest/java folder, then "Run tests", working, but it performs all the tests.</p>
<p>Thanks for your time</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-06-18 06:30:29
[cucumber/cucumber-jvm] Pull request opened by ebreck
<p>--add-plugin is no longer a valid synonym for --plugin; it was removed in <a href="https://github.com/cucumber/cucumber-jvm/commit/839dba7ccc734428d95a628c3886356ed9ed1677">839dba7</a> . But the USAGE still listed it as a synonym.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-18 06:45:55
[cucumber/cucumber-jvm] Comment on #2319
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2319">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2319</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/3ef079d0e07bad82b06a7c1811c3c41ea127216c">3ef079d</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/b73b38b5acea8db436b5ddcc41e82dc278087d3d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/b73b38b5acea8db436b5ddcc41e82dc278087d3d?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b73b38b5acea8db436b5ddcc41e82dc278087d3d">b73b38b</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## main #2319 +/- ##
=========================================
Coverage 83.36% 83.36%
Complexity 2320 2320
=========================================
Files 300 300
Lines 8272 8272
Branches 750 750
=========================================
Hits 6896 6896
Misses 1079 1079
Partials 297 297
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|b73b38b...3ef079d">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2319?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|b73b38b...3ef079d</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-18 06:46:40
[cucumber/cucumber-jvm] Comment on #2319
<p>Hi <a href="https://github.com/ebreck">@ebreck</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-18 06:46:41
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-18 06:46:49
[cucumber/cucumber-jvm] Comment on #2319
<p>Cheers!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-20 02:35:20
[cucumber/cucumber-jvm] Issue opened by artysidorenko
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
Currently when you run scenarios with data tables, the table input is not included in the terminal output.</p>
<p><strong>Describe the solution you'd like</strong><br />
Would like to include these tables in the output. I've got a <a href="https://github.com/cucumber/cucumber-jvm/compare/main...artysidorenko:print-data-tables">forked branch that shows a sample of the required changes I think</a>, however wasn't sure if it's something you would like to have as part of the existing plugin, switched on by default, or if these tables were originally excluded by design, and it's better to have it as some separate option if at all. Let me know what you think.</p>
<p><strong>Describe alternatives you've considered</strong><br />
Was manually printing the tables via the step definitions, however the order of the items in the output was confusing.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-20 04:24:40
[cucumber/cucumber-jvm] Comment on #2320
<p>This is a good suggestion!</p>
<p>To implement this the <a href="https://github.com/cucumber/common/blob/main/datatable/java/datatable/src/main/java/io/cucumber/datatable/TablePrinter.java"><code>TablePrinter</code></a> could be reused.</p>
<p>Though <a href="https://github.com/cucumber/common/blob/main/datatable/java/datatable/src/main/java/io/cucumber/datatable/TablePrinter.java#L27">it currently prints everything at a fixed indent</a> and <a href="https://github.com/cucumber/common/blob/main/datatable/java/datatable/src/main/java/io/cucumber/datatable/TablePrinter.java#L73">escapes the cell content</a>. The latter isn't great for readability. So this could be made configurable. Something like:</p>
<pre><code>DataTablePrinter printer = DataTablePrinter.builder()
.indent(" ")
.escapeCells(false)
.build();
printer.print(table, out);
</code></pre>
<p>Additionally the current <code>TablePrinter</code> and would need a once over to be made part of the public API. Would you like to prepare the PRs for this?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-20 11:49:08
[cucumber/cucumber-jvm] Issue opened by bikashkumarnayak
<p>I am trying to create a maven project so I am adding cucumber-java dependency version 6.10.4. If I<br />
am creating a before method and after method, the maximum time package is missing.</p>
<p><a href="https://user-images.githubusercontent.com/64064727/122684949-3a155980-d226-11eb-8d03-e2ebf232a0a8.png">Screenshot (19)</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-20 11:50:08
[cucumber/cucumber-jvm] Comment on #2321
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-20 11:50:41
[cucumber/cucumber-jvm] Comment on #2321
<p>Can resolve issue ASAP</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-20 12:35:29
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-20 12:35:30
[cucumber/cucumber-jvm] Comment on #2321
<p>Hello <a href="https://github.com/bikashkumarnayak">@bikashkumarnayak</a> this is the issue tracker of an open source project. The project is mostly ran by volunteers. For programming questions you might be better of on Stackoverflow.</p>
<p><a href="https://cucumber.io/docs/guides/10-minute-tutorial/">https://cucumber.io/docs/guides/10-minute-tutorial/</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-20 13:57:19
[cucumber/cucumber-jvm] Comment on #2321
<p>The entitlement of some people 😆</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-20 17:00:53
[cucumber/cucumber-jvm] Comment on #2320
<p>Sure, I'll put something together. Hadn't come across the cucumber/common repo yet but I'll familiarise myself and have a stab at it 👍</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-21 18:57:28
[cucumber/cucumber-jvm] Issue opened by gbalaji94
<p>Hi,</p>
<p>I have a step which contains a datatable, I want the same step to be executed even without a datatable. When I try to do that I get '0 argument error'. Is there any way that I can achieve this?</p>
<p>Thanks in Advance!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 03:38:03
[cucumber/cucumber-jvm] Pull request opened by aslakhellesoy
<p>Many users need help setting environment variables</p>
<p>This updates the banner to point to new docs added in <a href="https://github.com/cucumber/docs/pull/636">cucumber/docs#636</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 03:42:04
[cucumber/cucumber-jvm] Comment on #2323
<p>My editor removed extra trailing whitespace it seems. I hope nobody kicks up a fuss about that :-/</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 03:52:17
[cucumber/cucumber-jvm] Comment on #2323
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2323">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2323</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/6fc9ddfd4ba60e629468ed83c78e631ac25687a6">6fc9ddf</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/798982d86512f7479059a32f3ee59d2161e1953c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/798982d86512f7479059a32f3ee59d2161e1953c?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/798982d86512f7479059a32f3ee59d2161e1953c">798982d</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## main #2323 +/- ##
=========================================
Coverage 83.36% 83.36%
Complexity 2320 2320
=========================================
Files 300 300
Lines 8272 8272
Branches 750 750
=========================================
Hits 6896 6896
Misses 1079 1079
Partials 297 297
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|798982d...6fc9ddf">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2323?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|798982d...6fc9ddf</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 04:07:41
[cucumber/cucumber-jvm] Issue opened by aslakhellesoy
<p><strong>Is your feature request related to a problem? Please describe.</strong></p>
<p>I would like to capture the URL of the published report and send a message to an external service (Slack) with the URL of the report.</p>
<p><strong>Describe the solution you'd like</strong></p>
<p>I want to be able to specify an alternative implementation of <code>UrlReporter</code>, perhaps using a system property:</p>
<pre><code>-Dcucumber.publish.urlreporter=com.acme.MyUrlReporter
</code></pre>
<p>Work involved:</p>
<p>• Split the current <code>UrlReporter</code> class to a <code>UrlReporter</code> interface and a <code>DefaultUrlReporter</code> class
• Use <code>java.util.ServiceLoader</code> to instantiate the class, taken from the <code>cucumber.publish.urlreporter</code> system property</p>
<p><strong>Describe alternatives you've considered</strong></p>
<p>Redirecting STDERR to a file, then parse it with a shell script and send the message. That's quite a roundabout way of doing this.</p>
<p><strong>Additional context</strong></p>
<p>This is actually something that's requested by a user of Cucumber Reports.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 04:20:59
[cucumber/cucumber-jvm] Comment on #2324
<p>I imagine you may be better of by making Cucumber reports a Slack app that makes the call backs. Similar to the Jira and Pagerduty Slack apps.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 04:52:38
[cucumber/cucumber-jvm] Comment on #2323
<p>Mon ami, tu sais quel est mon prénom.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 04:53:12
[cucumber/cucumber-jvm] mpkorstanje approved aslakhellesoy's pull request
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 04:54:10
[cucumber/cucumber-jvm] Comment on #2323
<p>Mmh. There may be a few items that aren't included yet. Check before releasing.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 04:58:14
[cucumber/cucumber-jvm] Comment on #2324
<p>Okay. I am definitely convinced this isn't a good feature. Aside from being a nice example of feature creep, if the cucumber reports app were to make the calls to slack it would allow this functionality to work for all implementations rather then only <code>cucumber-jvm</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 07:12:51
[cucumber/cucumber-jvm] Pull request merged by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 08:22:21
[cucumber/cucumber-jvm] Comment on #2324
<p>I wasn't suggesting implementing the slack logic - I only mentioned slack as an example. All I'm suggesting is to allow users to specify an implementation class of their own.</p>
<p>It could be used to send the result to a variety of destinations, depending on the users' needs. Some possible use cases:</p>
<p>• Send a request to a HTTP API
• Append to a file
• Send an email</p>
<p>The idea is to open up the API so users can capture the URL in their own team/environment/organisation specific way.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 08:50:52
[cucumber/cucumber-jvm] Comment on #2324
<p>I'm aware. I don't think that is worth the complexity. Ideally we provide a plugin system such that these concerns are addressable by the end user. And between a redesign, feature creep or alternative solution I reckon the alternative solution is the better way to support the example usecase.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-22 08:52:50
[cucumber/cucumber-jvm] Comment on #2324
<p>See also: <a href="https://github.com/cucumber/cucumber-jvm/issues/1834">#1834</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-23 00:21:03
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-23 00:21:03
[cucumber/cucumber-jvm] Comment on #2322
<p>It is not possible to make data tables an optional part of the step. Try changing the language in the step instead to reflect that there is no data.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-23 07:02:56
[cucumber/cucumber-jvm] Comment on #2324
<p>I agree we should have a uniform plugin solution rather than many different ones sprinkled across the codebase.</p>
<p>Are you saying that if we implement <a href="https://github.com/cucumber/cucumber-jvm/issues/1834">#1834</a> we might be able to support a pluggable <code>UrlReporter</code> too?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-23 09:22:02
[cucumber/cucumber-jvm] Comment on #2324
<p>No but the publish plugin would have it's own module and it's own api. Part of that API could be a client to talk to the reports api.</p>
<p>People with different use cases could reuse that client in their own plugin. And then for example compose their slack notifier around it.</p>
<p>The biggest challenge is accessing configuration for plugins and url reporters. With a better plugin system we can make that easier. Instead of providing a single purpose extension point by enabling composition we can facilitate much more.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-23 09:25:54
[cucumber/cucumber-jvm] Issue opened by venkataSaiKrishna
<p>I have created a feature file and it was running fine. I did some changes and when I ran the runner file, this error shows up. I fixed all the issues, still getting the same issue. I created a new feature file with only Scenario, still getting the same issue</p>
<p>RunnerFile.Java :<br />
<a href="https://github.com/RunWith">@RunWith</a>(Cucumber.class)<br />
@CucumberOptions(</p>
<pre><code> features="classpath:features",
glue="com.ibm.stepdefs",
tags="@google",
monochrome=true,
plugin = {
"pretty",
"html:target/html/",
"json:target/json/file.json",
"com.aventstack.extentreports.cucumber.adapter.ExtentCucumberAdapter:"
},
strict=false,
dryRun=false
)
</code></pre>
<p>public class RunTest {</p>
<p>}</p>
<p><a href="https://user-images.githubusercontent.com/26459082/123133686-9ddd9380-d46d-11eb-9c25-cc707381ee5a.png">image</a></p>
<p>Now nothing is working, I gave absolute path of my feature file, still same issue. Please help me ... coz I have written so much of code, and this has been working for last 6 months, am suddenly facing the issues</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-23 09:44:47
[cucumber/cucumber-jvm] Comment on #2325
<p>I have checked all the feature files in the features folder and found in one of feature files, I missed | . So I am getting this error to every where</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-23 09:44:50
[cucumber/cucumber-jvm] Issue closed by venkataSaiKrishna
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-23 09:45:00
[cucumber/cucumber-jvm] Comment on #2325
<p>I have checked all the feature files in the features folder and found in one of feature files, I missed | . So I am getting this error to every where</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-23 11:06:04
[cucumber/cucumber-android] Issue opened by rewgoes
<p>If I have a Scenario Outline's name that contains a forward slash ( / ), cucumber stops running and does not run any other steps after that.</p>
<p>Example:</p>
<pre><code>Scenario Outline: This is a scenario/example using forward slash
</code></pre>
<p><strong>Version:</strong><br />
io.cucumber:cucumber_android:4.8.4</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-06-23 12:11:06
[cucumber/cucumber-android] Issue closed by lsuski
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-06-24 03:24:52
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-24 03:25:28
[cucumber/cucumber-jvm] Comment on #2283
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will now ignore this update (2.3.4). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the <code>ignoreDeps</code> array of your renovate config.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-30 05:56:44
[cucumber/cucumber-jvm] Issue opened by aslakhellesoy
<p><strong>Is your feature request related to a problem? Please describe.</strong></p>
<p>Some users use Log4j and want their application logs to end up in the reports.</p>
<p><strong>Describe the solution you'd like</strong></p>
<p>A <code>CucumberLog4jAppender</code> appender class that outputs to <code>Scenario#log</code>. Since a new scenario instance is created for each scenario, we would probably need a static method on the appender that can be called from a hook:</p>
<pre><code>@Before
public void updateAppender(Scenario scenario) {
CucumberLog4jAppender.setScenario(scenario)
}
</code></pre>
<p><strong>Additional context</strong></p>
<p>This should probably be implemented in a separate sub project (<code>/log4j</code>).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-30 06:54:37
[cucumber/cucumber-jvm] Comment on #2326
<p>This seems like the thing users can implement and maintain themselves without our assistance. What would be the benefit of providing this as part of cuucmber-jvm?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-06-30 07:32:20
[cucumber/cucumber-jvm] Comment on #2326
<p>If you want to run this as an experiment consider:</p>
<p>• Use a seperate repository e.g. <code>cucumber-jvm-log2scenario</code>
• Instead of using annotated hooks, implement a <code>Backend</code> that adds these hooks directly to the glue.
• There are multiple logging frameworks for java. Consider either providing modules for all of them or using SLF4J.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-02 09:06:03
[cucumber/cucumber-jvm] Comment on #2326
<p>> What would be the benefit of providing this as part of cuucmber-jvm?</p>
<p>It would benefit users since they have a ready-to-use library. It would benefit maintainers because they don't have to explain over and over again how to implement this. (It's a question we've received three times over the past month in the Intercom support for <a href="http://reports.cucumber.io">reports.cucumber.io</a>).</p>
<p>I think it would be easier to manage releases if it were just another module in this repo.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-02 09:08:04
[cucumber/cucumber-jvm] Comment on #2326
<p>I've added back the <code>good first issue</code> label because it's something I don't think the core team is interested in implementing. I want to sign-post that this is something we would rely on the wider community to contribute.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-02 10:48:18
[cucumber/cucumber-jvm] Comment on #2326
<p>> I think it would be easier to manage releases if it were just another module in this repo.</p>
<p>Maybe after the prototype/incubator stage is done.</p>
<p>Until you've nailed down all the problems the release frequency and general churn is going to be much higher. Not something you can do while also commiting to semver.</p>
<p>> I've added back the good first issue label because it's something I don't think the core team is interested in implementing. I want to sign-post that this is something we would rely on the wider community to contribute.</p>
<p>Given the amount of uncertainty in the exact shape of the solution, the lack of clear acceptance criteria, knowledge of, both Cucumber and logging frameworks required and general lack of clear direction this is any thing but a good first issue.</p>
<p>> It would benefit maintainers because they don't have to explain over and over again how to implement this. (It's a question we've received three times over the past month in the Intercom support for <a href="http://reports.cucumber.io">reports.cucumber.io</a>).</p>
<p>So it would benefit SmartBear, not the maintainers. Though there is some overlap. Yet at the moment it sounds like SmartBear is not interested in sponsoring this.</p>
<p>Perhaps you can start with a lower cost investment and write a blog post instead.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 04:09:06
[cucumber/cucumber-jvm] Issue opened by peterwkc85
<p>Dear All,<br />
I had code multiple features file but only one feature file get executed. I don't know why like this.</p>
<p>I supply the source code for your reference: <a href="https://drive.google.com/file/d/1zgXCxSzoQj70FEVCWQf65n8iQWIcfPxm/view?usp=sharing">https://drive.google.com/file/d/1zgXCxSzoQj70FEVCWQf65n8iQWIcfPxm/view?usp=sharing</a></p>
<p>Please help. Thanks.<br />
<a href="https://github.com/cucumber/cucumber-jvm/files/6759781/cucumber-java-skeleton.zip">cucumber-java-skeleton.zip</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 04:57:28
[cucumber/cucumber-jvm] Comment on #2327
<p>This is the issue tracker of an open source project. For questions and general programming assistance you're probably better of asking a coworker, fellow student, or stack overflow.</p>
<p>If you do think you've found a bug and would like to report it, do follow these guide lines on making a <a href="https://stackoverflow.com/help/mcve">minimal and reproducible example</a>. Read this document and the linked documents closely. Remember that you are asking a complete stranger for help, you should at least put in the effort to make your problem easy to understand.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 04:57:28
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 10:07:53
[cucumber/cucumber-jvm] Issue opened by satya081
<p>........<br />
2021-07-03 19:33:49 DEBUG TestListener:44 - onFinish<br />
2021-07-03 19:33:49 DEBUG SuiteListener:23 - onFinish<br />
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 9.458 s <<< FAILURE! - in TestSuite<br />
[ERROR] europa.edit.testRunner.EC_RepositoryBrowserTestRunner.tearDownClass Time elapsed: 6.484 s <<< FAILURE!<br />
java.lang.RuntimeException: java.net.ConnectException: Connection refused: connect<br />
Caused by: java.net.ConnectException: Connection refused: connect<br />
Caused by: java.net.ConnectException: Connection refused: connect</p>
<p>[INFO]<br />
[INFO] Results:<br />
[INFO]<br />
[ERROR] Failures:<br />
[ERROR] EC_RepositoryBrowserTestRunner>AbstractTestNGCucumberTests.tearDownClass:53 » Runtime<br />
[INFO]<br />
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0<br />
[INFO]<br />
[ERROR] There are test failures.</p>
<p>Please refer to C:\Users\dasatya\workspace\edit\pilot\modules\test-e2e\target\surefire-reports for the individual test results.<br />
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 10:10:25
[cucumber/cucumber-jvm] Issue opened by satya081
<p>How can we use same step definition with different annotation.<br />
e.g- let say there is line in feature which can be used in Then Annotation and AND annonation then how can use same step definition with multiple annotation</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 10:29:48
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 10:29:48
[cucumber/cucumber-jvm] Comment on #2328
<p>This is the issue tracker of an open source project. For questions and general programming assistance you're probably better of asking a coworker, fellow student, or stack overflow.</p>
<p>If you do think you've found a bug and would like to report it, do follow these guide lines on making a <a href="https://stackoverflow.com/help/mcve">minimal and reproducible example</a>. Read this document and the linked documents closely. Remember that you are asking a complete stranger for help, you should at least put in the effort to make your problem easy to understand.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 10:33:37
[cucumber/cucumber-jvm] Comment on #2329
<p>This is the issue tracker of an open source project. For questions you're probably better of asking a coworker, fellow student, or stack overflow.</p>
<p>That said, step definitions do not include the keyword. So all steps in:</p>
<pre><code>Scenario: Do it again
Given I do the thing
And I do the thing
When I do the thing
Then I do the thing
</code></pre>
<p>Will both be matched match by a single step definition:</p>
<pre><code>@Given("I do the thing")
....
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 10:33:37
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-04 15:09:57
[cucumber/cucumber-jvm] Comment on #2330
<p>the code structure is a bit different to how the rest of the step is being printed (<code>out.print(...)</code> on line 133 vs <code>tableFormatter.formatTo(...out)</code> on line 144. Considered formatting the DataTable to a string so I could follow the same pattern but it meant only the first row of the table was getting the right indent.</p>
<p>Let me know if it's worth restructuring the rest of <code>PrettyFormatter.printStep</code> to make this a bit more streamlined.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 00:48:59
[cucumber/cucumber-jvm] Issue opened by void-spark
<p><strong>Describe the bug</strong><br />
With the latest versions of the surefire plugin, no features are executed, or the run fails entirely.</p>
<p><strong>To Reproduce</strong><br />
Steps to reproduce the behavior:<br />
Use the example from: <a href="https://github.com/bonigarcia/mastering-junit5/tree/b19313dc1f6a1b7c4421e84ac9d6afd117c218d5/junit5-cucumber">https://github.com/bonigarcia/mastering-junit5/tree/b19313dc1f6a1b7c4421e84ac9d6afd117c218d5/junit5-cucumber</a><br />
Run it once, everything works fine (surefire 2.22.2):</p>
<pre><code>Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
</code></pre>
<p>In the POM, change surefire to 3.0.0-M3, all still good:</p>
<pre><code>Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
</code></pre>
<p>In the POM, change surefire to 3.0.0-M4, tests are executed (can check with stdout 'ADD' in steps), but not reported:</p>
<pre><code>[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
ADD
ADD
ADD
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
</code></pre>
<p>In the POM, change surefire to 3.0.0-M5, tests are executed (can check with stdout 'ADD' in steps), but not reported,<br />
and an error is logged:</p>
<pre><code>[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[ERROR] jul 06, 2021 9:47:26 AM org.junit.platform.launcher.core.LauncherConfigurationParameters loadClasspathResource
[ERROR] INFO: Loading JUnit Platform configuration parameters from classpath resource [file:/C:/workspace/IdeaProjects/junit5-cucumber/target/test-classes/junit-platform.properties].
ADD
ADD
ADD
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
</code></pre>
<p><strong>Context & Motivation</strong><br />
We just want to use Junit5 + Cucumber, but with the latest versions of everything it just doesn't work.<br />
Since the results are not reported to surefire, it also doesn't fail on errors, so we don't notice if there's a problem.</p>
<p><strong>Your Environment</strong></p>
<p>• Cucmber 6.10.4
• Junit-Jupiter 5.7.2
• Windows 10
• Maven 3.8.1</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 03:02:28
[cucumber/cucumber-jvm] Comment on #2331
<p>You may be expecting a bit too much from a milestone release.</p>
<p>That said, as you are using Cucumber through the JUnit Platform the problem is probably somewhere between Surefire and the JUnit Platform rather then Cucumber. You may want to file an issue there instead.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 03:37:11
[cucumber/cucumber-jvm] Comment on #2331
<p>And I think it's because this section does not include a check for <code>isRootContainer</code>.</p>
<p><a href="https://github.com/apache/maven-surefire/blob/aff6eebe59721ac3c318e277aaba711aca55aee6/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java#L108-L110">https://github.com/apache/maven-surefire/blob/aff6eebe59721ac3c318e277aaba711aca55aee6/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java#L108-L110</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 03:42:56
[cucumber/cucumber-jvm] Comment on #2331
<p>And there is quite a few more bits of code that assume that tests have a class source.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 05:58:44
[cucumber/cucumber-jvm] Issue closed by void-spark
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 05:58:44
[cucumber/cucumber-jvm] Comment on #2331
<p>I'll revert to an older surefire version for now then. Wasn't actually sure what -M meant, I know -RC and -Beta and such :)<br />
We come up with too many acronyms..<br />
Sounds like the surefire team isn't really paying attention to non class sources, I guess Cucumber is one of the few (if any) frameworks using that.<br />
Since this doesn't seem to be a Cucumber issue I'll close this one with this comment.<br />
I'll hold off on posting an issue with them for now, it makes more sense to me for someone who actually understands what's going on to do that :) (And I'm not very fond of their Jira system :) ).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 06:00:12
[cucumber/cucumber-jvm] Comment on #2331
<p>And thank you for your attention, it's certainly appreciated :)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 12:18:49
[cucumber/cucumber-jvm] Pull request opened by sidharta
<p><strong>Is your pull request related to a problem? Please describe.</strong><br />
This PR tries to solve two issues:</p>
<p>• There's no way to provide your own <code>ObjectFactory</code> which was possible in previous versions (4.x and below)
• If you provide a BackendSupplier, that object is not necessarily related to the <code>ObjectFactory</code> that is created on <code>Runtime</code></p>
<p><strong>Describe the solution you have implemented</strong><br />
Following the steps of <code>BackendSupplier</code> and <code>FeatureSupplier</code>, I added a new method to the builder to receive the ObjectFactorySupplier and I'm checking if that is provider it's not necessary to create a new one on <code>.build()</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 13:32:19
[cucumber/cucumber-jvm] Comment on #2332
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2332">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2332</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/8772794014f2cd45f227229d91c3f439b2ec4c85">8772794</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/9dd94ffa38aa304c4b9b72dd1f32affdbc7d03a5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/9dd94ffa38aa304c4b9b72dd1f32affdbc7d03a5?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/9dd94ffa38aa304c4b9b72dd1f32affdbc7d03a5">9dd94ff</a>) will <strong>decrease</strong> coverage by <code>0.04%</code>.<br />
> The diff coverage is <code>50.00%</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## main #2332 +/- ##
============================================
- Coverage 83.36% 83.32% -0.05%
Complexity 2320 2320
============================================
Files 300 300
Lines 8272 8276 +4
Branches 750 751 +1
============================================
Hits 6896 6896
- Misses 1079 1082 +3
- Partials 297 298 +1
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|9dd94ff...8772794">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2332?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|9dd94ff...8772794</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 13:35:35
[cucumber/cucumber-jvm] Comment on #2332
<p>By replacing the <code>ObjectFactorySupplier</code> the <code>ThreadLocalObjectFactorySupplier</code> and <code>SingletonObjectFactorySupplier</code> are no longer correctly applied. Considering making the <code>ObjectFactoryServiceLoader</code> implement the <code>ObjectFactorySupplier</code> and so that <code>ThreadLocalObjectFactorySupplier</code> and <code>SingletonObjectFactorySupplier</code> can be implemented as proper decorators.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-06 13:35:36
[cucumber/cucumber-jvm] mpkorstanje requested changes on sidharta's pull request
<p>Other then the practical problems that you are solving, what are you trying achieve by programatically adding an <code>ObjectFactorySupplier</code>?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-07 03:24:48
[cucumber/cucumber-jvm] Issue opened by Mkrish123
<p>Description:-</p>
<p>On executing feature file step definition snippet is not coming to the console.</p>
<p><strong>To Reproduce</strong><br />
Steps to reproduce the behavior:</p>
<ol><li>select the project and open feature file and run it as cucumber feature.</li>
</ol>
<p>eclipse console output:-</p>
<pre><code>Feature: Login test feature
Scenario: Test Flipkart login page. # C:/Users/HP/eclipse-workspace/CucumberSelenium/src/test/java/Features/login.feature:3
Given: Navigate to the login page.
When: login with valid "username" and "password"
Then: click on login button.
And: Capture the home page.
0 Scenarios
0 Steps
0m0.000s
</code></pre>
<p>In above output step definition snippet suggestion is missing.</p>
<p>+++++++++++++++++++++pom.xml file+++++++++++++++++++++++++++++++</p>
<pre><code>&lt;?xml version="1.0" encoding="UTF-8"?&gt;
&lt;project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"&gt;
&lt;modelVersion&gt;4.0.0&lt;/modelVersion&gt;
&lt;groupId&gt;CucumberSelenium&lt;/groupId&gt;
&lt;artifactId&gt;CucumberSelenium&lt;/artifactId&gt;
&lt;version&gt;0.0.1-SNAPSHOT&lt;/version&gt;
&lt;name&gt;CucumberSelenium&lt;/name&gt;
&lt;!-- FIXME change it to the project's website --&gt;
&lt;url&gt;<http://www.example.com>&lt;/url&gt;
&lt;properties&gt;
&lt;project.build.sourceEncoding&gt;UTF-8&lt;/project.build.sourceEncoding&gt;
&lt;maven.compiler.source&gt;1.7&lt;/maven.compiler.source&gt;
&lt;maven.compiler.target&gt;1.7&lt;/maven.compiler.target&gt;
&lt;/properties&gt;
&lt;dependencies&gt;
&lt;dependency&gt;
&lt;groupId&gt;junit&lt;/groupId&gt;
&lt;artifactId&gt;junit&lt;/artifactId&gt;
&lt;version&gt;4.11&lt;/version&gt;
&lt;/dependency&gt;
&lt;dependency&gt;
&lt;groupId&gt;info.cukes&lt;/groupId&gt;
&lt;artifactId&gt;cucumber-java&lt;/artifactId&gt;
&lt;version&gt;1.2.5&lt;/version&gt;
&lt;/dependency&gt;
&lt;!-- https://mvnrepository.com/artifact/io.cucumber/cucumber-junit --&gt;
&lt;!-- https://mvnrepository.com/artifact/info.cukes/cucumber-junit --&gt;
&lt;dependency&gt;
&lt;groupId&gt;info.cukes&lt;/groupId&gt;
&lt;artifactId&gt;cucumber-junit&lt;/artifactId&gt;
&lt;version&gt;1.2.5&lt;/version&gt;
&lt;scope&gt;test&lt;/scope&gt;
&lt;/dependency&gt;
&lt;dependency&gt;
&lt;groupId&gt;org.seleniumhq.selenium&lt;/groupId&gt;
&lt;artifactId&gt;selenium-java&lt;/artifactId&gt;
&lt;version&gt;3.141.59&lt;/version&gt;
&lt;/dependency&gt;
&lt;/dependencies&gt;
&lt;build&gt;
&lt;pluginManagement&gt;&lt;!-- lock down plugins versions to avoid using Maven defaults (may be moved to parent pom) --&gt;
&lt;plugins&gt;
&lt;!-- clean lifecycle, see https://maven.apache.org/ref/current/maven-core/lifecycles.html#clean_Lifecycle --&gt;
&lt;plugin&gt;
&lt;artifactId&gt;maven-clean-plugin&lt;/artifactId&gt;
&lt;version&gt;3.1.0&lt;/version&gt;
&lt;/plugin&gt;
&lt;!-- default lifecycle, jar packaging: see https://maven.apache.org/ref/current/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging --&gt;
&lt;plugin&gt;
&lt;artifactId&gt;maven-resources-plugin&lt;/artifactId&gt;
&lt;version&gt;3.0.2&lt;/version&gt;
&lt;/plugin&gt;
&lt;plugin&gt;
&lt;artifactId&gt;maven-compiler-plugin&lt;/artifactId&gt;
&lt;version&gt;3.8.0&lt;/version&gt;
&lt;/plugin&gt;
&lt;plugin&gt;
&lt;artifactId&gt;maven-surefire-plugin&lt;/artifactId&gt;
&lt;version&gt;2.22.1&lt;/version&gt;
&lt;/plugin&gt;
&lt;plugin&gt;
&lt;artifactId&gt;maven-jar-plugin&lt;/artifactId&gt;
&lt;version&gt;3.0.2&lt;/version&gt;
&lt;/plugin&gt;
&lt;plugin&gt;
&lt;artifactId&gt;maven-install-plugin&lt;/artifactId&gt;
&lt;version&gt;2.5.2&lt;/version&gt;
&lt;/plugin&gt;
&lt;plugin&gt;
&lt;artifactId&gt;maven-deploy-plugin&lt;/artifactId&gt;
&lt;version&gt;2.8.2&lt;/version&gt;
&lt;/plugin&gt;
&lt;!-- site lifecycle, see https://maven.apache.org/ref/current/maven-core/lifecycles.html#site_Lifecycle --&gt;
&lt;plugin&gt;
&lt;artifactId&gt;maven-site-plugin&lt;/artifactId&gt;
&lt;version&gt;3.7.1&lt;/version&gt;
&lt;/plugin&gt;
&lt;plugin&gt;
&lt;artifactId&gt;maven-project-info-reports-plugin&lt;/artifactId&gt;
&lt;version&gt;3.0.0&lt;/version&gt;
&lt;/plugin&gt;
&lt;/plugins&gt;
&lt;/pluginManagement&gt;
&lt;/build&gt;
&lt;/project&gt;
</code></pre>
<p>please help me to solve the issue...</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-07 03:26:09
[cucumber/cucumber-jvm] Comment on #2333
<p>Do you have the same issue when executing the tests from within a terminal directly and not using the eclipse plugin?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-07 03:32:39
[cucumber/cucumber-jvm] Comment on #2333
<p>Not tried through terminal.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-07 04:47:58
[cucumber/cucumber-jvm] Comment on #2333
<p>You're using a very old version of Cuucmber. You should probably upgrade to the latest version first.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/tree/main/release-notes">https://github.com/cucumber/cucumber-jvm/tree/main/release-notes</a></p>
<p>And since it looks like you are starting fresh, consider following the tutorial to get a proper start:</p>
<p><a href="https://cucumber.io/docs/guides/10-minute-tutorial/">https://cucumber.io/docs/guides/10-minute-tutorial/</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-07 04:48:00
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-07 12:02:39
[cucumber/cucumber-jvm] Issue opened by jparams
<p><strong>Describe the bug</strong><br />
ThreadLocalRunnerSupplier leaks memory because the thread local is not cleared at the end of the test.</p>
<p>The simplest fix would be to add a finalize method which clears the thread local. As your compile target is Java 8, this should still be fine. The other option is to make the supplier closable, and make sure the supplier is closed at the end of the test.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-07 15:36:47
[cucumber/cucumber-jvm] Comment on #2334
<p>Could you explain the circumstances needed to reproduce this?</p>
<p>Afaik once the <code>ThreadLocalRunnerSupplier</code> is eligible for garbage collection so should the thread local be.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 03:19:39
[cucumber/cucumber-jvm] Comment on #2334
<p>The thread local will be garbage collected once the Thread is garbage collected, not when ThreadLocalRunnerSupplier is garbage collected.</p>
<p>Admittedly, I am not using Cucumber in the most conventional way, but I have a wrapper around Cucumber to run the same set of tests several times. The idea is to simulate a soak test. However, each execution of Cucumber leaks memory and eventually my soak test end with an out of memory error.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 06:00:46
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
cucumber/messages-java
<strong><a href="https://togithub.com/cucumber/messages-java/compare/v16.0.1...v17.0.0"><code>v17.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/messages-java/compare/v16.0.1...v17.0.0">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/messages-java/compare/v16.0.0...v16.0.1"><code>v16.0.1</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/messages-java/compare/v16.0.0...v16.0.1">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/messages-java/compare/v15.0.0...v16.0.0"><code>v16.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/messages-java/compare/v15.0.0...v16.0.0">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 06:41:44
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 06:42:26
[cucumber/cucumber-jvm] Comment on #2335
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for <em>any</em> future 17.x releases. However, if you upgrade to 17.x manually then Renovate will then reenable updates for minor and patch updates automatically.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 07:45:46
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
cucumber/gherkin-java
<strong><a href="https://togithub.com/cucumber/gherkin-java/compare/v19.0.3...v20.0.0"><code>v20.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-java/compare/v19.0.3...v20.0.0">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/gherkin-java/compare/v19.0.2...v19.0.3"><code>v19.0.3</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-java/compare/v19.0.2...v19.0.3">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/gherkin-java/compare/v19.0.1...v19.0.2"><code>v19.0.2</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-java/compare/v19.0.1...v19.0.2">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/gherkin-java/compare/v19.0.0...v19.0.1"><code>v19.0.1</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-java/compare/v19.0.0...v19.0.1">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/gherkin-java/compare/v18.1.1...v19.0.0"><code>v19.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-java/compare/v18.1.1...v19.0.0">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 07:53:51
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 07:54:32
[cucumber/cucumber-jvm] Comment on #2336
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for <em>any</em> future 20.x releases. However, if you upgrade to 20.x manually then Renovate will then reenable updates for minor and patch updates automatically.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 12:43:28
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 12:51:47
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 12:52:24
[cucumber/cucumber-jvm] Comment on #2337
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for <em>any</em> future 6.x releases. However, if you upgrade to 6.x manually then Renovate will then reenable updates for minor and patch updates automatically.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 14:14:24
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
cucumber/html-formatter-java
<strong><a href="https://togithub.com/cucumber/html-formatter-java/compare/v15.0.2...v16.0.0"><code>v16.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/html-formatter-java/compare/v15.0.2...v16.0.0">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/html-formatter-java/compare/v15.0.1...v15.0.2"><code>v15.0.2</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/html-formatter-java/compare/v15.0.1...v15.0.2">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/html-formatter-java/compare/v15.0.0...v15.0.1"><code>v15.0.1</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/html-formatter-java/compare/v15.0.0...v15.0.1">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/html-formatter-java/compare/v14.0.0...v15.0.0"><code>v15.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/html-formatter-java/compare/v14.0.0...v15.0.0">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/html-formatter-java/compare/v13.0.0...v14.0.0"><code>v14.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/html-formatter-java/compare/v13.0.0...v14.0.0">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 14:38:13
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 14:38:52
[cucumber/cucumber-jvm] Comment on #2338
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for <em>any</em> future 16.x releases. However, if you upgrade to 16.x manually then Renovate will then reenable updates for minor and patch updates automatically.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 17:15:23
[cucumber/cucumber-jvm] Comment on #2331
<p>Let's keep this open. Just in case some one else has time to do the leg work.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-08 17:15:24
[cucumber/cucumber-jvm] Issue reopened by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-11 14:11:02
[cucumber/cucumber-jvm] Comment on #2334
<p>With normal use both the thread using the threadlocal and the threadlocal are eligible for garbage collection. So no references should remain. Do you have a memory dump or a reproducer?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-11 14:12:35
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-12 10:23:57
[cucumber/cucumber-android] Issue opened by sylwek845
<p><strong>Describe the bug</strong><br />
Trying to run Dagger Hilt Rule and Cucumber tests, and it seems like the Hilt Rule is not getting invoked. Hilt Injection seems to be working without cucumber with exact the same setup.</p>
<p>Thats my custom runner</p>
<pre><code>class ScreenshotTestRunner : CucumberAndroidJUnitRunner() {
override fun onCreate(bundle: Bundle?) {
super.onCreate(bundle)
ScreenshotRunner.onCreate(this, bundle)
ComposeScreenshotRunner.onCreate(this)
}
override fun onDestroy() {
ScreenshotRunner.onDestroy()
super.onDestroy()
}
override fun finish(resultCode: Int, results: Bundle?) {
ScreenshotRunner.onDestroy()
ComposeScreenshotRunner.onDestroy()
super.finish(resultCode, results)
}
override fun newApplication(
cl: ClassLoader,
appName: String,
context: Context
): Application {
return super.newApplication(
cl, HiltTestApplication::class.java.name, context
)
}
}
</code></pre>
<p><strong>Additional context</strong><br />
Add any other context about the problem here.</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-07-12 17:21:22
[cucumber/cucumber-android] Pull request opened by juanmendez
<p>Updates to different libraries.</p>
<p><strong>Description</strong></p>
<p>• support for latest Gradle dependency versions.
• support for deprecated <code>ActivityTestRule</code> in favor of <code>ActivityScenario</code>
• Kotlin 1.5
• removed use of jcenter repository in cukeulator module.</p>
<p><em>Describe your changes in detail</em></p>
<p><strong>Motivation & context</strong></p>
<p>The demo app uses old dependencies, and deprecated <code>ActivityTestRule</code><br />
<em>Why is this change required? What problem does it solve?<br />
If it fixes an open issue, please link to the issue here.</em></p>
<p><em>e.g. "Fixes #99"</em></p>
<p><strong>Type of change</strong></p>
<p>• Refactoring/debt (improvement to code design or tooling without changing behaviour)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new behaviour)
• Breaking change (will cause existing functionality to not<br />
work as expected)</p>
<p><em>Remember to add an entry to the relevant section of CHANGELOG.md as part of this pull request.</em></p>
<p><strong>Note to other contributors</strong></p>
<p><em>If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.</em></p>
<p><strong>Update required of <a href="http://cucumber.io/docs**|cucumber.io/docs**">http://cucumber.io/docs</strong>|cucumber.io/docs**</a></p>
<p><em>If the <a href="https://cucumber.io/docs/">Cucumber documentation</a> will require an update,<br />
submit an issue or ideally a pull request to <a href="https://github.com/cucumber/docs/">cucumber/docs</a> and<br />
reference it here.</em></p>
<p><em>e.g. "Ref: cucumber/docs/pull/#99"</em></p>
<p><strong>Checklist:</strong></p>
<p>☐ My code follows the code style of this project.
☐ My change requires a change to the documentation.
☐ I have updated the documentation accordingly.
☐ I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.
☐ I have added tests to cover my changes.
☐ All new and existing tests passed.</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-07-13 06:48:25
[cucumber/cucumber-jvm] Issue opened by Renaud11232
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
I'm trying to implement tests using SerenityBDD with Cucumber6. Serenity provides a way to define and report manual tests using normal <code>.feature</code> files. Since these features are manual tests, they don't need Step definitions.</p>
<p>Without the ability to set <code>strict=false</code> in the <code>@CucumberOptions</code>, every manual test is throwing a <code>io.cucumber.java.PendingException</code> and makes the test fail.</p>
<p><strong>Describe the solution you'd like</strong><br />
Re-introduce a way to configure tests in a way that don't make them fail if they have undefined steps. IE by re-adding an alternative to <code>strict=false</code>.</p>
<p><strong>Describe alternatives you've considered</strong><br />
So far, I haven't found any alternative.<br />
Filtering out the features that have the <code>@manual</code> tag also removes them from the generated live documentation.</p>
<p>Thanks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-13 07:24:14
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-13 07:24:14
[cucumber/cucumber-jvm] Comment on #2339
<p>A non-strict mode or any variation there off will not come back.</p>
<p>As a work around you could implement the steps. In these steps, if the <code>CI</code> environment variable is set to <code>true</code>, you can throw any of these exceptions to mark the step as skipped.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/bb8f6bb1e007870b79d8d43d828be6490b6d3189/core/src/main/java/io/cucumber/core/runner/TestStep.java#L28-L33">cucumber-jvm/core/src/main/java/io/cucumber/core/runner/TestStep.java</a></p>
<p>Lines 28 to 33 in </cucumber/cucumber-jvm/commit/bb8f6bb1e007870b79d8d43d828be6490b6d3189|bb8f6bb></p>
<p>But as as you are using SerenityBDD you'll really have to pick take this up with them.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-15 17:20:51
[cucumber/cucumber-jvm] Issue opened by mithunkoppal
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
Currently we have a lot of step definitions written using cucumber-java8. If and when cucumber-java8 is deprecated and we have to start using cucumber-lambda, is there a plan to provide a converter or a migration tool to convert the java8-style step definitions to cucumber-lambda-style?</p>
GitHub
2021-07-16 02:46:11
[cucumber/cucumber-jvm] Comment on #2340
<p>There is not. Would you potentially be wiling to open source a solution?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-16 10:53:57
[cucumber/cucumber-jvm] Issue opened by nddipiazza
<p>I find myself wishing there was a simple SDK with the ability to pretty print (format) gherkin files.</p>
<p>Like how intellij cucumber plugin formats them is exactly what I want.</p>
<p>Is there some way to add a simple static method for this?</p>
<p><code>GherkinFormatter.prettyPrint(gherkinString)</code></p>
<p>I think there is a way to do this with the library, but it's not as simple.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-16 18:30:33
[cucumber/cucumber-jvm] Comment on #1829
<p>In Kotlin I think I would prefer to write something like this:</p>
<pre><code>class StepDefinitions(belly: Belly) {
@Given
fun `there are {int} cukes in my belly`(cukes : Int){
belly.setCukes(cukes)
}
}
</code></pre>
<p>Is it as simple as saying that if the description is not provided, the name of the method is used as the description?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-16 19:14:01
[cucumber/cucumber-jvm] Issue opened by hakanai
<p><strong>Given</strong> you are implementing a feature:</p>
<pre><code>Feature: HTML-safe Strings
Scenario: A string is created
Given an HTML-safe string html_safe("blah")
Then it converts to HTML "blah"
</code></pre>
<p><strong>And</strong> step definitions:</p>
<pre><code>import assertk.assertThat
import assertk.assertions.isEqualTo
import io.cucumber.java8.En
class HtmlSafeStringStepdefs: En {
var htmlSafeString: HtmlSafeString? = null
init {
ParameterType("html_safe_string", "html_safe\\({string}\\)") { string: String -&gt;
HtmlSafeString(string)
}
Given("an HTML-safe string {html_safe_string})") { string: HtmlSafeString -&gt;
htmlSafeString = string
}
Then("it converts to HTML {string}") { string: String -&gt;
assertThat(htmlSafeString).isEqualTo(string)
}
}
}
</code></pre>
<p><strong>And</strong> supposing you implemented the class like this:</p>
<pre><code>@JvmInline
value class HtmlSafeString(private val content: String) {
fun toHtml() {
content
}
}
</code></pre>
<p><strong>When</strong> you compile, everything goes fine.</p>
<p><strong>Then</strong> when you run, you expect the specifications to be run.</p>
<p><strong>But</strong> you actually get this:</p>
<pre><code>Failed to instantiate class com.example.bug.HtmlSafeStringStepdefs
io.cucumber.core.exception.CucumberException: Failed to instantiate class com.example.bug.HtmlSafeStringStepdefs
at io.cucumber.core.runtime.ObjectFactoryServiceLoader$DefaultJavaObjectFactory.cacheNewInstance(ObjectFactoryServiceLoader.java:135)
at io.cucumber.core.runtime.ObjectFactoryServiceLoader$DefaultJavaObjectFactory.getInstance(ObjectFactoryServiceLoader.java:121)
at io.cucumber.java8.Java8Backend.buildWorld(Java8Backend.java:63)
at io.cucumber.core.runner.Runner.buildBackendWorlds(Runner.java:167)
at io.cucumber.core.runner.Runner.runPickle(Runner.java:62)
at io.cucumber.junit.PickleRunners$NoStepDescriptions.run(PickleRunners.java:149)
at io.cucumber.junit.FeatureRunner.runChild(FeatureRunner.java:83)
at io.cucumber.junit.FeatureRunner.runChild(FeatureRunner.java:24)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at io.cucumber.junit.Cucumber.runChild(Cucumber.java:185)
at io.cucumber.junit.Cucumber.runChild(Cucumber.java:83)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at io.cucumber.junit.Cucumber$RunCucumber.evaluate(Cucumber.java:219)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:119)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
at io.cucumber.core.runtime.ObjectFactoryServiceLoader$DefaultJavaObjectFactory.cacheNewInstance(ObjectFactoryServiceLoader.java:129)
... 54 more
Caused by: java.lang.IllegalStateException: Expected single 'accept' method on body class, found '[]'
at io.cucumber.java8.AbstractGlueDefinition.getAcceptMethod(AbstractGlueDefinition.java:41)
at io.cucumber.java8.AbstractGlueDefinition.&lt;init&gt;(AbstractGlueDefinition.java:21)
at io.cucumber.java8.Java8ParameterTypeDefinition.&lt;init&gt;(Java8ParameterTypeDefinition.java:21)
at io.cucumber.java8.LambdaGlue.ParameterType(LambdaGlue.java:464)
at com.example.bug.HtmlSafeStringStepdefs.&lt;init&gt;(HtmlSafeStringStepdefs.kt:11)
... 59 more
</code></pre>
<p>• Java 11
• Kotlin 1.5.21
• AssertK 0.22
• Cucumber JVM 5.7.0</p>
<p><a href="https://github.com/hakanai/cucumber-java-bug-repro">Demo repository here</a></p>
<p>Where I actually hit this was trying to wrap <code>Tuple</code> into <code>Point</code> and <code>Vector</code> value classes for <a href="https://github.com/ephemeral-laboratories/red-rocket">Red Rocket</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-17 02:47:00
[cucumber/cucumber-jvm] Comment on #1829
<p>> Is it as simple as saying that if the description is not provided, the name of the method is used as the description?</p>
<p>Unfortunately not. See: <a href="https://github.com/cucumber/cucumber-jvm/issues/1829#issuecomment-558640666">#1829 (comment)</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-17 04:00:37
[cucumber/cucumber-jvm] Comment on #2342
<p>There is an unrelated mistake in the regex of the parameter type of your reproducer. So to make this discussion easier I will be using this parameter type declaration to trigger the exception:</p>
<pre><code>package com.example.bug
import io.cucumber.java8.En
class HtmlSafeStringStepdefs : En {
init {
ParameterType("html_safe_string", "html_safe\\(\"(.**)\"\\)") { string: String -&gt;
HtmlSafeString(string)
}
}
}
</code></pre>
<p>And this is essentially the same as using a lambda reference:</p>
<pre><code>package com.example.bug
import io.cucumber.java8.En
class HtmlSafeStringStepdefs: En {
var htmlSafeString: HtmlSafeString? = null
init {
ParameterType("html_safe_string", "html_safe\\(\"(.**)\"\\)", ::HtmlSafeString)
}
}
</code></pre>
<p>When declaring a <code>ParameterType</code> Cucumber expects the lambda argument to be a subclass of <code>ParameterDefinitionBody.A1&lt;T&gt;</code> with an <code>accept</code> method.</p>
<p>Because <code>A1&lt;T&gt;</code> is generic the JVM will add in bridge methods (see <a href="http://www.angelikalanger.com/GenericsFAQ/FAQSections/TechnicalDetails.html#FAQ102">this excellent explanation why</a> ) so that both the method <code>accept(String) : Object</code> and <code>accept(String): String</code> exist.</p>
<p>And we want to get the non-bridge <code>accept(String): String</code> because we need the non-generic type arguments from the methods signature later on.</p>
<p>Unfortunately this gets a bit complicated when the target is a method reference to a value class. Because the class is inlined the real method has been name mangled into <code>accept-IDPvPPfA(String): String</code> while the bridge method remains untouched.</p>
<p>As such you have the following options.</p>
<ol><li>Do not use inlined classes.</li><li>Add extra braces around the lambda to avoid a method reference to the inlined value class.</li>
</ol>
<pre><code>package com.example.bug
import io.cucumber.java8.En
class HtmlSafeStringStepdefs : En {
init {
ParameterType("html_safe_string", "html_safe\\(\".**\"\\)") { string: String -&gt;
{
HtmlSafeString(string)
}
}
}
}
</code></pre>
<ol start="3"><li>Submit a PR that changes the behaviour of <code>AbstractGlueDefinition</code> such that instead of filtering the <code>accept</code> methods on the <code>bodyClass</code> it sorts the methods and picks the most preferred candidate.</li>
</ol>
GitHub
2021-07-17 04:41:55
[cucumber/cucumber-jvm] Comment on #1829
<p>That's unfortunate. I'd still prefer to write that for all the cases where it <em>is</em> possible, but it sucks that Java doesn't just let us use any character in a method name. (At the bytecode level, why should they care?)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-17 05:04:35
[cucumber/cucumber-jvm] Comment on #2342
<p>Option 3 seems a bit tricky so I might be going with option 2.</p>
<p>Also, I see there is wind of cucumber-java8 being deprecated. Is the replacement available? Maybe it doesn't have the issue.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-17 05:48:23
[cucumber/cucumber-jvm] Comment on #2342
<p>We're considering a lambda based implementation in <a href="https://github.com/cucumber/cucumber-jvm/issues/2279">#2279</a>. It'd need someone willing to implement it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-17 06:13:53
[cucumber/cucumber-jvm] Issue opened by PostelnicuGeorge
<p>As far as documentation goes, the fact that jackson json library is used and DataTableType can have multiple return types, it's not that obvious why DocStringType has only 1 return type for all feature files/project?</p>
<p>Given the following example:<br />
Scenario: Test whether DocStringType allows conversion of 2 different types of records<br />
Given I have the following cars<br />
"""json<br />
[<br />
{<br />
"name": "Murcielago",<br />
"brand": "Lamborghini"<br />
},<br />
{<br />
"name": "Sandero",<br />
"brand": "Dacia"<br />
}<br />
]<br />
"""<br />
And one animal I like<br />
"""json<br />
{<br />
"name": "Lion",<br />
"domesticated": false<br />
}<br />
"""</p>
<p>public class DemoStepDef {</p>
<pre><code>@DocStringType(contentType = "json")
public List&lt;Car&gt; convertCars(String json) throws JsonProcessingException {
return new ObjectMapper().readValue(json,
new TypeReference&lt;List&lt;Car&gt;&gt;() {});
}
@DocStringType(contentType = "json")
public Animal convertAnimal(String json) throws JsonProcessingException {
return new ObjectMapper().readValue(json,
new TypeReference&lt;Animal&gt;() {});
}
@Given("I have the following cars")
public void i_have_cars(List&lt;Car&gt; cars) {
System.out.println(cars);
}
@And("one animal I like")
public void one_animal_I_like(Animal animal) {
System.out.println(animal);
}
</code></pre>
<p>}</p>
<p>public class Animal {<br />
private String name;<br />
private boolean domesticated;<br />
// setters and getters omitted<br />
}</p>
<p>public class Car {<br />
private String name;<br />
private String brand;<br />
// setters and getters omitted<br />
}</p>
<p>Gives the following error:<br />
<strong>Caused by: io.cucumber.docstring.CucumberDocStringException: There is already docstring type registered for 'json' and com.lumeon.cpm.models.records.Animal.</strong></p>
<p>My feeling is that if jackson library is allowed for DocStringType annotation, then we should be able to leverage the full potential of it, and not be forced to have JsonNode as the only option. Having extra intermediary methods to convert to the actual types needed for the step definitions.</p>
<p>Work-around at the moment:<br />
public class DemoThatWorksStepDef {</p>
<pre><code>@DocStringType(contentType = "json")
public JsonNode json(String json) throws JsonProcessingException {
return new ObjectMapper().readTree(json);
}
public List&lt;Car&gt; convertCars(JsonNode jsonNode) throws IOException {
return new ObjectMapper().readValue(jsonNode.traverse(),
new TypeReference&lt;List&lt;Car&gt;&gt;() {});
}
public Animal convertAnimal(JsonNode jsonNode) throws IOException {
return new ObjectMapper().readValue(jsonNode.traverse(),
new TypeReference&lt;Animal&gt;() {});
}
@Given("I have the following cars")
public void i_have_cars(JsonNode jsonNode) throws IOException {
System.out.println(convertCars(jsonNode));
}
@And("one animal I like")
public void one_animal_I_like(JsonNode jsonNode) throws IOException {
System.out.println(convertAnimal(jsonNode));
}
</code></pre>
<p>}</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-17 07:54:26
[cucumber/cucumber-jvm] Comment on #2343
<p>Ah. Indeed.</p>
<p>Currently the <code>DocStringTypeRegistry</code> maintains a <code>Map&lt;String, DocStringType&gt;</code> and <code>Map&lt;Type, DocStringType&gt;</code> which forces there to be a single doc string type per content type string and java type. This could be a <code>Map&lt;String, Map&lt;Type, DocStringType&gt;&gt;</code> which would accommodate multiple converters for json documents to different java types.</p>
<p>Some care must be when dealing with the empty content type as then the following would be ambiguous:</p>
<pre><code>@DocStringType(contentType = "json")
public List&lt;Car&gt; convertCars(String json) {
}
@DocStringType(contentType = "xml")
public List&lt;Car&gt; convertCars(String xml) {
}
</code></pre>
<p>Would you be interested in making a pull request for this?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-17 09:31:48
[cucumber/cucumber-jvm] Comment on #2343
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> thanks for the super fast response. I will give it a go, lets see if I can manage :)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-17 15:44:47
[cucumber/cucumber-jvm] Pull request opened by PostelnicuGeorge
<p>Support multiple DocStringTypes with the same contentType <a href="https://github.com/cucumber/cucumber-jvm/issues/2343">#2343</a></p>
GitHub
2021-07-17 16:21:51
[cucumber/cucumber-jvm] Comment on #2344
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-18 03:00:42
[cucumber/cucumber-jvm] Comment on #2344
<p>I would expect that when given a doc string without a content type, we make an attempt to look for the doc string type by its java type instead.</p>
<p>And if this results in multiple converters we throw an exception that explains to the user that they must disambiguate by adding a content type to the doc string.</p>
<p>So that:</p>
<pre><code>Given a list of cars
""""
"""
</code></pre>
<p>Will attempt to use the following converter when registered:</p>
<pre><code>@DocStringType(contentType = "json")
public List&lt;Car&gt; convertCars(String json) {
}
</code></pre>
<p>But if another converter for the same type was also registered:</p>
<pre><code>@DocStringType(contentType = "xml")
public List&lt;Car&gt; convertCars(String xml) {
}
</code></pre>
<p>Throw the exception:</p>
<pre><code>Multiple converters for `List&lt;Car&gt;`... Add a doc string type to the doc string ...
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-18 03:00:42
[cucumber/cucumber-jvm] Comment on #2344
<p>No tests for the happy path?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-18 03:00:42
[cucumber/cucumber-jvm] Comment on #2344
<p>Consider using <code>Map.computeIfAbsent</code> to simplify this section.</p>
<p><a href="https://docs.oracle.com/javase/8/docs/api/java/util/Map.html#computeIfAbsent-K-java.util.function.Function-">https://docs.oracle.com/javase/8/docs/api/java/util/Map.html#computeIfAbsent-K-java.util.function.Function-</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-18 03:00:43
[cucumber/cucumber-jvm] mpkorstanje commented on PostelnicuGeorge's pull request
<p>I don't know if you are done or not. If you're still working on this and would rather wait for feedback until you are done, you can mark the PR as a draft using the drop down on the green button.</p>
<p>For now I've added a few suggestions. Most of them are related to code style, but don't worry about that too much until the functionality and tests are done.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-18 03:00:43
[cucumber/cucumber-jvm] Comment on #2344
<p>Consider using</p>
<pre><code>lookup
.map(docStringType -&gt; docStringType.transform(docString.getContent()))
.orElseThrow(...)
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-18 03:00:53
[cucumber/cucumber-jvm] Comment on #2344
<p>Here and in <code>lookup</code> you have a pattern where you check if the <code>DocStringType</code> is present and then get the item. Consider using a method like this to simplify this:</p>
<pre><code> private Optional&lt;DocStringType&gt; find(String contentType, Type type) {
Map&lt;Type, DocStringType&gt; docStringTypesByType = docStringTypes.get(contentType);
if (docStringTypesByType == null) {
return empty();
}
return ofNullable(docStringTypesByType.get(type));
}
</code></pre>
GitHub
2021-07-19 02:05:47
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled due to failing status checks.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-19 02:06:02
[cucumber/cucumber-jvm] Comment on #2345
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge, however this is not possible so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
GitHub
2021-07-19 02:48:15
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-19 02:49:04
[cucumber/cucumber-jvm] Comment on #2345
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will now ignore this update (1.2.4). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the <code>ignoreDeps</code> array of your renovate config.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
GitHub
2021-07-19 07:52:05
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
codecov/codecov-action
<strong><a href="https://togithub.com/codecov/codecov-action/compare/v1...v2"><code>v2</code></a></strong></p>
<p><a href="https://togithub.com/codecov/codecov-action/compare/v1...v2">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-19 08:31:35
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-19 08:32:16
[cucumber/cucumber-jvm] Comment on #2346
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for <em>any</em> future 2.x releases. However, if you upgrade to 2.x manually then Renovate will then reenable updates for minor and patch updates automatically.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-21 09:53:04
[cucumber/cucumber-jvm] Issue opened by chasangchual
<p><strong>Describe the bug</strong></p>
<p>• using IntelliJ for development
• step definition java files are in the across modules. the those step definitions have its own package path and they are different.
• specified step definition packages with "glue" option
• one of module has a feature file. from the feature file, it is not able to refer steps in the different module</p>
<p><strong>To Reproduce</strong><br />
Steps to reproduce the behavior:</p>
<ol><li>create a two modules, 'price' & 'product',</li><li>create a step definition in com.my.price.steps package in price modules</li><li>create a step definition in com.my.product.steps package in product modules</li><li>create a <strong>Feature file in price modules</strong>, and it uses steps in com.my.price.steps and com.my.product.steps</li><li>on running, specify "glue" options with com.my.price.steps and com.my.price.steps</li><li>it fails to run because it was not able to find step definition in <strong>product module</strong></li>
</ol>
<p><strong>Expected behavior</strong><br />
success to run the Feature with step definitions across modules.</p>
<p><strong>Context & Motivation</strong><br />
single code repo has been split to multiple modules, and we want to share common step definitions across modules.<br />
Seeing other had experienced the same issue, <a href="https://stackoverflow.com/questions/66909568/cucumber-doesnt-find-steps-definition-in-other-module">https://stackoverflow.com/questions/66909568/cucumber-doesnt-find-steps-definition-in-other-module</a></p>
<p><strong>Screenshots</strong></p>
<p><strong>Your Environment</strong></p>
<p>• gradle cucumber dependencies used<br />
testImplementation "io.cucumber:cucumber<em>java:6.10.4"<br />
testImplementation "io.cucumber:cucumber</em>spring:6.10.4"<br />
testImplementation "io.cucumber:cucumber<em>junit</em>platform_engine:6.10.4"
• Operating System and version [e.g. ** Operating System and version:] mac os 11.2.3
• Build tool [e.g. Apache Maven 3.6.0]: Gradle 6.5</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-21 10:36:16
[cucumber/cucumber-jvm] Comment on #2347
<p>> on running, specify "glue" options with com.my.price.steps and com.my.price.steps</p>
<p>Is this a typo or intentional?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-23 11:14:35
[cucumber/cucumber-jvm] Comment on #2315
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2315">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2315</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/7ab1552d0b3ba9a35fb5156f9dc7913991588ab5">7ab1552</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/fa3d5ec6cefe09e7abb2d1b1f1e3a8ca9f9f9864?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|v7.x.x">https://codecov.io/gh/cucumber/cucumber-jvm/commit/fa3d5ec6cefe09e7abb2d1b1f1e3a8ca9f9f9864?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|v7.x.x</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/fa3d5ec6cefe09e7abb2d1b1f1e3a8ca9f9f9864">fa3d5ec</a>) will <strong>decrease</strong> coverage by <code>0.22%</code>.<br />
> The diff coverage is <code>91.17%</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## v7.x.x #2315 +/- ##
============================================
- Coverage 83.36% 83.13% -0.23%
+ Complexity 2320 2290 -30
============================================
Files 300 292 -8
Lines 8272 8226 -46
Branches 750 738 -12
============================================
- Hits 6896 6839 -57
- Misses 1079 1098 +19
+ Partials 297 289 -8
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|a380a7e...7ab1552">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2315?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|a380a7e...7ab1552</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-23 11:15:08
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-23 11:15:14
[cucumber/cucumber-jvm] Pull request reopened by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-26 02:51:09
[cucumber/cucumber-jvm] Issue opened by jlink
<p><strong>Describe the bug</strong></p>
<p>If a discovery filter is set, e.g. when using Intellij JUnit Configuration with a Pattern, the Cucumber test engine ignores this filter and runs all tests regardless.</p>
<p>This is mostly a problem when Cucumber is used together with other engines and only a subset of tests is supposed to run.</p>
<p><strong>Expected behavior</strong></p>
<p>DiscoveryFilter instances, which can be retrieved through <code>EngineDiscoveryRequest.getFiltersByType()</code> should be evaluated.</p>
<p><strong>Solution suggestion</strong></p>
<p>Here's the relevant code from the jqwik engine, which creates a predicate to use for filtering all test classes:</p>
<pre><code> private static Predicate&lt;String&gt; buildClassNamePredicate(EngineDiscoveryRequest request) {
List&lt;DiscoveryFilter&lt;String&gt;&gt; filters = new ArrayList&lt;&gt;();
filters.addAll(request.getFiltersByType(ClassNameFilter.class));
filters.addAll(request.getFiltersByType(PackageNameFilter.class));
return composeFilters(filters).toPredicate();
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-26 05:24:52
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-26 05:24:52
[cucumber/cucumber-jvm] Comment on #2348
<p>The discovery request IDEA creates when using Pattern: <code>com.example.**</code>.<br />
<a href="https://user-images.githubusercontent.com/6946919/126990242-87393d08-a6be-4eda-ad7c-5341ff286a65.png">image</a></p>
<pre><code>request = {DefaultDiscoveryRequest@1460}
selectors = {ArrayList@1465} size = 2
0 = {ClasspathRootSelector@1475} "ClasspathRootSelector [classpathRoot = file:///path/to/project/target/test-classes/]"
1 = {ClasspathRootSelector@1476} "ClasspathRootSelector [classpathRoot = file:///path/to/project/target/classes/]"
engineFilters = {ArrayList@1466} size = 0
discoveryFilters = {ArrayList@1467} size = 2
0 = {IncludeClassNameFilter@1542} "IncludeClassNameFilter that includes class names that match one of the following regular expressions: 'com.example.**'"
1 = {ExcludeClassNameFilter@1543} "ExcludeClassNameFilter that excludes class names that match one of the following regular expressions: 'com\.intellij\.rt.**' OR 'com\.intellij\.junit3.**'"
</code></pre>
<p>Cucumber tests are located in feature files. As such they do not have a class to filter on and are not removed from the result.</p>
<p>By generically calling it "Pattern" IDEA is creating the wrong expectations. There is no such thing in the JUnit Platform API. I would suggest that you file a ticket with IDEA to and request that their UI matches the semantics of discovery selectors and filters more closely.</p>
<p>Note: package filters are supported for feature files located on the class path.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/5203c4c316bd7cb450cab962406317a0a0c78671/junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/DiscoverySelectorResolver.java#L30-L33">cucumber-jvm/junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/DiscoverySelectorResolver.java</a></p>
<p>Lines 30 to 33 in </cucumber/cucumber-jvm/commit/5203c4c316bd7cb450cab962406317a0a0c78671|5203c4c></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-26 05:29:48
[cucumber/cucumber-jvm] Comment on #2348
<p>Also note that if you are using the <code>@Cucumber</code> annotated class as a work around, it is only used when explicitly requested through a <code>ClassSelector</code> to accommodate Gradle and Surefire.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/5203c4c316bd7cb450cab962406317a0a0c78671/junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/FeatureResolver.java#L163-L171">cucumber-jvm/junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/FeatureResolver.java</a></p>
<p>Lines 163 to 171 in </cucumber/cucumber-jvm/commit/5203c4c316bd7cb450cab962406317a0a0c78671|5203c4c></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-26 05:37:55
[cucumber/cucumber-jvm] Issue reopened by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-26 05:37:55
[cucumber/cucumber-jvm] Comment on #2348
<p>I'll leave this issue open for some one to do the leg work with InteliJ.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-26 14:46:03
[cucumber/cucumber-jvm] Comment on #2331
<p>See:</p>
<p>• <a href="https://issues.apache.org/jira/browse/SUREFIRE-1896">https://issues.apache.org/jira/browse/SUREFIRE-1896</a>
• <a href="https://issues.apache.org/jira/browse/SUREFIRE-1849">https://issues.apache.org/jira/browse/SUREFIRE-1849</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-27 11:13:37
[cucumber/cucumber-android] Issue opened by kanitkarketki
<p>I want to implement case insensitivity in my gherkin for my project such that the following works:</p>
<p>Scenario: test case insensitive gherkin<br />
Given <strong>i</strong> enable WiFi<br />
Given <strong>I</strong> disable WiFi</p>
<p>I wrote the following step definition (for the above gherkin steps) with the following regex:</p>
<p><a href="https://github.com/given">@given</a>("^(?i)I (enable|disable) WiFi")<br />
public void switchWiFi(String mode) {<br />
//Implementation<br />
}</p>
<p>Basically, I prefixed (?i) regex prior to regex start which resolved all the gherkin steps. However, when I executed the test, I got the following error:</p>
<p><code>at io.cucumber.cucumberexpressions.TreeRegexp$IntRange.next(TreeRegexp.java:99) at io.cucumber.cucumberexpressions.TreeRegexp$IntRange.next(TreeRegexp.java:82) at io.cucumber.cucumberexpressions.GroupBuilder.build(GroupBuilder.java:18) at io.cucumber.cucumberexpressions.GroupBuilder.build(GroupBuilder.java:21) at io.cucumber.cucumberexpressions.TreeRegexp.match(TreeRegexp.java:75) at io.cucumber.cucumberexpressions.Argument.build(Argument.java:12) at io.cucumber.cucumberexpressions.RegularExpression.match(RegularExpression.java:54) at io.cucumber.stepexpression.StepExpression.match(StepExpression.java:22) at io.cucumber.stepexpression.ExpressionArgumentMatcher.argumentsFrom(ExpressionArgumentMatcher.java:21) at cucumber.runtime.java.JavaStepDefinition.matchedArguments(JavaStepDefinition.java:62) at cucumber.runner.Glue.stepDefinitionMatches(Glue.java:114) at cucumber.runner.Glue.stepDefinitionMatch(Glue.java:96) at cucumber.runner.Runner.addTestStepsForPickleSteps(Runner.java:74) at cucumber.runner.Runner.createTestCaseForPickle(Runner.java:64) at cucumber.runner.Runner.runPickle(Runner.java:49) at io.cucumber.junit.AndroidPickleRunner.run(AndroidPickleRunner.java:46) at io.cucumber.junit.AndroidFeatureRunner.runChild(AndroidFeatureRunner.java:43) at io.cucumber.junit.AndroidFeatureRunner.runChild(AndroidFeatureRunner.java:14) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at io.cucumber.junit.CucumberJUnitRunner.runChild(CucumberJUnitRunner.java:256) at io.cucumber.junit.CucumberJUnitRunner.runChild(CucumberJUnitRunner.java:52) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at io.cucumber.junit.CucumberJUnitRunner$1.evaluate(CucumberJUnitRunner.java:287) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56) at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:444) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2075)</code></p>
<p>This should ideally recognize (?i) to indicate case insensitivity but throws an exception instead. This issue was found in the cucumber-jvm library, refer <a href="https://groups.google.com/g/cukes/c/I5jqlf7L2ZM">https://groups.google.com/g/cukes/c/I5jqlf7L2ZM</a> and fixed in a subsequent release.</p>
<p>The cucumber-android library might need to upgrade the cucumber-java/cucumber-jvm dependency to reflect this change.</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-07-28 20:19:30
[cucumber/cucumber-jvm] Issue opened by GayanSandaruwan
<p>Currently the TestNGCucumberRunner is final. So we can't add custom behavior.</p>
<p>We have different glue paths and feature paths for each test suites. In io.cucumber we achieved this through by adding two parameters in the testNG.xml and then customize the TestNGCucumberRunner to with new Cucumber Options on each suite run dynamically.<br />
Since the tests are being run in parallel we cant pass them via System Properties or by setting annotations dynamically to be used in the Runner.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/issues/2078">#2078</a> is also referring something similar for Cucumber Junit runner.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 00:16:29
[cucumber/cucumber-jvm] Comment on #2348
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> I'd argue that as soon as there is a Include/ExcludeClassNameFilter present the cucumber engine should not run any tests since this discovery request is clearly targeted at class-based engines.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 00:48:10
[cucumber/cucumber-jvm] Comment on #2349
<p>Extension is something that should be designed for. This ensures the extension points can be documented and tested. This in turn ensures we don't break an extension point by accident.</p>
<p>Could you elaborate on how you are passing options from testng.xml to the runner?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 01:22:09
[cucumber/cucumber-jvm] Comment on #2348
<p>That doesn't seem consistent with the design of the API. <code>getFiltersByType</code> allows a test engine to provide and look for its own <code>DiscoveryFilter</code> implementations. Other test engines can't honor such a filter so categorically you can not expect a test engine to honor all filters in a discovery request.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 01:52:27
[cucumber/cucumber-jvm] Comment on #2348
<p>I think you're right in principle. The contract, however, of ClasspathRootSelector (and other selectors as well), is not clear enough. At the time of design, we did not consider the problem of combining class-based with file-based engines in a single discovery request. I know, because I was there.<br />
That's why I think that the best a file-based engine can do is use heuristics to determine if the current discovery request is really aimed at it.</p>
<p><a href="https://github.com/junit-team">@junit-team</a> @junit-team/junit-committers What do you think: Should we differentiate between Classpath selector for files / for classes / for both? Or should the filter contract be reworked to include filters that MUST be honoured?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 03:31:50
[cucumber/cucumber-jvm] Comment on #2348
<p>The contract mentions class files <em>or</em> resources:</p>
<p>> A DiscoverySelector that selects a classpath root so that TestEngines can search for class files or resources within the physical classpath — for example, to scan for test classes.</p>
<p>What is your objection to petitioning IDEA for support for a package filter?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 03:33:08
[cucumber/cucumber-jvm] Comment on #2348
<p>At a glance the <code>ExcludeClassNameFilter</code> should have been an <code>ExcludePackageNameFilter</code> anyway.</p>
<pre><code> discoveryFilters = {ArrayList@1467} size = 2
0 = {IncludeClassNameFilter@1542} "IncludeClassNameFilter that includes class names that match one of the following regular expressions: 'com.example.**'"
1 = {ExcludeClassNameFilter@1543} "ExcludeClassNameFilter that excludes class names that match one of the following regular expressions: 'com\.intellij\.rt.**' OR 'com\.intellij\.junit3.**'"
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 04:29:01
[cucumber/cucumber-jvm] Comment on #2348
<p>> The contract mentions class files <em>or</em> resources:
>
> > A DiscoverySelector that selects a classpath root so that TestEngines can search for class files or resources within the physical classpath — for example, to scan for test classes.</p>
<p>Exactly, we missed that only one of those may be wanted sometimes.</p>
<p>> What is your objection to petitioning IDEA for support for a package filter?</p>
<p>No objection. It’s just that some of my „suggestions“ and bug issues with JetBrains have been open for years. I’m looking for pragmatic ways to solve problem timely.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 05:03:30
[cucumber/cucumber-jvm] Comment on #2348
<p>If JetBrains was committed they'd already added an Engine filter, which would also solve my problem.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 06:12:22
[cucumber/cucumber-jvm] Comment on #2348
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 06:16:06
[cucumber/cucumber-jvm] Comment on #2348
<p>Tell me about it:</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/bb8f6bb1e007870b79d8d43d828be6490b6d3189/core/src/main/java/io/cucumber/core/options/PluginOption.java#L65-L75">cucumber-jvm/core/src/main/java/io/cucumber/core/options/PluginOption.java</a></p>
<p>Lines 65 to 75 in </cucumber/cucumber-jvm/commit/bb8f6bb1e007870b79d8d43d828be6490b6d3189|bb8f6bb></p>
<p>I've considered adding a special case for IDEA. The <code>'com\.intellij\.rt.**' OR 'com\.intellij\.junit3.**'</code> pattern in the string representation is a fairly descent indicator.</p>
<p>Unfortunately when using the context menu on a package with feature files we see:</p>
<pre><code>request = {DefaultDiscoveryRequest@1461}
selectors = {ArrayList@1466} size = 2
0 = {ClasspathRootSelector@1476} "ClasspathRootSelector [classpathRoot = file:///path/to/project/target/test-classes/]"
1 = {ClasspathRootSelector@1477} "ClasspathRootSelector [classpathRoot = file:///path/to/project/target/classes/]"
engineFilters = {ArrayList@1467} size = 0
discoveryFilters = {ArrayList@1468} size = 2
0 = {IncludeClassNameFilter@1543} "IncludeClassNameFilter that includes class names that match one of the following regular expressions: 'com.example'"
1 = {ExcludeClassNameFilter@1544} "ExcludeClassNameFilter that excludes class names that match one of the following regular expressions: 'com\.intellij\.rt.**' OR 'com\.intellij\.junit3.**'"
</code></pre>
<p>So I can't apply a pragmatic solution without also breaking the expected usage for Cucumber.</p>
<hr />
<p>Hah. When using "All in directory" for any directory inside the project:</p>
<pre><code>request = {DefaultDiscoveryRequest@1461}
selectors = {ArrayList@1466} size = 2
0 = {ClasspathRootSelector@1476} "ClasspathRootSelector [classpathRoot = file:///path/to/project/target/test-classes/]"
1 = {ClasspathRootSelector@1477} "ClasspathRootSelector [classpathRoot = file:///path/to/project/target/classes/]"
engineFilters = {ArrayList@1467} size = 0
discoveryFilters = {ArrayList@1468} size = 2
0 = {IncludeClassNameFilter@1543} "IncludeClassNameFilter that includes class names that match one of the following regular expressions: 'com.example'"
1 = {ExcludeClassNameFilter@1544} "ExcludeClassNameFilter that excludes class names that match one of the following regular expressions: 'com\.intellij\.rt.**' OR 'com\.intellij\.junit3.**'"
</code></pre>
<p>And for any directory below the project:</p>
<pre><code>OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Jul 29, 2021 3:15:13 PM org.junit.platform.launcher.core.LauncherConfigurationParameters loadClasspathResource
INFO: Loading JUnit Platform configuration parameters from classpath resource [file:/path/to/project/target/test-classes/junit-platform.properties].
Internal Error occurred.
org.junit.platform.commons.PreconditionViolationException: LauncherDiscoveryRequest must not be null
at org.junit.platform.commons.util.Preconditions.condition(Preconditions.java:281)
at org.junit.platform.commons.util.Preconditions.notNull(Preconditions.java:54)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:72)
at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:71)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 06:18:12
[cucumber/cucumber-jvm] Comment on #2348
<p>It's a mess.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 06:20:38
[cucumber/cucumber-jvm] Comment on #2348
<p>I'm not interested in working around that mess.</p>
<p>Jetbrains fixes issues by "interest". So how about you create the issue. Tweet something snarky, and hopefully get people to vote for it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-07-29 06:21:52
[cucumber/cucumber-jvm] Comment on #2348
<p>I'll see if I can get some Cucumber folks to join up to.</p>
<p><a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> ☝️</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-02 21:17:29
[cucumber/cucumber-android] Issue opened by liweiran10086
<p><strong>Describe the bug</strong><br />
A clear and concise description of what the bug is.<br />
When I change the code in build.gradle to change targetSdkVersion and buildToolsVersion to 30,</p>
<pre><code> targetSdkVersion = 30
buildToolsVersion = '30.0.2'
</code></pre>
<p>and then run UItest on cucumber.cukeulator.test/cucumber.cukeulator.test.CukeulatorAndroidJUnitRunner, it failed to run and crashed</p>
<pre><code>$ adb shell am instrument -w -m --no-window-animation -e debug false cucumber.cukeulator.test/cucumber.cukeulator.test.CukeulatorAndroidJUnitRunner
Test running failed: Process crashed.
Tests ran to completion.
</code></pre>
<p>From the Logcat, the error is Unable to find instrumentation info</p>
<pre><code>2021-08-03 11:59:10.977 29602-29602/cucumber.cukeulator E/AndroidRuntime: FATAL EXCEPTION: main
Process: cucumber.cukeulator, PID: 29602
java.lang.RuntimeException: Unable to find instrumentation info for: ComponentInfo{cucumber.cukeulator.test/cucumber.cukeulator.test.CukeulatorAndroidJUnitRunner}
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6408)
at android.app.ActivityThread.access$1300(ActivityThread.java:229)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1885)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:216)
at android.app.ActivityThread.main(ActivityThread.java:7464)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:549)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:955)
</code></pre>
<p>Use adb command to check , it exists.</p>
<pre><code>$ adb shell pm list instrumentation
instrumentation:androidx.test.orchestrator/.AndroidTestOrchestrator (target=androidx.test.orchestrator)
instrumentation:cucumber.cukeulator.test/.CukeulatorAndroidJUnitRunner (target=cucumber.cukeulator)
</code></pre>
<p><strong>Expected behavior</strong></p>
<p>It works well if I change back targetSdkVersion to 29, see attched screenshot<br />
<a href="https://user-images.githubusercontent.com/44474610/127956342-ff143d29-6766-445b-a585-9f82c6ca0ca3.png">cucumber-android</a></p>
<p><strong>Additional context</strong><br />
This is the config I use to run the UITest, set the config like this and tap the run All Tests button<br />
<a href="https://user-images.githubusercontent.com/44474610/127956846-8cdd733c-50ba-47a0-babd-33f26b7aaab3.png">图片</a></p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-08-03 00:51:42
[cucumber/cucumber-jvm] Comment on #2350
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge, however this is not possible so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 00:51:43
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled due to failing status checks.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 07:25:16
[cucumber/cucumber-jvm] Comment on #2348
<p>I'm not really sure which feature I'd like to request. If IntelliJ supported File/DirectorySelector this would not solve my problem. If IntelliJ supported EngineFilter it would not solve Cucumber's problem.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 14:39:12
[cucumber/cucumber-jvm] Pull request ready for review by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 14:42:19
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 14:43:00
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 15:08:36
[cucumber/cucumber-jvm] Comment on #2330
<p>No looks good.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 15:08:59
[cucumber/cucumber-jvm] Comment on #2330
<p>I didnt' get any notification because you've marked the PR as a Draft. It does mostly look ready to me. Do you have anything to add?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 15:10:36
[cucumber/cucumber-jvm] Comment on #2330
<p>Btw, because the datatable changes from v3 to v4 this has to go into Cucumber v7. Could you rebase your branch on top of the <code>v7.x.x</code> branch? You can drop any commits that weren't made by you.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 15:10:47
[cucumber/cucumber-jvm] Comment on #2330
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2330">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2330</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/5ceef20b4fcb3bb497cd2384d113732202d19e06">5ceef20</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/2b37d8e57de7b2ea468c567f600f375c242aea6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/2b37d8e57de7b2ea468c567f600f375c242aea6e?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/2b37d8e57de7b2ea468c567f600f375c242aea6e">2b37d8e</a>) will <strong>increase</strong> coverage by <code>0.00%</code>.<br />
> The diff coverage is <code>87.50%</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## main #2330 +/- ##
=========================================
Coverage 83.36% 83.37%
- Complexity 2320 2321 +1
=========================================
Files 300 300
Lines 8272 8287 +15
Branches 750 751 +1
=========================================
+ Hits 6896 6909 +13
- Misses 1079 1081 +2
Partials 297 297
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|2b37d8e...5ceef20">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2330?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|2b37d8e...5ceef20</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 15:11:28
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 15:12:13
[cucumber/cucumber-jvm] Comment on #2286
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for <em>any</em> future 3.x releases. However, if you upgrade to 3.x manually then Renovate will then reenable updates for minor and patch updates automatically.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 15:26:09
[cucumber/cucumber-jvm] Comment on #2281
<p>This needs a better solution that allows <code>instance of</code> to be used.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 20:53:01
[cucumber/cucumber-jvm] Comment on #2349
<p>Our goal is to run the test suites in parallel. ( not methods, not scenarios, not features). And these test suites are different packages in the feature path. Since we have thousands of test cases, it's hard to pass filter tags differently. We use a common tag which specify each module. ( we have around 20 likewise tags )<br />
So in info.cukes version we achieved this via adding two parameters, gluePaths, featurePaths in testNG.xml, then duplicated the Runner to create our own. There we initialized the runner with new cucumber Options for glue and feature taken from the test Suite xml parameters.<br />
From the way current design is, the only option was to create different classes with different annotations. But I think given the context you might have realized that its hard to do.</p>
<p>So we solved this this time as well by duplicating the Runner, and passing cutomOptions in constructor. This was not neat a neat solution.<br />
Let me know if I'm not clear.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 20:54:45
[cucumber/cucumber-jvm] Comment on #2349
<p>So, if it's not possible to allow extending, I think it would be nice to allow custom cucumber options to be passed to the Runner. I can send a pull request if you are interested.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 23:29:24
[cucumber/cucumber-jvm] Comment on #2349
<p>I think it might be useful in general for Cucumber to take parameters from TestNG.xml rather then only the annotation.</p>
<p>But I would like to understand how this works a bit better before asking for a pull request.</p>
<p>> So in info.cukes version we achieved this via adding two parameters, gluePaths, featurePaths in testNG.xml, then duplicated the Runner to create our own. There we initialized the runner with new cucumber Options for glue and feature taken from the test Suite xml parameters.</p>
<p>I do not use TestNG on a regular basis. Could you show me an example of what you've described here?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 23:29:24
[cucumber/cucumber-jvm] Issue reopened by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-03 23:50:35
[cucumber/cucumber-jvm] Comment on #2349
<p>Following is a sample testNG.xml suite that I'm using.</p>
<pre><code><!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" >
&lt;suite name="Test Suite"&gt;
&lt;parameter name="cucumber.filter.tags.file" value="CustomTags.txt" /&gt;
&lt;test name="Load Operation Apps" junit="false" preserve-order="true"&gt;
&lt;parameter name="cucumber.features" value="test/feature/estateManager/loadOperationApps"/&gt;
&lt;parameter name="cucumber.glue" value="com.abccompany.web.stepDefinitions"/&gt;
&lt;classes&gt;
&lt;class name="com.abccompany.core.automation.cucumber.RunCucumberTests"/&gt;
&lt;/classes&gt;
&lt;/test&gt;
&lt;test name="Customer Credit Account Withdrawal Reason Maintenance" junit="false" preserve-order="true"&gt;
&lt;parameter name="cucumber.features" value="test/feature/estateManager/reasonMaintenance/customerCreditAccountWithdrawalReason"/&gt;
&lt;parameter name="cucumber.glue" value="com.abccompany.web.stepDefinitions"/&gt;
&lt;classes&gt;
&lt;class name="com.abccompany.core.automation.cucumber.RunCucumberTests"/&gt;
&lt;/classes&gt;
&lt;/test&gt;
&lt;test name="Alert Maintenance" junit="false" preserve-order="true"&gt;
&lt;parameter name="cucumber.features" value="test/feature/estateManager/alertMaintenance"/&gt;
&lt;parameter name="cucumber.glue" value="com.abccompany.web.stepDefinitions"/&gt;
&lt;classes&gt;
&lt;class name="com.abccompany.core.automation.cucumber.RunCucumberTests"/&gt;
&lt;/classes&gt;
&lt;/test&gt;
&lt;test name="Alert Type Maintenance" junit="false" preserve-order="true"&gt;
&lt;parameter name="cucumber.features" value="test/feature/estateManager/alertTypeMaintenance"/&gt;
&lt;parameter name="cucumber.glue" value="com.abccompany.web.stepDefinitions"/&gt;
&lt;classes&gt;
&lt;class name="com.abccompany.core.automation.cucumber.RunCucumberTests"/&gt;
&lt;/classes&gt;
&lt;/test&gt;
&lt;test name="Attribute Option Set Maintenance" junit="false" preserve-order="true"&gt;
&lt;parameter name="cucumber.features" value="test/feature/estateManager/attributeOptionSetMaintenance"/&gt;
&lt;parameter name="cucumber.glue" value="com.abccompany.web.stepDefinitions"/&gt;
&lt;classes&gt;
&lt;class name="com.abccompany.core.automation.cucumber.RunCucumberTests"/&gt;
&lt;/classes&gt;
&lt;/test&gt;
&lt;/suite&gt;
</code></pre>
<p>The cucumber.tags.file is a parameter I introduced in our custom runner which would take the tags from a file.</p>
<p>In runtime, when the Runner is initialized I'm passing the customOptions made with the extra options taken from suite xml, to the runner.</p>
<p>In a side note : I believe this testNG xml reading part should somehow handled in Runner itself, not passed from out but I wasnt able to access the TestNGContext from the runner ( could be possible, but could figure out how)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 00:04:33
[cucumber/cucumber-jvm] Comment on #2349
<pre><code>Given you seem more interested in enabling the Runner to get from suite parameters rather than passing custom Options to the runner as a second parameter.
And if you are interested in making this happen
Then if you can point me a way to access testNGContext within the Runner
Then I'll be able to submit a PR
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 00:11:19
[cucumber/cucumber-jvm] Comment on #2349
<p>I would first like to understand how parameters work.</p>
<p>Passing custom options, or an options provider is another solution but we'd have to think about the way it interacts with the other ways cucumber accepts options.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 00:22:26
[cucumber/cucumber-jvm] Comment on #2349
<p>In abstract, when the testNG is executing each suite, the parameters for that suite is accessible through context.</p>
<p>Currently in the TestNGCucumberRunner the options are passed in the following order.</p>
<ol><li>propertiesFileOptions</li><li>annotationOptions</li><li>environmentOptions</li><li>runtimeOptions</li>
</ol>
<p>options are overridden in the order. My suggestion is to add the testNG suite parameters/ custom options at 3rd. so will be following order.</p>
<ol><li>propertiesFileOptions</li><li>annotationOptions</li><li>customOptions</li><li>environmentOptions</li><li>runtimeOptions</li>
</ol>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 00:35:01
[cucumber/cucumber-android] Issue closed by liweiran10086
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-08-04 01:04:44
[cucumber/cucumber-jvm] Comment on #2349
<p>That makes sense. So you'd use something like this:</p>
<pre><code>public interface ConfigurationParameters {
Optional&lt;String&gt; get(String key);
}
</code></pre>
<pre><code> @BeforeClass(alwaysRun = true)
@Parameters({ "cucumber.glue", "cucumber.features" })
public void setUpClass(String glue String features) {
ConfigurationParameters parameters = key -&gt; {
if ("cucumber.glue".equals(key)) {
return Optional.ofNullable(glue);
}
if ("cucumber.features".equals(key)) {
return Optional.ofNullable(features);
}
return Optional.empty();
};
testNGCucumberRunner = new TestNGCucumberRunner(this.getClass(), parameters);
}
</code></pre>
<p>This looks doable. The <code>CucumberPropertiesParser</code> could be changed to accept the <code>ConfigurationParameters</code> as an argument in addition to a <code>Map&lt;String, String&gt;</code>.</p>
<p>Would you like to draft a PR for this? To be accepted the PR should include the code, tests and some javadoc and a section in the <code>testng/README.md</code> that explains how to use this feature.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 01:06:30
[cucumber/cucumber-jvm] Comment on #2349
<p>I also wonder if we can make this <em>just work</em> by reading all TestNG parameters at once in the <code>AbstractTestNGCucumberTests</code>. This could reuse the <code>ConfigurationParameters</code> passed to the <code>TestNGCucumberRunner</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 01:16:05
[cucumber/cucumber-jvm] Comment on #2349
<p>IMO, in a parallel environment, reading all the parameters at once will not be a good way to do it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 01:21:59
[cucumber/cucumber-jvm] Comment on #2349
<p>Could you explain how you would read all parameters and how it would fail?</p>
<p>From looking at the documentation it does look like <code>ITestContext</code> should be safe to use concurrently:</p>
<pre><code> @BeforeClass(alwaysRun = true)
public void setUpClass(ITestContext context) {
XmlTest currentXmlTest = context.getCurrentXmlTest();
ConfigurationParameters parameters = currentXmlTest::getParameter;
testNGCucumberRunner = new TestNGCucumberRunner(this.getClass(), parameters);
}
</code></pre>
<pre><code>public interface ConfigurationParameters {
String get(String key);
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 01:40:43
[cucumber/cucumber-jvm] Comment on #2349
<p>Okay I misunderstood what you asked ( I thought you are referring to read the parameters in all suites. ). Yes it is better to read all the parameters for the suite.</p>
<p>To read all samples, we could something simple as,</p>
<p>in RunCucumberTests</p>
<pre><code> @BeforeClass(alwaysRun = true)
public void setUpClass(ITestContext context) {
List&lt;String, String&gt; parameters = context.getCurrentXmlTest().getAllParameters();
testNGCucumberRunner = new CucumberTestNGRunner(this.getClass(), parameters);
}
</code></pre>
<p>In runner</p>
<pre><code>class TestNGCucumberRunner(Class&lt;?&gt; clazz, Map&lt;String, String&gt; additionalOptions) {
RuntimeOptions propertiesFileOptions = new CucumberPropertiesParser()
.parse(CucumberProperties.fromPropertiesFile())
.build();
RuntimeOptions annotationOptions = new CucumberOptionsAnnotationParser()
.withOptionsProvider(new TestNGCucumberOptionsProvider())
.parse(clazz)
.build(propertiesFileOptions);
RuntimeOptions otherOptions = new CucumberPropertiesParser()
.parse(additionalOptions)
.build(annotationOptions);
RuntimeOptions environmentOptions = new CucumberPropertiesParser()
.parse(CucumberProperties.fromEnvironment())
.build(otherOptions);
RuntimeOptions runtimeOptions = new CucumberPropertiesParser()
.parse(CucumberProperties.fromSystemProperties())
.enablePublishPlugin().build(environmentOptions);
..............................
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 01:52:39
[cucumber/cucumber-jvm] Comment on #2349
<p>Looks pretty decent!</p>
<p>I would like to see the <code>Map&lt;String, String&gt; additionalOptions</code> replaced with <code>ConfigurationParameters</code> though so the public api isn't any larger then strictly necessary. <code>Map</code> is a fairly large interface and we are only using <code>get(String)</code> on it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 02:44:15
[cucumber/cucumber-jvm] Comment on #2331
<p>Ah, I've just found this issue. Thanks for making it.</p>
<p>I've discovered that excluding nothing and including all .java files results in one test running (even though I have ~250 scenarios. It's better than <code>Tests run: 0</code>...</p>
<pre><code>[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
</code></pre>
<pre><code> &lt;plugin&gt;
&lt;groupId&gt;org.apache.maven.plugins&lt;/groupId&gt;
&lt;artifactId&gt;maven-surefire-plugin&lt;/artifactId&gt;
&lt;version&gt;3.0.0-M5&lt;/version&gt;
&lt;configuration&gt;
&lt;excludes&gt;
&lt;!-- Don't exclude any @Test by default --&gt;
&lt;exclude/&gt;
&lt;/excludes&gt;
&lt;includes&gt;
&lt;include&gt;****/**.java&lt;/include&gt;
&lt;/includes&gt;
&lt;/configuration&gt;
&lt;/plugin&gt;
</code></pre>
<p>I'm using the following dependencies</p>
<p>• org.springframework.boot:spring<em>boot</em>starter<em>parent:2.5.3
• org.springframework.boot:spring</em>boot<em>starter</em>test:2.5.3
• org.junit.jupiter:junit<em>jupiter:5.7.2
• org.junit.platform:junit</em>platform<em>launcher:5.7.2
• io.cucumber:cucumber</em>java:6.10.4
• io.cucumber:cucumber<em>junit</em>platform<em>engine:6.10.4
• io.cucumber:cucumber</em>spring:6.10.4</p>
<p>and excluding junit vintage</p>
<p>org.junit.vintage:junit-vintage-engine</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 03:26:23
[cucumber/cucumber-jvm] Comment on #2349
<p>I agree with you but couldn't find a suitable method in CucumberPropertiesParser to parse properties from a CustomType.<br />
I'll have to<br />
Get all the parameters from the TestNG as Map and then converting them to ConfugurationProperties type<br />
To use it with CucumberPropertiesParser then convert it back to a Map</p>
<p>This feels like a bit of a over kill. Please advice.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 03:58:52
[cucumber/cucumber-jvm] Comment on #2349
<p>Lets do it with a map first. We can refactor that afterwards.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 04:00:25
[cucumber/cucumber-jvm] Comment on #2331
<p>This is not a problem with Cucumber. Please do not report additional instances. Do upvote the issue in the Surefire bug tracker:</p>
<p><a href="https://issues.apache.org/jira/browse/SUREFIRE-1849">https://issues.apache.org/jira/browse/SUREFIRE-1849</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 04:04:55
[cucumber/cucumber-jvm] Comment on #2331
<p>If it's not an issue with Surefire, why are you linking to an open Surefire issue?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 04:09:36
[cucumber/cucumber-jvm] Comment on #2331
<p>Fixed.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 05:31:52
[cucumber/cucumber-jvm] Pull request opened by GayanSandaruwan
<p><a href="https://github.com/cucumber/cucumber-jvm/issues/2349">#2349</a><br />
<strong>problem</strong><br />
Cannot configure different test suits of same run with different cucumber options.</p>
<p><strong>Describe the solution you have implemented</strong></p>
<ol><li>Supply Custom options to TestNGCucumberRunner.</li><li>Read Cucumber Options from testNG.xml</li>
</ol>
<p><strong>Additional context</strong><br />
See test Execution results.<br />
<a href="https://user-images.githubusercontent.com/17314407/128181012-1f042351-b414-4807-b8fc-786871ad705f.png">AbstractTestNGCucumberTests</a><br />
<a href="https://user-images.githubusercontent.com/17314407/128181023-5bb3c531-4981-4b04-985b-8fbb814c21b8.png">TestNGCucumberRunner</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 05:33:17
[cucumber/cucumber-jvm] Comment on #2349
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> I have sent the Pull request, kindly take a look at it and let me know.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 07:49:52
[cucumber/cucumber-jvm] Comment on #2351
<p><code>customOptions</code> appears to be written to, but never read from.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 07:51:33
[cucumber/cucumber-jvm] Comment on #2351
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 07:52:16
[cucumber/cucumber-jvm] Comment on #2351
<p>You can format the code the right way by running mvn spotless:apply.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 07:53:56
[cucumber/cucumber-jvm] Comment on #2351
<p>Because TestNG.xml is used to "run" the runner class, should the options from TestNG not override those from the runner?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:03:14
[cucumber/cucumber-jvm] Comment on #2351
<p>the options annotated in the runner are taken in the annotationOptions, and they are overridden here.</p>
<p>I think, the testNG.xml is more susceptible to be changed by the end user than the runner class annotations when they feel something need to be changed.<br />
Configuration over Code.</p>
<p>And on the other hand, though the Runner Class is found by xml, we are reading and loading the parameters inside the runner. So the xml params comes after the class</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:20:02
[cucumber/cucumber-jvm] Comment on #2351
<p>So lets look at some practical scenario:</p>
<pre><code>@CucumberOptions(feature="example.feature")
public class RunCucumberTest extends AbstractTestNGCucumberTests { }
</code></pre>
<p>Testng xml:</p>
<pre><code>run RunCucumberTest
run RunCucumberTest with `cucumber.features=example2.feature
run RunCucumberTest with `cucumber.features=example3.feature
</code></pre>
<p>What should this do?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:30:16
[cucumber/cucumber-jvm] mpkorstanje commented on GayanSandaruwan's pull request
<p>Looks good!</p>
<p>I've extracted out the properties provider. We just need to sort out the precedence of the different property sources.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:31:20
[cucumber/cucumber-jvm] Comment on #2351
<p>This test only passes because the <code>Plugin.events</code> are not reset between tests.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:33:01
[cucumber/cucumber-jvm] Comment on #2351
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2351">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2351</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/94020e166a4ad9d05c4ad78f40917a9f0c169d85">94020e1</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/37e5408d2d4526946be9aa8c5f4276cece46d4a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/37e5408d2d4526946be9aa8c5f4276cece46d4a9?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/37e5408d2d4526946be9aa8c5f4276cece46d4a9">37e5408</a>) will <strong>increase</strong> coverage by <code>0.01%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## main #2351 +/- ##
============================================
+ Coverage 83.36% 83.38% +0.01%
- Complexity 2320 2322 +2
============================================
Files 300 300
Lines 8272 8280 +8
Branches 750 750
============================================
+ Hits 6896 6904 +8
Misses 1079 1079
Partials 297 297
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|37e5408...94020e1">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2351?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|37e5408...94020e1</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:37:40
[cucumber/cucumber-jvm] Comment on #2349
<p>I was trying to send a updated pull request back and noticed that, you have already implemented and merged ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:44:08
[cucumber/cucumber-jvm] Comment on #2351
<p>run RunCucumberTest will run with example.feature<br />
run RunCucumberTest with <code>cucumber.features=example2.feature will run with 2 run RunCucumberTest with</code> cucumber.features=example3.feature will run with 3</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:44:42
[cucumber/cucumber-jvm] Comment on #2351
<p>yes, the test is wrong, I'm updating</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:45:37
[cucumber/cucumber-jvm] Comment on #2349
<p>I've pushed an additional commit to your <code>main</code> branch. The commit doesn't exists in the <code>main</code> branch of this repository.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 08:53:01
[cucumber/cucumber-jvm] Comment on #2351
<p>Is this correct ? shows an error in eclipse for me</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 09:08:45
[cucumber/cucumber-jvm] Comment on #2351
<p>Note to self: This is a functional interface. Annotate it as such.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 09:10:28
[cucumber/cucumber-jvm] Comment on #2351
<p>Yes. <code>parse</code> accepts a <code>CucumberPropertiesProvider</code> which is a functional interface with a signature of <code>String -&gt; String</code>.<br />
<code>properties::get</code> is a method reference that also has the form <code>String -&gt; String</code>. Maybe you have to annotate both <code>CucumberPropertiesProvider</code> with <code>@FunctionalInterface</code> for eclipse to understand.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 09:24:05
[cucumber/cucumber-jvm] Comment on #2351
<p>Don't worry about the semver chechk failing. That can be solved later.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 12:10:41
[cucumber/cucumber-jvm] Comment on #2351
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 12:26:56
[cucumber/cucumber-jvm] Comment on #2351
<p>Error was gone after importing core to workspace</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 13:17:44
[cucumber/cucumber-jvm] Comment on #2330
<p>> I didnt' get any notification because you've marked the PR as a Draft. It does mostly look ready to me. Do you have anything to add?</p>
<p>Ah right - apologies for the duplicated work. I didn't have anything to add, but had been planning to QA test - building it locally and importing into my other project to see in-real-life if it was working as expected. Unfortunately I had some other work things come up that got me side-tracked.</p>
<p>Just rebased on <code>v7.x.x</code> (which removed a bunch of now-empty commits). Will try to get it running locally this weekend, but marked as ready-to-review in any case as I wasn't expecting any code changes.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-04 13:18:14
[cucumber/cucumber-jvm] Pull request ready for review by artysidorenko
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 03:14:29
[cucumber/cucumber-jvm] Issue opened by SubinDenis
<p>When starting large amount of test cases (~11000, permissions cross checks) there is memory leaks in java, as I think, because of large amount of stepdef instances that are not clearing by GC. Those instances are linked to org.aspectj.weaver.loadtime.Aj$WeaverContainer.</p>
<p>Maybe it's possible to delete such instances automatically after test run?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 04:10:08
[cucumber/cucumber-jvm] Comment on #2352
<p>Without more information on how to reproduce this problem I don't think there is anything any one can do to help you. Especially because <code>org.aspectj.weaver.loadtime.Aj$WeaverContainer</code> is not part of Cucumber so it is not clear what Cucumber should clean up after a test, if anything at all.</p>
<p>Would you be able to provide a minimal reproducer in the form of a github repository that shows this is a Cucumber problem?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 06:01:10
[cucumber/cucumber-jvm] Comment on #2352
<p>Test.feature is:</p>
<pre><code>Feature: Test
Background:
Given user authenticated with "login" "password"
Scenario: user can do some action number 1
And user try to doing someAction_1 and expect status "200"
...
78 scenarios are ommited
...
Scenario: user can do some action number 80
And user try doing someAction_80 and expect status "200"
</code></pre>
<p>AuthStepDefs.java:</p>
<pre><code>...
public class AuthStepDefs {
...
@Given("user authenticated with {string} {string}")
public void authenticateWith(String login, String password) {
int status = someAuthRestClient.authenticateWith(login, password);
assertEquals(200, status)
}
}
</code></pre>
<p>TestStepDefs.java:</p>
<pre><code>public class TestStepDefs {
...
@And("user try to doing someAction_1 and expect status {string}")
public void action(string expectedStatus) {
int status = someComponentARestClient.doAction();
assertEquals(expectedStatus, status);
}
...
ommited steps
...
@And("user try to doing someAction_80 and expect status {string}")
public void otherAction(int expectedStatus) {
int status = someComponentARestClient.doOtherAction();
assertEquals(expectedStatus, status);
}
}
</code></pre>
<p>Test.feature repeated 150 times for variety of users to check security implementation. We have 150**80=12000 tests. Each test creates 2 instances - new AuthStepDefs, new TestStepDefs. 24000 instances allocated in memory and tests become clow. When I used exlipse memory analyzer it shows enormous classloader. Almost 80 percent of memory was filled with classloader. The largest object in classloader is org.aspectj.weaver.loadtime.Aj$WeaverContainer.</p>
<p>After MAT analyzer I tried to do some 'dumb' analyzing.<br />
Example:</p>
<pre><code>public class Util {
public static Map&lt;Class, List&lt;String&gt;&gt; objects;
}
</code></pre>
<p>In each constructor I added</p>
<pre><code>List&lt;String&gt; strings = Util.objects.get(this.getClass());
if (strings == null) {
strings = new ArrayList&lt;&gt;();
}
strings.add(this.toString());
Util.objects.put(this.class, strings);
</code></pre>
<p>In the last step I printed content of Util.objects and got something like this:</p>
<pre><code>AuthStepDefs: [AuthStepDefs@111111, AuthStepDefs@222222, ..., AuthStepDefs@xxxxxx],
TestStepDefs: [TestStepDefs@111111, ..., TestStepDefs@xxxxxx]
</code></pre>
<p>GC cannot clean space, because every stepdef instance are reachable from gc root. Those duplicate instances are not needed for tests, but we cannot delete it anyway.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 07:37:14
[cucumber/cucumber-jvm] Issue opened by mpkorstanje
<p>During the contributors meeting we observed that the copyright attribution in the various license files is inconsistent between projects and between reality.</p>
<p>I would suggest using "Cucumber Ltd and Contributors".</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 07:41:43
[cucumber/cucumber-jvm] Comment on #2352
<p>> GC cannot clean space, because every stepdef instance are reachable from gc root.</p>
<p>Could you show how they are reachable from root?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 07:54:35
[cucumber/cucumber-jvm] Comment on #2352
<p>> Those duplicate instances are not needed for tests, but we cannot delete it anyway.</p>
<p>The duplicate instances of step definition are intentional. It ensures that each scenario runs in an isolated context, this prevents the state from one test influencing the other.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 09:35:00
[cucumber/cucumber-jvm] Comment on #2351
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> is there anything else I need to do ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 09:52:23
[cucumber/cucumber-jvm] Comment on #2309
<p><a href="https://github.com/dipakkumar1225">@dipakkumar1225</a><br />
Yes you can take screenshots via a custom plugin.<br />
Just need to implement the EventListener / ConcurrentEventListener, and there you can add event listeners for the events you have mentioned above.</p>
<p>Probably you are looking at taking a screenshot when the scenario has failed. Following snippet will help you.</p>
<pre><code>public class ScreenshotEmitter implements ConcurrentEventListener{
private static final String screenshotDirectory = "./target";
public void setEventPublisher(EventPublisher publisher) {
publisher.registerHandlerFor(TestStepFinished.class,this::handleTestStepFinished);
}
private void testStepFinished(TestStepFinished event){
Result result = event.getResult();
if (!Status.PASSED.equals(result.getStatus())) {
String message = "Test did not pass (" + result.getStatus() + "): " + currentFeature + " - " + currentScenario;
if (StringUtils.notEmpty(screenshotDirectory) &amp;&amp; result.getError() != null) {
try {
String screenshotName = currentFeature + "_" + currentScenario + "_" + TIMESTAMP.format(new Date()) + ".png";
File file = getController().captureScreenshot();
// Get destination directory
File destinationDir = new File(screenshotDirectory);
// Rename the screenshot
File destinationFile = new File(destinationDir.getAbsolutePath() + File.separator + screenshotName);
// Copy file
FileUtils.copyFile(file, destinationFile);
String screenshotLink = String.format("&lt;a href='%s' target='_blank'&gt;%s&lt;/a&gt;", screenshotDirectory + "/" + screenshotName,
screenshotName);
message += " - " + screenshotLink;
} catch (Exception ex) {
// Just log exceptions caught here. Don't re-throw them otherwise
// we'll loose the original test failure cause.
ex.printStackTrace();
}
}
System.err.println(message);
}
}
}
</code></pre>
<p>then you have to add the plugin via launcher parameters.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 12:26:02
[cucumber/cucumber-jvm] Comment on #2351
<p>No looks good. I'm going to have to have a look at the semver problem.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 13:26:05
[cucumber/cucumber-jvm] Comment on #2351
<p>Hi <a href="https://github.com/GayanSandaruwan">@GayanSandaruwan</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 13:26:05
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<https://github.com/cucumber/cucumber-jvm/pull/2351|#2351 [TestNG] Add `CucumberPropertiesProvider`>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 13:32:58
[cucumber/cucumber-jvm] Comment on #2351
<p>All done. Can't use the <code>ITestContext</code> without breaking semantic versioning so that will drop into v7. You'll have to copy the <code>AbstractTestNGCucumberTests</code> and modify the setup step:</p>
<pre><code> @BeforeClass(alwaysRun = true)
public void setUpClass(ITestContext context) {
XmlTest currentXmlTest = context.getCurrentXmlTest();
CucumberPropertiesProvider properties = currentXmlTest::getParameter;
testNGCucumberRunner = new TestNGCucumberRunner(this.getClass(), properties);
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:22:04
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>When using TestNG suites can be declared in <code>testng.xml</code>. These suites can be<br />
configured with parameters. When using <code>AbstractTestNGCucumberTests</code> these<br />
will be picked up automatically.</p>
<p>When using the <code>TestNGCucumberRunner</code> they can be read through <code>ITestContext</code>.</p>
<pre><code> @BeforeClass(alwaysRun = true)
public void setUpClass(ITestContext context) {
XmlTest currentXmlTest = context.getCurrentXmlTest();
CucumberPropertiesProvider properties = currentXmlTest::getParameter;
testNGCucumberRunner = new TestNGCucumberRunner(this.getClass(), properties);
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:23:53
[cucumber/cucumber-jvm] Comment on #2354
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2354">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2354</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/96316c8ffacfeab262e288e8246dc08acf46b667">96316c8</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/1be1b5276326802b88e575eaf045c1e7ac0db010?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|v7.x.x">https://codecov.io/gh/cucumber/cucumber-jvm/commit/1be1b5276326802b88e575eaf045c1e7ac0db010?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|v7.x.x</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/1be1b5276326802b88e575eaf045c1e7ac0db010">1be1b52</a>) will <strong>increase</strong> coverage by <code>0.01%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## v7.x.x #2354 +/- ##
============================================
+ Coverage 83.12% 83.14% +0.01%
- Complexity 2292 2294 +2
============================================
Files 292 292
Lines 8251 8259 +8
Branches 738 738
============================================
+ Hits 6859 6867 +8
Misses 1103 1103
Partials 289 289
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|0923926...96316c8">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2354?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|0923926...96316c8</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:46:14
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:50:44
[cucumber/cucumber-jvm] Comment on #2330
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:50:50
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:51:01
[cucumber/cucumber-jvm] Pull request reopened by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:51:10
[cucumber/cucumber-jvm] Comment on #2330
<p>Wrong button.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:51:58
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:51:58
[cucumber/cucumber-jvm] Comment on #2349
<p>Fixed by <a href="https://github.com/cucumber/cucumber-jvm/commit/db3e17b1e5060c4f4fae6b9553cd19336a66ce99">db3e17b</a> and <a href="https://github.com/cucumber/cucumber-jvm/commit/03ea225d32cfc9fb986f1a08834ae5340947018d">03ea225</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 14:55:45
[cucumber/cucumber-jvm] Comment on #2347
<p><a href="https://github.com/chasangchual">@chasangchual</a> when looking for features, Cucumber scans the entire classpath for features and glue unless configured otherwise. So when you are talking about modules. Are you talking about maven modules, modules in IDEA/Eclipse, java modules or something else?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 15:12:18
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-05 15:12:56
[cucumber/cucumber-jvm] Comment on #2350
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will now ignore this update (2.3.5). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the <code>ignoreDeps</code> array of your renovate config.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-06 12:21:06
[cucumber/cucumber-android] Pull request merged by lsuski
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-08-07 16:46:50
[cucumber/cucumber-jvm] Comment on #2330
<p>I think the order of the nested json fields under <code>pattern</code> was not always the same, causing the comparison order to get reversed</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-07 16:47:57
[cucumber/cucumber-jvm] Comment on #2330
<p>Managed to try it out locally on my other project - looks as I had expected/hoped :)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-08 14:33:46
[cucumber/cucumber-jvm] Comment on #2330
<p>Yeah. Order isn't guaranteed with json. Nicely spotted.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-08 14:42:45
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-08 14:45:41
[cucumber/cucumber-jvm] Comment on #2330
<p>Cheers!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-09 02:34:22
[cucumber/cucumber-jvm] Issue opened by rajgopalrajesh
<p>io.cucumber cucumber-core 6.10.2 io.cucumber cucumber-testng 6.10.2 test io.cucumber cucumber-java 6.10.2 org.testng testng 7.1.0 compile org.testng testng 7.1.0 tech.grasshopper extentreports-cucumber6-adapter 2.8.3 test io.qameta.allure allure-cucumber6-jvm 2.14.0 com.epam.reportportal agent-java-cucumber6 5.1.0-RC-3 [ERROR] Failed to execute goal on project API: Could not resolve dependencies for project API🫙1.0-SNAPSHOT: Failed to collect dependencies for com..cortellis:API:jar:1.0<em>SNAPSHOT: Could not resolve version conflict among [io.cucumber:cucumber</em>testng:jar:6.10.2 -> io.cucumber:cucumber<em>core:jar:6.10.2 -> io.cucumber:messages:jar:14.0.1, io.cucumber:cucumber</em>testng:jar:6.10.2 -> io.cucumber:cucumber<em>core:jar:6.10.2 -> io.cucumber:html</em>formatter:jar:12.0.0 -> io.cucumber:messages:jar:[14.0.1,15.0.0), io.cucumber:cucumber<em>testng:jar:6.10.2 -> io.cucumber:cucumber</em>core:jar:6.10.2 -> io.cucumber:create<em>meta:jar:3.0.0 -> io.cucumber:messages:jar:[14.0.1,15.0.0), io.qameta.allure:allure</em>cucumber6<em>jvm:jar:2.14.0 -> io.cucumber:gherkin:jar:18.0.0 -> io.cucumber:messages:jar:[15.0.0,16.0.0)] -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project API: Could not resolve dependencies for project com.thomsonreuters.cortellis:API:jar:1.0</em>SNAPSHOT: Failed to collect dependencies for com.thomsonreuters.cortellis:API:jar:1.0-SNAPSHOT at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:269)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-09 02:48:07
[cucumber/cucumber-jvm] Comment on #2355
<p>You are using <code>allure-cucumber6-jvm</code>. You should probably report your issue with them.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 03:05:29
[cucumber/cucumber-android] Pull request opened by andreasmarkussen
<p><strong>Description</strong></p>
<p>All the updates in this PR are in the README.md file - no code changes.</p>
<p>• Changed the gradle target to be the debug and not the release version of the app (assemble vs assembleDebug)
• Changed the gradle target to be the android test target, not the jvm test (assembleDebugTest vs assembleDebugAndroidTest)
• Removed old-style code formatting, to shorten the README.md raw file. This makes it easier to read when viewing in the terminal.
• Added details on how to extract the cucumber report files
• Added info about the difference between running with adb and gradlew</p>
<p><strong>Motivation & context</strong></p>
<p>Makes it easier to use the sample project.</p>
<p><strong>Type of change</strong></p>
<p>• Documentation - no need for a CHANGELOG.md change</p>
<p><strong>Note to other contributors</strong></p>
<p><em>If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.</em></p>
<p><strong>Update required of <a href="http://cucumber.io/docs**|cucumber.io/docs**">http://cucumber.io/docs</strong>|cucumber.io/docs**</a></p>
<p>(N/A)</p>
<p><strong>Checklist:</strong></p>
<p>(N/A - No code changes)</p>
<p>☐ My code follows the code style of this project.
☐ My change requires a change to the documentation.
☐ I have updated the documentation accordingly.
☐ I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.
☐ I have added tests to cover my changes.
☐ All new and existing tests passed.</p>
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-08-10 04:26:31
[cucumber/cucumber-android] Pull request merged by lsuski
<a href="https://github.com/cucumber/cucumber-android">cucumber/cucumber-android</a>
GitHub
2021-08-10 12:31:42
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>Prefer using the annotation based method of providing parameters instead.<br />
For example:</p>
<pre><code>Feature: Parameter Types
Scenario: flights
Given LHR-CDG has been delayed 45 minutes
</code></pre>
<pre><code> @Given("{flight} has been delayed {int} minutes")
public void lhrCDGHasBeenDelayedMinutes(Flight flight, int delay) {
assertEquals("LHR", flight.from);
assertEquals("CDG", <a href="http://flight.to">flight.to</a>);
assertEquals(45, delay);
}
@ParameterType(value = "([A-Z]{3})-([A-Z]{3})", useForSnippets = true)
public Flight flight(String from, String to) {
return new Flight(from, to);
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 12:37:10
[cucumber/cucumber-jvm] Comment on #2356
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2356">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2356</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/acea42d3b70693f168a3de85206d2d1f96fb823d">acea42d</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/2fcd4b1877702afe2cfaf336fdc72f6185eb5258?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|v7.x.x">https://codecov.io/gh/cucumber/cucumber-jvm/commit/2fcd4b1877702afe2cfaf336fdc72f6185eb5258?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|v7.x.x</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/2fcd4b1877702afe2cfaf336fdc72f6185eb5258">2fcd4b1</a>) will <strong>increase</strong> coverage by <code>0.09%</code>.<br />
> The diff coverage is <code>85.71%</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## v7.x.x #2356 +/- ##
============================================
+ Coverage 83.14% 83.23% +0.09%
+ Complexity 2295 2291 -4
============================================
Files 292 290 -2
Lines 8270 8213 -57
Branches 739 732 -7
============================================
- Hits 6876 6836 -40
+ Misses 1105 1093 -12
+ Partials 289 284 -5
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|2fcd4b1...acea42d">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2356?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|2fcd4b1...acea42d</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 12:38:06
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:01:25
[cucumber/cucumber-jvm] Comment on #2352
<p>Just did a relatively simple check. Could not reproduce the issue. If you do think this is a issue caused by cucumber please provide a <em>minimal</em> example that reproduces the problem in the form of a Github repo.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:01:25
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:07:57
[cucumber/cucumber-jvm] Comment on #2334
<p>Unless you can show this is a problem with normal use of Cucumber through a <em>minimal</em> reproducer in the form of a github repo I'm not going to make any affordances for this now and in the long run the thread locals will be removed. So this issue should eventually be moot.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:07:57
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:09:23
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:09:43
[cucumber/cucumber-jvm] Comment on #2320
<p>Fixed by <a href="https://github.com/cucumber/cucumber-jvm/pull/2330">#2330</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:09:43
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:12:14
[cucumber/cucumber-jvm] Comment on #2348
<p>You request what you need, and I'll request what I'll need. I'm sure we can fit more then one link in a tweet.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:12:26
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:16:50
[cucumber/cucumber-jvm] Comment on #2302
<p>The Quarkus team has decided to support Cucumber through a quarkiverse plugin. When using <code>quarkus-cucumber</code> please direct any and all questions, issues, and bug reports there.</p>
<p><a href="https://github.com/quarkusio/quarkus/issues/11045#issuecomment-894883127">quarkusio/quarkus#11045 (comment)</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:16:50
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 13:38:41
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>Closes: <a href="https://github.com/cucumber/cucumber-jvm/issues/2308">#2308</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 14:02:13
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 14:02:14
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 14:04:26
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>We can not exclude the possibility that an event is published to the event bus<br />
after test execution has completed. For example because the test framework may<br />
have decided that a test case has timed out and is now terminating test<br />
execution.</p>
<p>As such events from the pending testcase on the synchronized bus may race with<br />
the events from the unsynchronized bus. This in turn may break the <code>LinkedList</code><br />
in the <code>CanonicalOrderEventPublisher</code>.</p>
<p>Fixes: <a href="https://github.com/cucumber/cucumber-jvm/issues/2288">#2288</a> (mabye??)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 14:20:17
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 14:20:19
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 14:22:33
[cucumber/cucumber-jvm] Comment on #2288
<p>Found something that could potentially cause the problem but I'm not certain. If you want to try this solution before a release is made you could copy the implementation of <code>TestNGCucumberRunner</code> from <a href="https://github.com/cucumber/cucumber-jvm/pull/2358">#2358</a> and see if it solves your problem.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 15:08:40
[cucumber/cucumber-jvm] Comment on #2254
<p>There is definitely a mismatch between <code>Scenario.getId()</code> and <code>TestCase.getId()</code> and I think the best way to resolve this conflict would be to make <code>Scenario.getId()</code> return the same value as <code>TestCase.getId()</code>. The old representation can still be obtained by combining the scenarios uri and line together.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-10 15:09:00
[cucumber/cucumber-jvm] Comment on #2254
<p>This is breaking change so it'd have to go into v7.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-11 13:15:10
[cucumber/cucumber-jvm] Comment on #2308
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> thanks for example, but i moved in other way, not the best code, but working</p>
<pre><code>package io.cucumber.junit.platform.engine
import org.junit.platform.engine.FilterResult
import org.junit.platform.engine.TestDescriptor
import org.junit.platform.engine.support.descriptor.FileSource
import org.junit.platform.launcher.PostDiscoveryFilter
import java.io.File
import java.net.URI
class CucumberPostDiscoveryFilter : PostDiscoveryFilter {
private val rerunEnabled = !System.getProperty("cucumber.rerun.file").isNullOrEmpty()
private val testsToRerun: Map&lt;URI, List&lt;Int&gt;&gt;? = System.getProperty("cucumber.rerun.file")?.let {
File(it).takeIf { it.exists() }?.let { file -&gt;
parseRerunFile(file)
}
}
private val actualAmountRerunTests: Int = testsToRerun?.values?.flatten()?.size ?: 0
private val maxRerunTestsCount: Int? = System.getProperty("cucumber.rerun.count")?.toInt()
private fun parseRerunFile(rerunFile: File): Map&lt;URI, List&lt;Int&gt;&gt; {
return rerunFile.readLines().map { URI(it) }.associate { uri -&gt;
uri.schemeSpecificPart.split(":").let {
File(it.first()).absoluteFile.toURI() to it.drop(1)
.map { lineNumber -&gt; lineNumber.toInt() }
}
}
}
override fun apply(descriptor: TestDescriptor): FilterResult {
if (!rerunEnabled) {
return FilterResult.included("Rerun is disabled, nothing to filter")
}
if (descriptor.children.isNotEmpty()) {
return FilterResult.included("filter only applied for tests")
}
return if (descriptor is PickleDescriptor) {
if (testsToRerun.isNullOrEmpty()) {
throw IllegalStateException("Rerun was enabled but rerun file property was empty")
}
maxRerunTestsCount?.let {
if (actualAmountRerunTests &gt; it) {
throw IllegalStateException("Amount of tests to rerun: [$actualAmountRerunTests] is bigger than allowed: [$maxRerunTestsCount]")
}
}
val featureFile = getSourceUri(descriptor)
testsToRerun[featureFile]?.let {
val line = getSourcePositionLine(descriptor)
FilterResult.includedIf(line in it, { "Test was in rerun file" }, { "Test was absent in rerun file" })
} ?: FilterResult.excluded("Absent in rerun file")
} else {
FilterResult.included("filter only applied for cucumber tests")
}
}
private fun getSourceUri(descriptor: TestDescriptor): URI? {
return (descriptor.source.orElse(null) as? FileSource)?.uri
}
private fun getSourcePositionLine(descriptor: TestDescriptor): Int? {
return (descriptor.source.orElse(null) as? FileSource)?.position?.orElse(null)?.line
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-12 12:55:23
[cucumber/cucumber-jvm] Comment on #2324
<p>I am very surprised this feature is not implemented already. Clicking on a console output shouldn't be the only way to reach report. There is basically no way to share report link with others with your automation code.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-12 13:24:39
[cucumber/cucumber-jvm] Comment on #2324
<p>Cucumber is an opensource project and mostly maintained by people in their spare time. Are you interested in doing the work needed to make the plugin system more pluggable?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-12 18:22:50
[cucumber/cucumber-jvm] Comment on #2324
<p>Also see the last paragraph of the <a href="https://github.com/cucumber/cucumber-jvm/blob/main/LICENCE">LICENSE</a>. If you really want this you can contribute it yourself. We're here to help you if you have any questions about how to proceed.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-12 20:31:54
[cucumber/cucumber-jvm] Comment on #2351
<p>is there anyway to figure out if this commit has been included in the latest release ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-12 22:27:05
[cucumber/cucumber-jvm] Comment on #2351
<p>You can see the tags that include the commit by clicking on it. Commits are squash merged so you'll want <a href="https://github.com/cucumber/cucumber-jvm/commit/db3e17b1e5060c4f4fae6b9553cd19336a66ce99">db3e17b</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-15 03:02:33
[cucumber/cucumber-jvm] Comment on #2359
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge, however this is not possible so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-15 03:02:33
[cucumber/cucumber-jvm] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: At any time (no schedule defined).</p>
<p>🚦 <strong>Automerge</strong>: Disabled due to failing status checks.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-jvm">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-15 06:47:35
[cucumber/cucumber-jvm] Issue opened by ahu0605
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
when I use junit5 ,I can not set different path .feature eg: src/test/xxx/xxx.java ,src/test/resources/xxx/xx.feature</p>
<p><strong>Describe the solution you'd like</strong><br />
I want to config freedom path for .feature</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-15 08:23:15
[cucumber/cucumber-jvm] Comment on #2360
<p>I have a very hard time understanding what your problem is. So I'm going to guess a few answers:</p>
<ol><li>When using the <code>@Cucumber</code> annotation, Cucumber will look for features in the same package as the annotated class. When using the the <code>@Cucumber</code> there can only be one value of <code>cucumber.glue</code>.</li><li>You can use the <a href="https://github.com/cucumber/cucumber-jvm/tree/main/junit-platform-engine#supported-discovery-selectors-and-filters">supported discovery selectors</a> from JUnit 5. You can use these through the <a href="https://junit.org/junit5/docs/current/user-guide/#advanced-topics">JUnit Platform Launcher API</a> or through their <a href="https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher">Console Launcher</a>.</li><li>Finally, if you have multiple suites, each with a different set of features and glue, you can use the experimental <code>junit-platform-suite</code> to declare multiple suites, each with different configuration parameters. <a href="https://github.com/mpkorstanje/junit-platform-suite-demo">https://github.com/mpkorstanje/junit-platform-suite-demo</a></li>
</ol>
<p>If this doesn't help, perhaps you can provide a concrete example of your problem.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-15 13:06:26
[cucumber/cucumber-jvm] Comment on #2359
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2359">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2359</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/045e51d07037cc264ebb2456d33e65c93cdbc356">045e51d</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/fc4596bd8d51c5f10f91678d4c0b1d8e51341607?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/fc4596bd8d51c5f10f91678d4c0b1d8e51341607?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/fc4596bd8d51c5f10f91678d4c0b1d8e51341607">fc4596b</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## main #2359 +/- ##
=========================================
Coverage 83.45% 83.45%
Complexity 2325 2325
=========================================
Files 300 300
Lines 8279 8279
Branches 750 750
=========================================
Hits 6909 6909
Misses 1074 1074
Partials 296 296
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|fc4596b...045e51d">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2359?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|fc4596b...045e51d</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-15 14:14:06
[cucumber/cucumber-jvm] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-15 20:01:15
[cucumber/cucumber-jvm] Comment on #2360
<p>thank you，I will try</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-15 20:01:15
[cucumber/cucumber-jvm] Issue closed by ahu0605
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-16 05:36:50
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>When using:</p>
<pre><code>cucumber.junit-platform.naming-strategy=long
</code></pre>
<p>Will output the node names as:</p>
<pre><code>[root]
Basic Arithmetic
Basic Arithmetic - Addition
Basic Arithmetic - Another Addition
Basic Arithmetic - Many additions
Basic Arithmetic - Many additions - Single digits
Basic Arithmetic - Many additions - Single digits - Example #1
Basic Arithmetic - Many additions - Single digits - Example #2
Basic Arithmetic - Many additions - Double digits
Basic Arithmetic - Many additions - Double digits - Example #1
Basic Arithmetic - Many additions - Double digits - Example #2
Dates with different date formats
Dates with different date formats - Determine past date
Shopping
Shopping - Give correct change
</code></pre>
<p>Useful when dealing with Surefir</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
Codecov: 83.20% (-0.13%) compared to 464a7e5
(https://github.com/cucumber/cucumber-jvm/runs/3340076599)
Codecov: 68.00% of diff hit (target 83.32%)
(https://github.com/cucumber/cucumber-jvm/runs/3340076595)
GitHub
2021-08-16 05:42:25
[cucumber/cucumber-jvm] Comment on #2361
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2361">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2361</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b8b912d125f1bbbab23931b38766fabab4dca71a">b8b912d</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/464a7e5f48fc127260a8234d7d8a8e27d99c99cc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|v7.x.x">https://codecov.io/gh/cucumber/cucumber-jvm/commit/464a7e5f48fc127260a8234d7d8a8e27d99c99cc?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|v7.x.x</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/464a7e5f48fc127260a8234d7d8a8e27d99c99cc">464a7e5</a>) will <strong>decrease</strong> coverage by <code>0.12%</code>.<br />
> The diff coverage is <code>68.00%</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## v7.x.x #2361 +/- ##
============================================
- Coverage 83.32% 83.20% -0.13%
- Complexity 2294 2297 +3
============================================
Files 290 291 +1
Lines 8212 8241 +29
Branches 732 733 +1
============================================
+ Hits 6843 6857 +14
- Misses 1086 1101 +15
Partials 283 283
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|464a7e5...b8b912d">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2361?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|464a7e5...b8b912d</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-16 10:35:38
[cucumber/cucumber-jvm] Pull request ready for review by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-16 10:35:46
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-16 10:38:34
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-16 10:45:26
[cucumber/cucumber-jvm] Comment on #2331
<p>With Cucumber v7 (not yet released) and JUnit 5.8 (not yet released) we will deprecate <code>@Cucumber</code> in favour of <code>@Suite</code>. This should coincidently fix the issue with Surefire > M4.</p>
<p>Add:</p>
<pre><code>&lt;dependency&gt;
&lt;groupId&gt;org.junit.platform&lt;/groupId&gt;
&lt;artifactId&gt;junit-platform-suite&lt;/artifactId&gt;
&lt;version&gt;${junit-platform.version}&lt;/version&gt;
&lt;scope&gt;test&lt;/scope&gt;
&lt;/dependency&gt;
</code></pre>
<p>Then use:</p>
<pre><code>package com.example;
import org.junit.platform.suite.api.ConfigurationParameter;
import org.junit.platform.suite.api.SelectClasspathResource;
import org.junit.platform.suite.api.Suite;
import static io.cucumber.junit.platform.engine.Constants.GLUE_PROPERTY_NAME;
@Suite
@SelectClasspathResource("com/exmaple")
@ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "com.example")
public class RunCucumberTest {
}
</code></pre>
<p>To improve the readability of the reports provide the<br />
<code>cucumber.junit-platform.naming-strategy=long</code> configuration parameter.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-16 10:45:26
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-16 11:14:03
[cucumber/cucumber-jvm] Comment on #2362
<p>Waiting for JUnit 5.8 to be available.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-16 11:18:52
[cucumber/cucumber-jvm] Comment on #2362
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2362">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2362</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/9a1a1b8b2dc3f9f4a46c437309af6a68a26ca331">9a1a1b8</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/ebbd4b994797a85c53f544ea0f4049a1d1ee4afc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|v7.x.x">https://codecov.io/gh/cucumber/cucumber-jvm/commit/ebbd4b994797a85c53f544ea0f4049a1d1ee4afc?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|v7.x.x</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/ebbd4b994797a85c53f544ea0f4049a1d1ee4afc">ebbd4b9</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## v7.x.x #2362 +/- ##
=========================================
Coverage 83.31% 83.31%
Complexity 2298 2298
=========================================
Files 291 291
Lines 8241 8241
Branches 733 733
=========================================
Hits 6866 6866
Misses 1092 1092
Partials 283 283
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|ebbd4b9...9a1a1b8">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2362?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|ebbd4b9...9a1a1b8</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 06:13:05
[cucumber/cucumber-jvm] Comment on #2281
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2281">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2281</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/4ae039348b025c5a00a1fab703c20857b99103ac">4ae0393</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/ebbd4b994797a85c53f544ea0f4049a1d1ee4afc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|v7.x.x">https://codecov.io/gh/cucumber/cucumber-jvm/commit/ebbd4b994797a85c53f544ea0f4049a1d1ee4afc?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|v7.x.x</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/ebbd4b994797a85c53f544ea0f4049a1d1ee4afc">ebbd4b9</a>) will <strong>increase</strong> coverage by <code>0.02%</code>.<br />
> The diff coverage is <code>83.49%</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## v7.x.x #2281 +/- ##
============================================
+ Coverage 83.31% 83.33% +0.02%
- Complexity 2298 2323 +25
============================================
Files 291 295 +4
Lines 8241 8299 +58
Branches 733 737 +4
============================================
+ Hits 6866 6916 +50
- Misses 1092 1098 +6
- Partials 283 285 +2
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|ebbd4b9...4ae0393">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2281?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|ebbd4b9...4ae0393</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 10:55:32
[cucumber/cucumber-jvm] Comment on #2363
<p>Also waiting for JUnit 5.8</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 10:58:58
[cucumber/cucumber-jvm] Comment on #2363
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2363">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2363</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/d41e9d1a90dfd9bfc24b48ac3910c8ca891652cd">d41e9d1</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/ebbd4b994797a85c53f544ea0f4049a1d1ee4afc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|v7.x.x">https://codecov.io/gh/cucumber/cucumber-jvm/commit/ebbd4b994797a85c53f544ea0f4049a1d1ee4afc?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|v7.x.x</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/ebbd4b994797a85c53f544ea0f4049a1d1ee4afc">ebbd4b9</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## v7.x.x #2363 +/- ##
=========================================
Coverage 83.31% 83.31%
Complexity 2298 2298
=========================================
Files 291 291
Lines 8241 8241
Branches 733 733
=========================================
Hits 6866 6866
Misses 1092 1092
Partials 283 283
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|ebbd4b9...d41e9d1">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2363?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|ebbd4b9...d41e9d1</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 12:59:49
[cucumber/cucumber-jvm] Pull request ready for review by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 13:00:25
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 13:15:45
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>Closes: <a href="https://github.com/cucumber/cucumber-jvm/issues/2306">#2306</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 13:16:35
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 13:16:49
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 13:40:22
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>Closes: <a href="https://github.com/cucumber/cucumber-jvm/issues/2294">#2294</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 13:45:33
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 13:45:39
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 14:04:05
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>To obtain the original <code>&lt;uri&gt;:&lt;line-number&gt;</code> identifier use<br />
<code>scenario.getUri() + ":" + scenario.getLine()</code>.</p>
<p>Closes: <a href="https://github.com/cucumber/cucumber-jvm/issues/2254">#2254</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 14:04:53
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-17 14:05:03
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 04:40:03
[cucumber/cucumber-jvm] Pull request ready for review by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 04:54:22
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 06:58:44
[cucumber/cucumber-jvm] Pull request ready for review by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 07:25:53
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 07:31:46
[cucumber/cucumber-jvm] Issue closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 09:50:48
[cucumber/cucumber-jvm] Comment on #2255
<p>Superseded by <a href="https://github.com/cucumber/cucumber-jvm/pull/2363">#2363</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 09:50:50
[cucumber/cucumber-jvm] Pull request closed by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 12:33:04
[cucumber/cucumber-jvm] Pull request opened by mpkorstanje
<p>When dealing with undefined steps, or steps that do not have a location the<br />
pretty formatter prints a null value. This print should be omitted.</p>
<pre><code> Scenario: a few cukes # io/cucumber/skeleton/belly.feature:3
Given I have 42 cukes in my belly # io.cucumber.skeleton.StepDefinitions.I_have_cukes_in_my_belly(int)
When I wait 1 hour # null
Then my belly should growl # null
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 12:39:38
[cucumber/cucumber-jvm] Comment on #2367
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2367">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2367</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/1b6ffdbed0f7d30efbd3cde2944371d2be065fd4">1b6ffdb</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/39af9164723fe4c0d9d7d58e193c85b0f3b170b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/39af9164723fe4c0d9d7d58e193c85b0f3b170b8?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/39af9164723fe4c0d9d7d58e193c85b0f3b170b8">39af916</a>) will <strong>increase</strong> coverage by <code>0.01%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=tree&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Impacted file tree graph></p>
<pre><code>@@ Coverage Diff @@
## main #2367 +/- ##
============================================
+ Coverage 83.34% 83.35% +0.01%
- Complexity 2327 2329 +2
============================================
Files 296 296
Lines 8309 8314 +5
Branches 737 738 +1
============================================
+ Hits 6925 6930 +5
Misses 1099 1099
Partials 285 285
</code></pre>
<hr />
<p><https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Continue to review full report at Codecov>.</p>
<p>> <strong>Legend</strong> - <https://docs.codecov.io/docs/codecov-delta?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|Click here to learn more><br />
> <code>Δ = absolute &lt;relative&gt; (impact)</code>, <code>ø = not affected</code>, <code>? = missing data</code><br />
> Powered by <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=footer&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Codecov</a>. Last update <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|39af916...1b6ffdb">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2367?src=pr&el=lastupdated&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|39af916...1b6ffdb</a>. Read the <https://docs.codecov.io/docs/pull-request-comments?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|comment docs>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 12:40:32
[cucumber/cucumber-jvm] Pull request merged by mpkorstanje
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 15:07:01
[cucumber/cucumber-jvm] Comment on #2362
<p>This sounds great! When something is deprecated I think docs should etc should document the new way rather than the old.</p>
<p>We need a ticket to keep track of what needs to be updated. Quick brain dump:</p>
<p>• docs repo
• skeleton repo
• archetype repo
• this repo (in case <a href="https://github.com/cucumber">@cucumber</a> is still ised)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2021-08-18 15:44:13
[cucumber/cucumber-jvm] Comment on #2362
<p>The <code>@Cucumber</code> annotation was never documented outside this repository. It was a workaround to get Cucumber going with JUnit5 and Surefire/Gradle.</p>
<p>We <em>can</em> replace JUnit 4 with JUnit 5 now in the <a href="http://docs.cucumber.io">docs.cucumber.io</a> though.</p>
<p>> archetype repo</p>
<p>Part of this repo. Already covered.</p>
<p>> skeleton repo</p>
<p><a href="https://github.com/cucumber/cucumber-java-skeleton/pull/64/files">https://github.com/cucumber/cucumber-java-skeleton/pull/64/files</a></p>
<p>> docs repo</p>
<p>Only thing left to do.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-10-18 02:49:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2627#issuecomment-1282125856">Comment</a> on issue by <a href="https://github.com/mpkorstanje">@mpkorstanje</a>
<p>You can tag different example groups. Then select a group by its tag.</p>
<pre><code>Feature:
Scenario Outline: The user can login
Given the &lt;url&gt; for &lt;country&gt;
When the user logs in
Then They land on the localized homepage for &lt;country&gt;
@country-SG
Examples:
| country | url |
| SG | <a href="http://www.xxx.sg">www.xxx.sg</a> |
@country-IN
Examples:
| country | url |
| IN | <a href="http://www.xxx.in">www.xxx.in</a> |
@country-HK
Examples:
| country | url |
| HK | <a href="http://www.xxx.hk">www.xxx.hk</a> |
</code></pre>
<p>Though as you can see this get unwieldy quickly. If you are using examples as a way to parameterize your entire test suite, consider extracting the country, url, ect to a <code>&lt;country&gt;.properties</code> file and use an environment variable to select which country the suite will be used for that run. You can then use multiple jobs in CI, one for each country to get complete coverage.</p>
<hr />
<p>For future reference:</p>
<p>• This is the issue tracker of an open source project. Please use stack overflow for questions on how to use it.
• When posting a question on Github or Stackoverflow, please use Markdown syntax to make your posts readable.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-10-19 11:51:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2628#issuecomment-1284437568">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You are using a Cucumber expression. And at glance <code>(from|as)</code> should be <code>from/as</code>. The <code>(..|..)</code> worked in v6 because Regex characters in a Cucumber expression were not properly escaped in all situations.</p>
<p><a href="https://github.com/cucumber/common/pull/771">cucumber/common#771</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-10-20 01:50:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2628#issuecomment-1285165704">Comment</a> on issue by <a href="https://github.com/cmclopes">cmclopes</a>
<p>Hi <a href="https://github.com/mpkorstanje">@mpkorstanje</a> , thanks for your help. Yes, with your suggestion, it works fine with 7.x!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-10-24 12:39:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2491#issuecomment-1289507979">Comment</a> on issue by <a href="https://github.com/m-schlatt">m-schlatt</a>
<p>Hi, I tried to implement the suggested changes. Hope I got it right. But this is like my first commit, so any feedback is appreciated.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-10-27 03:01:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2631#issuecomment-1293286478">Comment</a> on issue by <a href="https://github.com/fslev">fslev</a>
<p>If feature starts with description followed by comment, everything works fine</p>
<pre><code>Feature: Feature 2
some description
# some comment
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-10-31 05:01:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2631#issuecomment-1296985415">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> Run feature, either from Maven or from the IDE. You may also try to execute the whole suite of tests containing this Feature. No test will be executed.</p>
<p>These are very different execution paths.</p>
<p>With the <code>@Suite</code> I see:</p>
<pre><code>Caused by: io.cucumber.core.gherkin.FeatureParserException: Failed to parse resource at: classpath:io/cucumber/skeleton/belly.feature
(3:3): expected: #EOF, #Comment, #BackgroundLine, #TagLine, #ScenarioLine, #RuleLine, #Empty, got 'some description'
at io.cucumber.core.gherkin.messages.GherkinMessagesFeatureParser.parse(GherkinMessagesFeatureParser.java:43)
</code></pre>
<p>Though with the CLI the parse error is silently dropped.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-10-31 06:49:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2631#issuecomment-1297123577">Comment</a> on issue by <a href="https://github.com/fslev">fslev</a>
<p>So, after all this is an invalid syntax:</p>
<pre><code>Feature: Some feature
# some comment
With some description
</code></pre>
<p>, but this is valid ?</p>
<pre><code>Feature: Some feature
# some comment
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-10-31 07:55:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2631#issuecomment-1297211829">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Gherkin has a grammar that explicitly includes comments and comments are not allowed before the description.</p>
<p><a href="https://github.com/cucumber/common/blob/main/gherkin/gherkin.berp#L37">https://github.com/cucumber/common/blob/main/gherkin/gherkin.berp#L37</a></p>
<pre><code>DescriptionHelper := #Empty** Description? #Comment**
</code></pre>
<p>You may want to create an issue in <a href="https://github.com/cucumber/common">https://github.com/cucumber/common</a> to address that.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-02 01:41:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2631#issuecomment-1299837102">Comment</a> on issue by <a href="https://github.com/fslev">fslev</a>
<p>By upgrading the cucumber-showcase project from above to 7.9.0 and building it via Maven, it seems the feature parse error is still not displayed</p>
<pre><code>mvn clean test
[ERROR] TestEngine with ID 'junit-platform-suite' failed to discover tests
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process
[ERROR] TestEngine with ID 'junit-platform-suite' failed to discover tests
</code></pre>
<p>However, using the -e option , the error is now displayed</p>
<pre><code>mvn clean test -e
TestEngine with ID 'junit-platform-suite' failed to discover tests
org.junit.platform.commons.JUnitException: TestEngine with ID 'junit-platform-suite' failed to discover tests
Caused by: io.cucumber.core.gherkin.FeatureParserException: Failed to parse resource at: classpath:io/example/Feature2.feature
(3:3): expected: #EOF, #Comment, #BackgroundLine, #TagLine, #ScenarioLine, #RuleLine, #Empty, got 'some description'
</code></pre>
<p>Though, this might be expected..</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-02 03:43:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2631#issuecomment-1300020453">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Yeah, that's between JUnit 5 and Surefire. You could petition the JUnit 5 team to include more information in the <code>JUnitException</code> thrown when discovery fails.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-10 04:00:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2636#issuecomment-1310179399">Comment</a> on issue by <a href="https://github.com/JustinH1989">JustinH1989</a>
<p>> Not really sure if this is a bug but I am not able to get passed this step in my Maven Build. My integration tests pass successfully but I receive the following error message at the end of my build and the build fails: <code>[ERROR] Failed to execute goal org.apache.maven.plugins:maven_surefire_plugin:3.0.0-M7:test (default-test) on project HostAPITesting:
&gt;
&gt; [ERROR] ExecutionException There was an error in the forked process [ERROR] Test mechanism :: io.cucumber.junit.FeatureRunner$FeatureId cannot be cast to gherkin.formatter.model.Feature [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException There was an error in the forked process [ERROR] Test mechanism :: io.cucumber.junit.FeatureRunner$FeatureId cannot be cast to gherkin.formatter.model.Feature</code> I do see that The junit Feature runner class generates a feature ID, but it cannot cast to the Gherkin class which is on info.cukes:gherkin 2.12.2 version however this is not specified anywhere in the POM of my project and I am not sure where is it getting this dependency from.
>
> I have checked online but I cannot find any solution, any assistance will be appreciated,
>
> I am using io.cucumber version 7.8.1 in my project with a junit-surefire-plugin</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-10 04:01:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2636#issuecomment-1310180039">Comment</a> on issue by <a href="https://github.com/JustinH1989">JustinH1989</a>
<p>Here is the full stack trace<br />
`# Created at 2022-11-10T13:37:41.894<br />
org.apache.maven.surefire.api.testset.TestSetFailedException: Test mechanism :: io.cucumber.junit.FeatureRunner$FeatureId cannot be cast to gherkin.formatter.model.Feature<br />
at org.apache.maven.surefire.common.junit4.JUnit4RunListener.rethrowAnyTestMechanismFailures(JUnit4RunListener.java:226)<br />
at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:138)<br />
at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeLazy(JUnitCoreWrapper.java:119)<br />
at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:87)<br />
at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)<br />
at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158)<br />
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)<br />
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)<br />
at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)<br />
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)<br />
Caused by: java.lang.ClassCastException: io.cucumber.junit.FeatureRunner$FeatureId cannot be cast to gherkin.formatter.model.Feature<br />
at za.co.nedbank.junit.listener.Listener.testRunStarted(Listener.java:144)<br />
at org.junit.runner.notification.SynchronizedRunListener.testRunStarted(SynchronizedRunListener.java:35)<br />
at org.junit.runner.notification.RunNotifier$1.notifyListener(RunNotifier.java:91)<br />
at org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:72)<br />
at org.junit.runner.notification.RunNotifier.fireTestRunStarted(RunNotifier.java:88)<br />
at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:54)<br />
at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)<br />
... 8 more</p>
<p>`</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-10 09:38:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2636#issuecomment-1310655171">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> I do see that The junit Feature runner class generates a feature ID, but it cannot cast to the Gherkin class which is on info.cukes:gherkin 2.12.2 version however this is not specified anywhere in the POM of my project and I am not sure where is it getting this dependency from.</p>
<p>I suspect you may be pulling in this dependency transitively. You can try to use <code>mvn dependency:tree</code> to see where the dependency comes from. Alternatively you can <a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber-java-skeleton</a> to see the a minimal working setup.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-10 09:44:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2636#issuecomment-1310661271">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<pre><code>Caused by: java.lang.ClassCastException: io.cucumber.junit.FeatureRunner$FeatureId cannot be cast to gherkin.formatter.model.Feature
at za.co.nedbank.junit.listener.Listener.testRunStarted(Listener.java:144)
</code></pre>
<p>From you stack trace it looks like <code>za.co.nedbank.junit.listener.Listener</code> is making the cast. I suspect you'll find the (transitive) dependency on <code>info.cukes:gherkin 2.12.2</code> there too.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-10 09:28:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2637#issuecomment-1310641433">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>A PR would be welcome.</p>
<p>You can try to interpret the ordering string as a fully qualified class name.</p>
<p>Though rather then using this string to load a class I would prefer a solution based on <a href="https://docs.oracle.com/javase/tutorial/sound/SPI-intro.html">Service Provider Interfaces</a>. It hides all problems associated with class loading and should play nicely with modules in the future. The <code>PickleOrder</code> class could be the service interface. For inspiration consider looking at <code>ObjectFactoryServiceLoader</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-13 07:12:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2640#issuecomment-1312753545">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Instead of using the rerun formatter you may want to consider using a programmatic API to drive your entire test execution including reruns. A programmatic API allows for much more control about what to rerun and when to do so.</p>
<p>Unfortunately Cucumber doesn't have a great API. However, JUnit 5 does, and Cucumber integrates with JUnit 5. It also maps most of Cucumbers features decently well including tags.</p>
<p>You can read about it specifically in this section of the readme, though if you choose to use JUnit 5 you should read it in it's entirety.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine#rerunning-failed-scenarios">https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine#rerunning-failed-scenarios</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-14 06:52:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2640#issuecomment-1313876932">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Ah. I didn't recognize the generic Github Avatar so I forgot about some context.</p>
<p>Unfortunately <a href="https://github.com/cucumber/cucumber-jvm/issues/2637">#2637</a> does not work with JUnit 5. Where the CLI executes the pickles as a single list, JUnit 5 hierarchically works down a tree. All nodes with the same parent are ordered implicitly in the order they are discovered. Roughly speaking this means that you can only order feature files and within those only scenarios.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-15 04:37:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2640#issuecomment-1315253020">Comment</a> on issue by <a href="https://github.com/hovi">hovi</a>
<p>Thank you for all the time you took for the answer :-) I am playing with different options and exploring.<br />
I found rerun option nice because it is one more way to "log" and "reuse" when trying to be expressive for testers so the file can be useful mostly at times when something goes wrong and then is "manually" checked.<br />
For automation, doing this in the code itself seems better, currently based on <code>io.cucumber.core.cli.Main</code>, that way I have full control over plugins for each run.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-16 14:02:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2640#issuecomment-1317729330">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> For automation, doing this in the code itself seems better, currently based on io.cucumber.core.cli.Main, that way I have full control over plugins for each run.</p>
<p>The JUnit API should give you equivalent control over the plugins. Unfortunately you'll have to configure them all via a single property. So something like <code>cucumber.plugin=pretty:target/pretty.txt,html:target/cucumber.html,ect,ect,ect</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-16 08:29:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2606#issuecomment-1317302000">Comment</a> on issue by <a href="https://github.com/zgordon02">zgordon02</a>
<p><a href="https://github.com/figuedmundo">@figuedmundo</a> what was your resolution to this?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-25 00:50:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2646#issuecomment-1327170799">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>If you want to report a bug, you should include sufficient information to reproduce the problem. Currently that is impossible.</p>
<p>Please have a look at <a href="https://stackoverflow.com/help/mcve">https://stackoverflow.com/help/mcve</a> and feel free to open a new issue afterwards.</p>
<p>Note that you can fork <a href="https://github.com/cucumber/cucumber-java-skeleton">https://github.com/cucumber/cucumber-java-skeleton</a> to get a good starting point.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-25 07:52:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2647#issuecomment-1327648281">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> In the process await() creates a singleton bean and it cannot access any pageObjects that are scenario scoped.</p>
<p>That sounds plausible. The <code>CucumberTestContext</code> is also bound to a thread. So creating a bean on a different thread could result in problems.</p>
<p>How did you establish a bean is being created only once <code>objObject</code>is referenced (i.e when <code>objObject.isDisplayed()</code> is called)?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-25 08:58:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2647#issuecomment-1327713981">Comment</a> on issue by <a href="https://github.com/susnigdha1">susnigdha1</a>
<p>How did you establish a bean is being created only once objObject is referenced (i.e when objObject.isDisplayed() is called)?<br />
To answer it, in this case await() creates a singleton bean, and from within, it is trying to access objObject which is a ScenarioScope bean, as it is scenario scope the application context is having only 1 instance of the bean, considering tests are not running in parallel. My curiosity is cucumber-spring 4.8.1, we were using <a href="https://github.com/scope">@scope</a>(SCOPE<em>CUCUMBER</em>GLUE), and await() was working perfectly. So can you explain why cucumber-spring 6.x.x and above does not share state with another standard bean?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-25 09:22:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2647#issuecomment-1327732771">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> To answer it, in this case await() creates a singleton bean, and from within, it is trying to access objObject which is a ScenarioScope bean</p>
<p>But how did you establish this is in fact what happens? Can you explain what observations you made and how you reached your conclusion?</p>
<p>And were you able to see that this happened on a different thread?</p>
<p>Please bear in mind that you are trying to explain your problem to a complete stranger with a cell phone and some spare time while the food is in the oven. 😄</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-27 05:10:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2647#issuecomment-1328243919">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>To reproduce the problem use:</p>
<pre><code>public class ExampleSteps {
@Autowired
private ScenarioScopedContainer container;
@Given("some step")
public void the_user_has_posted_the_message() {
UUID s = container.getId();
Awaitility.await().until(() -&gt; {
assertEquals(s, container.getId());
return true;
});
}
}
</code></pre>
<p>The assertion will fail when used in combination with:</p>
<pre><code>@ScenarioScope
@Component
public class ScenarioScopedContainer {
private final UUID id = UUID.randomUUID();
public UUID getId() {
return id;
}
}
</code></pre>
<p>However it will pass when using <code>@Scope("cucumber-glue")</code>.</p>
<p>The difference between <code>@ScenarioScope</code> and <code>@Scope("cucumber-glue")</code> can be found in the source:</p>
<pre><code>public @interface ScenarioScope {
@AliasFor(
annotation = Scope.class)
ScopedProxyMode proxyMode() default ScopedProxyMode.TARGET_CLASS;
}
</code></pre>
<p>Because the <code>ScopedProxyMode.TARGET_CLASS</code> is used, each time a method on the <code>ScenarioScopedContainer</code> is used, a scenario scoped instance of it will be retrieved from the <code>CucumberScenarioScope</code>.</p>
<p>Combined with:</p>
<p>• <code>Awaitility.await()</code> does it's polling on a separate thread,
• <code>CucumberScenarioScope</code> depending on a threadlocal to keep track of the active scope</p>
<p>We end up attempting to create a new scope for awaitilities thread.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-27 05:29:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2647#issuecomment-1328247152">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>The motivation for using <code>ScopedProxyMode.TARGET_CLASS</code> can be found in <a href="https://github.com/cucumber/cucumber-jvm/pull/1974">#1974</a>.</p>
<p>And this is also the solution to your problem. If your scenario scoped objects are only reachable through step definition classes and are not leaked into the application context you can either use <code>@ScenarioScope(proxyMode = <a href="http://ScopedProxyMode.NO">ScopedProxyMode.NO</a>)</code> or <code>@Scope(CucumberTestContext.SCOPE_CUCUMBER_GLUE)</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-27 12:29:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2647#issuecomment-1328333412">Comment</a> on issue by <a href="https://github.com/susnigdha1">susnigdha1</a>
<p>Hi <a href="https://github.com/mpkorstanje">@mpkorstanje</a>, highly appreciate your time in analysing the problem in simple terms and recommending the solution with an example. However, there are some more challenges attached to it. Consider below given points first:</p>
<ol><li>In general, people use Maven <code>Surefire</code> plugin to run tests in parallel, using Junit4 and WebDriver. If they use Factory Design Pattern in Spring, then they need to annotate the Bean responsible for creating WebDriver with <code>@ScenarioScope</code>, to instantiate a new browser instance for the scenarios coming from different feature files for parallel run</li><li>Additionally, if they use <code>WebDriver</code> PageFactory design pattern in their PageObject classes (annotated with <code>@Component</code> and <code>@ScenarioScope</code>), and initialize the page factory using constructor, supplying the reference to the WebDriver bean created. And the web elements are declared with <code>@FindBy</code>.<br />
Now, look into the below issues:</li><li>if we change <code>@ScenarioScope</code> proxy mode as per your recommendation in no 1 (above), then Cucumber will leak thread state and parallel run using Surefire will malfunction</li><li>if we use <code>await()</code> on any <code>PageObject</code>' object from StepDefinition/PageActions class, it will still throw <code>ScopeNotActive</code> exception. Reason: The <code>PageObject</code> class is @ScenarioScoped and WebDriver PageFactory may create another thread to lazily retrieve the <code>WebElement</code>. if we change its <code>ProxyMode</code> or use the <code>@Scope(CucumberTestContext.SCOPE_CUCUMBER_GLUE)</code> then it will leak state and catastrophic result is a certainty.<br />
So, for large automation project, whose existing code uses a lot of await() and with(), migration to cucumber 6.10.2 and above going to involve huge effort in code refactoring. As, it is neither feasible, nor recommended, to create new classes with all objects that will be accessed only within <code>Await()</code>.<br />
FYI... if we create a local variable and store the proxy object into it within the same class file, and pass it within <code>Await()</code>, that also works.</li>
</ol>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-27 16:41:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2647#issuecomment-1328388601">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>It's a feature of Spring to reuse the Application context between tests. Not just for Cucumber, but also for example for JUnit. Until <a href="https://github.com/cucumber/cucumber-jvm/issues/1846#ref-pullrequest-541103690">#1846 (reference)</a> Cucumber would override some of Springs internals to prevent this. But ultimately that was the wrong choice.</p>
<p>You may want to reconsider if Spring is the right dependency injection framework for you. If you aren't testing a Spring application <code>cucumber-pico</code> or <code>cucumber-guice</code> may be more suitable. Unlike Spring, with these frameworks each scenario has it's own.</p>
<p>> if we change @ScenarioScope proxy mode as per your recommendation in no 1 (above), then Cucumber will leak thread state and parallel run using Surefire will malfunction</p>
<p>Could you provide a concrete example of this? Since these objects are only accessible through the already Scenario scoped step definitions it is not immediately apparent to me how any state would be leaked.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-30 18:17:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2647#issuecomment-1333063026">Comment</a> on issue by <a href="https://github.com/susnigdha1">susnigdha1</a>
<p>Hi, thanks a lot for your guidance and support. Sorry for delay in my response, my framework structure is almost same to this one. Differences are: cucumber version we are using is 6.10.2, and we are creating webdriver bean similarly, with @ScenarioScope. Observed one new challenge, tests stopped working in Docker Selenium but running without Docker. I am yet to deep dive on the issue. As per preliminary investigation, new webdriver session gets created as per container logs, there are no errors, but browser does not load application as all tests failing with blank screenshot. <a href="https://github.com/soraiareis/demo-spring-selenium">https://github.com/soraiareis/demo-spring-selenium</a></p>
<p><#|…></p>
<p>On Mon, 28 Nov 2022, 00:41 M.P. Korstanje, <strong><em>*</strong>@<strong></em><em></strong>.<strong></em><em></strong>> wrote: It's a feature of Spring to reuse the Application context between tests. Not just for Cucumber, but also for example for JUnit. Until <a href="https://github.com/cucumber/cucumber-jvm/issues/1846">#1846</a> (reference) <<a href="https://github.com/cucumber/cucumber-jvm/issues/1846#ref-pullrequest-541103690">#1846 (reference)</a>> Cucumber would override some of Springs internals to prevent this. But ultimately that was the wrong choice. You may want to reconsider if Spring is the right dependency injection framework for you. If you aren't testing a Spring application cucumber-pico or cucumber-guice may be more suitable. Unlike Spring, with these frameworks each scenario has it's own. if we change @ScenarioScope proxy mode as per your recommendation in no 1 (above), then Cucumber will leak thread state and parallel run using Surefire will malfunction Could you provide a concrete example of this? Since these objects are only accessible through the already Scenario scoped step definitions it is not immediately apparent to me how any state would be leaked. — Reply to this email directly, view it on GitHub <<a href="https://github.com/cucumber/cucumber-jvm/issues/2647#issuecomment-1328388601">#2647 (comment)</a>>, or unsubscribe <<a href="https://github.com/notifications/unsubscribe-auth/AFSLLM7LR2XQ7T4DYUMLJEDWKP5TTANCNFSM6AAAAAASLNDCUM">https://github.com/notifications/unsubscribe-auth/AFSLLM7LR2XQ7T4DYUMLJEDWKP5TTANCNFSM6AAAAAASLNDCUM</a>> . You are receiving this because you authored the thread.Message ID: <strong></em><em></strong>@<strong></em><em></strong>.<strong></em>*</strong>></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-27 10:41:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2648#issuecomment-1328314342">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>It is possible to execute the <code>maven-compile-plugin</code> in the <code>generate-sources</code> phase. So it should be possible to compile the source generation code before executing it.</p>
<p><a href="https://stackoverflow.com/a/43187728/3945473">https://stackoverflow.com/a/43187728/3945473</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-12 04:17:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2648#issuecomment-1346379455">Comment</a> on issue by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>Potential templating engines:</p>
<p>• <a href="https://velocity.apache.org/">Apache Velocity</a>
• <a href="https://freemarker.apache.org/">Apache FreeMarker</a>
• <a href="http://www.stringtemplate.org/">StringTemplate</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-21 01:05:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2648#issuecomment-1361038899">Comment</a> on issue by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>From quick search, FreeMarker looks to be the most popular / active, so I'll try that out.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-27 10:08:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2650#issuecomment-1328307957">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><a href="https://github.com/toepi">@toepi</a> you once contributed this implementation in <a href="https://github.com/cucumber/cucumber-jvm/pull/1616">#1616</a>. Can you confirm that there currently is no viable way to use DeltaSpike on Java 17?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-11 08:11:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2650#issuecomment-1345594180">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Decided to deprecate Delta Spike. Will be removed in v8.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-11-29 06:44:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2653#issuecomment-1330758071">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Hi! Please include sufficient information to reproduce your problem. Have a careful look at:</p>
<p>• <a href="https://stackoverflow.com/help/how-to-ask">https://stackoverflow.com/help/how-to-ask</a>
• <a href="https://stackoverflow.com/help/minimal-reproducible-example">https://stackoverflow.com/help/minimal-reproducible-example</a></p>
<p>After you've done so please open a new issue and follow the template for reporting bugs. It is prefilled into the issue form.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-05 01:34:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2035#issuecomment-1337029272">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I can confirm that all step expressions are recreated at each test scenario (for one of my project with about 400 test scenarios, expressions are recreated about 400 times). Also I understand the issue of caching with respect to the parameter type registry.</p>
<p>Thus, I tested a cached version of my proposed <code>ExpressionFactory</code> improvement <a href="https://github.com/cucumber/cucumber-expressions/issues/185">cucumber/cucumber-expressions#185</a> / <a href="https://github.com/cucumber/cucumber-expressions/pull/187">cucumber/cucumber-expressions#187</a> . This cached version takes the parameter type registry into account (i.e. <code>Map&lt;ParameterTypeRegistry, Map&lt;String, Expression&gt;&gt;</code>). I measured the duration of my ~400 test scenarios over 10 runs and got on average:</p>
<p>• without caching: 12s 851ms
• with caching: 12s 923ms</p>
<p>I can conclude that adding caching made no significant improvement. Thus, I'm not sure having such caching is the way to go to improve the performance.</p>
<p>For completeness, there is the code with caching:</p>
<pre><code>public final class ExpressionFactory {
private static final Pattern PARAMETER_PATTERN = Pattern.compile("((?:\\\\){0,2})\\{([^}]**)\\}");
private static final Map&lt;ParameterTypeRegistry, Map&lt;String, Expression&gt;&gt; expressionsByRegistry = new HashMap&lt;&gt;();
private final ParameterTypeRegistry parameterTypeRegistry;
private final Map&lt;String, Expression&gt; expressions;
public ExpressionFactory(ParameterTypeRegistry parameterTypeRegistry) {
this.parameterTypeRegistry = parameterTypeRegistry;
expressions = expressionsByRegistry.computeIfAbsent(this.parameterTypeRegistry, key -&gt; new HashMap&lt;&gt;());
}
public Expression createExpression(String expressionString) {
Expression expression = expressions.get(expressionString);
if (expression!=null) {
return expression;
}
int length = expressionString.length();
int lastCharIndex = 0;
char firstChar = 0;
char lastChar = 0;
if (length &gt; 0) {
lastCharIndex = length - 1;
firstChar = expressionString.charAt(0);
lastChar = expressionString.charAt(lastCharIndex);
}
if (firstChar == '^' || lastChar == '$') {
// java regexp =&gt; create from regexp
expression = this.createRegularExpressionWithAnchors(expressionString);
} else if (firstChar == '/' &amp;&amp; lastChar == '/') {
// script style regexp =&gt; create from regexp
expression = new RegularExpression(Pattern.compile(expressionString.substring(1, lastCharIndex)), this.parameterTypeRegistry);
} else {
// otherwise create cucumber style expression
expression = new CucumberExpression(expressionString, this.parameterTypeRegistry);
}
expressions.put(expressionString, expression);
return expression;
}
private RegularExpression createRegularExpressionWithAnchors(String expressionString) {
try {
return new RegularExpression(Pattern.compile(expressionString), this.parameterTypeRegistry);
} catch (PatternSyntaxException var3) {
if (PARAMETER_PATTERN.matcher(expressionString).find()) {
throw new CucumberExpressionException("You cannot use anchors (^ or $) in Cucumber Expressions. Please remove them from " + expressionString, var3);
} else {
throw var3;
}
}
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-05 03:25:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2035#issuecomment-1337173078">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> I can conclude that adding caching made no significant improvement. Thus, I'm not sure having such caching is the way to go to improve the performance.</p>
<p>Currently we have to have to rebuild all Cucumber expressions for each scenario because <code>cucumber-java8</code> defines step definitions at test execution time (actually, after the test has already started). This means that each scenario execution can contain a different set of cucumber expressions. If/once <code>cucumber-java8</code> is removed all we can cache expressions by language.</p>
<p>But <a href="https://github.com/cucumber/cucumber-jvm/issues/2174">#2174</a> and <a href="https://github.com/cucumber/cucumber-jvm/issues/2279">#2279</a> will take a long time.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-06 11:02:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2654#issuecomment-1339837364">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Could you sprinkle some breakpoints in the <a href="https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/mock/mockito/MockitoTestExecutionListener.java"><code>MockitoTestExecutionListener</code></a> and see what happens?</p>
<p>I would expect something goes wrong when <code>prepareTestInstance</code> is called.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-06 11:17:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2654#issuecomment-1339855823">Comment</a> on issue by <a href="https://github.com/sashokbg">sashokbg</a>
<p>Hello <a href="https://github.com/mpkorstanje">@mpkorstanje</a> , thank you for prompt response !</p>
<p>I was already debugging and it turns out the spring context gets properly populated with the mocked beans.</p>
<p>I put a breakpoint in my @BeforeAll and did inject the Spring ApplicationContext then did in evaluate mode "context.getBean(EmailChannelAdapter.class)" and it returns the mock.</p>
<p>This means that the problem is in the injection of the beans.</p>
<p>After following your advice:</p>
<p>I found out that inside the following method in the MockitoTestExecutionListenr, if I set the property REINJECT<em>DEPNDENCIES</em>ATTRIBUTES to true - then everything works fine.</p>
<pre><code>@Override
public void beforeTestMethod(TestContext testContext) throws Exception {
if (Boolean.TRUE.equals(
testContext.getAttribute(DependencyInjectionTestExecutionListener.REINJECT_DEPENDENCIES_ATTRIBUTE))) {
initMocks(testContext);
reinjectFields(testContext);
}
}
</code></pre>
<p>Any help is greatly appreciated :)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-06 11:39:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2654#issuecomment-1339912620">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Sounds like <a href="https://github.com/cucumber/cucumber-jvm/issues/2572">#2572</a>, specifically we don't invoke <code>prepareTestInstance</code>.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/51cde873cc860c33665c777ffe3bdbb06612941e/cucumber-spring/src/main/java/io/cucumber/spring/TestContextAdaptor.java#L52-L58">cucumber-jvm/cucumber-spring/src/main/java/io/cucumber/spring/TestContextAdaptor.java</a></p>
<p>Lines 52 to 58 in </cucumber/cucumber-jvm/commit/51cde873cc860c33665c777ffe3bdbb06612941e|51cde87></p>
<p>As you can see we create a test instance by pulling it from the application context. This ensures the test instance is a bean that can be injected into other step definition class instances and others can be injected into it.</p>
<p>JUnit doesn't have this requirement (only one test class ever). So JUnit creates the test instance using the zero-arg constructor and outside of the application context. By invoking <code>prepareTestInstance</code> JUnit then auto wires the spring and mock beans.</p>
<p>I have no idea what would happen if we do call <code>prepareTestInstance</code> on a bean.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-06 12:34:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2654#issuecomment-1339974159">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>This may provide a solution with <code>AUTOWIRE_NO</code>. The fields van then be auto wired with <code>prepareTestInstance</code>.</p>
<p><a href="https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/beans/factory/config/AutowireCapableBeanFactory.html#initializeBean(java.lang.Object,java.lang.String)|https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/beans/factory/config/AutowireCapableBeanFactory.html#initializeBean(java.lang.Object,java.lang.String)">https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/beans/factory/config/AutowireCapableBeanFactory.html#initializeBean(java.lang.Object,java.lang.String)|https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/beans/factory/config/AutowireCapableBeanFactory.html#initializeBean(java.lang.Object,java.lang.String)</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-07 00:52:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2654#issuecomment-1340602688">Comment</a> on issue by <a href="https://github.com/sashokbg">sashokbg</a>
<p>Hello <a href="https://github.com/mpkorstanje">@mpkorstanje</a> and thank you for your help.</p>
<p>Unfortunately I don't really understand how to properly configure the AutowireCapableBeanFactory for cucumber context :( - do you have any examples of how it is done ? I tried searching on the internet but results are sparse.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-07 01:11:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2654#issuecomment-1340624527">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>If you want to, you'd have to fix it in the <code>[TestContextAdaptor.java](<https://github.com/cucumber/cucumber-jvm/blob/51cde873cc860c33665c777ffe3bdbb06612941e/cucumber-spring/src/main/java/io/cucumber/spring/TestContextAdaptor.java#L52-L58>)</code> and send a pull request.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-07 05:47:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2654#issuecomment-1340993785">Comment</a> on issue by <a href="https://github.com/sashokbg">sashokbg</a>
<p>I will try to do that tonight after work hours - being busy at the moment.<br />
Thank you</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-07 08:50:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2654#issuecomment-1341266518">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers. No rush though.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 01:49:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2654#issuecomment-1342395126">Comment</a> on issue by <a href="https://github.com/sashokbg">sashokbg</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> <a href="https://github.com/cucumber/cucumber-jvm/pull/2655">#2655</a> opened. I mentioned you in the second commit message since you solved the issue :)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 04:01:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2655#issuecomment-1342621840">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2655?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2655?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2655?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2655">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2655?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2655</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/36e0ef01ba51b2021dd636682939fe92e8711bfd">36e0ef0</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/9de55cfaed319d8e575df5f0f504024a72c63549?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/9de55cfaed319d8e575df5f0f504024a72c63549?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/9de55cfaed319d8e575df5f0f504024a72c63549">9de55cf</a>) will <strong>increase</strong> coverage by <code>0.00%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2655 +/- ##
=========================================
Coverage 84.77% 84.77%
Complexity 2686 2686
=========================================
Files 322 322
Lines 9532 9533 +1
Branches 903 903
=========================================
+ Hits 8081 8082 +1
Misses 1120 1120
Partials 331 331
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 06:44:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2655#discussion_r1043434970">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Note to self: <code>delegateTestInstance</code> is used as an implicit condition to determine if <code>beforeTestMethod</code> has fired. Consider separating creation+preparation from assignment.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 14:42:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2655#issuecomment-1343468059">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Thanks for the PR! I was hoping to get it released today. But while this is part of the solution, I did some research and unless all methods of the test context manager are invoked issues like this will keep popping up.</p>
<p>Now I do know how to invoke those properly, but it will take a bit of time. And will need some proper tests written for it. So I'm afraid you'll have to use the double <code>@Autowired</code> and <code>@MockBean</code> annotation for a while.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 05:32:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2656#issuecomment-1342743632">Comment</a> on issue by <a href="https://github.com/sashokbg">sashokbg</a>
<p>Hello, <a href="https://github.com/MrGung">@MrGung</a>, are you using junit 5 ? It might be related to <a href="https://github.com/cucumber/cucumber-jvm/issues/2654">#2654</a>.<br />
It seems fields annotated with @MockBean and @SpyBean annotations are not injected. There is a PR opened that addresses this issue, could you please check it out and try to see if it fixes your problem ?</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/pull/2655">#2655</a></p>
<p>To test it checkout my branch, do</p>
<pre><code> mvn clean install -pl :cucumber_spring,:cucumber-bom -am"
</code></pre>
<p>and then in your pom.xml</p>
<pre><code> &lt;dependency&gt;
&lt;groupId&gt;io.cucumber&lt;/groupId&gt;
&lt;artifactId&gt;cucumber-spring&lt;/artifactId&gt;
&lt;version&gt;7.10.0-SNAPSHOT&lt;/version&gt;
&lt;/dependency&gt;
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 05:36:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2656#issuecomment-1342749070">Comment</a> on issue by <a href="https://github.com/sashokbg">sashokbg</a>
<p>As a temporary solution what you can do is just use plain old spring and create a produced method that returns a Mockito.spy() or Mockito.mock() instance.</p>
<p>... In your test spring config</p>
<pre><code>@Bean
public MyClass mySpy() {
return Mockito.spy(new mySpy())
}
</code></pre>
<p>... In your test class</p>
<p><code>@Autowired // &lt;-- not that we use classic spring and no mockito annotations</code><br />
MyClass mySpy;</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 05:54:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2656#issuecomment-1342773361">Comment</a> on issue by <a href="https://github.com/MrGung">MrGung</a>
<p>Since we are using <code>@SpyBean</code> successfully on several other dependencies - it does not seem to be a general problem. I do remember we switched from <code>MockBean</code> to <code>SpyBean</code> because they wouldn't get mocked several weeks ago, though.</p>
<p>I will try 7.10.0-SNAPSHOT and report back.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 06:00:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2656#issuecomment-1342781478">Comment</a> on issue by <a href="https://github.com/MrGung">MrGung</a>
<p>Seems I cannot access the snapshot (corporate firewall). I'll try the workaround.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 06:55:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2656#issuecomment-1342857576">Comment</a> on issue by <a href="https://github.com/MrGung">MrGung</a>
<p>I cannot get this to work - it seems there is a problem in our TestConfiguration when overwriting Beans.</p>
<p>Thanks for the quick feedback, though!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-08 07:15:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2656#issuecomment-1342886444">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>We don't publish snapshots. You will have to build locally.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-09 00:51:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2657#issuecomment-1344021595">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-09 00:57:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2657#issuecomment-1344027043">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2657?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2657?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2657?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2657">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2657?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2657</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/d8009c53d3519e3a5fe7c0c38dbc03816cd5a80b">d8009c5</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/2e7e243863f0bebd042cefbaf5d48cc0ee1dbff0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/2e7e243863f0bebd042cefbaf5d48cc0ee1dbff0?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/2e7e243863f0bebd042cefbaf5d48cc0ee1dbff0">2e7e243</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2657 +/- ##
=========================================
Coverage 84.77% 84.77%
Complexity 2686 2686
=========================================
Files 322 322
Lines 9532 9532
Branches 903 903
=========================================
Hits 8081 8081
Misses 1120 1120
Partials 331 331
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-11 07:49:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2657#issuecomment-1345588450">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.<br />
You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-09 04:35:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2659#issuecomment-1344254295">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2659?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2659?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2659?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2659">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2659?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2659</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/46d61c0ef35e1f0cc416a79bff6999392148792d">46d61c0</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/b5cf913eee20a8b3ab677e6e8ccb6116c5a3e157?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/b5cf913eee20a8b3ab677e6e8ccb6116c5a3e157?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b5cf913eee20a8b3ab677e6e8ccb6116c5a3e157">b5cf913</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2659 +/- ##
=========================================
Coverage 84.77% 84.77%
Complexity 2686 2686
=========================================
Files 322 322
Lines 9532 9532
Branches 903 903
=========================================
Hits 8081 8081
Misses 1120 1120
Partials 331 331
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-09 04:47:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2660#issuecomment-1344269730">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2660?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2660?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2660?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2660">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2660?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2660</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/e5acdfd2935800f641a7d6ab5050fb35886b3845">e5acdfd</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/b5cf913eee20a8b3ab677e6e8ccb6116c5a3e157?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/b5cf913eee20a8b3ab677e6e8ccb6116c5a3e157?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b5cf913eee20a8b3ab677e6e8ccb6116c5a3e157">b5cf913</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2660 +/- ##
=========================================
Coverage 84.77% 84.77%
Complexity 2686 2686
=========================================
Files 322 322
Lines 9532 9532
Branches 903 903
=========================================
Hits 8081 8081
Misses 1120 1120
Partials 331 331
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-09 06:11:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2660#discussion_r1044491287">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Typo ;)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-09 06:12:55
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/mlvandijk">mlvandijk's</a> pull request
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-09 08:24:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2660#discussion_r1044618985">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Suggested change</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-12 02:26:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2660#discussion_r1045646615">Comment</a> on pull request by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>Doh!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-11 08:00:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2639#issuecomment-1345590893">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Mmh. What about running <code>mvn install</code>?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-12 10:04:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2639#issuecomment-1346968852">Comment</a> on pull request by <a href="https://github.com/hovi">hovi</a>
<p>• Fails on missing <code>cucumber-bom</code> snapshot.
• When I first <code>mvn install</code> that project manually, everything passes.
• When I run <code>nvm spotless:apply</code> after, I get the error again.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-14 19:14:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2662#issuecomment-1352503633">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-14 19:22:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2662#issuecomment-1352507274">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2662?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2662">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2662?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2662</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/e3a47e68625189615e3a783e1dfbe6c50e0974a4">e3a47e6</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/07bf5de87ff4b5a130c88ab1d2d3d3947529bdcf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/07bf5de87ff4b5a130c88ab1d2d3d3947529bdcf?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/07bf5de87ff4b5a130c88ab1d2d3d3947529bdcf">07bf5de</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2662 +/- ##
=========================================
Coverage 84.81% 84.81%
Complexity 2693 2693
=========================================
Files 322 322
Lines 9570 9570
Branches 905 905
=========================================
Hits 8117 8117
Misses 1121 1121
Partials 332 332
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-16 05:45:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2663#issuecomment-1354802605">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers! Fixed in 7.10.1</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-17 04:25:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2663#issuecomment-1356234903">Comment</a> on issue by <a href="https://github.com/rotilho">rotilho</a>
<p>Ultra fast fix. Thanks!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-16 05:40:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2664#issuecomment-1354789690">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2664?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2664?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2664?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2664">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2664?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2664</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/13f319f36c3942c8d70d09a400aa0ab43296b9d3">13f319f</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/fe2d66707031806511052129021f505ed60edb3a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/fe2d66707031806511052129021f505ed60edb3a?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/fe2d66707031806511052129021f505ed60edb3a">fe2d667</a>) will <strong>increase</strong> coverage by <code>0.00%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<p>> ❗ Current head <a href="https://github.com/cucumber/cucumber-jvm/commit/13f319f36c3942c8d70d09a400aa0ab43296b9d3">13f319f</a> differs from pull request most recent head <a href="https://github.com/cucumber/cucumber-jvm/commit/1a55e418b032c2b33f4ddbbb976d4211501d6baa">1a55e41</a>. Consider uploading reports for the commit <a href="https://github.com/cucumber/cucumber-jvm/commit/1a55e418b032c2b33f4ddbbb976d4211501d6baa">1a55e41</a> to get more accurate results</p>
<pre><code>@@ Coverage Diff @@
## main #2664 +/- ##
=========================================
Coverage 84.81% 84.82%
Complexity 2693 2693
=========================================
Files 322 322
Lines 9570 9573 +3
Branches 905 905
=========================================
+ Hits 8117 8120 +3
Misses 1121 1121
Partials 332 332
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-17 11:19:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2665#issuecomment-1356402401">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2665?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2665?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2665">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2665?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2665</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/cea8f64132eeab2787c49403c84c1461856f4dff">cea8f64</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/9b629429adf0570d1fb7b64ce7c546f1be0bac74?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/9b629429adf0570d1fb7b64ce7c546f1be0bac74?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/9b629429adf0570d1fb7b64ce7c546f1be0bac74">9b62942</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2665 +/- ##
=========================================
Coverage 84.82% 84.82%
Complexity 2693 2693
=========================================
Files 322 322
Lines 9573 9573
Branches 905 905
=========================================
Hits 8120 8120
Misses 1121 1121
Partials 332 332
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-17 11:11:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2642#issuecomment-1356394056">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.<br />
You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-17 11:32:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2642#issuecomment-1356404843">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2642?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2642?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2642">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2642?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2642</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/5374a3297c05a41e0006aa0f398143bfebcfb86a">5374a32</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/5dd6686219dca9d7b209298b3dbb039ceb1f0c21?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/5dd6686219dca9d7b209298b3dbb039ceb1f0c21?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/5dd6686219dca9d7b209298b3dbb039ceb1f0c21">5dd6686</a>) will <strong>increase</strong> coverage by <code>0.00%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<p>> ❗ Current head <a href="https://github.com/cucumber/cucumber-jvm/commit/5374a3297c05a41e0006aa0f398143bfebcfb86a">5374a32</a> differs from pull request most recent head <a href="https://github.com/cucumber/cucumber-jvm/commit/2b1028005ae298e5bec920c6a359fbf2ff072193">2b10280</a>. Consider uploading reports for the commit <a href="https://github.com/cucumber/cucumber-jvm/commit/2b1028005ae298e5bec920c6a359fbf2ff072193">2b10280</a> to get more accurate results</p>
<pre><code>@@ Coverage Diff @@
## main #2642 +/- ##
=========================================
Coverage 84.82% 84.82%
- Complexity 2693 2695 +2
=========================================
Files 322 322
Lines 9573 9576 +3
Branches 905 907 +2
=========================================
+ Hits 8120 8123 +3
Misses 1121 1121
Partials 332 332
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-20 07:57:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2666#issuecomment-1359607628">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Very interesting. I would be happy to accept option 6.</p>
<p>That said, I'm going to have to find some broader consensus on the use ChatGTP. It has been known to reproduce it's training data more or less verbatim.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-20 13:57:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2666#issuecomment-1360374533">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> : I'll do a PR with option 6.</p>
<p>Regarding ChatGPT, you may be interested by the transcript of option 3 (I finally did not include the last solution proposed by ChatGPT because it was becoming unreadable code) :<br />
<a href="https://github.com/cucumber/cucumber-jvm/files/10272895/ChatGPT.optimizes.TestAbortedExceptions.pdf">ChatGPT optimizes TestAbortedExceptions.pdf</a> (my inputs are in bold text and the ChatGPT output are in unformatted text).<br />
I would certainly not use ChatGPT output blindly, but I must admit that the quality is pretty good. And human developers also reproduce data structures and algorithms that are familiar to them 😉</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-13 07:30:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2666#issuecomment-1382020657">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>On my project with ~400 scenarios, the cucumber tests execution duration is on average 20.5 seconds instead of 24.3 seconds (that's a 16% improvement).</p>
<p><a href="https://github.com/fslev">@fslev</a> : could you please test cucumber <code>7.11.0</code> (which includes this patch) on your suite of ~1000 scenarios in dry-run mode ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-22 02:27:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2667#discussion_r1055315775">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Would a for loop be faster?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-22 03:44:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2667#issuecomment-1362741355">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>If you run <code>mvn clean install</code> it will run all tests and fix the formatting.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-22 07:24:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2667#issuecomment-1362969859">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2667?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2667?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2667">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2667?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2667</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/9900d2d1c8d018eff9a03a4baefa78acc008a88b">9900d2d</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/e32379e0158285509e8204eca751e7d23645d22c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/e32379e0158285509e8204eca751e7d23645d22c?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/e32379e0158285509e8204eca751e7d23645d22c">e32379e</a>) will <strong>decrease</strong> coverage by <code>0.00%</code>.<br />
> The diff coverage is <code>80.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2667 +/- ##
============================================
- Coverage 84.82% 84.82% -0.01%
+ Complexity 2695 2694 -1
============================================
Files 322 322
Lines 9576 9574 -2
Branches 907 907
============================================
- Hits 8123 8121 -2
Misses 1121 1121
Partials 332 332
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-22 12:54:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2667#discussion_r1055841635">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I benchmarked the following code:</p>
<pre><code>static Predicate&lt;Throwable&gt; createIsTestAbortedExceptionPredicate7() {
ClassLoader defaultClassLoader = ClassLoaders.getDefaultClassLoader();
return throwable -&gt; {
for (String s : TEST_ABORTED_EXCEPTIONS) {
try {
Class&lt;?&gt; aClass = defaultClassLoader.loadClass(s);
if (aClass.isInstance(throwable)) {
return true;
}
} catch (Throwable t) {
rethrowIfUnrecoverable(t);
log.debug(t,
() -&gt; String.format(
"Failed to load class %s: will not be supported for aborted executions.", s));
}
}
return false;
};
}
</code></pre>
<p>The JMH benchmark says the variant 7 (the one with a loop) is slightly slower than the proposed version (variant 6), but not significantly :</p>
<pre><code>Benchmark Mode Cnt Score Error Units
TestAbortedExceptionsBenchmark.createIsTestAbortedExceptionPredicate5 thrpt 25 264824252,996 ± 4775342,657 ops/s
TestAbortedExceptionsBenchmark.createIsTestAbortedExceptionPredicate6 thrpt 25 259886661,320 ± 1766902,768 ops/s
TestAbortedExceptionsBenchmark.createIsTestAbortedExceptionPredicate7 thrpt 25 254627500,665 ± 12269987,245 ops/s
</code></pre>
<p>I think the code readability is better with the Stream+anyMatch than with the loop, so I would prefer to keep the proposed version..</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-22 12:58:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2667#discussion_r1055843890">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Suggested change</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-22 12:59:43
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2667#issuecomment-1363334622">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/jkronegg">@jkronegg</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-22 12:59:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2667#issuecomment-1363334796">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-24 01:49:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#issuecomment-1364500241">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2669?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2669?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2669?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2669">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2669?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2669</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/5b52815063f9a8535d4a47b63de181f674acc989">5b52815</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/f53abb64dd9b3990c34d09514f3bba3112e34bd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/f53abb64dd9b3990c34d09514f3bba3112e34bd5?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/f53abb64dd9b3990c34d09514f3bba3112e34bd5">f53abb6</a>) will <strong>decrease</strong> coverage by <code>0.88%</code>.<br />
> The diff coverage is <code>0.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2669 +/- ##
============================================
- Coverage 84.82% 83.93% -0.89%
Complexity 2694 2694
============================================
Files 322 324 +2
Lines 9574 9675 +101
Branches 907 912 +5
============================================
Hits 8121 8121
- Misses 1121 1222 +101
Partials 332 332
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-27 12:02:09
*Thread Reply:*
Review comment by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/mlvandijk">mlvandijk's</a> pull request
<p>Nice! But it didn't work on my machine because of relative paths. I guess. I've pushed some fixes for that to the <code>cucumber-java</code> part.</p>
<p>Also put the code gen code into <code>src/codegen/java</code> instead. This is then compiled to <code>target/codegen-classes</code> to avoid packaging the code gen code in the jar build with <code>mvn package</code>.</p>
<p>For now lets polish <code>cucumber-java</code> that before we copy it over to <code>cucumber-java8</code>. It would be good to keep in mind that this will be copied over. You can do this by extracting all the configuration constants to the top of the file and/or program arguments.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-27 12:02:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1057885319">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>The block of code this catch is in is pretty long. The try-catch doesn't help. Consider replacing the <code>.forEach</code> which a regular throw so exceptions don't need to be caught and rethrown. Or consider moving the try catch into <code>createInterfaces</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-27 12:02:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1057885595">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>This comment smells like a method name.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-27 12:02:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1057886358">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Consider wrapping this setup code in a method along with <code>createInterfaces</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-27 12:02:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1057867093">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>In <code>dependencyManagement</code>?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-27 12:02:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1057884144">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>The <code>target/generated-sources/i18n/java/</code> part is duplicated here and in the pom. Consider extracting it to an program argument. This can then be provided to the exec maven plugin.</p>
<pre><code> &lt;configuration&gt;
...
&lt;arguments&gt;
&lt;argument&gt;${project.build.directory}/generated-sources/i18n/java&lt;/argument&gt;
&lt;/arguments&gt;
&lt;/configuration&gt;
</code></pre>
<p>This also means that <code>${project.build.directory}/generated-sources/i18n/java</code> becomes duplicated which you could extract to a property.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-27 12:17:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1057894443">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>This fixes the relative path problems. But it's a bit messy.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-27 12:18:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1057895299">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>These lines are all java <code>nio</code>. It's a much nicer interface to use then <code>new File()</code>. Might be good to read a bit more about.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-27 12:23:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1057897150">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I've just had to do part of this because of the relative path problem.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-03 01:15:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1060391504">Comment</a> on pull request by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>Fair. I copied the comment from the original script, but you're right. No reason to add improvements.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-03 01:40:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2669#discussion_r1060411115">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Groovy was a bit more compact. Then it matters less if the quality is good. 😆</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2022-12-31 02:01:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2512#issuecomment-1368194178">Comment</a> on issue by <a href="https://github.com/fslev">fslev</a>
<p>Also, a new Junit version (5.10.0) will soon be available, which uses saturated thread pool by default:<br />
<a href="https://junit.org/junit5/docs/snapshot/release-notes/#deprecations-and-breaking-changes-2">https://junit.org/junit5/docs/snapshot/release-notes/#deprecations-and-breaking-changes-2</a><br />
Hence, no need for a custom parallel execution configuration strategy anymore, in this case.<br />
Thus, the<br />
cucumber.execution.parallel.config.strategy=fixed should work as expected.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-02 15:36:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2670#issuecomment-1369272071">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2670?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2670?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2670?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2670">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2670?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2670</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b4bd00b1895086e04d93d101758abcce8f18e72b">b4bd00b</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/734fdf223e211769fa07a7dbb4a556e7b864d548?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/734fdf223e211769fa07a7dbb4a556e7b864d548?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/734fdf223e211769fa07a7dbb4a556e7b864d548">734fdf2</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2670 +/- ##
=========================================
Coverage 84.68% 84.68%
Complexity 2680 2680
=========================================
Files 322 322
Lines 9444 9444
Branches 899 899
=========================================
Hits 7998 7998
Misses 1120 1120
Partials 326 326
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-03 11:28:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2670#issuecomment-1370145486">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.<br />
You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-05 18:21:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2672#issuecomment-1373056325">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>On behalve of everyone who's contributed to this I'd like thank you for your praise. Personally I'm happy to see that you've been able to achieve such a significant performance improvement. I'm glad you've found it useful.</p>
<p>As for your issue.</p>
<p>Unfortunately the way Surefire implements <code>rerunFailingTestsCount</code> is by starting a new execution of Cucumber, just for those failed tests. Currently Cucumber can't tell the difference and will happily overwrite any files it created in the first run, with the files from the second run.</p>
<p>Once JUnit 5 provides the ability for a test engine to store information in a session that spans both executions (i.e. <a href="https://github.com/junit-team/junit5/issues/2816">junit-team/junit5#2816</a>) it should in theory be possible to write the report only once with the reruns included.</p>
<p>> As a comparison, we're also using the excellent tool <code>maven-cucumber-reporting</code> by damianszczepanik and it seems to support the failsafe property just fine as you can see below :)</p>
<p>So this is quite puzzling. From what I understand, the plugin reads the json files produced by Cucumber. Those should have been overwritten. Perhaps there is a more subtle bug going on? From memory, the plugin merges multiple report files. Could it be possible that you are looking at json files produces by previous tests or different tests?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-05 18:43:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2672#issuecomment-1373070409">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>And a few notes for the future:</p>
<ol><li>Surefire currently closes <a href="https://github.com/apache/maven-surefire/blob/surefire-3.0.0-M7/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java#L171-L208">the launcher and launcher session</a> for the initial attempt and every rerun. This means that even if JUnit 5 were to support sessions for test engines, Cucumber would not be aware of them. As Maven plugins tend to release and develop at a glacial speed, I would not expect it to be possible to report on reran scenarios 1-2 years until after JUnit implements support for it.</li><li><p>The core of Cucumber JVM currently does not support retrying tests. There is no good default strategy for retrying or rerunning tests, nor is there sensible way to report on those retried test. I'm loathe to deal with the fractal of complexity that comes with implementing one or more specific implementation of a rerun strategy</p>
<p>So while I'm happy to help make it possible to run the same scenario multiple times, I'd rather support this at a programmatic level only.</p></li><li>Cucumber JS currently supports rerunning, so the html report and the messages used to create the report should too.</li>
</ol>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-06 07:01:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2674#issuecomment-1373742277">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2674?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2674?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2674?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2674">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2674?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2674</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b632b7794f56b53b95c0e412ccc3dae73a66994b">b632b77</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/a288ad2259db8c27095ee518f367841b04dcc80f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/a288ad2259db8c27095ee518f367841b04dcc80f?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/a288ad2259db8c27095ee518f367841b04dcc80f">a288ad2</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2674 +/- ##
=========================================
Coverage 84.68% 84.68%
Complexity 2680 2680
=========================================
Files 322 322
Lines 9444 9444
Branches 899 899
=========================================
Hits 7998 7998
Misses 1120 1120
Partials 326 326
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-06 06:58:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2650#issuecomment-1373738885">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Looks like it can be made to work. It was mostly the tests that needed updating.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-11 09:21:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2677#issuecomment-1379223395">Comment</a> on issue by <a href="https://github.com/fslev">fslev</a>
<p>Since 5.9.2</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-11 06:32:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2678#issuecomment-1378841546">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Ah thanks! But unfortunately this is not a copy paste mistake.</p>
<p>Cucumber JVM has a bit of a history. It started out as port of Cucumber Ruby and existed only as a command line interface. This CLI could be invoked as:</p>
<pre><code>cucumber my.feature --plugin rerun:rerun.txt
cucumber @rerun.txt
</code></pre>
<p>Though in the Java landscape a CLI is rather cumbersome people prefer to use Maven and JUnit. This was made possible through a single system property <code>cucumber.options</code> that mimicked the command line.</p>
<pre><code>mvn test -Dcucumber.options="my.feature --plugin rerun:rerun.txt"
mvn test -Dcucumber.options="@rerun.txt"
</code></pre>
<p>But this was quite hacky and had lots of problems. So the individual arguments were given their own properties. E.g. <code>cucumber.features</code> and <code>cucumber.plugin</code>. Because the rerun file and feature takes the same place in the CLI they were both mapped to the <code>cucumber.features</code> property.</p>
<pre><code>mvn test -Dcucumber.feature="my.feature" -Dcucumber.plugin="rerun:rerun.txt"
mvn test -Dcucumber.feature="@rerun.txt"
</code></pre>
<p>So this probably worth a code comment or two. 😄</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-11 06:36:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2678#issuecomment-1378847425">Comment</a> on issue by <a href="https://github.com/rubienr">rubienr</a>
<p>Thank you for the quick clarification.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-11 11:39:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2678#issuecomment-1379390534">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I'll leave this open as a reminder to a comment.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-11 06:47:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2679#issuecomment-1378862716">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Non strict execution caused a lot of friction with other tooling (for example see <a href="https://github.com/cucumber/cucumber-junit-xml-formatter#test-outcome-mapping">cucumber-junit-xml-formatter#test-outcome-mapping</a>) so we are in the process of deprecating and removing it from all Cucumber implementations. Cucumber JVM has already gone through this cycle. You can read more about the rationale in <a href="https://github.com/cucumber/cucumber-jvm/issues/1788">#1788</a> and <a href="https://github.com/cucumber/common/issues/714">cucumber/common#714</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-12 01:30:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2679#issuecomment-1380041455">Comment</a> on issue by <a href="https://github.com/rubienr">rubienr</a>
<p>Is it possible to somehow mimic this behaviour without <code>--strict</code> (and without tag filtering)? I also don't understand the difference in-between 'undefined' and 'pending' in the table at <a href="https://github.com/cucumber/common/issues/714">cucumber/common/issues/714</a>.</p>
<p>The procedure I tried is:</p>
<ol><li>write a step <code>WHEN this step is not implemented</code>, leave it undefined</li><li>run Cucumber in <code>sbt</code>: <code>sbt:root&gt; cucumber</code></li><li>copy paste the snippet from the test result message:
<pre><code>When("""this step is not implemented""") { () =&gt;
// Write code here that turns the phrase above into concrete actions
throw new io.cucumber.scala.PendingException()
}
</code></pre></li><li>re-run Cucumber in <code>sbt</code></li><li>i still see it failing
<pre><code>[error] stack trace is suppressed; run last &lt;module-name&gt; / cucumber for the full output
[error] (&lt;module-name&gt; / cucumber) java.lang.IllegalStateException: Cucumber did not succeed and returned error =1
[error] Total time: 1 s, completed Jan 12, 2023, 10:13:03 AM
</code></pre></li><li>and the respective step in the HTML-test report is red</li>
</ol>
<p>I would want</p>
<p>• the undefined step to be yellow in the report (not red) and
• to be able to distinguish in <code>sbt</code> (for example return code from cucumber)
• a) if the test run failed
• b) or all were passed, except some were not implemented.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-12 06:14:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2679#issuecomment-1380417361">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> Is it possible to somehow mimic this behaviour without --strict (and without tag filtering)?</p>
<p>No. The CLI will exit with a non-zero code for any scenarios that have steps that aren't passed or skipped. If we don't follow this pattern we make it more difficult for the ecosystem that process reports.</p>
<p>> the undefined step to be yellow in the report (not red)</p>
<p>I think that would be sensible. I would expect each status to have a somewhat distinct color. They're defined in:</p>
<p><a href="https://github.com/cucumber/react-components/blob/main/src/components/app/StatusesSummary.module.scss">https://github.com/cucumber/react-components/blob/main/src/components/app/StatusesSummary.module.scss</a></p>
<p>Perhaps you can send a pull request, my react skills are practicality non-existent.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-13 01:08:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2679#issuecomment-1381511841">Comment</a> on issue by <a href="https://github.com/rubienr">rubienr</a>
<p>> No. The CLI will exit with a non-zero code for any scenarios that have steps that aren't passed or skipped. If we don't follow this pattern we make it more difficult for the ecosystem that process reports.</p>
<p>I see.</p>
<p>> I think that would be sensible. I would expect each status to have a somewhat distinct color. They're defined in:
>
> <a href="https://github.com/cucumber/react-components/blob/main/src/components/app/StatusesSummary.module.scss">https://github.com/cucumber/react-components/blob/main/src/components/app/StatusesSummary.module.scss</a>
>
> Perhaps you can send a pull request, my react skills are practicality non-existent.</p>
<p>Well the predefined colors seem fine. I would probably change the leading symbol from red-X to organge-X. Unfortunately I have absolutely no react skills.</p>
<p>I think we can close this issue, since the most important part for me would have been to not fail if steps are not implemented. I understand the decision and the reasoning to deprecate 'strict'.</p>
<p>Thank you very much for the fast replies and quick clarification.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-11 19:50:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2680#issuecomment-1379776385">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-12 07:53:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2680#issuecomment-1380601980">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.<br />
You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-12 08:28:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2680#issuecomment-1380683473">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2680?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2680?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2680?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2680">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2680?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2680</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/af076b33e1a8fd8e9488272c7cedf620c142f9a3">af076b3</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/bf1fa8f0c25eb1f5e8330197d0d4b282bf146db3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/bf1fa8f0c25eb1f5e8330197d0d4b282bf146db3?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/bf1fa8f0c25eb1f5e8330197d0d4b282bf146db3">bf1fa8f</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2680 +/- ##
=========================================
Coverage 84.67% 84.67%
Complexity 2679 2679
=========================================
Files 322 322
Lines 9444 9444
Branches 899 899
=========================================
Hits 7997 7997
Misses 1120 1120
Partials 327 327
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-13 05:53:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2682#issuecomment-1381887321">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>With the information you've provided it is impossible to reproduce your problem. Please have a look at <a href="https://stackoverflow.com/help/minimal-reproducible-example">How to create a Minimal, Reproducible Example</a> for guidance.</p>
<p>It may also help if you van pinpoint exactly which version included the breaking change.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-15 03:14:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2682#issuecomment-1383122751">Comment</a> on issue by <a href="https://github.com/MadhuQAAutomation">MadhuQAAutomation</a>
<p>Hi - I checked the versions from 7.3.4 till 7.8.0 and it was working fine. Error is getting displayed for version 7.9.0.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/files/10420001/qa-test-automation.zip">qa-test-automation.zip</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-15 04:26:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2682#issuecomment-1383138206">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I'm disappointed to see that you've not followed the guidance on creating a minimal example. Your reproducer is anything but minimal. If you can not provide a minimal example it is impossible to help you. The <a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber-java-skeleton</a> would be a good starting point should you need it.</p>
<p>I also see that you are using <a href="https://github.com/prashant-ramcharan/courgette-jvm">Courgette-JVM</a> to run your tests rather than Cucumber-JVM. If your problem can not be reproduced without this dependency you should create an issue there instead.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-16 00:36:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2682#issuecomment-1383667904">Comment</a> on issue by <a href="https://github.com/MadhuQAAutomation">MadhuQAAutomation</a>
<p>Ok.. Thank you!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-27 03:46:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2683#issuecomment-1406386787">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>We invoke <code>bus.send</code> with both <code>TestCaseEvents</code> and <code>Envelope</code> messages.</p>
<pre><code>ArgumentCaptor&lt;TestCaseEvent&gt; captor = forClass(TestCaseEvent.class);
verify(bus, times(2)).send(captor.capture());
</code></pre>
<p>Depending on the JVM it appears that the captor will either capture both <code>Envelope</code> and <code>TestCaseEvents</code> or only <code>TestCaseEvents</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-27 03:48:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2683#issuecomment-1406389280">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Looks like it's IDEA's compiler that somehow doesn't cause complaints.</p>
<p>Still an interesting change from Mockito 4 to 5.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-15 04:56:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2684#issuecomment-1383144577">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Actually kinda hard with the current design.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-15 04:56:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2685#issuecomment-1383144661">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<https://github.com/cucumber/cucumber-jvm/pull/2685|#2685 [Core] Warn when cucumber.options is used>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2685?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2685?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2685?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2685">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2685?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2685</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/86c22904b7b2561c3aaee0b5cc12039a141bcf9e">86c2290</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/35c71f0310c95cb44d7537f03a066077cefd2254?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/35c71f0310c95cb44d7537f03a066077cefd2254?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/35c71f0310c95cb44d7537f03a066077cefd2254">35c71f0</a>) will <strong>increase</strong> coverage by <code>0.00%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2685 +/- ##
=========================================
Coverage 84.67% 84.68%
- Complexity 2679 2680 +1
=========================================
Files 322 322
Lines 9444 9450 +6
Branches 899 899
=========================================
+ Hits 7997 8003 +6
Misses 1120 1120
Partials 327 327
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-23 21:32:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2593#issuecomment-1401417891">Comment</a> on issue by <a href="https://github.com/nicksav">nicksav</a>
<p>So what to do here? How to change name of the test method?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-24 00:48:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2593#issuecomment-1401564993">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Without changing TestNG there isn't much that can be done.</p>
<p>Though none of the existing options are great. They all lose some fidelity. Using JUnit 5 with the Cucumber JUnit Platform Engine potentially has the best report names. But only if used directly with the Console Launcher.</p>
<p>So if you must use TestNG you may have to look into contributing a fix to that project and/or the reporters involved.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-25 03:59:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/1805#issuecomment-1403498737">Comment</a> on issue by <a href="https://github.com/class101">class101</a>
<p>some motivation guys, asking for a dissertation on a use case of a request is, admittedly legitimate, but has been going on for months so this request has received over 15 votes, should be an indication of ill will and that something is missing that should have been implemented, there is really no need for a dissertation for that and I find the patience of the participants impressive there. Respect guys.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-27 02:10:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2686#issuecomment-1406288340">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>In brief, the problem is that invoking <code>new TestContextManager(someContextConfiguration)</code> for identical instances of <code>someContextConfiguration</code> is not actually thread-safe. Spring caches the configuration derived from <code>someContextConfiguration</code> and when AOT is used, will fail to apply idempotent updates configuration .</p>
<p>It's not quite clear to me why <code>-Dgroups=DEBUG</code> is essential to reproducing the problem.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-26 11:05:22
*Thread Reply:*
Review comment by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/ntthaibk">ntthaibk's</a> pull request
<p>Looks pretty decent. If you build a SNAPSHOT (mvn clean install -DskipTests) and use that in your reproducer, does the problem go away?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-26 11:14:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2687#discussion_r1088243336">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Assuming the race condition is caused by the concurrent creation of <code>TestContextManager</code>s some of these changes could be avoided by using a supplier. I.e:</p>
<pre><code>new TestContextAdaptor(() -&gt; manager, singletonList(SomeContextConfiguration.class))
</code></pre>
<p>And then in the <code>TestContextManager</code> invoking this supplier inside a <code>synchronized (monitor)</code> block in the constructor.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-26 11:40:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2687#discussion_r1088267386">Comment</a> on pull request by <a href="https://github.com/ntthaibk">ntthaibk</a>
<p>> And then in the TestContextManager invoking this supplier inside a synchronized (monitor) block in the constructor.</p>
<p>I think in this you mean in the <code>TestContextAdaptor</code> right? So in order to not introduce any changes in the unit test, I should just provide the <code>TestContextManager</code> instance inside the synchronized block of <code>TestContextAdaptor</code> block right. If that's correct, I will try that tomorrow to see how :D</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-26 11:45:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2687#issuecomment-1405534678">Comment</a> on pull request by <a href="https://github.com/ntthaibk">ntthaibk</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> hi, just want to inform that I’ve tried the SNAPSHOT version and it work!!!! Thanks a lot for your help ❤️</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-26 12:16:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2687#discussion_r1088299089">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Yes! Ultimately I'd like to preserve the adaptor pattern. Having non-null final fields all the time is kinda nice.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-26 20:41:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2687#issuecomment-1406013083">Comment</a> on pull request by <a href="https://github.com/ntthaibk">ntthaibk</a>
<p>Just updated the constructor of <code>TestContextAdaptor</code> to receive the Supplier of <code>TestContextManager</code> instead, so that the unit test for cucumber-spring has passed</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-26 20:57:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2687#discussion_r1088586766">Comment</a> on pull request by <a href="https://github.com/ntthaibk">ntthaibk</a>
<p>I've just updated the constructor of <code>TestContextAdaptor</code> to receive the Supplier of <code>TestContextManager</code> instead, so that the unit test for cucumber-spring has passed</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-27 02:03:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2687#issuecomment-1406281056">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2687?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2687?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2687?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2687">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2687?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2687</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/63ac82da31672ec55256c6ddff8e423f9e3e3f32">63ac82d</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/e5ff5f6abbe3373115811d9ba0456fac9e265d98?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/e5ff5f6abbe3373115811d9ba0456fac9e265d98?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/e5ff5f6abbe3373115811d9ba0456fac9e265d98">e5ff5f6</a>) will <strong>decrease</strong> coverage by <code>0.01%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2687 +/- ##
============================================
- Coverage 84.68% 84.68% -0.01%
- Complexity 2680 2682 +2
============================================
Files 322 322
Lines 9450 9449 -1
Branches 899 899
============================================
- Hits 8003 8002 -1
Misses 1120 1120
Partials 327 327
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-27 02:17:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2687#issuecomment-1406297239">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/ntthaibk">@ntthaibk</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-28 03:30:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1407378960">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You're using a fat jar. Make sure it's constructed by correctly merging all files from <code>META-INF</code>. See also <a href="https://github.com/cucumber/cucumber-jvm/issues/2588#issuecomment-1192425183">#2588 (comment)</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-30 00:02:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1408145819">Comment</a> on issue by <a href="https://github.com/adarshhm6">adarshhm6</a>
<p>Thanks for the response <a href="https://github.com/mpkorstanje">@mpkorstanje</a><br />
I just cross checked. I am already using apache-maven-shaded-plugin in pom.xml of gluesteps module as below.<br />
<a href="https://user-images.githubusercontent.com/56758173/215407773-392cad7a-ccf7-4438-ac7c-93e1307dcc93.png">image</a></p>
<p>As mentioned, I have grouped glue steps, features and utility methods in independent modules and it's working fine with 7.0.0 version and able to run it via CLI and inside the jar. But with upgrade to 7.11.0 it's throwing NullPointer Exception for autowiring ExecutionContext class present in Util module from ScenarioHooks class in glue steps module. However inside the jar, both classes are present and merged properly just like with 7.0.0</p>
<p><a href="https://user-images.githubusercontent.com/56758173/215413816-4af86873-6041-404a-b163-2338ab02264f.png">image</a></p>
<p>Am I missing something that it fails to run with 7.11.0?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-30 01:10:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1408230833">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> However inside the jar, both classes are present and merged properly just like with 7.0.0</p>
<p>The <code>META-INF/services</code> folder does not typically contain class files. I don't think you have understood the problem you have yet.</p>
<p>Please read and carefully consider the comments after <a href="https://github.com/cucumber/cucumber-jvm/issues/2588#issuecomment-1192425183">#2588 (comment)</a>. At the very least you should verify the packing is the problem by running your tests with a regular jar and adding the dependencies to the classpath.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-30 03:19:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1408443128">Comment</a> on issue by <a href="https://github.com/adarshhm6">adarshhm6</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> I understood your point about META-INF part. But I just elaborated on where exactly am facing the issue. As you mentioned in <a href="https://github.com/cucumber/cucumber-jvm/issues/2588">#2588</a> I have already added maven-shade-plugin and here is the content of that in the jar.<br />
<a href="https://user-images.githubusercontent.com/56758173/215460539-5f0d5e74-cd0a-4052-ad4e-61f156369f78.png">image</a></p>
<p>Are you suggesting like, I should explicitly add the cucumber related dependencies(cucumber-core, cucumber-java, cucumber-spring, cucumber-junit, reporting-plugin) as jar into the buildpath instead of pom dependency and build the jar and run the tests?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-30 06:16:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1408701486">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>No, typically, rather than using a fat jar, you would run a java program using <code>java -jar my-project.jar -cp dir-with-depenency-jars/</code>. You can use this to convince yourself that it is the shading process that causes your problem.</p>
<p>Then once you are convinced that this is indeed the problem and look at how the maven shade plugin merges the <code>META-INF/services</code> directory you'll see that if multiple dependencies have the same services file name e.g. <code>io.cucumber.core.ObjectFactory</code> the shade plugin will overwrite these files rather than merge their contents.</p>
<p>You can tweak this by configuring the <a href="https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer">ServicesResourceTransformer</a> on the Maven Shade Plugin. Though as you're using Spring, chances are you'll be incorrectly merging other files as well. If you absolutely must use a single jar file, consider using Springs executable jar format instead.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-05 11:11:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1418241582">Comment</a> on issue by <a href="https://github.com/adarshhm6">adarshhm6</a>
<p>Thanks for detailed explanation <a href="https://github.com/mpkorstanje">@mpkorstanje</a> which gives better understanding.<br />
In my project, I need to bundle multiple modules into one jar for shaded plugin is used.<br />
I tried to follow the steps which you suggested.<br />
<strong>Suggestion 1)</strong> Instead of maven-shade plugin, used spring-boot-maven-plugin and tried to run it as jar</p>
<p><a href="https://user-images.githubusercontent.com/56758173/216839460-9300507c-eb9e-487b-a380-8891c5073892.png">image</a></p>
<p><a href="https://user-images.githubusercontent.com/56758173/216837716-fd38a926-6abe-40dc-b74f-88f931136ff1.png">image</a></p>
<p>When tried to run it as java -jar <strong>JarPath</strong>/automation-glue-1.0-SNAPSHOT.jar.jar, I got No Features found at classpath</p>
<p>So modified the command as below and tried to run it<br />
java -DAUTOMATION<em>LOG</em>PATH=<strong>LogPath</strong>\logs -DAUTOMATION_CONFIG=<strong>ConfigPath</strong>\test-configuration-local.conf -jar <strong>JarPath</strong>/automation-glue-1.0-SNAPSHOT.jar -t "<a href="https://github.com/sanity">@sanity</a>" --glue com.automation <strong>FeaturesPath</strong><br />
which resulted in below error</p>
<p><a href="https://user-images.githubusercontent.com/56758173/216837292-73c6d29b-806c-46ad-87c5-d9dc4c7633ce.png">image</a></p>
<p>Since, my glue module is dependent on util and test-domain module, I tried to add those as classpath with -cp<br />
java -DAUTOMATION<em>LOG</em>PATH=<strong>LogPath</strong>\logs -DAUTOMATION<em>CONFIG=<strong>ConfigPath</strong>\test-configuration-local.conf -cp Utils</em>Module_Path\automation-utils\target -jar <strong>JarPath</strong>/automation-glue-1.0-SNAPSHOT.jar -t "<a href="https://github.com/sanity">@sanity</a>" --glue com.automation <strong>FeaturesPath</strong> but again the same error as in above screenshot like doesn't support classpath scan of nested jars. So, Couldn't successfully run it as java program using Spring executable format</p>
<p><strong>Suggestion 2)</strong> So followed the 2nd approach which is the work around you provided to tweak configuration to include ServicesResourceTransformer<br />
<a href="https://user-images.githubusercontent.com/56758173/216837621-ab8665a3-fc3e-463f-bedd-7ee84a047b00.png">image</a><br />
And then I could see that under <strong>META_INF/services</strong> inside the io.cucumber.core.backend.ObjectFactory 2 entries which concludes like it was shading problem earlier where merging of entries was not proper.<br />
<a href="https://user-images.githubusercontent.com/56758173/216838053-6c65ea87-03cb-4bad-a5e6-55082284f36b.png">image</a></p>
<p>After that I was able to run the Cucumber Application via Command Line using the generated fat jar which is bundled with all modules(dependent modules) using initial command<br />
java -DAUTOMATION<em>LOG</em>PATH=<strong>LogPath</strong>\logs -DAUTOMATION_CONFIG=<strong>ConfigPath</strong>\test-configuration-local.conf -cp <strong>CongFilePath</strong>\conf -cp JarPath\target\automation\lib\automation-glue-1.0-SNAPSHOT-fat.jar io.cucumber.core.cli.Main <strong>FeatureFilePath</strong> --glue com.automation -t ""<a href="https://github.com/sanity">@sanity</a>"" -p me.jvt.cucumber.report.PrettyReports:ReportsDirPath\pretty -p html:ReportsDirPath\html\report.html -p rerun:ReportsDirPath\rerun\rerun.txt</p>
<p>The shading problem was not there while using version 7.0.0, may be with new changes and dependencies it caused overwriting which is resolved with the help of ServicesResourceTransformer as you suggested.</p>
<p>and also you suggested If I have to use a single jar file, consider using Springs executable jar format instead.<br />
Using springs executable jar format, I faced the issue as I mentioned in <strong>Suggestion 1</strong> that am not able to reference the dependent util jar modules via classpath. Is there any alternative way to reference the dependent modules in classpath and run it as Spring Executable Jar using java -jar <strong>JarPath</strong>/automation-glue-1.0-SNAPSHOT.jar.jar ?</p>
<p>My need is that I need to bundle all dependent modules into one jar which is the reason am using maven-shade-plugin which is one of the way to create executable jar. With inclusion of <strong>ServicesResourceTransformer</strong> with maven-shade-plugin issue is resolved, whether any issues in using maven-shade-plugin that you suggested for spring executable jar format?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-05 14:27:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1418282051">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Unfortunately these two facts are hard to change:</p>
<ol><li>Correctly shading jar requires correctly configuring the shade plugin which is a non trivial endeavour.</li><li>Cucumber currently can't scan inside Spring Boot dependencies (only the root jar).</li>
</ol>
<p>So given your situation you don't have many good choices. Fundamentally you could remove the need to deploy single jars and you would resolve your problems. But without knowing your circumstances I can't say if that is an option for you.</p>
<p>I am open to suggestions that make 2) possible but that too isn't trivial.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-06 10:40:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1419570551">Comment</a> on issue by <a href="https://github.com/adarshhm6">adarshhm6</a>
<p>Correctly shading jar requires correctly configuring the shade plugin which is a non trivial endeavour --> Agreed. As of now, solution for me is configuring ServicesResourceTransformer with apache maven-shade-plugin but not sure in future what problem will arise when I try to upgrade the cucumber version again.</p>
<p>Cucumber currently can't scan inside Spring Boot dependencies (only the root jar) --> Yes, that is the sad part where it's not scanning the nested jars in the classpath with Spring-boot-maven-plugin</p>
<p>With that limitation, to achieve Springs executable format then ideal solution would be to have a single module with different packages for features, glue-steps, util-code and domain related stuff instead of multi-module structure ??<br />
If any other alternative ways for classpath scan of dependent modules(nested jars) with Spring executable format in multi module structure, then please do suggest.</p>
<p>As of now am planning to continue with shade plugin with tweak in configuration ServicesResourceTransformer as you suggested. Hope there is no harm in using it.</p>
<p>Thanks for your time and detailed guidelines which helped me to understand the issue and get this sorted out.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-09 08:12:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1424447902">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> With that limitation, to achieve Springs executable format then ideal solution would be to have a single module with different packages for config related files, features, glue-steps, util-code and domain related stuff instead of multi-module structure ??<br />
> If any other alternative ways for classpath scan of dependent modules(nested jars) with Spring executable format in multi module structure, then please do suggest.</p>
<p>Yes. I do believe that a single module would work. I don't think there are any alternatives.</p>
<p>> The module structure incorporated in my project to bifurcate between different components like glue module, features, configuration related files, Utility Code.</p>
<p>Only features and glue (step definitions), the other code can be anywhere. Maybe that helps.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-11 02:27:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1426688512">Comment</a> on issue by <a href="https://github.com/adarshhm6">adarshhm6</a>
<p>> Yes. I do believe that a single module would work. I don't think there are any alternatives.</p>
<p>Ok. Understood</p>
<p>> Only features and glue (step definitions), the other code can be anywhere. Maybe that helps.</p>
<p>Isn't this contradicts the first statement? The other code(Utility modules which includes jdbc connections and common methods) also needs to be in the same glue(step definitions) module as currently I am adding the utility module as a dependency module in pom.xml of glue module and Cucumber scans only the root jar and it doesn't scan the nested dependent jars or classpath entries (<strong>Error screenshot where util lib is nested jar inside glue jar</strong>). Hence the only solution is to <strong>keep a single module with separate packages for glue and utility code.</strong></p>
<p><a href="https://user-images.githubusercontent.com/56758173/218252689-9abbe509-eb11-42c6-95c5-da9e4287b133.png">image</a></p>
<p>So as you suggested for me the work around solution as of now is to use <a href="https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer">ServicesResourceTransformer</a> in the maven-shade-plugin.<br />
With that may be this issue can be marked as resolved. Thank you <a href="https://github.com/mpkorstanje">@mpkorstanje</a> for the detailed explanation and solution.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-11 09:31:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2689#issuecomment-1426832787">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> Isn't this contradicts the first statement?</p>
<p>Depends a bit on how your packages and glue property are configured. If your modules contain distinct package names that are siblings to each and the glue targets one of those and not other there shouldn't be problems.</p>
<p>> Thank you <a href="https://github.com/mpkorstanje">@mpkorstanje</a> for the detailed explanation and solution.</p>
<p>You're welcome!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-30 16:00:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2691#issuecomment-1409540939">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Third time is the charm <a href="https://github.com/cucumber/cucumber-jvm/actions/runs/4023570054/jobs/6965401520">https://github.com/cucumber/cucumber-jvm/actions/runs/4023570054/jobs/6965401520</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-31 03:42:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2604#issuecomment-1410207355">Comment</a> on pull request by <a href="https://github.com/ch-akash">ch-akash</a>
<p>How is this implemented? There is no documentation I am able to find. I am chasing same problem - want to run scenario in sequence but feature in parallel.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-31 04:21:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2604#issuecomment-1410252736">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><a href="https://github.com/ch-akash">@ch-akash</a> the documentation was updated as part of this PR. If you look at the changes in the PR, I'm sure you'll be able to find the documentation.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-31 04:36:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2604#issuecomment-1410271252">Comment</a> on pull request by <a href="https://github.com/ch-akash">ch-akash</a>
<p>I saw the readme file, checked on Cucumber's official documentation for parallel execution and even in this PR I did not find the solution as in how is it achieved and what are the steps to be taken. I checked this PR but it has no 'Steps to do' or migration guide. As far as I checked. Any direct link to this documentation? The checklist says doc updated but where is it?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-31 06:02:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2604#issuecomment-1410410018">Comment</a> on pull request by <a href="https://github.com/sambathkumar-sekar">sambathkumar-sekar</a>
<p><a href="https://github.com/ch-akash">@ch-akash</a> if you have really gone through the PR you might’ve found the solution. You need to use the Junit5 property <code>cucumber.execution.execution-mode.feature</code> to achieve your desired execution. and this solution is only for cucumber7 with Junit platform. Behaviour of this property is explained in Readme file of <code>cucumber-junit-platform-engine</code> project.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-31 07:40:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2604#issuecomment-1410611936">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><a href="https://github.com/ch-akash">@ch-akash</a> This is an opensource project that mostly runs on peoples spare time. Unfortunately writing detailed migration guides and step by step tutorials is a time consuming effort.</p>
<p>However if you read the JUnit Platform README and the JUnit 5 documentation from top to bottom all the information you need should be there. If this is too much at once consider looking for a JUnit 5 tutorial first before moving into the JUnit 5 and Cucumber documentation.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-01-31 07:50:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2604#issuecomment-1410629640">Comment</a> on pull request by <a href="https://github.com/ch-akash">ch-akash</a>
<p>Many thanks <a href="https://github.com/mpkorstanje">@mpkorstanje</a> and <a href="https://github.com/sambathkumar-sekar">@sambathkumar-sekar</a> for replying. I respect the time you gave to my comment. I will try it and will go through the documentation first if I have doubts.</p>
<p>Best regards.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-06 04:08:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-java-skeleton/issues/77#issuecomment-1418979455">Comment</a> on issue by <a href="https://github.com/gchakroun">gchakroun</a>
<p>Same error in Stack: <a href="https://stackoverflow.com/questions/75360317/how-to-run-multiple-tags-in-cucumber-junit-version-7">https://stackoverflow.com/questions/75360317/how-to-run-multiple-tags-in-cucumber-junit-version-7</a></p>
<a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber/cucumber-java-skeleton</a>
GitHub
2023-02-06 05:18:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-java-skeleton/issues/77#issuecomment-1419066775">Comment</a> on issue by <a href="https://github.com/gchakroun">gchakroun</a>
<p>Just closed ? no comment or anything ?</p>
<a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber/cucumber-java-skeleton</a>
GitHub
2023-02-07 12:00:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2349#issuecomment-1421365266">Comment</a> on issue by <a href="https://github.com/aniljain1982">aniljain1982</a>
<h2>TestNG: </h2>
<pre><code>Step definitions base class:
</code></pre>
<hr />
<pre><code>import org.openqa.selenium.WebDriver;
import org.testng.Reporter;
import org.testng.xml.XmlTest;
public class BaseStepDefinition {
WebDriver driver;
XmlTest xmlTest;
public BaseStepDefinition() {
try {
xmlTest = Reporter.getCurrentTestResult().getTestContext().getCurrentXmlTest();
System.out.println(xmlTest.getParameter("browser"));
} catch (Exception e) {
e.printStackTrace();
}
}
}
Step definitions class:
</code></pre>
<hr />
<pre><code>import io.cucumber.java.After;
import io.cucumber.java.en.Given;
public class SauceDemoStepDefinition extends BaseStepDefinition {
@After
public void tearDown() throws Exception {
}
@Given("^User is on login page$")
public void user_is_on_login_page() throws Exception {
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-09 16:42:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2639#issuecomment-1425022775">Comment</a> on pull request by <a href="https://github.com/hovi">hovi</a>
<p>Let's wrap this one up if possible. :) Doesn't matter if the mvn command doesn't work for me if it works for you and you can check yourself. It is weird thought.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-05 10:49:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2639#issuecomment-1455171794">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers! Unfortunately I have been a bit short on time for the last few weeks and the time available has gone into more urgent matters.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-05 10:55:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2639#issuecomment-1455173142">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> Doesn't matter if the mvn command doesn't work for me if it works for you and you can check yourself. It is weird thought.</p>
<p>The build is currently failing on a lack of formatting. It also appears that some comments have gone unaddressed.</p>
<p>In other circumstances I would be happy to fix these small imperfections but I'm a little pressed for time at the moment.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-14 01:32:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2693#issuecomment-1429411028">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-24 00:09:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2694#issuecomment-1443060722">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Interesting. Looks like Cucumber got an exception before <code>testRunStarted</code> got called.</p>
<p>Could you put some breakpoints here <a href="https://github.com/cucumber/cucumber-jvm/blob/main/cucumber-junit/src/main/java/io/cucumber/junit/Cucumber.java#L227">https://github.com/cucumber/cucumber-jvm/blob/main/cucumber-junit/src/main/java/io/cucumber/junit/Cucumber.java#L227</a> and follow the execution with a debugger?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-24 00:20:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2694#issuecomment-1443096350">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I do see that you are using <code>cucumber-jvm-deps.jar</code> as a dependency. This suggests you are either manually managing your dependencies or including transitive depencies in your dependency management tool.</p>
<p>So in all likely hood the exception before <code>testRunStarted</code> is related to missing depencies.</p>
<p>Consider using Maven or Gradle and if you are remove the transitive depencies. You can find a minimal working example here: <a href="https://github.com/cucumber/cucumber-java-skeleton">https://github.com/cucumber/cucumber-java-skeleton</a></p>
<p>I'll leave this issue open as a reminder to remove the <code>try-finally</code> so future exceptions won't be swallowed.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-02-27 05:49:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2696#issuecomment-1446354552">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-05 10:19:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2696#issuecomment-1455164833">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-05 10:25:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2696#issuecomment-1455166143">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2696?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2696?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2696?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2696">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2696?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2696</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/15dc9734e209568e3ba79141f3cc790f312dd8ee">15dc973</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/6f4ebc087a7c02757f99eb1d60b4c61f96ddcdc0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/6f4ebc087a7c02757f99eb1d60b4c61f96ddcdc0?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/6f4ebc087a7c02757f99eb1d60b4c61f96ddcdc0">6f4ebc0</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2696 +/- ##
=========================================
Coverage 84.68% 84.68%
Complexity 2682 2682
=========================================
Files 322 322
Lines 9449 9449
Branches 899 899
=========================================
Hits 8002 8002
Misses 1120 1120
Partials 327 327
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-03 12:11:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1454073409">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p>When you talk about improving the exception message using step definitions, are you asking to verify the step definitions if they are a part of classpath?</p>
<p>I have added a sample code for your reference.</p>
<p>// Verify that step definitions have been declared and are available on the classpath<br />
try (ScanResult scanResult = new ClassGraph().enableClassInfo().scan()) {<br />
ClassInfoList stepDefinitionClasses = scanResult.getClassesWithAnnotation("io.cucumber.java.**");<br />
if (stepDefinitionClasses.isEmpty()) {<br />
String errorMessage = "No step definitions were found. Please make sure you have declared your step definitions on the classpath.";<br />
LOGGER.error(errorMessage);<br />
throw new CucumberException(errorMessage);<br />
}<br />
}</p>
<p>I am using the ClassGraph library to scan the classpath for classes that have been annotated with <a href="https://github.com/given">@given</a>, <a href="https://github.com/when">@when</a>, or <a href="https://github.com/then">@then</a> annotations. If no step definition classes are found, we throw a CucumberException with an appropriate error message.</p>
<p>Does this improve the exception message?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-05 10:24:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1455165884">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>The exception I originally mentioned typically happens when a user tries to use cucumber without either <code>cucumber-java</code> or <code>cucumber-java8</code> as a dependency. These dependencies contain the <code>JavaBackend</code> and <code>Java8Backend</code> which are <code>Backend</code> implementations. The exception you mention would happen only if/when either backend is present but doesn't discover any step definitions.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-08 20:59:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1461280826">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p>> The exception I originally mentioned typically happens when a user tries to use cucumber without either <code>cucumber-java</code> or <code>cucumber-java8</code> as a dependency. These dependencies contain the <code>JavaBackend</code> and <code>Java8Backend</code> which are <code>Backend</code> implementations. The exception you mention would happen only if/when either backend is present but doesn't discover any step definitions.</p>
<p>Thank you for your response. So, I assume, we just need to add few details to the error message. Can I improve the exception with the following message:</p>
<p>"No backends were found. Cucumber consists of two main components: cucumber-core, which runs Cucumber, and a backend, which declares step definitions. Please make sure you have a backend module on your CLASSPATH, such as cucumber-java or cucumber-java8, which contain the JavaBackend and Java8Backend implementations. If you already have a backend module on your CLASSPATH, this error may occur if there are no step definitions present in your project."</p>
<p>This message provides more information about the cause of the exception, explains the role of the backend in Cucumber, and provides suggestions for resolving the issue. Additionally, it mentions the possibility of the error occurring when there are no step definitions present in the project, which could be a common cause of the error.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-09 00:53:43
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1461592474">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Aside from being factually incorrect, the message you propose is rather woolly and mentions (to the user) irrelevant implementation details.</p>
<p>Out of curiosity, did you just ask ChatGTP to write an error message based on my input?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-09 00:58:12
*Thread Reply:*
New comment on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-09 01:03:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1461608198">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p>> Aside from being factually incorrect, the message you propose is rather woolly and mentions (to the user) irrelevant implementation details.
>
> Out of curiosity, did you just ask ChatGTP to write an error message based on my input?</p>
<p>Pardon me. I am new to open source contribution. Though, I had exposure to cucumber testing framework during my spring-boot-uplift at work. I have been taking chatGPT's help lately. However, I do intend to act responsibly and make sure have my doubts cleared before I initiate a PR. It can become little difficult to comprehend the issues, therefore ChatGPT. However, your guidance on the same would be much appreciated.</p>
<p>I understood your above comment. Is it possible for you to showcase what an exception message would look like, an example maybe? I have understood the DI container, and how can it be used in exception message. But, I am still confused about point 1 and 2 in your propsoed solution.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-09 01:38:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1461667140">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>That's cool.</p>
<p>Unfortunately ChatGTP is only a language model. This means that it will generate text that sounds plausibele and convincing but also has no basis in factual reality. If you do not have the knowledge of the underlying system you will not be able to tell ofcourse. So you are setting yourself up to be disappointed.</p>
<p>Additionally, your real writing voice has certain mannerisms (I would guess you are from India) while ChatGTP has other distinct mannerisms. The switch between the two is rather obvious.</p>
<p>I would prefer it if going forward you didn't use ChatGTP at all. I would rather talk to a person in what I assume is a second language for both of us. I don't mind if it's not perfect. I would rather see that you learn from it.</p>
<p>Now I would like to show you want the exception should look like but writing it will take a little time. So I made this issue as a reminder for the future.</p>
<p>Instead I think it is better if you spend some trying to understand the problem. Perhaps you can start by reproducing it. You can use the skeleton project to get started quickly. Removing the <code>cucumber-java</code> dependency should do the trick.</p>
<p>Once you have the exception. Look at the code that causes it. If you can explain to me what is going on there we can move on to the next step.</p>
<p><a href="https://github.com/cucumber/cucumber-java-skeleton">https://github.com/cucumber/cucumber-java-skeleton</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-09 12:01:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1462693682">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p>Yes, I am from India. Thank you for such warm gesture. I did as mentioned starting with Java-Skeleton repository. So, without removing the cucumber-java, it already had some issues with steps. Whenever I try to run my scenario from feature file, it gave me following error:</p>
<pre><code>Scenario: a few cukes # io/cucumber/skeleton/belly.feature:3
Given I have 42 cukes in my belly # io.cucumber.skeleton.StepDefinitions.I_have_cukes_in_my_belly(int)
When I wait 1 hour
Then my belly should growl
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.088 s &lt;&lt;&lt; FAILURE! - in io.cucumber.skeleton.RunCucumberTest
[ERROR] Belly.Belly - a few cukes Time elapsed: 0.051 s &lt;&lt;&lt; ERROR!
io.cucumber.junit.platform.engine.UndefinedStepException:
The step 'I wait 1 hour' and 1 other step(s) are undefined.
You can implement these steps using the snippet(s) below:
@When("I wait {int} hour")
public void i_wait_hour(Integer int1) {
// Write code here that turns the phrase above into concrete actions
throw new io.cucumber.java.PendingException();
}
@Then("my belly should growl")
public void my_belly_should_growl() {
// Write code here that turns the phrase above into concrete actions
throw new io.cucumber.java.PendingException();
}
</code></pre>
<p>However, it had no impact even if i had commented out <code>cucumber-java</code> dependency from pom.xml. here:</p>
<p>Do you want me to explain <code>UndefinedStepException</code>?<br />
As I understand, the feature file's <code>When</code> and <code>Then</code> are not being implemented in <code>StepDefinition</code> Class. And, for that reason, it is showing <code>UndefinedStepException</code>. And, as suggestion, It is asking them to be implemented in <code>StepDefinition</code> class as mentioned above.</p>
<p>But, I also corrected them and did pass my scenarios. Now, when everything was working fine after having implemented in my <code>StepDefinition</code> class, I did comment out <code>cucumber-java</code> dependency to see the result. And, that threw me compilation errors.</p>
<p>I hope I didn't confuse you.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-09 12:36:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1462751989">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Sounds like you're getting there!</p>
<p>If you want to use the project after removing the <code>cucumber-java</code> dependency you'll also have to remove the classes that use imports from this dependency. This might make the project look non-functional but should still get you the error we're trying to reproduce.</p>
<p>One of the real world situations this may happen in is when people only upgrade <code>cucumber-core</code> and not <code>cucumber-java</code>. For example this <a href="https://stackoverflow.com/questions/75608974/upgrading-cucumber-4-5-x-to-v5-0-0">Stackoverflow question</a>. Or leave out <code>cucumber-java</code> altogether.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-09 13:02:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1462814672">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<pre><code>Before All/After All failed
io.cucumber.core.exception.CompositeCucumberException: There were 2 exceptions. The details are in the stacktrace below.
at io.cucumber.core.runtime.RethrowingThrowableCollector.getThrowable(RethrowingThrowableCollector.java:57)
at io.cucumber.core.runtime.CucumberExecutionContext.getThrowable(CucumberExecutionContext.java:102)
at io.cucumber.core.runtime.CucumberExecutionContext.finishTestRun(CucumberExecutionContext.java:97)
at io.cucumber.core.runtime.Runtime.run(Runtime.java:89)
at io.cucumber.core.cli.Main.run(Main.java:87)
at io.cucumber.core.cli.Main.main(Main.java:30)
Suppressed: io.cucumber.core.exception.CucumberException: No backends were found. Please make sure you have a backend module on your CLASSPATH.
at io.cucumber.core.runtime.BackendServiceLoader.get(BackendServiceLoader.java:39)
at io.cucumber.core.runtime.BackendServiceLoader.get(BackendServiceLoader.java:33)
at io.cucumber.core.runtime.SingletonRunnerSupplier.createRunner(SingletonRunnerSupplier.java:43)
at io.cucumber.core.runtime.SingletonRunnerSupplier.get(SingletonRunnerSupplier.java:35)
at io.cucumber.core.runtime.RethrowingThrowableCollector.executeAndThrow(RethrowingThrowableCollector.java:35)
at io.cucumber.core.runtime.CucumberExecutionContext.getRunner(CucumberExecutionContext.java:134)
at io.cucumber.core.runtime.CucumberExecutionContext.runBeforeAllHooks(CucumberExecutionContext.java:86)
at io.cucumber.core.runtime.Runtime.lambda$run$0(Runtime.java:83)
at io.cucumber.core.runtime.Runtime.execute(Runtime.java:99)
at io.cucumber.core.runtime.Runtime.run(Runtime.java:82)
... 2 more
Suppressed: io.cucumber.core.exception.CucumberException: No backends were found. Please make sure you have a backend module on your CLASSPATH.
at io.cucumber.core.runtime.BackendServiceLoader.get(BackendServiceLoader.java:39)
at io.cucumber.core.runtime.BackendServiceLoader.get(BackendServiceLoader.java:33)
at io.cucumber.core.runtime.SingletonRunnerSupplier.createRunner(SingletonRunnerSupplier.java:43)
at io.cucumber.core.runtime.SingletonRunnerSupplier.get(SingletonRunnerSupplier.java:35)
at io.cucumber.core.runtime.RethrowingThrowableCollector.executeAndThrow(RethrowingThrowableCollector.java:35)
at io.cucumber.core.runtime.CucumberExecutionContext.getRunner(CucumberExecutionContext.java:134)
at io.cucumber.core.runtime.CucumberExecutionContext.runAfterAllHooks(CucumberExecutionContext.java:91)
at io.cucumber.core.runtime.Runtime.execute(Runtime.java:99)
at io.cucumber.core.runtime.Runtime.run(Runtime.java:87)
... 2 more
</code></pre>
<p>Now, I am able to reproduce the exception. Thanks a ton. If I could try to explain the exception, cucumber-jvm repository has a Class named <code>BackendServiceLoader</code>. And, it throws the above exception when it fails to create <code>Backend</code> instance. And, the reasons for such an exception can be as mentioned above i.e. If the user has left <code>cucumber-java</code> dependency in their pom.xml or upgrading <code>cucumber-core</code> and not <code>cucumber-java</code>. There could be other possible scenarios too, which I am not aware.</p>
<p>How to proceed from here?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-09 13:22:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1462842753">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>So imagine you're using Cucumber. You're also new to software development, testing and Cucumber. Then you get this error message. It's not very helpful.</p>
<p>Can you change it in such a way that becomes helpful?</p>
<p>I imagine that this explanation might have a few parts. One to explain that cucumber has multiple modules, one to explain what those modules are, one to explain the problem and finally how to solve it.</p>
<p>edit: It's night here. You can think about it for a while.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 08:31:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1464061790">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p>No backends were found. Cucumber relies on backend module to run steps. It appears to be missing from your CLASSPATH. Please make sure you have a backend module in your project's dependencies or explicitly added to your CLASSPATH. For example, you can add the 'cucumber-jvm' backend module to your project. If you already have <code>cucumber-jvm</code> in your CLASSPATH, please make sure the version of <code>cucumber-core</code> and <code>cucumber-jvm</code> are in sync.</p>
<p>What improvement/correction could I bring in to the above exception message?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 11:48:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1464331253">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> Cucumber relies on backend module to run steps.</p>
<p>Sounds about right. The module both discovers and run steps.</p>
<p>> Please make sure you have a backend module in your project's dependencies or explicitly added to your CLASSPATH.</p>
<p>Yes!</p>
<p>> For example, you can add the cucumber-jvm backend module to your project.</p>
<p>I don't think this is quite right. Did you try this as a solution in tbe the broken project we are using to reproduce the problem?</p>
<p>> If you already have cucumber-jvm in your CLASSPATH, please make sure the version of cucumber-core and cucumber-jvm are in sync.</p>
<p>Very nice! I didn't think to include that.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 12:18:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1464369289">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p>> > Cucumber relies on backend module to run steps.
>
> Sounds about right. The module both discovers and run steps.
>
> > Please make sure you have a backend module in your project's dependencies or explicitly added to your CLASSPATH.
>
> Yes!
>
> > For example, you can add the cucumber-jvm backend module to your project.
>
> I don't think this is quite right. Did you try this as a solution in tbe the broken project we are using to reproduce the problem?
>
> > If you already have cucumber-jvm in your CLASSPATH, please make sure the version of cucumber-core and cucumber-jvm are in sync.
>
> Very nice! I didn't think to include that.</p>
<p>I am a bit confused. When I say this, 'For example, you can add the <code>cucumber-jvm</code> backend module to your project.', Doesn't it guide the customer/user to add a backend module? And, isn't <code>cucumber-jvm</code> that backend module?</p>
<p>edit: Should it be <code>cucumber-java</code> instead of <code>cucumber-jvm</code> for the statement 'For example, you can add the <code>cucumber-jvm</code> backend module to your project.'?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 13:02:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1464468144">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>The best way to know if your instructions fix the problem is to try it out. You've made a reproducer so you can use it to test what happens when you use <code>cucumber-jvm</code> or <code>cucumber-java</code>.</p>
<p>Once you've tried it and know which one works, we can look at why the other one didn't.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 13:15:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1464483944">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p>So, as mentioned above, I just uncommented cucumber-java and the corresponding step class, and i no longer could see the error message i.e.</p>
<pre><code>[ERROR] Errors:
[ERROR] No backends were found. Please make sure you have a backend module on your CLASSPATH.
</code></pre>
<p>And, when I visit the documentation web page of Cucumber, I see the dependency for cucumber-jvm mentioned as</p>
<pre><code>&lt;dependency&gt;
&lt;groupId&gt;io.cucumber&lt;/groupId&gt;
&lt;artifactId&gt;cucumber-java&lt;/artifactId&gt;
&lt;version&gt;7.11.1&lt;/version&gt;
&lt;scope&gt;test&lt;/scope&gt;
&lt;/dependency&gt;
</code></pre>
<p>Does this mean I can add this to the exception message?<br />
'For example, you can add the cucumber-jvm backend module to your project.'</p>
<p>Reference:<a href="https://cucumber.io/docs/installation/java/">https://cucumber.io/docs/installation/java/</a> #</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 13:45:32
*Thread Reply:*
New comment on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 13:49:47
*Thread Reply:*
New comment on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 13:49:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1464515399">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I think you understand what to do to trigger the problem and to make it go away. But I don't think you've quite connected that yet to helping someone fix the problem.</p>
<p>I think if you told someone to add the <code>cucumber-jvm</code> as a backend, they'd would literally try that. Try doing that and see what happens.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 13:54:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1464519296">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p>> I think you understand what to do to trigger the problem and to make it go away. But I don't think you've quite connected that yet to helping someone fix the problem.
>
> I think if you told someone to add the <code>cucumber-jvm</code> as a backend, they'd would literally try that. Try doing that and see what happens.</p>
<p>Got it. I deleted my earlier response. I would have a more refined exception message as below:</p>
<p>No backends were found. Cucumber relies on backend module to discover and run steps. It appears to be missing from your CLASSPATH. Please make sure you have a backend module in your project's dependencies or explicitly added to your CLASSPATH. If you already have <code>cucumber-jvm</code> in your CLASSPATH, please make sure the version of <code>cucumber-core</code> and <code>cucumber-jvm</code> are in sync.</p>
<p>Edit: How about a slight change in the last line? Does it make sense?<br />
If you already have backend module in your CLASSPATH, please make sure Cucumber version is the same for all Cucumber dependencies.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-15 02:28:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1469653834">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>So, I made a project to reproduce this problem and I keep following your advice of adding <code>cucumber-jvm</code> as a dependency. It doesn't work, the error doesn't go away!</p>
<p>Can you tell me what I'm doing wrong?</p>
<p>And perhaps that sounds a bit silly. We both know the solution. But we are trying to help people who don't know. So we must act like people who don't know if we want to test the advice we give them.</p>
<p>If it helps, completely remove the code you commented from your project. It will make it look more like the work of someone who made the mistake and less like a tool to reproduce the problem.</p>
<p>Also, I'm not telling you exactly what is wrong with your message. The point of this exercise is that you learn how to verify if your own instructions are correct. By following is them.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-15 05:42:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2697#issuecomment-1469936213">Comment</a> on issue by <a href="https://github.com/relentless-pursuit">relentless-pursuit</a>
<p>Makes sense.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-02 13:07:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2698#issuecomment-1452546190">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Unfortunately I haven't had time to consider this yet.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-05 10:47:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2698#issuecomment-1455171287">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Unfortunately I've not been able to give this the consideration this is due just yet. Never the less this are my quick consideration:</p>
<p>• I believe that <a href="https://github.com/cucumber/cucumber-jvm/issues/2035">#2035</a> is a major contributing factor this this problem. The resolution of this depends on the deprecation of <code>cucumber-java8</code> and it's replacement with <code>cucumber-lambda</code> (<a href="https://github.com/cucumber/cucumber-jvm/issues/2279">#2279</a>). This is unfortunately a long way away.
• I would like to avoid adding a dependency to Cucumber.
• I would like to retain the ability to use random UUIDs. The messages from one process should not collide with those from another process. This becomes much more likely when using a time based UUID.
• A brief glance at the difference UUID generators shows a cacophony of possible options and properties for the different generators. I do not believe we can pick the correct one for all use cases.</p>
<p>Based on this I reckon the best course of action would be to</p>
<ol><li>Retain the random UUID generator as the default</li><li>Refactor the default UUID generator into a implementation that is loaded via SPI.</li><li>Provide a property to select other UUID generators via SPI (note: this should work with <code>cucumber.properties</code>, <code>junit-platform.properties</code>, <code>@CucumberOption</code>, environment variables and the CLI).</li>
</ol>
<p>For reference look at the current <a href="https://github.com/cucumber/cucumber-jvm/blob/main/cucumber-core/src/main/java/io/cucumber/core/runtime/ObjectFactoryServiceLoader.java">ObjectFactoryServiceLoader</a> implementation.</p>
<p>If you are willing to write a pull request for this, I would be happy to accept it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-06 06:23:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2698#issuecomment-1456230787">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I think a time-based UUID will work (there is no collision risk when using multithreading in the same JVM because the generators are have a time-based component and a counter component).</p>
<p>But I agree on the other arguments:</p>
<p>• On my project, the parser generates about 5000 UUIDs when the rest of test framework generates about 90'000 UUIDs: thus, it's probably true that <a href="https://github.com/cucumber/cucumber-jvm/issues/2035">#2035</a> is a major contributing factor (although I didn't verify).
• It's better to avoid adding dependencies.
• There are lot of configuration options in UUID generators.</p>
<p>Configuring the UUID generator using SPI is a good solution to delegate the choice to the user. But as the user will need to add specific configuration, it's not guaranteed that many people will use this feature.</p>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> do you think it is worth doing it now, or is it better to invest development time on <a href="https://github.com/cucumber/cucumber-jvm/issues/2035">#2035</a> / <a href="https://github.com/cucumber/cucumber-jvm/issues/2279">#2279</a> ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-06 13:01:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2698#issuecomment-1456991695">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> I think a time-based UUID will work (there is no collision risk when using multithreading in the same JVM because the generators are have a time-based component and a counter component).</p>
<p>Reports may be generated on different JVMs at the same time. A typical example would be one suite that tests against Firefox and another against Safari.</p>
<p>There are ofcourse solutions for this as well but the advantage of the random UUID is that they'll work in all situations.</p>
<p>> But as the user will need to add specific configuration, it's not guaranteed that many people will use this feature.</p>
<p>That is rather unfortunate indeed. Though technically the cost is rather low. So in my estimation it evens out.</p>
<p>> <a href="https://github.com/mpkorstanje">@mpkorstanje</a> do you think it is worth doing it now, or is it better to invest development time on <a href="https://github.com/cucumber/cucumber-jvm/issues/2035">#2035</a> / <a href="https://github.com/cucumber/cucumber-jvm/issues/2279">#2279</a> ?</p>
<p>As a maintainer I would generally favour the long term approach. But the 5% improvement you mentioned is something that can be achieved in the short term and mostly without my input. So I think it mostly depends on your willingness and interests.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-07 22:58:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2698#issuecomment-1459633303">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Ok, I'll do it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-03 19:52:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2699#issuecomment-1454364831">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2699?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2699?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2699?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2699">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2699?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2699</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/a754b020af8958a1b1cfffd2f359f45b93931ce7">a754b02</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/d61fa04c14233f7939587924f0aa79c1f23f39f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/d61fa04c14233f7939587924f0aa79c1f23f39f3?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/d61fa04c14233f7939587924f0aa79c1f23f39f3">d61fa04</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2699 +/- ##
=========================================
Coverage 84.68% 84.68%
Complexity 2682 2682
=========================================
Files 322 322
Lines 9449 9449
Branches 899 899
=========================================
Hits 8002 8002
Misses 1120 1120
Partials 327 327
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-09 11:45:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2700#issuecomment-1462675088">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-10 03:16:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2702#issuecomment-1463656195">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cucumber uses Scenarios/Examples as the fundamental unit of execution. This means they are assumed to be independent from each other. And as such they can be executed in any order and also in parallel. Feature hooks would break this assumption. So we will not introduce them (<a href="https://github.com/cucumber/cucumber-jvm/issues/2112">#2112</a>, <a href="https://github.com/cucumber/cucumber-jvm/issues/1827">#1827</a>, <a href="https://github.com/cucumber/cucumber-jvm/issues/666">#666</a>).</p>
<p>But this doesn't mean you will have to repeat your setup for each scenario. You can use ~<a href="https://en.wikipedia.org/wiki/Memoization">Memoization</a>~ <a href="https://en.wikipedia.org/wiki/Cache_(computing)|Caching">https://en.wikipedia.org/wiki/Cache_(computing)|Caching</a> to reuse the previous scenario. For example:</p>
<pre><code>private static Map&lt;Capabilities, App&gt; runningApplications = new HashMap&lt;&gt;();
public static App startApplication(Capabilities capabilities)
App runningApp = runningApplications.get(capabilities);
if (runningApp != null){
return runningApp;
}
// Stop the old application
runningApplications.values().forEach(app -&gt; app.stop());
runningApplication.clear();
App newApp = // start a new application with the right capabilities
runningApplications.put(capabilities, app);
return newApp;
}
// Use @AfterAll hook to stop any running application after all test have been ran
</code></pre>
<p>Now this example won't work if you execute in parallel but you could the <a href="https://en.wikipedia.org/wiki/Object_pool_pattern">Object pool pattern</a> for that.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-12 10:01:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2174#issuecomment-1465248463">Comment</a> on issue by <a href="https://github.com/timtebeek">timtebeek</a>
<p>Quick update here: the migration recipes will move to <a href="https://github.com/cucumber/cucumber-jvm-migration/pull/1">cucumber/cucumber-jvm-migration#1</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 00:43:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#issuecomment-1467560029">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2703?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2703?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2703?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2703">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2703?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2703</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/50004a726a241f29f694c3eb1c375ee98f2121a0">50004a7</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/291b8f89353c01b3897c2c73863cb06835b0ed66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/291b8f89353c01b3897c2c73863cb06835b0ed66?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/291b8f89353c01b3897c2c73863cb06835b0ed66">291b8f8</a>) will <strong>decrease</strong> coverage by <code>0.13%</code>.<br />
> The diff coverage is <code>69.62%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2703 +/- ##
============================================
- Coverage 84.68% 84.55% -0.13%
- Complexity 2682 2702 +20
============================================
Files 322 328 +6
Lines 9449 9526 +77
Branches 899 912 +13
============================================
+ Hits 8002 8055 +53
- Misses 1120 1138 +18
- Partials 327 333 +6
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 00:47:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#issuecomment-1467567605">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>How to solve the Semver build error? Should I just change the version to <code>7.12.1-SNAPSHOT</code> ? Most probably it is caused by</p>
<pre><code>[ERROR] java.method.addedToInterface: method java.lang.Class&lt;? extends io.cucumber.core.eventbus.UuidGenerator&gt; io.cucumber.core.options.CucumberOptionsAnnotationParser.CucumberOptions::uuidGenerator(): Method was added to an interface. <https://revapi.org/revapi-java/differences.html#java.method.addedToInterface>
</code></pre>
<p>Also I saw that the test coverage is not so good, I'll work on that...</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 01:24:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#issuecomment-1467624372">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Incrementing the minor version should make the semver check pass. You can use <code>mvn versions:set</code> for this.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 02:23:04
*Thread Reply:*
Review comment by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/jkronegg">jkronegg's</a> pull request
<p>Didn't look at everything yet but these stood out immediately.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 02:23:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1135225634">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Please rename this to <code>RandomUuidGenerator</code>. Should we ever switch to the fast generator as a default we won't get stuck on that.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 02:23:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1135235208">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>This exception needs some consideration. We have multiple generators by default so I don't think it is applicable.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 02:23:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1135221509">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>What is the purpose of the current thread ID? I reckon we are tempting Hyrum's Law by using it.</p>
<p>If a value must be used here, we could use a random value that is determined on initialization (a session Id of sorts). That would solve some of the collision concerns between JVMs.</p>
<p>And given that the bits of a UUID also have meaning, we may need to set the correct flag somewhere.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 02:23:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#issuecomment-1467713382">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Incrementing to <code>7.12.0-SNAPSHOT</code> solved some semver issues, but I still have:</p>
<pre><code>[ERROR] Failed to execute goal org.revapi:revapi_maven_plugin:0.15.0:check (check) on project cucumber-core: The following API problems caused the build to fail:
[ERROR] java.method.addedToInterface: method java.lang.Class&lt;? extends io.cucumber.core.eventbus.UuidGenerator&gt; io.cucumber.core.options.CucumberOptionsAnnotationParser.CucumberOptions::uuidGenerator(): Method was added to an interface. <https://revapi.org/revapi-java/differences.html#java.method.addedToInterface>
[ERROR] java.method.addedToInterface: method java.lang.Class&lt;? extends io.cucumber.core.eventbus.UuidGenerator&gt; io.cucumber.core.runner.Options::getUuidGeneratorClass(): Method was added to an interface. <https://revapi.org/revapi-java/differences.html#java.method.addedToInterface>
[ERROR]
</code></pre>
<p>As the <code>CucumberOptionsAnnotationParser</code> and the <code>Options</code> are internal Cucumber classes, is it a false positive ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 02:27:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#issuecomment-1467722640">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>We can consider them false positives. You can add it to the <code>internal</code> section in this file:</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/main/.revapi/api-changes.json">https://github.com/cucumber/cucumber-jvm/blob/main/.revapi/api-changes.json</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 05:15:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1135451329">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>While it's hard to imagine that a faster generator could be created, I don't think the implementation speed is the property that should be used to name this. I think something like <code>IncrementingUuidGenerator</code> would be better.</p>
<p>That is, assuming we don't change the implementation to be something else.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 06:15:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1135524341">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>True, I made a mistake here, mixing the "thread-safety" with the "collision" features. The thread-safe feature is provided through the <code>AtomicLong</code>, so we don't need the current thread identifier to at the generation time.</p>
<p>To avoid the collisions, using the current thread identifier may not be the best approach, because one thread could have two <code>IncrementingUuidGenerator</code>s, When using a pure random session identifier is not ideal as well, as there is a small collision risk. But an incrementing session identifier (e.g. <code>static final AtomicLong</code> field) would do the trick. I'll refactor.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 09:21:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1135828299">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I'll continue to work on this part.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-15 09:58:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1137449320">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> I added some test cases on the <code>UuidGeneratorServiceLoader</code> (which revealed one issue regarding the exception message above).</p>
<p>Then I applied the same concepts on <code>ObjectFactoryServiceLoader</code>, but kept the tests <code>@Disabled</code> because they are not passing: <a href="https://github.com/cucumber/cucumber-jvm/pull/2703/files#diff-cbb57a5f00daaf5e93ea9bf64b59ae727113b0af3e5a98b70d06ad5118864766">https://github.com/cucumber/cucumber-jvm/pull/2703/files#diff-cbb57a5f00daaf5e93ea9bf64b59ae727113b0af3e5a98b70d06ad5118864766</a> . Thus, either we have an issue in the tests or in the code.</p>
<p>Could you please confirm me the expected <code>ObjectFactoryServiceLoader</code> behavior ?</p>
<p>(the two new <code>@Disabled</code> test cases cover the last two lines of the table above).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-15 10:18:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1137481500">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I think the current problem is caused by having two "defaults". The easy way around it would be to keep the fast/incrementing UUID generator in your own project.</p>
<p>If we do want to keep both implementations then things get rather complicated because we no longer have a good way to make the current default gracefully step aside.</p>
<p>So the correct solution would be to 1) non-defaults are prioritized. 2) When only default are available, use the primary default.</p>
<p>But in the interest of simplicity I think having only one "default" implementation is better.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-16 00:46:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1138241896">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I don't think there is a problem with the UUID generator.</p>
<p>Let's make some use-cases... (I'll keep my question on <code>ObjectFactory</code> aside for the moment).<br />
Note: the use-cases are ordered by decreasing estimated popularity.</p>
<p><strong>Use-case 1: multiple UUID generators from Cucumber</strong></p>
<p>My application uses Cucumber and no other UUID generator is provided. It will be only one <code>META-INF/services/io.cucumber.core.eventbus.UuidGenerator</code> files on the classpath. Thus, when the <code>UuidGeneratorServiceLoader</code> runs, the <code>ServiceLoader.iterator()</code> will have the following UUID generators (package name not mentioned for simplicity):</p>
<p>• <code>RandomUuidGenerator</code> (coming from Cucumber META-INF)
• <code>IncrementingUuidGenerator</code> (coming from Cucumber META-INF)</p>
<p>The <code>uuid-generator</code> selection parameter is left unspecified.</p>
<p><strong>Use-case 2: multiple UUID generators from multiple sources</strong></p>
<p>My application uses Cucumber with two other third-party libraries which implement Cucumber UUID generator SPI (respectively <code>LibraryOneUuidGenerator</code> and <code>LibraryTwoUuidGenerator</code>).</p>
<p>When the application is packaged in a classical way (i.e. not a fat jar), it will be 3 <code>META-INF/services/io.cucumber.core.eventbus.UuidGenerator</code> files on the classpath.<br />
Thus, when the <code>UuidGeneratorServiceLoader</code> runs, the <code>ServiceLoader.iterator()</code> will have the following UUID generators (package name not mentioned for simplicity):</p>
<p>• <code>RandomUuidGenerator</code> (coming from Cucumber META-INF)
• <code>IncrementingUuidGenerator</code> (coming from Cucumber META-INF)
• <code>LibraryOneUuidGenerator</code> (coming from LibraryOne META-INF)
• <code>LibraryTwoUuidGenerator</code> (coming from LibraryTwo META-INF)</p>
<p>The <code>uuid-generator</code> selection parameter is left unspecified.</p>
<p><strong>Use-case 3: only one UUID generator</strong></p>
<p>My application uses Cucumber and I packaged it as a fat jar with a single one custom <code>META-INF/services/io.cucumber.core.eventbus.UuidGenerator</code> files on the classpath. Let's say I specified only one UUID generator in this file, a custom <code>MyApplicationUuidGenerator</code>. Thus when the <code>UuidGeneratorServiceLoader</code> runs, the <code>ServiceLoader.iterator()</code> will have the UUID generators defined in this file:</p>
<p>• <code>MyApplicationUuidGenerator</code></p>
<p>The <code>uuid-generator</code> selection parameter is left unspecified.</p>
<p><strong>Use-case 4: multiple UUID generators without the <code>RandomUuidGenerator</code></strong></p>
<p>My application uses Cucumber and I packaged it as a fat jar with a single one custom <code>META-INF/services/io.cucumber.core.eventbus.UuidGenerator</code> files on the classpath. Let's say I specified only two UUID generators in this file, a custom <code>MyApplicationUuidGenerator</code> and Cucumber's <code>IncrementingUuidGenerator</code>. Thus when the <code>UuidGeneratorServiceLoader</code> runs, the <code>ServiceLoader.iterator()</code> will have the UUID generators defined in this file:</p>
<p>• <code>MyApplicationUuidGenerator</code>
• <code>IncrementingUuidGenerator</code></p>
<p>The <code>uuid-generator</code> selection parameter is left unspecified.</p>
<p><strong>Use-case 5: no UUID generator</strong></p>
<p>My application uses Cucumber and I packaged it as a fat jar with a single one custom <code>META-INF/services/io.cucumber.core.eventbus.UuidGenerator</code> files on the classpath. This file is empty. Thus when the <code>UuidGeneratorServiceLoader</code> runs, the <code>ServiceLoader.iterator()</code> will have the no UUID generators defined.</p>
<p>The <code>uuid-generator</code> selection parameter is left unspecified.</p>
<p><strong>Expected behavior</strong></p>
<p>So the rule is (when no "uuid-generator" selection parameter is provided) :</p>
<p>• when the <code>RandomUuidGenerator</code> is present, use it
• when a single <code>UuidGenerator</code> is present, use it
• when multiple <code>UuidGenerator</code> are present (without <code>RandomUuidGenerator</code>), raise an error "more than one UUID generator without selection"
• when no <code>UuidGenerator</code> is present, raise an error "no UUID generator found as SPI"</p>
<p>(note that the code must be robust to the UUID generators order in the SPI iterator: it must work no matter in the <code>RandomUuidGenerator</code> is the first or the last).</p>
<p>The code in this PR is implemented for the rules and test use-cases above.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-16 05:02:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1138543066">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I'm having a hard time parsing these use cases. This is the one I have in mind.</p>
<p>Essentially this means that</p>
<p>• (2) Cucumber works by default
• (4) When adding a custom implementation to the class path it is used automatically
• When cucumber should not guess (4) or can not guess (7), the property is used to force a choice</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-16 07:53:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1138819174">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>That's fine for me, I just need to use <code>IncrementingUuidGenerator</code> only when specified in the uuid-generator property.</p>
<p>That is (same as you wrote, with changes in <strong>bold</strong>) :</p>
<p>I think the <code>IncrementingUuidGenerator</code> must be included in Cucumber to be developer-friendly (the developer just need to set a property).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-16 08:32:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1138891285">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>If you can make that work, sure.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-17 13:48:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#issuecomment-1474388963">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> I've finished the work I planned to do on this PR. Do you see anything to change ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:55
*Thread Reply:*
Review comment by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/jkronegg">jkronegg's</a> pull request
<p>Reviewed this from my phone. Looks good overal. A few nitpicks and some minor stuff. I didn't see anything major.</p>
<p>I also left a few items for myself, please leave those open.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1141334367">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>If created randomly for each IncrementingUuidGenerator the session can prevent collisions outside of the JVM too.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1141337917">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Note to self:</p>
<p>I have some doubts about using UUIDs with a custom format. Specific bits in a UUID have specific meaning. We currently don't follow that format while pretending to use UUIDs. That's bound to cause some problems for someone.</p>
<p>Additionally these UUIDs string representations are used frequently in a relatively space hungry serializable format. We could safe some bytes here with a more efficient encoding.</p>
<p>Write an issue describing the considerations for a cucumber-id. This would consist of an (session id: long, counter: long) base64 encoded.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1141340919">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>By extending a functional interface this too becomes a functional interface. I like to retain the ability to add more methods in the future.</p>
<p>This also allows for a more descriptive name than <code>get</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1141346062">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>This too should be Javadoc</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1141345822">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Feels like this should be Javadoc on UuidGeneratorServiceLoader.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1141338452">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Please mark as experimental with the API guardian annotation. I would like to retain the ability to make breaking changes.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1141343079">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Consider a package private constructor to initialize a certain state problem for testing instead of using reflection.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1141347016">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Note to self: Write an issue with the considerations of using a null-safe API, returning null only on methods annotated with nullable. Specifically investigate automated checks.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:22:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1141345041">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I don't think this works on 8. I would be okay with using a different test source and target level though.</p>
<p><a href="https://maven.apache.org/plugins/maven-compiler-plugin/testCompile-mojo.html#testSource">https://maven.apache.org/plugins/maven-compiler-plugin/testCompile-mojo.html#testSource</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 07:49:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1142239058">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>UUIDs are faily common. Aren't we reinventing the wheel by having a "cucumber-id" ? I would prefer to correct the <code>IncrementingUuidGenerator</code> to contain valid specific version/variant bits.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 07:54:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1142246764">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I don't like having specific production code for test purpose only. But ok, I'll change it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 08:15:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1142277194">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I'm not sure how the correct bits would have to be set or what they would be. If you know how, please feel free to do so.</p>
<p>For what I had in mind, instead of having a base16 encoded string representation (<code>123e4567-e89b-12d3-a456-426652340000</code>) we'd use a base 64 encoded version (<code>Ej5FZ+ibEtOkVkJmUjQAAA==</code>). So we safe 12 characters per id.</p>
<p>I suppose that is something that could also be done with UUIDs. But that too is a consideration for a separate issue.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-28 01:59:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1150261462">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>True, this is Java 10, so I reverted.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-28 02:02:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1150265880">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Used package private visibility.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-28 02:04:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1150267212">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Added <code>UUID generateId()</code> method on the interface and a <code>default UUID get()</code> to keep the <code>Supplier&lt;UUID&gt;</code> interface.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-28 02:05:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1150268876">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>The <code>IncrementingUuidGenerator</code> has been refactored to implement specific bits properly (version 8, variant 2).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-28 02:07:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1150271950">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Fully refactored <code>IncrementingUuidGenerator</code> with the following structure:</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-28 02:12:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1150278240">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Done</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-28 02:12:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1150278427">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Done</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-05 10:05:10
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/jkronegg">jkronegg's</a> pull request
<p>Looks good. I'll take care of the last few comments and merge this tomorrow in all likelihood.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-05 10:05:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1158785707">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Suggested change</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-05 10:05:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1158786599">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Can this be made private?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-05 10:41:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1158826426">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Oops, I forgot to update the comment. The version and variant are now stable.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-05 22:06:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2703#discussion_r1159286216">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I the cleaned up the javadoc and made the field private.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-14 13:25:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2704#issuecomment-1468788406">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-16 13:52:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2704#issuecomment-1472723255">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-16 14:40:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2704#issuecomment-1472782789">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2704?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2704?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2704?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2704">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2704?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2704</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/c4e6726108ba563b755c1f2a97b5b78edc49b503">c4e6726</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/29714f6b45c5facb476c75d55136119fa5daf60f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/29714f6b45c5facb476c75d55136119fa5daf60f?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/29714f6b45c5facb476c75d55136119fa5daf60f">29714f6</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2704 +/- ##
=========================================
Coverage 84.68% 84.68%
Complexity 2682 2682
=========================================
Files 322 322
Lines 9449 9449
Branches 899 899
=========================================
Hits 8002 8002
Misses 1120 1120
Partials 327 327
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-16 03:44:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2705#issuecomment-1471712021">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I'd be happy to take a pull request that adds this.</p>
<p>To do this it would probably be best to change the <a href="https://github.com/cucumber/cucumber-jvm/blob/main/cucumber-java/src/codegen/java/GenerateI18n.java">GenerateI18n.java</a> so that in addition to generating a localized annotation for every <code>io.cucumber.java.&lt;lang&gt;</code> it also generates a <code>@Step</code> annotation in the <code>io.cucumber.java</code> package.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 09:40:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2705#issuecomment-1476578531">Comment</a> on issue by <a href="https://github.com/ntthaibk">ntthaibk</a>
<p>hi <a href="https://github.com/mpkorstanje">@mpkorstanje</a>, so I checked the <a href="https://github.com/cucumber/cucumber-jvm/blob/main/cucumber-java/src/codegen/java/GenerateI18n.java">Generatel18n.java</a> today, and found out that actually I need to modify the <a href="https://github.com/cucumber/gherkin-java/blob/main/src/main/groovy/io/cucumber/gherkin/GherkinDialects.gsp">Gherkin Dialect</a> in order to add the <code>@Step</code> for auto generation and I saw the repo already archived, can I send the MR for the archived repo there, thanks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 10:19:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2705#issuecomment-1476638718">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You can find the code for Gherkin in <a href="https://github.com/cucumber/gherkin">cucumber/gherkin</a>. What made you believe it was <a href="https://github.com/cucumber/gherkin-java">cucumber/gherkin-java</a>?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 10:21:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2705#issuecomment-1476642290">Comment</a> on issue by <a href="https://github.com/ntthaibk">ntthaibk</a>
<p>ahh I see, I thought it was gherkin-java after a google search with the keyword GherkinDialect.java</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 12:35:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2705#issuecomment-1476825069">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Btw, updating <code>languages.json</code> is not the right way to go. It will also make <code>Step</code> a valid keyword to use in Gherkin.</p>
<p>I don't think you'd have to change <code>languages.json</code> anyway . There already is the <code>**</code> keyword. However isn't rendered as an annotation because it is an invalid class name and filtered out. You could replace it with something that is valid.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/12c5029592684c3338f98f656b7de90f81cd6f36/cucumber-java/src/codegen/java/GenerateI18n.java#L76-L80">cucumber-jvm/cucumber-java/src/codegen/java/GenerateI18n.java</a></p>
<p>Lines 76 to 80 in </cucumber/cucumber-jvm/commit/12c5029592684c3338f98f656b7de90f81cd6f36|12c5029></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-16 12:00:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2706#issuecomment-1472587141">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 05:36:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2707#issuecomment-1475240902">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Yes. This makes sense. I would agree to Mockito replacements if:</p>
<ol><li>Stubs implementations are declared in the test class.</li><li>Stub implementations are simple.</li>
</ol>
<p>This will likely result in some duplication but that is an acceptable tradeoff.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-17 02:20:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2676#issuecomment-1473492166">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for <em>any</em> future 9.x releases. However, if you upgrade to 9.x manually then Renovate will reenable minor and patch updates automatically.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-19 06:11:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1475251786">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Indeed, in v4.8.1 the implementation of the resource loader could return multiple rerun files located either on the classpath or file system.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/9c957514e1b466b18c0a13186d308d913d1ad4a4/core/src/main/java/io/cucumber/core/model/RerunLoader.java#L26">cucumber-jvm/core/src/main/java/io/cucumber/core/model/RerunLoader.java</a></p>
<p>Line 26 in </cucumber/cucumber-jvm/commit/9c957514e1b466b18c0a13186d308d913d1ad4a4|9c95751></p>
<p>The assumption that rerun files could be on the classpath was complicating things but when removing that I also removed the ability to load more than one file.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/fc0209579597aeaabff7bba22750dc9971c6a275/cucumber-core/src/main/java/io/cucumber/core/options/CucumberPropertiesParser.java#L198-L204">cucumber-jvm/cucumber-core/src/main/java/io/cucumber/core/options/CucumberPropertiesParser.java</a></p>
<p>Lines 198 to 204 in </cucumber/cucumber-jvm/commit/fc0209579597aeaabff7bba22750dc9971c6a275|fc02095></p>
<p>This could be resolved by using the <code>ResourceScanner.scanForResourcesPath</code> but this comes with a relatively complex machine for handling classpath related problems (unpacking jar files).</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/fc0209579597aeaabff7bba22750dc9971c6a275/cucumber-core/src/main/java/io/cucumber/core/resource/ResourceScanner.java#L118">cucumber-jvm/cucumber-core/src/main/java/io/cucumber/core/resource/ResourceScanner.java</a></p>
<p>Line 118 in </cucumber/cucumber-jvm/commit/fc0209579597aeaabff7bba22750dc9971c6a275|fc02095></p>
<p>Using <code>Files.walkFileTree</code> directly would simplify the implementation as rerun files are generated at runtime and should generally not be part of the classpath.</p>
<p>Notes:</p>
<ol><li>Use <code>Files.walkFileTree</code></li><li>Empty directories should not be a failure.</li><li>Add a test case for directories with multiple files.</li>
</ol>
<p><a href="https://github.com/dbfwhitney">@dbfwhitney</a> would you like to submit a PR for this?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 08:05:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1476402337">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p>Would love to <a href="https://github.com/mpkorstanje">@mpkorstanje</a>, but not really sure how. Do you want me to try and change the code? If that's the case I really don't think I have the technical expertise. Could I create a walkFileTreeMethod that calls <code>parseRerunFile</code>?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 10:00:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1476608835">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> really don't know but gave it a shot. Won't commit the code but here's my attempt (not tested). In <code>src/main/java/io/cucumber/core/options/CucumberPropertiesParser.java</code>, created a new method that would replace <code>parseRerunFile</code> method:</p>
<pre><code> private Stream&lt;Collection&lt;FeatureWithLines&gt;&gt; parseRerunFiles(String property) {
if (property.startsWith("@")) {
Path propertyPath = Paths.get(property.substring(1));
if (propertyPath.isDirectory) { // path is a directory
File[] files = new File(propertyPath);
if (files != null &amp;&amp; files.length &gt; 0) {
// parse all files in folder
Files.walkFileTree(Paths.get(path), new SimpleFileVisitor&lt;Path&gt;()) {
return Stream.of(parseFeatureWithLinesFile(rerunFile)); // this probably is not correct
}
} else {
Stream.empty(); // no files in folder
}
} else { // path is a file
return Stream.of(parseFeatureWithLinesFile(rerunFile)); // parse file
}
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 10:12:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1476629180">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You can fork Cucumber JVM on Github, then clone your fork with Git, make and test the changes on your local machine. You can commit and push what ever you like. It won't be released until you've made a pull request.</p>
<p>You may want to read:</p>
<p>• <a href="https://docs.github.com/en/get-started/quickstart/fork-a-repo">https://docs.github.com/en/get-started/quickstart/fork-a-repo</a><br />
-<a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork">https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork</a></p>
<p>Also if this is your first time contributing to opensource check out:</p>
<p>• <a href="https://opensource.guide/how-to-contribute/">https://opensource.guide/how-to-contribute/</a></p>
<p>Though overall it shouldn't be too different from your professional workflow.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 10:37:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1476665780">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p>OK will look tonight. Thx</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 10:43:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1476673808">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers! Appreciated.</p>
<p>Btw, if you're fixing a problem for work, consider doing it on work time. It is the cost of using free software.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 13:52:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1476918912">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p>Have created a draft pr, but not at all sure how to implement <code>walkFileTree</code>. Tried to use existing class <code>PathScanner</code>, but it's not public</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 13:57:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1476924288">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Well, when you're in the project, you can change what you like 😉.</p>
<p>But I do think <code>walkFileTree</code> is the way to go. You could read the tutorial about it. It's a core piece of Java.</p>
<p><a href="https://docs.oracle.com/javase/tutorial/essential/io/walk.html">https://docs.oracle.com/javase/tutorial/essential/io/walk.html</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 20:13:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1477224977">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p>OK <a href="https://github.com/mpkorstanje">@mpkorstanje</a> I gave it another attempt, but at this point I'm kind of grasping at straws. My java knowledge, I would say, is mediocre at best. You might have to give me some more concrete/specific examples of how to proceed.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 05:12:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1477732777">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Ah. That is unfortunate. I or someone else can look at it took but that will take much longer before I'll have time available.</p>
<p>Btw, a quick google search pulls up several tutorials. For example:</p>
<p><a href="https://www.baeldung.com/java-list-directory-files#walking">https://www.baeldung.com/java-list-directory-files#walking</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 10:15:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1478290130">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p>I saw that tutorial. In fact, I used/modified the last one on the page (missed that very last part about not throwing null exception), but not sure if I'm even on the right track. If I am, my sticking points are I don't know how to fix/deal with the <code>Unhandled exception: java.io.IOException</code> on line 83 and whether returning a stream from the walkfile tree is even possible/workable (line 218-219) (both in CucumberPropertiesParser class).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 12:35:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1478473859">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You're making things difficult by nesting everything in a single method.</p>
<p>The tutorial shows a <code>listFilesUsingFileWalkAndVisitor</code> method that returns a set of files. If you use that method in <code>parseRerunFiles</code> the code will be easier to read by you and problems like the one you have now easier to solve.</p>
<p>The <code>parseRerunFiles</code> shouldn't declare any exceptions. You can catch the <code>IOExceptions</code> throw by <code>listFilesUsingFileWalkAndVisitor</code> and wrap it in a <code>RuntimeException</code>. Those don't need to be declared. And we can talk about cleaning that up later.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 12:45:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1478487137">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You'll also want to use the <code>files.stream().map(....)</code> operation to turn all the rerun files into a stream of feature-with-lines collections.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 12:47:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1478488935">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>So far I think you're doing fine btw.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 12:51:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1478493882">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p>OK thanks. Will continue when I get a chance</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-22 13:37:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1480229047">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p>I'm getting closer, but upon reflection I should have initially started with an attempt to describe what's happening in my own words - see if I have a grasp on what's going on (takes me a bit, but I get there eventually).<br />
Original code:<br />
Assuming rerun.txt file contains:</p>
<pre><code>file:src/main/resources/features/feature_1.feature:2:4:6
file:src/main/resources/features/feature_2.feature:14
file:src/main/resources/features/feature_12.feature:8:12
</code></pre>
<pre><code>parseRerunFiles("@target/rerun.txt") {
-&gt; parseFeatureWithLinesFile("target/rerun.txt");
returns something like:
[
file:src/main/resources/features/feature_1.feature&lt;2:4:6&gt;
file:src/main/resources/features/feature_2.feature&lt;14&gt;
file:src/main/resources/features/feature_12.feature&lt;8:12&gt;
]
}
</code></pre>
<p>Now were trying to achieve the same thing, but with rerun files like the original or like this:</p>
<pre><code>rerun_1.txt
file:src/main/resources/features/feature_1.feature:2:4:6
rerun_2.txt
file:src/main/resources/features/feature_2.feature:14
rerun_3.txt
file:src/main/resources/features/feature_12.feature:8:12
</code></pre>
<pre><code>parseRerunFiles("@target" | "@target/rerun.txt") {
-&gt; listRerunFiles("target"); // call to walkfiletree method - according to Baeldung - "the Stream guarantees to return at least one element, the provided file itself"
returns something like:
[
target/rerun_1.txt
target/rerun_2.txt
target/rerun_3.txt
]
-&gt; iterate rerun "list"
-&gt; add to "object" - parseFeatureWithLinesFile("target/rerun_1.txt")
-&gt; add to "object" - parseFeatureWithLinesFile("target/rerun_2.txt")
-&gt; add to "object" - parseFeatureWithLinesFile("target/rerun_3.txt")
and return "object" something like:
[
file:src/main/resources/features/feature_1.feature&lt;2:4:6&gt;
file:src/main/resources/features/feature_2.feature&lt;14&gt;
file:src/main/resources/features/feature_12.feature&lt;8:12&gt;
]
}
</code></pre>
<p>Does that look right?<br />
If that's close, do we need to somehow enforce that multiple "rerun" files and only rerun files must exist in a directory? Eg. path should be <code>@target/rerun</code> and not just <code>@target</code></p>
<p>Also if <code>@target/rerun.txt</code> is param passed in will walkFileTree stop "walking" as soon as it's found?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-22 17:35:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1480425830">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>No worries. Everyone starts with knowing nothing and misunderstanding everything.</p>
<p>And I think you may have misunderstood what <code>parseRerunFiles("@target/rerun.txt")</code> returns.</p>
<p>It actually returns a <code>Stream&lt;Collection&lt;FeatureWithLines&gt;&gt;</code> so that is a second "collection" that holds the first.</p>
<pre><code>[ // The stream
[ // The collection
file:src/main/resources/features/feature_1.feature&lt;2:4:6&gt;
file:src/main/resources/features/feature_2.feature&lt;14&gt;
file:src/main/resources/features/feature_12.feature&lt;8:12&gt;
]
]
</code></pre>
<p>And <code>parseRerunFiles("@target/rerun/")</code> would return a stream with multiple collections in it.</p>
<pre><code>[ // The stream
[ // The collection
file:src/main/resources/features/feature_1.feature&lt;2:4:6&gt;
file:src/main/resources/features/feature_2.feature&lt;14&gt;
file:src/main/resources/features/feature_12.feature&lt;8:12&gt;
], [
// Contents of the second rerun file
], [
// Contents of the third rerun file
]
]
</code></pre>
<p>> If that's close, do we need to somehow enforce that multiple "rerun" files and only rerun files must exist in a directory?</p>
<p>While that would be nice it is not nessesary. The old implementation also assumed all files in a directory would be rerun files. So we can leave that out of scope for this PR.</p>
<p>> Also if @target/rerun.txt is param passed in will walkFileTree stop "walking" as soon as it's found?</p>
<p>I don't know. It might be worth creating a few test cases. Perhaps manual at first. It's okay not to automate your tests when you're still figuring things out. We can discuss how to automate them later.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-22 17:44:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1480430669">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>And looking at the code you wrote I think you did understand do the right thing.</p>
<p>What I'd like for you to do now is anchor the current implementation with a few tests, then refactor the code written so far and maybe we'll discover a few more test cases.</p>
<p>I'll try to write some guidance on where and how to write tests. But I can't do that from phone. So hopefully I can do that tomorrow.</p>
<p>I'll also put future comments in the PR, if will be a bit easier going forward.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-24 12:40:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1483320760">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p>Ok will look at it next week. Other priorities right now.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-24 15:12:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1483491963">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>No worries. Let me know if you have to abandon it. Perhaps someone else can pick up after.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-03 07:54:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2708#issuecomment-1494477803">Comment</a> on issue by <a href="https://github.com/dbfwhitney">dbfwhitney</a>
<p>Sorry about the delay. Think I'm going to have to abandon. Spring is always a busy time of year and don't think I have the time. Thanks for all your guidance <a href="https://github.com/mpkorstanje">@mpkorstanje</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-20 05:03:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2709#issuecomment-1476102542">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Do you have the full stacktrace for:</p>
<pre><code>[WARNING] ForkStarter IOException: Element name cannot be empty
Element name cannot be empty. See the dump file /home/vsts/work/1/s/ui/target/surefire-reports/2023-03-20T06-39-40_033-jvmRun1.dumpstream
</code></pre>
<p>It should be in the dumpstream file.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 00:00:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2709#issuecomment-1477360405">Comment</a> on issue by <a href="https://github.com/carmenloghin">carmenloghin</a>
<p>There is no dumpstream file in the /home/vsts/work/1/s/ui/target/surefire-reports/ folder, only the TEST-RunCucumberTest.xml file.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 05:03:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2709#issuecomment-1477719389">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I suppose you didn't configure your pipeline to capture it. Is the dump file also absent if you reproduce the problem locally? It would help a lot because it would provide the exact line that makes the mistake.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 14:54:43
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2709#issuecomment-1478636163">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Okay. I think I found it.</p>
<p>You most likely have a scenario or feature without a name. For example:</p>
<pre><code>Feature:
Scenario:
Given a calculator I just turned on
When I add 4 and 7
Then the result is 2
</code></pre>
<p>As a work around you can give your scenarios and features a name.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-21 15:38:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2709#issuecomment-1478686492">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Nope. That's not actually it.</p>
<p>Weird thing is, I can get a stack trace, but it's nothing like yours:</p>
<pre><code>java.lang.NullPointerException: Cannot invoke "Object.hashCode()" because "key" is null
at java.base/java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
at io.cucumber.junitxmlformatter.XmlReportData.getFeatureName(XmlReportData.java:207)
at io.cucumber.junitxmlformatter.XmlReportWriter.writeTestCaseAttributes(XmlReportWriter.java:86)
at io.cucumber.junitxmlformatter.XmlReportWriter.writeTestcase(XmlReportWriter.java:77)
at io.cucumber.junitxmlformatter.XmlReportWriter.writeTestsuite(XmlReportWriter.java:45)
at io.cucumber.junitxmlformatter.XmlReportWriter.writeXmlReport(XmlReportWriter.java:34)
at io.cucumber.junitxmlformatter.MessagesToJunitXmlWriter.close(MessagesToJunitXmlWriter.java:60)
</code></pre>
<p>And I do need two failing scenarios in a feature to trigger the problem. Otherwise nothing bad happens at all.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-22 08:59:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2709#issuecomment-1479841415">Comment</a> on issue by <a href="https://github.com/carmenloghin">carmenloghin</a>
<p>I'm not able to see any dump files, neither on Azure nor on the local machine. What I can say is that the issue is reproducing when having at least 2 failing tests (I use 4 tests, 2 which pass and 2 which fails) and the command<br />
<strong>mvn test -Dcucumber.filter.tags="<a href="https://github.com/test">@test</a>" -Dsurefire.rerunFailingTestsCount=1.</strong></p>
<p>My <strong>feature file</strong> looks like this:</p>
<pre><code>@Test
Feature: Test
Scenario: Successfully test
Given that I open the page "<https://github.com/>"
Then the page title is "GitHub: Let’s build from here · GitHub"
Scenario: First unsuccessfully test
Given that I open the page "<https://github.com/>"
Then the page title is "Google"
Scenario: Second unsuccessfully test
Given that I open the page "<https://github.com/>"
Then the page title is "Youtube"
</code></pre>
<p>When I check the TEST-RunCucumberTest.xml I saw, at the end of the file, the same error you've mentioned before:</p>
<pre><code>&lt;testcase name="Cucumber" classname="UI tests" time="5.974"&gt;
&lt;error type="java.lang.NullPointerException"&gt;&lt;![CDATA[java.lang.NullPointerException
at java.base/java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
at io.cucumber.junitxmlformatter.XmlReportData.getFeatureName(XmlReportData.java:207)
at io.cucumber.junitxmlformatter.XmlReportWriter.writeTestCaseAttributes(XmlReportWriter.java:86)
at io.cucumber.junitxmlformatter.XmlReportWriter.writeTestcase(XmlReportWriter.java:77)
at io.cucumber.junitxmlformatter.XmlReportWriter.writeTestsuite(XmlReportWriter.java:45)
at io.cucumber.junitxmlformatter.XmlReportWriter.writeXmlReport(XmlReportWriter.java:34)
at io.cucumber.junitxmlformatter.MessagesToJunitXmlWriter.close(MessagesToJunitXmlWriter.java:60)
at io.cucumber.core.plugin.JUnitFormatter.write(JUnitFormatter.java:35)
at io.cucumber.core.eventbus.AbstractEventPublisher.send(AbstractEventPublisher.java:51)
at io.cucumber.core.eventbus.AbstractEventBus.send(AbstractEventBus.java:12)
at io.cucumber.core.runtime.SynchronizedEventBus.send(SynchronizedEventBus.java:47)
at io.cucumber.core.runtime.CucumberExecutionContext.emitTestRunFinished(CucumberExecutionContext.java:118)
at io.cucumber.core.runtime.CucumberExecutionContext.finishTestRun(CucumberExecutionContext.java:98)
at io.cucumber.junit.platform.engine.CucumberEngineExecutionContext.finishTestRun(CucumberEngineExecutionContext.java:126)
at io.cucumber.junit.platform.engine.CucumberEngineDescriptor.cleanUp(CucumberEngineDescriptor.java:60)
at io.cucumber.junit.platform.engine.CucumberEngineDescriptor.cleanUp(CucumberEngineDescriptor.java:10)
</code></pre>
<p>The error is displayed when I run the maven command from terminal as well.</p>
<p>The generated cucumber.xml is</p>
<pre><code>&lt;?xml version="1.0" encoding="UTF-8"?&gt;
&lt;testsuite name="Cucumber" time="3.606" tests="2" skipped="0" failures="2" errors="0"&gt;
&lt;testcase classname="Test" name="Second unsuccessfully test" time="1.635"&gt;
&lt;failure type="org.opentest4j.AssertionFailedError" message="expected: &lt;Youtube&gt; but was: &lt;GitHub: Let’s build from here · GitHub&gt;"&gt;
&lt;![CDATA[org.opentest4j.AssertionFailedError: expected: &lt;Youtube&gt; but was: &lt;GitHub: Let’s build from here · GitHub&gt;
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)
at steps.TestStepDefinition.thePageTitleIs(TestStepDefinition.java:85)
at ✽.the page title is "Youtube"(file:///Users/xxxx/ui/src/test/java/features/Test.feature:14)
]]&gt;
&lt;/failure&gt;
&lt;system-out&gt;&lt;![CDATA[
Given that I open the page "https://github.com/"............................passed
Then the page title is "Youtube"............................................failed
]]&gt;&lt;/system-out&gt;
&lt;/testcase&gt;
&lt;testcase
</code></pre>
<p>Notice the <strong>testcase</strong> tag is <strong>not closed</strong>.</p>
<p>When I run with the following command: <strong>mvn test -Dcucumber.filter.tags="<a href="https://github.com/test">@test</a>"</strong> then the error is no longer displayed and the cucumber.xml report looks like this:</p>
<pre><code>&lt;?xml version="1.0" encoding="UTF-8"?&gt;
&lt;testsuite name="Cucumber" time="11.511" tests="3" skipped="0" failures="2" errors="0"&gt;
&lt;testcase classname="Test" name="Successfully test" time="7.783"&gt;
&lt;system-out&gt;&lt;![CDATA[
Given that I open the page "https://github.com/"............................passed
Then the page title is "GitHub: Let’s build from here · GitHub".............passed
]]&gt;&lt;/system-out&gt;
&lt;/testcase&gt;
&lt;testcase classname="Test" name="First unsuccessfully test" time="1.728"&gt;
&lt;failure type="org.opentest4j.AssertionFailedError" message="expected: &lt;Google&gt; but was: &lt;GitHub: Let’s build from here · GitHub&gt;"&gt;
&lt;![CDATA[org.opentest4j.AssertionFailedError: expected: &lt;Google&gt; but was: &lt;GitHub: Let’s build from here · GitHub&gt;
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)
at steps.TestStepDefinition.thePageTitleIs(TestStepDefinition.java:85)
at ✽.the page title is "Google"(file:///Users/xxxx/ui/src/test/java/features/Test.feature:10)
]]&gt;
&lt;/failure&gt;
&lt;system-out&gt;&lt;![CDATA[
Given that I open the page "https://github.com/"............................passed
Then the page title is "Google".............................................failed
]]&gt;&lt;/system-out&gt;
&lt;/testcase&gt;
&lt;testcase classname="Test" name="Second unsuccessfully test" time="1.736"&gt;
&lt;failure type="org.opentest4j.AssertionFailedError" message="expected: &lt;Youtube&gt; but was: &lt;GitHub: Let’s build from here · GitHub&gt;"&gt;
&lt;![CDATA[org.opentest4j.AssertionFailedError: expected: &lt;Youtube&gt; but was: &lt;GitHub: Let’s build from here · GitHub&gt;
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)
at steps.TestStepDefinition.thePageTitleIs(TestStepDefinition.java:85)
at ✽.the page title is "Youtube"(file:///Users/xxxxx/ui/src/test/java/features/Test.feature:14)
]]&gt;
&lt;/failure&gt;
&lt;system-out&gt;&lt;![CDATA[
Given that I open the page "https://github.com/"............................passed
Then the page title is "Youtube"............................................failed
]]&gt;&lt;/system-out&gt;
&lt;/testcase&gt;
&lt;/testsuite&gt;
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-22 09:39:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2709#issuecomment-1479907676">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers. Then I think I've got it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 05:31:31
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/dbfwhitney">dbfwhitney's</a> pull request
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 05:40:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2710#issuecomment-1506894826">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/dbfwhitney">@dbfwhitney</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 05:42:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2710#issuecomment-1506898077">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><a href="https://github.com/dbfwhitney">@dbfwhitney</a> thanks for the first setup.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-22 01:55:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2712#issuecomment-1479133303">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Can you tell me what documentation you've read that makes you believe this should work?</p>
<p>For instance if you are using the <code>cucumber-junit-platform-engine</code> then <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine#tags">the documentation suggests using</a> <code>mvn verify -DexcludedGroups="Ignore" -Dgroups="Smoke | Sanity"</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-22 07:20:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2712#issuecomment-1479652171">Comment</a> on issue by <a href="https://github.com/ndagnhat">ndagnhat</a>
<p>I see that in ‘cucumber with serenity’ document. I should not log issue on this project. I will close it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-23 14:33:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2713#issuecomment-1481942686">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2713?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2713?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2713?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2713">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2713?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2713</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/9418905321ad8832cf96cb721ff7c212d6b76a5c">9418905</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/c7712fc8b5afa12536cf6e786348b691ddf5d63a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/c7712fc8b5afa12536cf6e786348b691ddf5d63a?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/c7712fc8b5afa12536cf6e786348b691ddf5d63a">c7712fc</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2713 +/- ##
=========================================
Coverage 84.69% 84.69%
Complexity 2685 2685
=========================================
Files 323 323
Lines 9456 9456
Branches 899 899
=========================================
Hits 8009 8009
Misses 1120 1120
Partials 327 327
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-28 14:13:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2716#issuecomment-1487599519">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> GuiceFactory.stop needs a null check to avoid NullPointerException</p>
<p>Agreed. Would you like to send a pull request for this?</p>
<p>> the cleanup code in Runner should ideally also suppress exceptions and add them to the root cause exception (using <a href="https://docs.oracle.com/javase/7/docs/api/java/lang/Throwable.html#addSuppressed%28java.lang.Throwable%29|Throwable.addSuppressed">https://docs.oracle.com/javase/7/docs/api/java/lang/Throwable.html#addSuppressed%28java.lang.Throwable%29|Throwable.addSuppressed</a>).</p>
<p>That's a bit trickier. I'll have to look for a good solution.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-29 00:58:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2717#issuecomment-1488115324">Comment</a> on issue by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>Hi <a href="https://github.com/ashwinth28">@ashwinth28</a>,<br />
Please use the <a href="https://cucumber.io/support">support</a> forums for questions and discussions. We'll be happy to help you there. We use GitHub issues to track bugs and contributions exclusively.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-29 13:19:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2717#issuecomment-1489250388">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>And to add a little bit to that. The problem you're having isn't with Cucumber but rather with Selenium. You may have more luck asking there.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-29 23:16:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2717#issuecomment-1489755525">Comment</a> on issue by <a href="https://github.com/ashwinth28">ashwinth28</a>
<p>Thank you Mr.<a href="https://github.com/mpkorstanje">@mpkorstanje</a> 🙂</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-02 05:59:36
*Thread Reply:*
Reviewed and changes requested by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/atdd-bdd">atdd-bdd's</a> pull request
<p>Hi! Thanks for helping to improve the documentation.</p>
<p>Unfortunately the parts you have added are also partially covered by the "Data Table Type" section. So this looks a bit redundant.</p>
<p>I also can't quite see what it is that you found lacking just from your additions so I can't suggest a better way for you to convey this. Perhaps you can explain what you found lacking first.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-02 06:07:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2718#issuecomment-1493327541">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I did add <a href="https://github.com/cucumber/cucumber-jvm/commit/50617424832b2f30fa9ff02b96847d24a1cb3f79">5061742</a> to improve the connection between the two sections of the docs and unpaxked that other primitives can be used.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-04 13:31:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2718#issuecomment-1496566969">Comment</a> on pull request by <a href="https://github.com/atdd-bdd">atdd-bdd</a>
<p>> I did add <a href="https://github.com/cucumber/cucumber-jvm/commit/50617424832b2f30fa9ff02b96847d24a1cb3f79">5061742</a> to improve the connection between the two sections of the docs and unpaxked that other primitives can be used.</p>
<p>> Hi! Thanks for helping to improve the documentation.
>
> Unfortunately the parts you have added are also partially covered by the "Data Table Type" section. So this looks a bit redundant.
>
> I also can't quite see what it is that you found lacking just from your additions so I can't suggest a better way for you to convey this. Perhaps you can explain what you found lacking first.</p>
<p>The issue is that the section on data tables does not show an example of transforming a datatable to a List. That's a common operation. (I know that many people had issues when the way tables were processed changed in 4.0 (I believe), when the Jackson stuff was added).</p>
<p>So having an example, using the default transformations, would show people that how it can be done simply. The example come from the introduction to Gherkin. (<a href="https://cucumber.io/docs/gherkin/reference/">https://cucumber.io/docs/gherkin/reference/</a>). Showing how to code that would be quite useful.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-17 06:56:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2718#issuecomment-1511403436">Comment</a> on pull request by <a href="https://github.com/atdd-bdd">atdd-bdd</a>
<p>There are two separate pages that talk about data tables. One shows up as <a href="https://cucumber.io/docs/cucumber/api/?lang=java">https://cucumber.io/docs/cucumber/api/?lang=java</a></p>
<p>These changes are for this one. If I've applied this to the wrong source, let me know. The purpose is to show that data tables can be used for a list of objects, which is a common way to use them.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-23 04:33:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2718#issuecomment-1519042643">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> There are two separate pages that talk about data tables. One shows up as <a href="https://cucumber.io/docs/cucumber/api/?lang=java">https://cucumber.io/docs/cucumber/api/?lang=java</a></p>
<p>That particular bit of documentation from the docs site comes from here: <a href="https://github.com/cucumber/docs/blob/main/content/docs/cucumber/api.md#data-tables">https://github.com/cucumber/docs/blob/main/content/docs/cucumber/api.md#data-tables</a>. Though bear in mind that my comments from <a href="https://github.com/cucumber/cucumber-jvm/pull/2720">#2720</a> would also apply. So you may avoid some duplication by leaving the docs as they are. There is already a link to the <code>cucumber-java/README.md</code> so people can find the more advanced transforms if they need them.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-24 08:06:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2718#issuecomment-1520356921">Comment</a> on pull request by <a href="https://github.com/atdd-bdd">atdd-bdd</a>
<p>The document e: <a href="https://github.com/cucumber/docs/blob/main/content/docs/cucumber/api.md#data-tables">https://github.com/cucumber/docs/blob/main/content/docs/cucumber/api.md#data-tables</a>. is a little harder for me to update, since it has kotlin and scala parts, and I don't know whether the same default transformations are available for them. Is that the case?</p>
<p>My point in making some change is to show how the example in <a href="https://cucumber.io/docs/gherkin/reference/">https://cucumber.io/docs/gherkin/reference/</a></p>
<p>Given the following users exist:<br />
| name | email | twitter |<br />
| Aslak | <a href="mailto:aslak@cucumber.io">aslak@cucumber.io</a> | @aslak_hellesoy |<br />
| Julien | <a href="mailto:julien@cucumber.io">julien@cucumber.io</a> | <a href="https://github.com/jbpros">@jbpros</a> |<br />
| Matt | <a href="mailto:matt@cucumber.io">matt@cucumber.io</a> | <a href="https://github.com/mattwynne">@mattwynne</a> |</p>
<p>can be coded using the default transformations (that ten lines of code). I think this should be prominently displayed with the mention of data tables, as an equal of converting to List. More complex transformations can be shown elsewhere (e.g. converting each entry separately).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-28 07:59:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2718#issuecomment-1527697441">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> The document e: <a href="https://github.com/cucumber/docs/blob/main/content/docs/cucumber/api.md#data-tables">https://github.com/cucumber/docs/blob/main/content/docs/cucumber/api.md#data-tables</a>. is a little harder for me to update, since it has kotlin and scala parts, and I don't know whether the same default transformations are available for them. Is that the case?</p>
<p>For Kotlin, and Scala it depends. If they're using <code>cucumber-java</code> yes. For Scala, you can find the documentation here: <a href="https://github.com/cucumber/cucumber-jvm-scala/blob/main/docs/datatables.md">https://github.com/cucumber/cucumber-jvm-scala/blob/main/docs/datatables.md</a></p>
<p>> My point in making some change is to show how the example in <a href="https://cucumber.io/docs/gherkin/reference/">https://cucumber.io/docs/gherkin/reference/</a></p>
<p>That is reasonable. You can either open a pull request against docs now or wait until you've finished <a href="https://github.com/cucumber/cucumber-jvm/pull/2720">#2720</a>. Since both should be relatively comparable I think waiting for the later to be done would make sense.</p>
<p>Either way, I'll close this one for now.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-31 08:20:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2719#issuecomment-1492112082">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Seems acceptable. The message protocol must be updated to include this information. Messages are generated from a schema definition in <a href="https://github.com/cucumber/messages">https://github.com/cucumber/messages</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-07 06:28:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2719#issuecomment-1500289368">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><a href="https://github.com/jkronegg">@jkronegg</a> you can branch of from <a href="https://github.com/cucumber/cucumber-jvm/pull/2727">#2727</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-03-31 12:02:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2720#issuecomment-1492457032">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Hi! Thanks for looking to improve the docs. Unfortunately there already is a section about using lists of objects. It's under the "Data Table Type" heading.</p>
<p>Perhaps you could integrate what you're missing there. It might just need to be a reference to that section from the data tables section.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-04 13:35:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2720#issuecomment-1496572355">Comment</a> on pull request by <a href="https://github.com/atdd-bdd">atdd-bdd</a>
<p>> Hi! Thanks for looking to improve the docs. Unfortunately there already is a section about using lists of objects. It's under the "Data Table Type" heading.
>
> Perhaps you could integrate what you're missing there. It might just need to be a reference to that section from the data tables section.</p>
<p>I've rearranged the entire page. All the details about parameter, data table, and doc string transformations are all together.<br />
That allowed taking out the duplicate code for default transformations.</p>
<p>The problem with the previous arrangement was that data tables appeared in two different places in the page. Therefore, one read the first example and didn't see the 2nd one.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 04:36:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2720#issuecomment-1506810498">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers! Sorry for the delayed reaction, this is one of the more complicated PRs so it's a bit harder to find a long enough block of free spare time to review it.</p>
<p>First I think there is a small conceptual misunderstanding.</p>
<p>Cucumber supports transforming data tables to these collections of <code>String</code> out of the box:</p>
<pre><code> ** `List&lt;List&lt;String&gt;&gt; table`
** `List&lt;Map&lt;String, String&gt;&gt; table`
** `Map&lt;String, String&gt; table`
** `Map&lt;String, List&lt;String&gt;&gt; table`
** `Map&lt;String, Map&lt;String, String&gt;&gt; table`
</code></pre>
<p>(As an aside, I think <code>List&lt;String&gt;</code> also works, not sure why it's missing).</p>
<p>You may consider these views on the table.</p>
<p>Cucumber then also supports:</p>
<pre><code> ** `List&lt;T&gt; table`
** `List&lt;Map&lt;K, V&gt;&gt; table`
** `Map&lt;K, V&gt; table`
** `Map&lt;K, List&lt;V&gt;&gt; table`
** `Map&lt;K1, Map&lt;K2, V&gt;&gt; table`
</code></pre>
<p>Which will transform the contents of the table into an arbitrary object if there is a data table type defined for that objects type. We can call these transforms.</p>
<p>So it is not quite right to say that views on the table includes <code>List&lt;Class&gt; table</code> isn't quite right. It is not a view, and also not the only transform.</p>
<p>The second problem I've got when reading the current version is that data tables are introduced as part of the transformers. However data tables and doc strings are perfectly usable on their own and should be introduced separately from their transforms. If it helps I would accept a version that introduce the data table and doc string first but only reference the <code>DataTable</code> and <code>DocString</code> objects leaving out the views and transforms for the transformation section.</p>
<p>It might also be reasonable to split the Parameter types for Cucumber expressions, from those of DocStrings and Datatables. So the outline could roughly look like:</p>
<p>• Step definitions
• Cucumber expressions
• What is / How to use
• Parameter Types
• Data Tables
• What is / How to use
• Transforming tables
• The views
• The transforms
• Transposing tables
• Doc Strings
• What is / How to use
• Transforming doc strings</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 04:37:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2720#issuecomment-1506814023">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I also keep confusing this PR with <a href="https://github.com/cucumber/cucumber-jvm/pull/2718">#2718</a>. Should this one supersede the other?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-17 07:13:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2720#issuecomment-1511439399">Comment</a> on pull request by <a href="https://github.com/atdd-bdd">atdd-bdd</a>
<p>I'll work on matching your outline. I think it makes things clearer.</p>
<p>The distinction between views and transforms is subtle. I get your point that views are different than transforms, as no string to object methods are needed.</p>
<p>If there is a default transformation in place, then it no additional code is necessary to transform objects, so that it works as a view.</p>
<p>You mentioned previously that you tend to use the default transformations. I think the documentation should make it clear that doing that simplifies the code. Creating explicit transformers could be done if more control was needed.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-17 07:20:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2720#issuecomment-1511453820">Comment</a> on pull request by <a href="https://github.com/atdd-bdd">atdd-bdd</a>
<p>I also keep confusing this PR with <a href="https://github.com/cucumber/cucumber-jvm/pull/2718">#2718</a>. Should this one supersede the other?</p>
<p>That one is for a different page. It introduces a list of objects that matches the example in the introductory page.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-23 04:26:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2720#issuecomment-1519041239">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers! Since both influence <code>cucumber-java/README.md</code> could you merge your improvements? Makes reviewing things a bit easier.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-24 08:22:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2720#issuecomment-1520383050">Comment</a> on pull request by <a href="https://github.com/atdd-bdd">atdd-bdd</a>
<p>Now I'm a little confused. It's not clear to me how " both influence cucumber-java/README.md could you merge your improvements". I may have misunderstood that I was changing the same page. But I thought I was changing two different pages.</p>
<p>In what appears on: <a href="https://cucumber.io/docs/cucumber/api/?lang=java">https://cucumber.io/docs/cucumber/api/?lang=java</a><br />
I think there should be an example of how to code the introductory example of what is on <a href="https://cucumber.io/docs/gherkin/reference/">https://cucumber.io/docs/gherkin/reference/</a> At least for java. It would not have the ten lines of default transformation code (which would be on the linked page (cucumber-java) ). So this would just be an addition to the Data Table entry by breaking it into two parts - Strings and objects. Reason - one should show how to do the introductory example.</p>
<p>Then in what appears on: <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-java#data-tables">https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-java#data-tables</a> the page could be revised per your outline. This is where the other variations of transformations could be shown.<br />
List table`</p>
<p>• <code>List&lt;Map&lt;K, V&gt;&gt; table</code>
• <code>Map&lt;K, V&gt; table</code>
• <code>Map&lt;K, List&lt;V&gt;&gt; table</code>
• <code>Map&lt;K1, Map&lt;K2, V&gt;&gt; table</code><br />
I don't think they appear anywhere in the documentation.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-28 08:09:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2720#issuecomment-1527713167">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> Now I'm a little confused. It's not clear to me how " both influence cucumber-java/README.md could you merge your improvements". I may have misunderstood that I was changing the same page. But I thought I was changing two different pages.</p>
<p>Ah. So both <a href="https://github.com/cucumber/cucumber-jvm/pull/2720/files#diff-5a597f444ed51f201a83c033b03653e17bce6b77761a0382e594a6c44c9a9d42">this change</a> in <a href="https://github.com/cucumber/cucumber-jvm/pull/2720">#2720</a> and <a href="https://github.com/cucumber/cucumber-jvm/pull/2718/files#diff-5a597f444ed51f201a83c033b03653e17bce6b77761a0382e594a6c44c9a9d42">this change</a> in <a href="https://github.com/cucumber/cucumber-jvm/pull/2718">#2718</a> go into the same file name <code>cucumber-java/README.md</code> in the <code>cucumber-jvm</code> repo. You'probably meant to change the <a href="https://github.com/cucumber/docs/blob/main/content/docs/cucumber/api.md#data-tables"><code>content/docs/cucumber/api.md</code> in the <code>docs</code> repo</a>.</p>
<p>> I don't think they appear anywhere in the documentation.</p>
<p>No you are absolutely right. That part is explained a bit more in the <a href="https://github.com/cucumber/cucumber-jvm/tree/main/datatable"><code>datatable/README.md</code></a> but there is no comprehensive explanation that explains everything end-to-end. So I would very much appreciate it if you were to write it. Please also feel free to update the <code>datatable/README.md</code> if that helps. Though it should still remain somewhat technology agnostic. <code>cucumber-jvm-scala</code> for example should also be able to refer to it.</p>
<p>> So this would just be an addition to the Data Table entry by breaking it into two parts - Strings and objects. Reason - one should show how to do the introductory example.<br />
> ...<br />
> Then in what appears on: <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-java#data-tables">https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-java#data-tables</a> the page could be revised per your outline.</p>
<p>That sounds quite reasonable.</p>
<p>PS: Please don't be disheartened by my irregular replies. While I can do quite a few things on my phone in an idle moment, reviewing documentation changes doesn't work so well. So for those I need to find a bigger time-slot. These are unfortunately a bit scarce.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-05 05:35:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2721#issuecomment-1497415548">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> Is it possible to support FeatureScoped?</p>
<p>No. Cucumber is designed with the assumption that scenarios are independent from each other.</p>
<p>And in principle you should design your tests to be independent from each other. This may mean logging in for each scenario. This may mean re-starting your application for each scenario. This may mean creating fresh data for each scenario.</p>
<p>This may seem wasteful, especially if you have written manual test scripts before, but with automation it should be fast enough that you can afford the independent test executions.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-05 09:55:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2722#issuecomment-1497826097">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You can use the <code>Main</code> method. It is documented <a href="https://cucumber.io/docs/cucumber/api/?lang=java#running-cucumber">on the documentation website</a>. This documentation assumes you're familiar with Java. If not, then I can't help you.</p>
<p>Beware that if you're going to make a fat jar, <a href="https://github.com/cucumber/cucumber-jvm/issues/2689">you'll have to do it properly</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-05 14:04:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2723#issuecomment-1498158803">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>This doesn't look like a Cucumber issue. So you should ask your question in the Slack channel, see <a href="https://cucumber.io/docs/community/get-in-touch/">https://cucumber.io/docs/community/get-in-touch/</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-05 20:35:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2723#issuecomment-1498445454">Comment</a> on issue by <a href="https://github.com/SakthiIsaiBharathi">SakthiIsaiBharathi</a>
<p>I am just looking for suggestions.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 06:40:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#issuecomment-1499082767">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2725?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2725?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2725?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2725">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2725?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2725</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/3d6198756ee1b73760742044b9586f09e5c73fe3">3d61987</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/50617424832b2f30fa9ff02b96847d24a1cb3f79?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/50617424832b2f30fa9ff02b96847d24a1cb3f79?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/50617424832b2f30fa9ff02b96847d24a1cb3f79">5061742</a>) will <strong>decrease</strong> coverage by <code>0.01%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2725 +/- ##
============================================
- Coverage 84.69% 84.69% -0.01%
Complexity 2685 2685
============================================
Files 323 323
Lines 9456 9455 -1
Branches 899 898 -1
============================================
- Hits 8009 8008 -1
Misses 1120 1120
Partials 327 327
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 07:37:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#discussion_r1159888481">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>How does this interact with transitive dependencies?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 12:37:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#discussion_r1160180757">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Just fine because <code>addClass</code> is recursive.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 12:42:37
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/jkronegg">jkronegg's</a> pull request
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 12:53:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#discussion_r1160192389">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>This will break step definitions that implement the <code>Startable</code> because the factory is no longer stopped/started at the right moment..</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 12:57:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#discussion_r1160195301">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>What about doing the <code>pico.start()</code> only once in <code>PicoFactory.start()</code> ?</p>
<pre><code>private boolean firstTime = true;
public void start() {
if (firstTime) {
this.pico.start();
firstTime = false;
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 13:02:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#discussion_r1160200026">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>And it doesn't because flushing from cache also invokes the life cycle methods.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 13:02:17
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/jkronegg">jkronegg's</a> pull request
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 13:06:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#issuecomment-1499554110">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><a href="https://github.com/jkronegg">@jkronegg</a> I can't find flaw this with MR. But it bothers me that we can simply skip invoking the life cycle methods on pico container and still see the same effect. Could you provide a brief rationale why this works? Or if brief takes up too much time, a slightly longer explanation is fine too.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 13:36:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#issuecomment-1499593379">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>> Could you provide a brief rationale why this works?</p>
<p>I tried to use the <code>stop()</code> and <code>dispose()</code> methods, with the hope that it will delete the instances but keep the class metadata: not only the instances are kept, but the the picocontainer stays in "stopped" or "disposed" mode and I was not able to restart it. I think this is because the pico lifecycle manager is only dispatching <code>stop()</code> and <code>dispose()</code> commands, but as they are not implemented, there is no effect. It's only on the container itself (on which the handlers are defined) that an effect can be seen.</p>
<p>As the picocontainer has been created "withCaching", my second trial was to look for a cache eviction method, but I could not find one.</p>
<p>My third approach (in this MR) is to remove the instances held by the <code>Cached</code> pico component adapters, in order to make the adapter think that the instances are not yet created. Fortunately, I found the <code>Cached.flush()</code> method and by chance it removes the instance. The <code>DefaultPicoContainer</code> has several collections that hold the pico adapters, so I empirically use the <code>getComponentAdapters()</code> method because it avoids casting. The method returns a pseudo immutable collection (the collection cannot be modified but the <code>Cached</code> objects are not themselves immutable), which explain why the component adapter cache can be flushed.</p>
<p>Then I ran the <code>PicoFactoryTest</code> and was happy to see that everything was already tested. Then I ran it on my usual project (which has a <code>TestContext</code> data object which is shared between 4-5 class files which define the cucumber steps) : as everything ran correctly, I supposed that the trick works properly.</p>
<p>I must admit : there is a part of empirical/brute force in the approach, I'm no picocontainer expert, and I was also surprised that it worked without much effort (it's only about 1 hour of work)😅.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-06 13:54:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#issuecomment-1499614737">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Mmh. I suppose because we are not using nested containers and only components, we can get away with skipping the lifecycle for the containers.</p>
<p>But I'm going to let this MR sit until I have some more time to look into Pico Containers features. Pico Container is one of the more common DI containers for Cucumber and has been around for a long time. There is a fair chance it is subject to Hyrum's Law.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-07 06:10:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2725#issuecomment-1500276708">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Okay. I think this is mostly fine because</p>
<ol><li>All added classes and their constructor dependencies are made into components</li><li>All components go through their life cycle hooks.</li><li>The internal state of the PicoFactory before and after each stop/start is the same.</li>
</ol>
<p>One case where Hyrum might come and bite us is the order in which the components are shut down.Pico Container does this in a specific order:</p>
<pre><code> private void stopAdapters() {
for (int i = getOrderedComponentAdapters().size() - 1; 0 &lt;= i; i--) {
ComponentAdapter&lt;?&gt; adapter = getOrderedComponentAdapters().get(i);
if (adapter instanceof ComponentLifecycle) {
ComponentLifecycle&lt;?&gt; componentLifecycle = (ComponentLifecycle&lt;?&gt;)adapter;
if (componentLifecycle.componentHasLifecycle() &amp;&amp; componentLifecycle.isStarted()) {
componentLifecycle.stop(DefaultPicoContainer.this);
}
}
}
}
</code></pre>
<p>This order appears to be the reverse order in which components are defined. But because we define from a unordered collection this should be fine there too.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/b182cf876a7f44bca7aa4583deefbaa3c4658c44/cucumber-picocontainer/src/main/java/io/cucumber/picocontainer/PicoFactory.java#L16-L34">cucumber-jvm/cucumber-picocontainer/src/main/java/io/cucumber/picocontainer/PicoFactory.java</a></p>
<p>Lines 16 to 34 in </cucumber/cucumber-jvm/commit/b182cf876a7f44bca7aa4583deefbaa3c4658c44|b182cf8></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-07 06:28:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2727#issuecomment-1500289266">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-07 06:38:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2727#issuecomment-1500297194">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2727?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2727?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2727?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2727">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2727?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2727</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/a51f6ed02c82fb1188f97f3ac0066075142d9819">a51f6ed</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/b182cf876a7f44bca7aa4583deefbaa3c4658c44?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/b182cf876a7f44bca7aa4583deefbaa3c4658c44?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b182cf876a7f44bca7aa4583deefbaa3c4658c44">b182cf8</a>) will <strong>increase</strong> coverage by <code>0.04%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2727 +/- ##
============================================
+ Coverage 84.98% 85.02% +0.04%
- Complexity 2723 2734 +11
============================================
Files 330 330
Lines 9556 9570 +14
Branches 916 917 +1
============================================
+ Hits 8121 8137 +16
Misses 1111 1111
+ Partials 324 322 -2
</code></pre>
<p>... and <https://codecov.io/gh/cucumber/cucumber-jvm/pull/2727/indirect-changes?src=pr&el=tree-more&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|1 file with indirect coverage changes></p>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-11 04:39:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2728#issuecomment-1503169745">Comment</a> on pull request by <a href="https://github.com/timtebeek">timtebeek</a>
<p>You'll want to run <code>mvn spotless:apply</code> locally to fix the format violations, and then commit the results.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-11 05:19:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2728#discussion_r1162734715">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Pretty good job on reconstructing the original sentence. But this is the Javadoc of io.cucumber.core.options.Constants so telling people to look there for details isn't quite right.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-12 09:29:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2728#issuecomment-1505576743">Comment</a> on pull request by <a href="https://github.com/vishesh10">vishesh10</a>
<p>Apologies for the recent operation. I am trying to figure out how to correct this.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-12 14:37:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2728#issuecomment-1505983450">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>No worries. If you can't reopen, try making a new branch from the old one.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-11 04:36:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2690#issuecomment-1503166184">Comment</a> on issue by <a href="https://github.com/vishesh10">vishesh10</a>
<p>Hi <a href="https://github.com/mpkorstanje">@mpkorstanje</a>,<br />
I have added a PR for this issue. Can you please have a look.<br />
Thanks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-11 11:47:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2729#issuecomment-1503913581">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers!</p>
<p>How did you generate these files. Unfortunately because this is a binary file I'll have to regenerate it to see if the results match.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-12 00:44:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2729#issuecomment-1504816012">Comment</a> on pull request by <a href="https://github.com/bmscomp">bmscomp</a>
<p>Hello <a href="https://github.com/mpkorstanje">@mpkorstanje</a> , I used to maven command <code>mvn wrapper:wrapper</code></p>
<p>Thanks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 04:05:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2729#issuecomment-1506771601">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/bmscomp">@bmscomp</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 04:05:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2729#issuecomment-1506771720">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-12 08:42:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2731#issuecomment-1505500407">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/Shayan418">@Shayan418</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-12 08:42:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2731#issuecomment-1505500588">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-12 14:30:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2732#issuecomment-1505975481">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>The settings in <code>build.gradle</code> override the settling from <code>junit-platform.properties</code>. So your plugin configuration doesn't take effect.</p>
<p><a href="https://github.com/bachhavdipak/CucumberJunit5/blob/9f5cbf7e21d81cd88c77d5ea0555bb0ed29db5ce/build.gradle.kts#L42-L52">https://github.com/bachhavdipak/CucumberJunit5/blob/9f5cbf7e21d81cd88c77d5ea0555bb0ed29db5ce/build.gradle.kts#L42-L52</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 03:22:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2733#issuecomment-1506719989">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Hi! This is the issue tracker of an open source project. We use this for bugs and feature requests. The project is mostly developed by volunteers in their spare time. It is not the right place to ask for help.</p>
<p>Additionally when asking for help from complete strangers you should at least make it easy for them to answer your question. You may want to read <a href="https://stackoverflow.com/help/how-to-ask">this and the linked pages</a> for a better understanding.</p>
<p>Duplicate of <a href="https://github.com/cucumber/cucumber-jvm/issues/2723">#2723</a>, <a href="https://github.com/cucumber/cucumber-jvm/issues/2722">#2722</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 03:50:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2733#issuecomment-1506752873">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>That said, the SmartBear forums are pretty much dead. You would be better of asking on Stackoverflow or Slack.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 05:45:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-java-skeleton/issues/79#issuecomment-1506902765">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>As the README says: </p>
<p><a href="https://github.com/cucumber/cucumber-java-skeleton/blob/d262b8dc017d01db5425c9b3727e411e36c32498/README.md?plain=1#L3-L8">cucumber-java-skeleton/README.md</a></p>
<p>Lines 3 to 8 in </cucumber/cucumber-java-skeleton/commit/d262b8dc017d01db5425c9b3727e411e36c32498|d262b8d></p>
<p>So this all is expected:</p>
<pre><code>RunCucumberTest &gt; Cucumber &gt; Belly &gt; io.cucumber.skeleton.RunCucumberTest.Belly - a few cukes FAILED
io.cucumber.junit.platform.engine.UndefinedStepException: The step 'I wait 1 hour' and 1 other step(s) are undefined.
You can implement these steps using the snippet(s) below:
@When("I wait {int} hour")
public void i_wait_hour(Integer int1) {
// Write code here that turns the phrase above into concrete actions
throw new io.cucumber.java.PendingException();
}
@Then("my belly should growl")
public void my_belly_should_growl() {
// Write code here that turns the phrase above into concrete actions
throw new io.cucumber.java.PendingException();
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber/cucumber-java-skeleton</a>
GitHub
2023-04-13 05:46:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-java-skeleton/issues/79#issuecomment-1506905396">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I can see it getting a bit lost in the other output though, so it may be worth reconsidering the "failing test example" approach.</p>
<a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber/cucumber-java-skeleton</a>
GitHub
2023-04-13 16:15:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2734#discussion_r1166117610">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>There appear to be some dots here.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-13 16:15:28
*Thread Reply:*
Reviewed and changes requested by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/vishesh10">vishesh10's</a> pull request
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 12:41:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2734#issuecomment-1509132608">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2734?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2734">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2734?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2734</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/fc53bd03b7b68f533d5497c5e65267e4cfe5cd65">fc53bd0</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/654cafc95121d6e53c6d06d59ecca464d5df523a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/654cafc95121d6e53c6d06d59ecca464d5df523a?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/654cafc95121d6e53c6d06d59ecca464d5df523a">654cafc</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2734 +/- ##
=========================================
Coverage 85.01% 85.01%
Complexity 2726 2726
=========================================
Files 331 331
Lines 9561 9561
Branches 914 914
=========================================
Hits 8128 8128
Misses 1110 1110
Partials 323 323
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 12:49:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2734#issuecomment-1509146576">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers. Looks good!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 12:50:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2734#issuecomment-1509148960">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<https://github.com/cucumber/cucumber-jvm/pull/2734|#2734 [Core] Fix unfinished sentence in Javadoc>
<p>Hi <a href="https://github.com/vishesh10">@vishesh10</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2309#issuecomment-1508179960">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2279#issuecomment-1508179941">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2108#issuecomment-1508179986">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:43
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/1871#issuecomment-1508180012">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2450#issuecomment-1508180044">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2439#issuecomment-1508180075">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/1829#issuecomment-1508180104">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2435#issuecomment-1508180125">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 03:04:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2435#issuecomment-1508268879">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Superseded by <a href="https://github.com/cucumber/cucumber-jvm/issues/2705">#2705</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2370#issuecomment-1508180153">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2409#issuecomment-1508180182">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-29 09:47:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2409#issuecomment-1528827436">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>See: <a href="https://github.com/cucumber/cucumber-jvm/commit/f507c4cfdd06b6a2cc1473eb7172b05e0b7932d6">f507c4c</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2383#issuecomment-1508180205">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2324#issuecomment-1508180224">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2215#issuecomment-1508180240">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2216#issuecomment-1508180267">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2054#issuecomment-1508180296">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 01:59:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/1921#issuecomment-1508180344">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 07:48:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2606#issuecomment-1508695297">Comment</a> on issue by <a href="https://github.com/srimanmittapally5">srimanmittapally5</a>
<p>It is solved by providing the right path of <strong>features</strong> directory.<br />
<strong>For Example</strong>: "src/test/resources/features"</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 11:11:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2735#issuecomment-1509043001">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<https://github.com/cucumber/cucumber-jvm/pull/2735|#2735 Add entry for vscode editor on .gitignore>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2735?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2735?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2735?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2735">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2735?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2735</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/4eb47bc4a6ccbae135da8a6eefd737e4ee37374e">4eb47bc</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/d513bac7a3f25f79183387cd4949b53536968b16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/d513bac7a3f25f79183387cd4949b53536968b16?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/d513bac7a3f25f79183387cd4949b53536968b16">d513bac</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2735 +/- ##
=========================================
Coverage 85.01% 85.01%
Complexity 2726 2726
=========================================
Files 331 331
Lines 9561 9561
Branches 914 914
=========================================
Hits 8128 8128
Misses 1110 1110
Partials 323 323
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 11:23:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2736#issuecomment-1509054685">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2736?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2736?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2736?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2736">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2736?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2736</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/0402ca99d56a1ff981a3ff0a296aa6ca1ec62997">0402ca9</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/d513bac7a3f25f79183387cd4949b53536968b16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/d513bac7a3f25f79183387cd4949b53536968b16?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/d513bac7a3f25f79183387cd4949b53536968b16">d513bac</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2736 +/- ##
=========================================
Coverage 85.01% 85.01%
Complexity 2726 2726
=========================================
Files 331 331
Lines 9561 9561
Branches 914 914
=========================================
Hits 8128 8128
Misses 1110 1110
Partials 323 323
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-14 12:08:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2736#issuecomment-1509100089">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Interesting! I would expect Renovate to pick this up.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-15 02:41:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2737#issuecomment-1509704730">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>When using JUnit 5, the JUnit Platform takes care of test discovery, selection and execution. This system assumes that test discovery is deterministic over its input and that the input doesn't change during test execution. Rerun files however are written during test execution and would then have to be executed in the same test run.</p>
<p>In theory rerun files could be supported by implementing a new <code>TestEngine</code> that reruns files as dynamic tests. This engine would have to be executed after the Cucumber Engine. Unfortunately JUnit 5 does not provide a way to order test engines. So a pull request for JUnit 5 would have to be created first.</p>
<p>Now I would welcome a pull request for a test engine that can execute rerun files. However given that both the JUnit PR and the rerun engine will quite a lot of work, and given that the JUnit Platform Launcher provides an API that makes it relatively easy to rerun failed tests, I doubt anyone will go through the effort.</p>
<p>> i see an example in github readme about how to rerun failing tests. but that relies on junit-platform-launcher. if i do rerun in that way, i don't know how it works with other Cucumber features like parallelism (tbh i don't know. maybe it reads cucumber config as well).</p>
<p>There are quite a few possible stacks that you can use to run your tests:</p>
<pre><code>Cucumber CLI -&gt; Cucumber
Maven Surefire -&gt; JUnit 4 -&gt; Cucumber JUnit -&gt; Cucumber
Maven Surefire -&gt; JUnit Platform Launcher -&gt; JUnit Vintage Engine -&gt; JUnit 4 -&gt; Cucumber JUnit -&gt; Cucumber
Maven Surefire -&gt; JUnit Platform Launcher -&gt; JUnit Suite Engine -&gt; Cucumber Engine -&gt; Cucumber
JUnit 5 Console Launcher -&gt; JUnit Platform Launcher -&gt; Cucumber Engine -&gt; Cucumber
The rerun example code -&gt; JUnit Platform Launcher -&gt; Cucumber Engine -&gt; Cucumber
</code></pre>
<p>When using the CLI or Cucumber JUnit 4, <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-core#properties-environment-variables-system-options">Cucumber takes properties from the CLI, the system, the environment, <code>@CucumberOptions</code> and <code>cucumber.properties</code></a>.</p>
<p>When using the JUnit Platform <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine#configuration-options">the Cucumber Engine receives its configuration from the JUnit Platform</a>. Effectively this comes down to taking properties from Surefire/Gradle/Console Launcher config, the system and <code>junit-platform.properties</code>.</p>
<p>The configuration is slightly different but the capabilities are comparable.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-15 09:49:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2738#issuecomment-1509891127">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2738?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2738">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2738?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2738</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/bb3734c7e5dfcc6bf32691a898174866a4c44a38">bb3734c</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/2f90ebf0bef808e34a14a547248c19147d555bde?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/2f90ebf0bef808e34a14a547248c19147d555bde?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/2f90ebf0bef808e34a14a547248c19147d555bde">2f90ebf</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2738 +/- ##
=========================================
Coverage 85.01% 85.01%
Complexity 2726 2726
=========================================
Files 331 331
Lines 9561 9561
Branches 914 914
=========================================
Hits 8128 8128
Misses 1110 1110
Partials 323 323
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-15 11:19:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2738#issuecomment-1509920502">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Hey thanks for picking this up. Unfortunately it's not as easy as the last one.</p>
<p>The Stackoverflow question I linked from in <a href="https://github.com/cucumber/cucumber-jvm/issues/2715">#2715</a> got was deleted. Nevertheless, in it a question was asked about the purpose and usage of the <code>@CucumberContextConfiguration</code>. This question should have been answered by the Javadoc.</p>
<p>The questions that should be answered are:</p>
<ol><li>What does this annotation do.</li><li>How should it be used.</li><li>How does it work?</li>
</ol>
<p>You may find some guidance in the readme but it doesn't fully explain everything.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-spring#configuring-the-test-application-context">https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-spring#configuring-the-test-application-context</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-17 06:06:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2738#issuecomment-1511305788">Comment</a> on pull request by <a href="https://github.com/vishesh10">vishesh10</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a>,<br />
Thanks for reviewing and providing the reference link. Will go through it and make the changes accordingly.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-14 05:41:51
*Thread Reply:*
Review comment by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/vishesh10">vishesh10's</a> pull request
<p>Cheers. I've merged the changes with some editing.</p>
<p>You initially put in most of the README in there. But that was a bit too much. The java doc should explain the purpose of the class not the entire module.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-14 05:41:51
*Thread Reply:*
New comment on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-14 20:47:43
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2738#issuecomment-1547150796">Comment</a> on pull request by <a href="https://github.com/vishesh10">vishesh10</a>
<p>Thanks <a href="https://github.com/mpkorstanje">@mpkorstanje</a> for reviewing the PR and providing the valuable inputs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-15 12:59:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2572#issuecomment-1509946225">Comment</a> on issue by <a href="https://github.com/apps/stale">stale[bot]</a>
<p>This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-17 12:20:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-java-skeleton/issues/80#issuecomment-1511955281">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I agree that "Then" step definitions should have at least one assert. But asserts should be optional for "Given" and "When" step definitions:</p>
<p>• "Given" step definitions defines the testing context : you could use assert to ensure your testing context is coherent (e.g. no negative number of cukes)
• "Then" step definitions define some action to do on the testing context : you could use assert to ensure your testing context is coherent (e.g. number of cukes has been defined)</p>
<p>So the <a href="https://github.com/given">@given</a> "I have {int} cukes in my belly" example should be replaced with a <a href="https://github.com/then">@then</a> step definition to make the issue more coherent.</p>
<p>By the way, it is true that this <a href="https://github.com/given">@given</a> example is not very good as it creates a <code>Belly</code> but this object instance is automatically deleted by the JVM when the method ends, so it cannot be used in another step definition (the line 8 <code>Belly belly = new Belly();</code> should be defined as a field to do so).</p>
<a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber/cucumber-java-skeleton</a>
GitHub
2023-04-17 13:10:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-java-skeleton/issues/80#issuecomment-1512016213">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You are looking at an intentionally incomplete project. The When and Then steps are present in the scenario:</p>
<p><a href="https://github.com/cucumber/cucumber-java-skeleton/blob/d262b8dc017d01db5425c9b3727e411e36c32498/maven/src/test/resources/io/cucumber/skeleton/belly.feature#L1-L6">cucumber-java-skeleton/maven/src/test/resources/io/cucumber/skeleton/belly.feature</a></p>
<p>Lines 1 to 6 in </cucumber/cucumber-java-skeleton/commit/d262b8dc017d01db5425c9b3727e411e36c32498|d262b8d></p>
<p>And this example project was written using a test driven approach. So just enough code has been written to get the tests running and failing. When run Cucumber will complain about two missing step definitions. You can add those and then incrementally implement the scenario.</p>
<p>This is great for people who are learning TDD, but probably less useful as a minimal working example. Please do feel free to workshop a better but still minimal example.</p>
<a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber/cucumber-java-skeleton</a>
GitHub
2023-04-18 16:06:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2637#issuecomment-1513894070">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I don't see the need for this new feature.</p>
<p>All test scenarios should be independent. Thus, there is no need for specific execution order.</p>
<p>The default execution order should be stable from one run to the other, so that reports could be compared between runs (which is the case with "lexical"). I like the idea of the "random" execution order to ease detection of dependent scenarios (<a href="https://github.com/cucumber/cucumber-jvm/pull/1645">#1645</a>).</p>
<p>By adding scenario running order possibilities, we encourage the bad practice of having dependent test scenarios. Thus, from this point of view, we should not implement this proposal.</p>
<p>As side comments:</p>
<p>• I don't even see the need to have the "reverse" order. I would suggest to deprecate it.
• if execution order is required for reporting, we could even argue that the ordering operation is a responsibility of the plugin (not the cucumber engine responsibility).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-19 00:59:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2637#issuecomment-1514302737">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> All test scenarios should be independent. Thus, there is no need for specific execution order.</p>
<p>There are uses for ordering that are not related to scenario dependence. For example running slow scenarios first, or frequently failing ones first, recently changed first, ect.</p>
<p>Especially when combined with a fail-fast (which Cucumber also doesn't have yet) these help getting feedback faster.</p>
<p>Since we can't quite predict which of these people will want I reckon it is useful to provide an extension point.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-19 23:40:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2637#issuecomment-1515790825">Comment</a> on issue by <a href="https://github.com/hovi">hovi</a>
<p>We have a couple of reasons:</p>
<p>• Our system is very expensive to reset and sometimes non-deterministic
• Some of these tests indeed affect each other so reset is necessary afterwards, completely random execution can cause failures
• Some tests can be run repeatedly without reset
• Some tests can be run only once and then need reset
• We reflect all this with tags
• We can then optimize ordering of tests (while still randomize it to some degree). Even then our test suite takes hours.
• If we were to do "independent test scenarios", tests would take almost a day due to reset times</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-20 04:11:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2637#issuecomment-1516144125">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Thanks for clarification. Indeed, very specific needs imply custom sort capability.<br />
<a href="https://github.com/hovi">@hovi</a> For curiosity : what is your Cucumber volumetry (in terms of parameter types, step definitions, features, rules, test scenarios) ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-18 23:35:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2739#issuecomment-1514202886">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2739?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2739?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2739?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2739">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2739?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2739</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/39ceed36ec70a7a76340b8fa17384e9ce9057050">39ceed3</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/2f90ebf0bef808e34a14a547248c19147d555bde?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/2f90ebf0bef808e34a14a547248c19147d555bde?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/2f90ebf0bef808e34a14a547248c19147d555bde">2f90ebf</a>) will <strong>increase</strong> coverage by <code>0.00%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2739 +/- ##
=========================================
Coverage 85.01% 85.01%
Complexity 2726 2726
=========================================
Files 331 331
Lines 9561 9565 +4
Branches 914 914
=========================================
+ Hits 8128 8132 +4
Misses 1110 1110
Partials 323 323
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-29 06:36:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2683#issuecomment-1528791123">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-29 06:43:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2683#issuecomment-1528792172">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2683?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2683?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2683?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2683">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2683?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2683</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/bbd30ede8137c41e08c20415d337aaf8efd5db4c">bbd30ed</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/38cd14d5138445a900fb9491273d947011048fde?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/38cd14d5138445a900fb9491273d947011048fde?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/38cd14d5138445a900fb9491273d947011048fde">38cd14d</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2683 +/- ##
=========================================
Coverage 85.00% 85.00%
Complexity 2726 2726
=========================================
Files 331 331
Lines 9538 9538
Branches 914 914
=========================================
Hits 8108 8108
Misses 1107 1107
Partials 323 323
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-23 19:31:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2741#issuecomment-1519295635">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-23 19:36:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2741#issuecomment-1519298162">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2741?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2741?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2741?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2741">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2741?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2741</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/f1c0c049c8310dd9b7f0ddf2e94c43b406ab6d42">f1c0c04</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/1ff745b1748010b20375a20b33265074b5f75f95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/1ff745b1748010b20375a20b33265074b5f75f95?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/1ff745b1748010b20375a20b33265074b5f75f95">1ff745b</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2741 +/- ##
=========================================
Coverage 85.01% 85.01%
Complexity 2726 2726
=========================================
Files 331 331
Lines 9565 9565
Branches 914 914
=========================================
Hits 8132 8132
Misses 1110 1110
Partials 323 323
</code></pre>
<p>Help us with your feedback. Take ten seconds to tell us <https://about.codecov.io/nps?utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|how you rate us>. Have a feature suggestion? <https://app.codecov.io/gh/feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here.></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-28 05:08:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2742#issuecomment-1527470890">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-28 05:16:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2742#issuecomment-1527479585">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2742?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://codecov.io/gh/cucumber/cucumber-jvm/pull/2742?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2742">https://codecov.io/gh/cucumber/cucumber-jvm/pull/2742?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2742</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/28fb4c6f93bca9bef017b8d454310ff09a399e44">28fb4c6</a>) into <a href="https://codecov.io/gh/cucumber/cucumber-jvm/commit/926d218ebccf826c346a586abb4191161192e27a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://codecov.io/gh/cucumber/cucumber-jvm/commit/926d218ebccf826c346a586abb4191161192e27a?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/926d218ebccf826c346a586abb4191161192e27a">926d218</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2742 +/- ##
=========================================
Coverage 85.01% 85.01%
Complexity 2726 2726
=========================================
Files 331 331
Lines 9565 9565
Branches 914 914
=========================================
Hits 8132 8132
Misses 1110 1110
Partials 323 323
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-29 04:06:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2743#issuecomment-1528760021">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I would welcome a PR that adds two properties:</p>
<pre><code>cucumber.junit-platform.naming-strategy.short.example-name=pickle-name|example-number
cucumber.junit-platform.naming-strategy.long.example-name=pickle-name|example-number
</code></pre>
<p>Then given the feature:</p>
<pre><code>Feature: Examples Tables
Scenario Outline: Eating &lt;eat&gt; of &lt;start&gt; cucumbers
Given there are &lt;start&gt; cucumbers
When I eat &lt;eat&gt; cucumbers
Then I should have &lt;left&gt; cucumbers
Examples: These are passing
| start | eat | left |
| 12 | 5 | 7 |
| 20 | 5 | 15 |
Examples: These are failing
| start | eat | left |
| 12 | 20 | 0 |
| 0 | 1 | 0 |
</code></pre>
<p>When the <code>cucumber.junit-platform.naming-strategy.short.example-name=example-number</code> is used this should be rendered as:</p>
<pre><code> ** Example Tables
** Eating &lt;eat&gt; of &lt;start&gt; cucumbers
** These are passing
** Example #1.1
** Example #1.2
** These are failing
** Example #1.1
** Example #1.2
</code></pre>
<p>When the <code>cucumber.junit-platform.naming-strategy.short.example-name=pickle-name</code> is used this should be rendered as:</p>
<pre><code> ** Example Tables
** Eating &lt;eat&gt; of &lt;start&gt; cucumbers
** These are passing
** Eating 5 of 12 cucumbers
** Eating 5 of 20 cucumbers
** These are failing
** Eating 20 of 12 cucumbers
** Eating 1 of 0 cucumbers
</code></pre>
<p>This can be implemented by changing the <code>DefaultNamingStrategy</code>. For inspiration on how to do this please have a look at the <code>org.junit.platform.engine.support.hierarchical.DefaultParallelExecutionConfigurationStrategy</code> from JUnit 5.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-29 03:01:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2744#issuecomment-1528741910">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>The purpose of Gherkin is to create human readable descriptions of a systems behavior. Replacement patters are not human readable. And more importantly, in this scenario the password is an incidental detail that can be omitted.</p>
<p>Please have a look at:</p>
<p>• <a href="https://cucumber.io/blog/bdd/cucumber-antipatterns-part-one/">https://cucumber.io/blog/bdd/cucumber-antipatterns-part-one/</a>
• <a href="https://cucumber.io/blog/bdd/cucumber-anti-patterns-part-two/">https://cucumber.io/blog/bdd/cucumber-anti-patterns-part-two/</a>
• <a href="https://docs.cucumber.io/docs/bdd/better-gherkin/">https://docs.cucumber.io/docs/bdd/better-gherkin/</a>
• <a href="https://cucumber.io/blog/bdd/keep-your-scenarios-brief-(1)/|https://cucumber.io/blog/bdd/keep-your-scenarios-brief-(1)/">https://cucumber.io/blog/bdd/keep-your-scenarios-brief-(1)/|https://cucumber.io/blog/bdd/keep-your-scenarios-brief-(1)/</a>
• <a href="https://cucumber.io/blog/bdd/introduction-to-formulation/">https://cucumber.io/blog/bdd/introduction-to-formulation/</a></p>
<p>If you do want easy access to environment variables without using <code>System.getenv()</code> you can use a dependency injection framework that supports it. For example if you are using <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-spring"><code>cucumber-spring</code></a> you can use the <code>@Value</code> annotation in your step definitions:</p>
<pre><code>public class ExampleStepDefinitions {
@Value("${user.password}")
String userPassword;
@Given("I type password in input type {string}")
public void enterPassword(String inputType) {
// Enter password into inputType
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-04-29 20:16:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-java-skeleton/issues/62#issuecomment-1528928581">Comment</a> on issue by <a href="https://github.com/manthan027">manthan027</a>
<p>While i was adding features and gave compile facing this issue . Please help me on this</p>
<p>Apr 30, 2023 8:42:46 AM cucumber.api.cli.Main run<br />
WARNING: You are using deprecated Main class. Please use io.cucumber.core.cli.Main</p>
<p>Scenario: Testing Signup Functionality # src/test/resources/Feature/Signup.feature:3</p>
<p>0 Scenarios<br />
0 Steps<br />
0m0.518s</p>
<p>?????????????????????????????????????????????????????????????????????????????????????<br />
? Share your Cucumber Report with your team at <a href="https://reports.cucumber.io">https://reports.cucumber.io</a> ?<br />
? Activate publishing with one of the following: ?<br />
? ?<br />
? src/test/resources/cucumber.properties: cucumber.publish.enabled=true ?<br />
? src/test/resources/junit-platform.properties: cucumber.publish.enabled=true ?<br />
? Environment variable: CUCUMBER<em>PUBLISH</em>ENABLED=true ?<br />
? JUnit: @CucumberOptions(publish = true) ?<br />
? ?<br />
? More information at <a href="https://cucumber.io/docs/cucumber/environment-variables/">https://cucumber.io/docs/cucumber/environment-variables/</a> ?<br />
? ?<br />
? Disable this message with one of the following: ?<br />
? ?<br />
? src/test/resources/cucumber.properties: cucumber.publish.quiet=true ?<br />
? src/test/resources/junit-platform.properties: cucumber.publish.quiet=true ?<br />
?????????????????????????????????????????????????????????????????????????????????????</p>
<a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber/cucumber-java-skeleton</a>
GitHub
2023-05-03 04:59:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2746#issuecomment-1532899406">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>It should work fine provided you've correctly created your fat jar. I suspect you're not correctly merging <code>META-INF/services</code>. You should configure the maven shade plugin to use the <a href="https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer">ServicesResourceTransformer</a>.</p>
<p>Duplicate of <a href="https://github.com/cucumber/cucumber-jvm/issues/2469">#2469</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-03 05:23:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2746#issuecomment-1532931669">Comment</a> on issue by <a href="https://github.com/Hakky54">Hakky54</a>
<p>Thank you <a href="https://github.com/mpkorstanje">@mpkorstanje</a> It seems indeed it was related to the issue you mentioned. Adjusting the maven shade plugin worked out. For anyone who is encountering a similar issue, I added the following commit to fix it in my project: <a href="https://github.com/Hakky54/mutual-tls-ssl/commit/bd472a46b91707ea91ebb831256a07ff0a547dda">Hakky54/mutual-tls-ssl@bd472a4</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-14 23:50:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2747#issuecomment-1547282661">Comment</a> on issue by <a href="https://github.com/pabitra-qa">pabitra-qa</a>
<p>Hi <a href="https://github.com/mpkorstanje">@mpkorstanje</a>, thanks for fixing this. Is this change available in current version? Or I have to wait for next release?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-11 06:13:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2749#issuecomment-1543987871">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-11 06:21:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2749#issuecomment-1544001227">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2749?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2749?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2749?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2749">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2749?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2749</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/e4dc43f7d405217580a7265b1934a31533e6e357">e4dc43f</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/dfcb94448e977d3532588f30561b5a50a1b4ec81?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/dfcb94448e977d3532588f30561b5a50a1b4ec81?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/dfcb94448e977d3532588f30561b5a50a1b4ec81">dfcb944</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2749 +/- ##
=========================================
Coverage 84.98% 84.98%
Complexity 2725 2725
=========================================
Files 331 331
Lines 9541 9541
Branches 914 914
=========================================
Hits 8108 8108
Misses 1108 1108
Partials 325 325
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-11 14:41:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2750#issuecomment-1544717510">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I can't tell from the information you've provided what is causing your project to be unable to find any step definitions. However if you use the <a href="https://github.com/cucumber/cucumber-java-skeleton">Skeleton Project</a> or <a href="https://cucumber.io/docs/guides/10-minute-tutorial/?lang=java">the 10-Minute tutorial from the docs</a> you should get a working project that uses <code>cucumber-java</code> with JUnit 5. So you may want to try that.</p>
<p>You can also find a comprehensive summary of the Cucucmber Engines capabilities <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine">in the modules README.md</a>.</p>
<p>> BTW: cucumber.publish.quiet=true in cucumber.properties doesn't work either.</p>
<p>When using Cucumber with JUnit 5, the JUnit Platform handles the discover, selection and configuration of tests. So all properties should go into <code>junit-platform.properties</code>.</p>
<p>Note that if you're using IDEA, when using the "Run Buttons" in a feature file, IDEA will still use the console which uses <code>cucumber.properties</code>. Please upvote this issue to get that experience fixed: <a href="https://youtrack.jetbrains.com/issue/IDEA-227508/Support-cucumber-junit-platform-engine">https://youtrack.jetbrains.com/issue/IDEA-227508/Support-cucumber-junit-platform-engine</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-11 15:57:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2751#issuecomment-1544798740">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2751?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2751?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2751?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2751">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2751?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2751</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b3216b1e24c8d225c8aa86d555a306d9c0c1a046">b3216b1</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/cd3581e78ae02757aa26ba6c677e9a70fc53920d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/cd3581e78ae02757aa26ba6c677e9a70fc53920d?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/cd3581e78ae02757aa26ba6c677e9a70fc53920d">cd3581e</a>) will <strong>increase</strong> coverage by <code>0.00%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2751 +/- ##
=========================================
Coverage 84.98% 84.98%
+ Complexity 2725 2724 -1
=========================================
Files 331 331
Lines 9541 9535 -6
Branches 914 913 -1
=========================================
- Hits 8108 8103 -5
Misses 1108 1108
+ Partials 325 324 -1
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-13 03:54:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2752#issuecomment-1546621222">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-13 03:59:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2752#issuecomment-1546622098">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2752?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2752?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2752?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2752">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2752?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2752</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/696f345d18eaddf06a6d2a758375e01526568712">696f345</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/fae449b8485bc133f1abb1b943fa7af5930ffebe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/fae449b8485bc133f1abb1b943fa7af5930ffebe?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/fae449b8485bc133f1abb1b943fa7af5930ffebe">fae449b</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2752 +/- ##
=========================================
Coverage 84.98% 84.98%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9535 9535
Branches 913 913
=========================================
Hits 8103 8103
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-13 03:49:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2753#issuecomment-1546620437">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>If you look at the packaging of the <code>cucumber-jvm</code> module you'll see that it is a POM artifact. POM artifacts do not typically include Javadoc. I suspect you'll want to look at <code>cucumber-java</code>.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/973ca79df939262f3e3dcf0d4005ad1538580494/pom.xml#L8-L10">cucumber-jvm/pom.xml</a></p>
<p>Lines 8 to 10 in </cucumber/cucumber-jvm/commit/973ca79df939262f3e3dcf0d4005ad1538580494|973ca79></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-15 08:25:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2754#issuecomment-1548077073">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Nice graphs!</p>
<p>When using the <code>cucumber-junit-platform-engine</code> the parallel execution is facilitated by the <code>ForkJoinPoolHierarchicalTestExecutorService</code> from JUnit 5. So ultimately this means that any fix would have to be submitted to JUnit 5.</p>
<p>Before we go there, would you happen to have a minimal reproducer that you can share in the form of a Github repository?</p>
<p>Now I suspect that you're running into <a href="https://github.com/junit-team/junit5/blob/704e383ddc43fb1adb3277ef9e3f18a049c036f3/junit-platform-engine/src/main/java/org/junit/platform/engine/support/hierarchical/ForkJoinPoolHierarchicalTestExecutorService.java#L123-L136">this specific comment</a>:</p>
<pre><code> // Limit the amount of queued work so we don't consume dynamic tests too eagerly
// by forking only if the current worker thread's queue length is below the
// desired parallelism. This optimistically assumes that the already queued tasks
// can be stolen by other workers and the new task requires about the same
// execution time as the already queued tasks. If the other workers are busy,
// the parallelism is already at its desired level. If all already queued tasks
// can be stolen by otherwise idle workers and the new task takes significantly
// longer, parallelism will drop. However, that only happens if the enclosing test
// task is the only one remaining which should rarely be the case.
if (testTask.getExecutionMode() == CONCURRENT &amp;&amp; ForkJoinTask.getSurplusQueuedTaskCount() &lt; parallelism) {
return exclusiveTask.fork();
}
exclusiveTask.compute();
return completedFuture(null);
</code></pre>
<p>But a reproducer would help to verify that and potentially make a stronger argument for changing this behavior.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-16 02:11:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2755#issuecomment-1549291846">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I would be happy to accept a PR for this.</p>
<p><a href="https://github.com/jkronegg">@jkronegg</a> which of these do you think is the better option?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-16 23:25:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2755#issuecomment-1550811986">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/flowerrrr">@flowerrrr</a> Are you sure this performance issue is related to the <code>Predicate&lt;Throwable&gt;</code> instance <strong>creation</strong> ? IMHO, most of the execution time comes from the <code>Predicate&lt;Throwable&gt;</code> <strong>execution</strong> (you can't get a <code>ClassNotFoundException</code> until the predicate is executed), see</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/02af97eeae2a75289d08d622d0c3ee36e31fc684/cucumber-core/src/main/java/io/cucumber/core/runner/TestAbortedExceptions.java#L26">cucumber-jvm/cucumber-core/src/main/java/io/cucumber/core/runner/TestAbortedExceptions.java</a></p>
<p>Line 26 in </cucumber/cucumber-jvm/commit/02af97eeae2a75289d08d622d0c3ee36e31fc684|02af97e></p>
<p>If I'm correct, you should have a lot of Exceptions that are thrown in your code. If you don't notice them, could it be possible that they are swallowed somewhere ? There are some swallowing mechanisms in Cucumber and I not sure this is working properly, e.g. see <a href="https://github.com/cucumber/cucumber-jvm/issues/2748">#2748</a></p>
<p>The <code>Predicate&lt;Throwable&gt;</code> execution performance has been improved through <a href="https://github.com/cucumber/cucumber-jvm/issues/2666">#2666</a> : performance can still be 2x faster by caching the classes in a static classloader, but this will change the code behavior, so I'm not sure this is the way to go.</p>
<p>This aside, regarding your proposed solutions, and considering that Exceptions should be exceptions, I would defer the Predicate creation until we need to evaluate it. This way, <code>TestCase</code> instance creation will be faster.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-16 23:48:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2755#issuecomment-1550843025">Comment</a> on issue by <a href="https://github.com/flowerrrr">flowerrrr</a>
<p>Oh, i see that the issue is already fixed in version v7.11.0 with this commit: <a href="https://github.com/cucumber/cucumber-jvm/commit/f53abb64dd9b3990c34d09514f3bba3112e34bd5">f53abb6</a><br />
Sorry for the confusion, i was still on an old version.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-17 02:49:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2755#issuecomment-1551088084">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/flowerrrr">@flowerrrr</a> 5 minutes for 10'000 scenarios is relatively fast, but you could have even better performance with Cucumber 7.12.0 by adding the following property:</p>
<pre><code>cucumber.uuid-generator=io.cucumber.core.eventbus.IncrementingUuidGenerator
</code></pre>
<p>see <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-core#event-bus">https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-core#event-bus</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-25 01:01:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2755#issuecomment-1562459649">Comment</a> on issue by <a href="https://github.com/flowerrrr">flowerrrr</a>
<p>Adding the property did produce a modest improvement of ~5%.<br />
Thank you for the tip.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-16 23:17:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2756#issuecomment-1550800548">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-16 23:28:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2756#issuecomment-1550814459">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2756?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2756?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2756?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2756">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2756?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2756</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/527619d74435e2ac86959e00e837b141c0a22118">527619d</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/02af97eeae2a75289d08d622d0c3ee36e31fc684?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/02af97eeae2a75289d08d622d0c3ee36e31fc684?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/02af97eeae2a75289d08d622d0c3ee36e31fc684">02af97e</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2756 +/- ##
=========================================
Coverage 84.98% 84.98%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9535 9535
Branches 913 913
=========================================
Hits 8103 8103
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-18 07:29:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2757#issuecomment-1553151445">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I'm having some trouble understanding your problem.</p>
<p>I can not produce a duplicate <code>DuplicateStepDefinitionException</code> from the code you have provided. Could you perhaps provide an MCVE in a Github Repo? You can use the skeleton project to get started <a href="https://github.com/cucumber/cucumber-java-skeleton">https://github.com/cucumber/cucumber-java-skeleton</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-18 08:08:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2757#issuecomment-1553207096">Comment</a> on issue by <a href="https://github.com/sanflg">sanflg</a>
<p>Hi <a href="https://github.com/mpkorstanje">@mpkorstanje</a><br />
Generated an specific branch where this issue is reproducible: <a href="https://github.com/sanflg/SeleniumTest/tree/DuplicateStepDefinition">https://github.com/sanflg/SeleniumTest/tree/DuplicateStepDefinition</a></p>
<p>Glue objects hierarchy: <code>src/main/java/org/seleniumTest/pageObjects</code><br />
Features: <code>src/test/resources/features/search.feature</code><br />
CucumberRunner: <code>src/test/java/org/seleniumTest/cucumber/CucumberRunnerTests.java</code></p>
<p>Running with cucumber.xml file I'm getting:</p>
<pre><code>io.cucumber.core.runner.DuplicateStepDefinitionException: Duplicate step definitions in org.seleniumTest.pageObjects.GoogleHomePage.goTo() and org.seleniumTest.pageObjects.GoogleHomePage.goTo()
at io.cucumber.core.runner.CachingGlue.lambda$prepareGlue$3(CachingGlue.java:278)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at io.cucumber.core.runner.CachingGlue.prepareGlue(CachingGlue.java:272)
at io.cucumber.core.runner.Runner.runPickle(Runner.java:72)
at io.cucumber.testng.TestNGCucumberRunner.lambda$runScenario$1(TestNGCucumberRunner.java:132)
at io.cucumber.core.runtime.CucumberExecutionContext.lambda$runTestCase$5(CucumberExecutionContext.java:137)
at io.cucumber.core.runtime.RethrowingThrowableCollector.executeAndThrow(RethrowingThrowableCollector.java:23)
at io.cucumber.core.runtime.CucumberExecutionContext.runTestCase(CucumberExecutionContext.java:137)
at io.cucumber.testng.TestNGCucumberRunner.runScenario(TestNGCucumberRunner.java:129)
at io.cucumber.testng.AbstractTestNGCucumberTests.runScenario(AbstractTestNGCucumberTests.java:35)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139)
at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:677)
at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:221)
at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:50)
at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:969)
at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:194)
at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:148)
at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:128)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at org.testng.TestRunner.privateRun(TestRunner.java:829)
at org.testng.TestRunner.run(TestRunner.java:602)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:437)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:431)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:391)
at org.testng.SuiteRunner.run(SuiteRunner.java:330)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1256)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1176)
at org.testng.TestNG.runSuites(TestNG.java:1099)
at org.testng.TestNG.run(TestNG.java:1067)
at com.intellij.rt.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:66)
at com.intellij.rt.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:109)
</code></pre>
<p>And with maven command "clean test -Ddriver=chrome -Dmaximize=false -DsuiteXmlFile=cucumber":</p>
<pre><code> Suppressed: io.cucumber.core.runner.DuplicateStepDefinitionException: Duplicate step definitions in org.seleniumTest.pageObjects.GoogleHomePage.goTo() and org.seleniumTest.pageObjects.GoogleHomePage.goTo()
at io.cucumber.core.runner.CachingGlue.lambda$prepareGlue$3(CachingGlue.java:278)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at io.cucumber.core.runner.CachingGlue.prepareGlue(CachingGlue.java:272)
at io.cucumber.core.runner.Runner.runPickle(Runner.java:72)
at io.cucumber.testng.TestNGCucumberRunner.lambda$runScenario$1(TestNGCucumberRunner.java:132)
at io.cucumber.core.runtime.CucumberExecutionContext.lambda$runTestCase$5(CucumberExecutionContext.java:137)
at io.cucumber.core.runtime.RethrowingThrowableCollector.executeAndThrow(RethrowingThrowableCollector.java:23)
at io.cucumber.core.runtime.CucumberExecutionContext.runTestCase(CucumberExecutionContext.java:137)
at io.cucumber.testng.TestNGCucumberRunner.runScenario(TestNGCucumberRunner.java:129)
at io.cucumber.testng.AbstractTestNGCucumberTests.runScenario(AbstractTestNGCucumberTests.java:35)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:139)
at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:677)
at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:221)
at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:50)
at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:969)
at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:194)
at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:148)
at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:128)
... 20 more
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-18 23:09:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2757#issuecomment-1554058743">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>> I can not produce a duplicate <code>DuplicateStepDefinitionException</code> from the code you have provided.</p>
<p>I could reproduce the issue by adding the classes <code>BasePageBehaviors</code>, <code>BasePage</code> and <code>GoogleHomePage</code> to one of my project which uses Cucumber 7.12.0.</p>
<p>This is due to the fact that <code>GoogleHomePage.class.getDeclaredMethods()</code> has two methods:</p>
<pre><code>0 = {Method@2523} "public mypackage.GoogleHomePage mypackage.GoogleHomePage.goTo()"
1 = {Method@2524} "public mypackage.BasePage mypackage.GoogleHomePage.goTo()"
</code></pre>
<p>That's interesting, I've never realized that such object-oriented construction will lead to two methods, one being an "alias" of the other. As the common Java developer, I learned this is not possible, see <a href="https://stackoverflow.com/questions/5561436/can-two-java-methods-have-same-name-with-different-return-type">https://stackoverflow.com/questions/5561436/can-two-java-methods-have-same-name-with-different-return-type</a> . But it seems I was wrong, see <a href="https://stackoverflow.com/a/5561736/698168">https://stackoverflow.com/a/5561736/698168</a></p>
<p>I see two solution variants:</p>
<p><strong>Ignore alias method based on <code>Field.slot</code></strong></p>
<p>We could use the <code>Field.slot</code> to differentiate them, e.g. <a href="https://stackoverflow.com/questions/47529744/what-is-a-java-lang-reflect-fieldslot">https://stackoverflow.com/questions/47529744/what-is-a-java-lang-reflect-fieldslot</a> (the method which returns a <code>GoogleHomePage</code> has slot 1 and the one which returns <code>BasePage</code> has slot 2). In this case we could ignore the <code>Method</code> with the same name/parameters that has the highest slot.</p>
<p>I see some drawbacks with this variant:</p>
<p>• we will need global information (a kind of "bag" with the two methods).
• detecting an "alias" is complex (we need to determine whether two methods are the same)
• relying on the undocumented <code>Field.slot</code> is not very secure (the behavior could depend on the JVM implementation)</p>
<p><strong>Ignore alias method based on <code>Method.modifiers</code></strong></p>
<p>We could also use the <code>Method.modifiers</code>, because they are different. <code>Modifier.toString(method.clazz.getDeclaredMethods()[i].getModifiers())</code> gives:</p>
<p>• <code>GoogleHomePage</code> -> "public"
• <code>BasePage</code> -> "public volatile"</p>
<p>In this case, we could ignore the methods with <code>volatile</code> modifier (<code>Modifier.isVolatile(method.getModifiers())</code>).</p>
<p>This variant has the advantage to use only local information (we can decide just based on the <code>Method</code> without requiring information about other potential "alias" <code>Method</code>s).</p>
<p>This could be done in <code>JavaBackend.loadGlue</code>:</p>
<pre><code>@Override
public void loadGlue(Glue glue, List&lt;URI&gt; gluePaths) {
GlueAdaptor glueAdaptor = new GlueAdaptor(lookup, glue);
gluePaths.stream()
.filter(gluePath -&gt; CLASSPATH_SCHEME.equals(gluePath.getScheme()))
.map(ClasspathSupport::packageName)
.map(classFinder::scanForClassesInPackage)
.flatMap(Collection::stream)
.distinct()
.forEach(aGlueClass -&gt; scan(aGlueClass, (method, annotation) -&gt; {
if (!Modifier.isVolatile(method.getModifiers()) { // &lt;----------------- added condition
container.addClass(method.getDeclaringClass());
glueAdaptor.addDefinition(method, annotation);
}
}));
}
</code></pre>
<p>Note: I tested the above code on my project and it works without throwing the <code>DuplicateStepDefinitionException</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-24 07:54:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2757#issuecomment-1561312824">Comment</a> on issue by <a href="https://github.com/sanflg">sanflg</a>
<p>TL&DR: Motivation on why would need abstraction on Step definitions, this is not related to any technical aspect but rather to work methodologies and what I consider good practices.</p>
<p><a href="https://github.com/jkronegg">@jkronegg</a> <a href="https://github.com/mpkorstanje">@mpkorstanje</a> followed the discussion in <a href="https://github.com/cucumber/cucumber-jvm/pull/2759">the PR</a> and may not be able to contribute technically to the solution but the whole motivation in making abstract implementations for "Step definitions" classes relies in the following problem, more related to a workin methodology and good practices rather than a real code problem:</p>
<p>For common verbal expressions (used in Gherkin), where there may not exist syntactical or conceptual difference, depending on the scenario, each of this expressions in Step Definitions may change a lot in the code implementation. Usually we have the acceptance criteria to check that all the requirements are implemented but some times we can miss some points or do half implementations.</p>
<p>Because of this, abstraction is the way that we have to enforce behaviors in OOP projects, in order to achieve this, we can use interfaces and abstract classes to enforce child classes to implement this general required behaviors, but adding the enforcement on step definition classes to also implement this behaviors, adds one layer more of compromise that this features will be applied, clearly this doesn't means that the feature files will be also enforced to implement this missing function part for common required behaviors/tests but this can be supplied with a custom plugging and even with some sort of automated script to generate feature files where we consume the already defined step definitions.</p>
<p>Clearly if we have step definitions with the same signature, cucumber will arise the DuplicateStepDefinition exception, but we can control this using <a href="https://blog.airbrake.io/blog/software-design/domain-driven-design">DDD</a> sort of solution with package visibility and order (<a href="http://confessionsofanagilecoach.blogspot.com/2017/05/teaching-cucumbers-about-boundaries.html">Check this blog post for more info</a>) and this way, with package control, we could have parent classes enforcing behaviors and holding the common methods for all this classes in a parent directory.</p>
<p>This whole discussion only makes sense in really big enterprise projects where we loss track of each one of the tickets/pages/implementations and this way we have one more tool to remember to don't miss them.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-24 15:26:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2757#issuecomment-1562007048">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Thanks for these clarifications.</p>
<p>> Usually we have the acceptance criteria to check that all the requirements are implemented but some times we can miss some points or do half implementations.</p>
<p>I totally agree with you. I got the same experience on some my projects based on Cucumber: your tests are passing just because the Steps definitions are wrongly implemented. I consider steps definitions as code : they should be tested as well. Ideally, you should have a kind of test harness/framework which helps the developer. Currently, I have custom code for this. But my dream would be that Cucumber do it for you, either built-in or through a plugin (I have no idea on how to do it, but IMHO the first-in-class framework which does this is Mockito: it tells you when one of your mock is useless and guide you to write better test code).</p>
<p>If you have ideas on how to integrate such automatic checks in Cucumber, do not hesitate to discuss the point on the Slack channel or to open a new issue on Github.</p>
<p>> solution with package visibility and order (<a href="http://confessionsofanagilecoach.blogspot.com/2017/05/teaching-cucumbers-about-boundaries.html">Check this blog post for more info</a>)</p>
<p>I would have done the same as proposed in the blog you mention. But without correcting the current issue, there will still be <code>DuplicateStepDefinition</code> errors.</p>
<p>BTW, which JVM do you use ? (as this issue seems to be JVM specific)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-25 03:53:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2757#issuecomment-1562696209">Comment</a> on issue by <a href="https://github.com/sanflg">sanflg</a>
<p>Currently for this project I'm using <code>corretto-11.0.16.1</code>. May I update it to another distribution/newer version?.</p>
<p>It would be nice to start checking plugging for IDE or a check for feature implementation, will start doing this investigation on my free time. The most similar thing that comes to my mind for a line by line usage check is <a href="https://github.com/jacoco/jacoco">Jacoco</a> more usually implemented by unitary tests due to the 1-1 matching nature of unitary testing but would not be entirely wrong to do some similar kind of implementation for stepDefinitions method usage.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 00:05:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2757#issuecomment-1563904754">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>> May I update it to another distribution/newer version?</p>
<p>No, that's not required. The issue should be resolved on Cucumber side (Cucumber should work the same way on all JVMs).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-02 13:15:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2757#issuecomment-1574265251">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/sanflg">@sanflg</a> this issue is solved in cucumber 7.12.1</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-19 03:58:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1554400304">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2759?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2759?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2759?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2759">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2759?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2759</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/4d1c88f351f6863e66c3ac49f956e4b237e59191">4d1c88f</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b53204e60447551a916d4a7b7e2856e8167fbf76?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b53204e60447551a916d4a7b7e2856e8167fbf76?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b53204e60447551a916d4a7b7e2856e8167fbf76">b53204e</a>) will <strong>increase</strong> coverage by <code>0.01%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2759 +/- ##
============================================
+ Coverage 84.98% 84.99% +0.01%
- Complexity 2724 2726 +2
============================================
Files 331 331
Lines 9535 9536 +1
Branches 913 913
============================================
+ Hits 8103 8105 +2
Misses 1108 1108
+ Partials 324 323 -1
</code></pre>
<p>... and <https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2759/indirect-changes?src=pr&el=tree-more&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|1 file with indirect coverage changes></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-19 05:29:08
*Thread Reply:*
Review comment by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/jkronegg">jkronegg's</a> pull request
<p>Thanks for picking this up so quickly!</p>
<p>But I don't think this is the correct solution. Rather <code>MethodScanner.scan</code> should not have produced the duplicate definition.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-19 05:37:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1554511727">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>It should also not be possible to write:</p>
<pre><code>interface Example {
@Given("a step")
void step();
}
</code></pre>
<p>This should result in a <code>InvalidMethodException</code>. I think it would currently merely be ignored. But I'm not sure.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-19 06:43:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1554595984">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I chose to correct the issue in <code>JavaBackend.loadGlue()</code> to reduce the risk of side effects, but I'll move the correction to <code>MethodScanner.scan</code>.</p>
<p>Regarding you step definition in the interface, I don't understand the point. The unit test is only defining an interface and a class which implements this interface.</p>
<pre><code>public interface StepsInterface {
Number test();
}
public class StepsWithInterface implements StepsInterface {
@Given("test")
public Integer test() {
return 1;
}
}
</code></pre>
<p>When doing <code>StepsWithInterface.class.getDeclaredMethods()</code>, it will return two methods (both behing annotated by <code>Given("test")</code>:</p>
<p>• Number test()
• Integer test()</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-19 07:07:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1554635567">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Mmh. Maybe I was a bit to quick with the second example. I'd have to look at the problem a bit more carefully I suppose. I'll do that as soon as I can find some time.</p>
<p>The general idea is that all step definition classes should be concrete and "effectively final".</p>
<p>If they're not it gets really confusing later on because people have trouble figuring out that their duplicate step definitions came from an abstract class or interface that is inherited by two other classes (novices think there is only one because they only wrote one).</p>
<p>Normally extending a class with step definitions causes a validation to fail. And I would have expected that to be the case for this method inherited from the interface too.</p>
<p>So in my mind there are two problems, the one reported and the one where the system (correctly, but only by accident) allows this method to pass validation. I would like to explore a bit around that.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-19 07:36:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1554689874">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>> The general idea is that all step definition classes should be concrete and "effectively final".</p>
<p>The <code>StepsWithInterface</code> class is concrete and "effectively final" (it's a minimalistic example which reproduces the issue, you don't need to use generics and abstract classes as suggested by <a href="https://github.com/sanflg">@sanflg</a> in the issue). If I write another class which implements the interface and define steps, this will lead to another step definition, without ambiguity, even for beginners.</p>
<p>Of course it's a bit "unusual" to implement an interface when you write a class which contains cucumber step definitions, but I don't see this approach as a problem. While I don't clearly see a situation where implementing an interface gives you an advantage, there is absolutely no issue to allow this in Cucumber.</p>
<p>BTW, I moved the check in the <code>MethodScanner.scan</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-19 12:11:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1555117477">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>In terms of how the <code>MethodScanner</code> should behave I agree with your description.</p>
<p>In terms of how I understand the implementation I would have behaved, there are a few more things I'd like to check. One being the example I gave. I'll try to find some time for that soon.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-21 03:31:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1556143153">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Note to self: I was puzzled why this method appears to be volatile while volatile is not a valid method modifier. The actual type is probably bridge which has the same bit mask value.</p>
<p><a href="https://stackoverflow.com/questions/6651867/why-make-a-method-volatile-in-java">https://stackoverflow.com/questions/6651867/why-make-a-method-volatile-in-java</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-21 13:36:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1556285692">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Good point (I'll be smarter when I get the "volatile method" question in a future job interview 😅).</p>
<p>Actually, I think we should use the "synthetic" flag rather than the "bridge" flag, because some synthetic methods generated by the compiler are not bridge methods. For example:</p>
<pre><code>public class TestSyntheticAndBridge {
@Retention(RetentionPolicy.RUNTIME)
static @interface Annotation {
}
static interface I {
Number get();
}
static class B implements I {
Function&lt;String, Integer&gt; func = s -&gt; s.length();
@Annotation
public Integer get() {
return 1;
}
}
public static final void main(String[] args) {
Stream.of(B.class.getDeclaredMethods()).forEach(method -&gt;
System.out.println(method+
", synthetic="+method.isSynthetic()+
", bridge="+method.isBridge()+
", annotations="+method.getAnnotations().length));
}
}
</code></pre>
<p>This displays:</p>
<pre><code>public java.lang.Number TestSyntheticAndBridge$B.get(), synthetic=true, bridge=true, annotations=0
public java.lang.Integer TestSyntheticAndBridge$B.get(), synthetic=false, bridge=false, annotations=1
private static java.lang.Integer TestSyntheticAndBridge$B.lambda$0(java.lang.String), synthetic=true, bridge=false, annotations=0
</code></pre>
<p>The lambda method has has been generated for the field "func" and is synthethic but not bridge.<br />
Note that here the method from the interface has no annotation (the test was done with Oracle JVM 10.0.1, while the tests in my previous posts were done using AzulZulu 17). I'll investigate further...</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-25 03:57:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#discussion_r1205342533">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Please split this condition into two statements. It will make the code comments easier to read.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-25 03:57:33
*Thread Reply:*
Review comment by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/jkronegg">jkronegg's</a> pull request
<p>Thanks for the explanation. That does cover most of my concerns and questions.</p>
<p>How do we know that there always is an non-synthetic annotated method?</p>
<p>For example, what happens in Kotlin?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-25 03:57:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#discussion_r1205341742">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I would consider this a bug fix. If we can get it to work.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-25 06:23:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1562902868">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>> How do we know that there always is an non-synthetic annotated method?</p>
<p>We may may have no non-synthetic method, but that should not be an issue (in this case the <code>MethodScanner</code> will process 0 methods).</p>
<p>For Kotlin, I don't have enough knowledge to say...</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 08:16:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1564546556">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I did a really quick manual test. Kotlin is going to be fine. I'm not happy with doing this manually, ideally we had an example project for this but that's all the time I've got right now.</p>
<p>I've narrowed the solution to bridge methods only. The bug report was about a bridge method and the tests we've written are also for bridge methods. If other bugs show up involving synthetics that aren't bridge methods, we can test those individually.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 08:18:00
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/jkronegg">jkronegg's</a> pull request
<p><a href="https://github.com/jkronegg">@jkronegg</a> I think this will do. But do have a look at my changes too.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 10:28:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2759#issuecomment-1564705194">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>> <a href="https://github.com/jkronegg">@jkronegg</a> I think this will do. But do have a look at my changes too.</p>
<p>That's fine for me.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-19 04:07:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2760#issuecomment-1554411758">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-19 04:18:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2760#issuecomment-1554423553">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2760?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2760?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2760?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2760">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2760?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2760</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/f3dfd76d9ba8f1b6c6ea60b4d72408fa7e8c0350">f3dfd76</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b53204e60447551a916d4a7b7e2856e8167fbf76?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b53204e60447551a916d4a7b7e2856e8167fbf76?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b53204e60447551a916d4a7b7e2856e8167fbf76">b53204e</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2760 +/- ##
=========================================
Coverage 84.98% 84.98%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9535 9535
Branches 913 913
=========================================
Hits 8103 8103
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-02 07:31:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2760#issuecomment-1573837158">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-25 03:50:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2761#issuecomment-1562691811">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>In your project Cucumber gets two test discovery/execution requests. One when Maven makes a discovery request. And a second one through the JUnit Platform Suite engine. Normally the request made by Maven fails to discover any tests because Maven only requests the discovery of classes. However by setting the <code>cucumber.features</code> it will discover something.</p>
<p>So when using <code>cucumber.features</code> you must ensure that there is only a single execution of the Cucumber Engine.</p>
<p>Ultimately this comes down to a lack of proper support for the JUnit Platform in Maven (<a href="https://github.com/junit-team/junit5/issues/2849">junit-team/junit5#2849</a>) and IDEA. If that existed you would not have to use the JUnit Platform Suite Engine to run Cucumber.</p>
<p>Though I'm surprised you didn't see this warning:</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/b53204e60447551a916d4a7b7e2856e8167fbf76/cucumber-junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/DiscoverySelectorResolver.java#L39-L44">cucumber-jvm/cucumber-junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/DiscoverySelectorResolver.java</a></p>
<p>Lines 39 to 44 in </cucumber/cucumber-jvm/commit/b53204e60447551a916d4a7b7e2856e8167fbf76|b53204e></p>
<p>Duplicate of <a href="https://github.com/cucumber/cucumber-jvm/issues/2567">#2567</a>, <a href="https://github.com/cucumber/cucumber-jvm/pull/2498">#2498</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-25 23:59:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2762#issuecomment-1563898151">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Can you provide a code sample please ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 06:31:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2762#issuecomment-1564401152">Comment</a> on issue by <a href="https://github.com/cfroh1">cfroh1</a>
<p>Thanks for the fast reply.</p>
<p>Sure, you can find a complete minimal example here:<br />
<a href="https://github.com/cfroh1/cucumber_UnsatisfiableDependenciesException_sample">https://github.com/cfroh1/cucumber<em>UnsatisfiableDependenciesException</em>sample</a></p>
<p>Otherwise, the relevant classes are:</p>
<p>MyStepdefs.class</p>
<pre><code>public class MyStepdefs {
private final ComponentDependency componentDependency;
public MyStepdefs(final ComponentDependency componentDependency) {
this.componentDependency = componentDependency;
}
@Given("Some step")
public void someStep() {
}
}
</code></pre>
<p>ComponentDependency.class</p>
<pre><code>// You could also use a different pico component interface like Startable
public class ComponentDependency implements Disposable {
private final PojoDependency pojoDependency;
public ComponentDependency(final PojoDependency pojoDependency) {
this.pojoDependency = pojoDependency;
}
@Override
public void dispose() {
}
}
</code></pre>
<p>PojoDependency.class</p>
<pre><code>public class PojoDependency {
}
</code></pre>
<p>Running with Cucumber JVM 7.12.0 this will result in the following exception:</p>
<pre><code>org.picocontainer.injectors.AbstractInjector$UnsatisfiableDependenciesException: org.example.ComponentDependency has unsatisfied dependency 'class org.example.PojoDependency' for constructor 'public org.example.ComponentDependency(org.example.PojoDependency)' from org.picocontainer.DefaultPicoContainer
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-02 13:15:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2762#issuecomment-1574266208">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/cfroh1">@cfroh1</a> this issue is solved in cucumber 7.12.1</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-04 22:30:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2762#issuecomment-1576069661">Comment</a> on issue by <a href="https://github.com/cfroh1">cfroh1</a>
<p>Awesome, thanks a lot! :)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 07:29:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2763#issuecomment-1564481868">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I see that you're not using the <code>cucumber-bom</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 07:46:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2763#issuecomment-1564504509">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I also think the software you're using to visualize the dependency tree doesn't understand ranges because:</p>
<p>• <code>gherkin</code> depends on <code>[19.1.4,23.0.0)</code>
• <code>html-formatter</code> depends on <code>[18.0.0,23.0.0)</code>
• <code>xml-formatter</code> depends on <code>[21.0.1,23.0.0)</code>
• <code>cucumber-core</code> depends on <code>22.0.0</code></p>
<p>So this should converge to <code>22.0.0</code> without issue.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 12:19:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2763#issuecomment-1564824645">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I rewrote the dependencies to use the BOM and got no more conflicts. Thanks.</p>
<pre><code>&lt;dependencyManagement&gt;
&lt;dependencies&gt;
&lt;dependency&gt;
&lt;groupId&gt;io.cucumber&lt;/groupId&gt;
&lt;artifactId&gt;cucumber-bom&lt;/artifactId&gt;
&lt;version&gt;${cucumber.version}&lt;/version&gt;
&lt;type&gt;pom&lt;/type&gt;
&lt;scope&gt;import&lt;/scope&gt;
&lt;/dependency&gt;
&lt;/dependencies&gt;
&lt;/dependencyManagement&gt;
&lt;dependencies&gt;
&lt;dependency&gt;
&lt;groupId&gt;io.cucumber&lt;/groupId&gt;
&lt;artifactId&gt;cucumber-java&lt;/artifactId&gt;
&lt;scope&gt;test&lt;/scope&gt;
&lt;/dependency&gt;
&lt;dependency&gt;
&lt;groupId&gt;io.cucumber&lt;/groupId&gt;
&lt;artifactId&gt;cucumber-junit-platform-engine&lt;/artifactId&gt;
&lt;scope&gt;test&lt;/scope&gt;
&lt;/dependency&gt;
&lt;dependency&gt;
&lt;groupId&gt;io.cucumber&lt;/groupId&gt;
&lt;artifactId&gt;cucumber-picocontainer&lt;/artifactId&gt;
&lt;scope&gt;test&lt;/scope&gt;
&lt;/dependency&gt;
...
&lt;/dependencies&gt;
</code></pre>
<p><a href="https://user-images.githubusercontent.com/2843894/241305224-eab5fb2f-7e1f-4bae-af33-622dec298c4e.png">when<em>used</em>in<em>project</em>and_bom</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 12:17:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2764#issuecomment-1564822279">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2764?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2764?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2764?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2764">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2764?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2764</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/531d961bc13852c90704a2eba2f07da92a5799d4">531d961</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/383ab6d087549ab6d7b8244a349f15184ad65d5c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/383ab6d087549ab6d7b8244a349f15184ad65d5c?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/383ab6d087549ab6d7b8244a349f15184ad65d5c">383ab6d</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2764 +/- ##
=========================================
Coverage 84.98% 84.98%
Complexity 2725 2725
=========================================
Files 331 331
Lines 9537 9537
Branches 914 914
=========================================
Hits 8105 8105
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 13:41:05
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/jkronegg">jkronegg's</a> pull request
<p>Code wise, no remarks.</p>
<p>I suppose you have to register bottom up now because the container has been started already?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 14:20:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2764#issuecomment-1564968810">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>> I suppose you have to register bottom up now because the container has been started already?</p>
<p>Yes, exactly. As the container has already been started, it tries to create a component instance of the FirstComponent, but this doesn't work because the SecondComponent class is not yet registered. By registering the classes from the constructor parameters first, the SecondComponent is registered when the container creates the FirstComponent instance.</p>
<p>I don't know why is the behaviour different depending on whether the Disposable interface is implemented or not...</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-31 23:40:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2764#issuecomment-1571448372">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> can you merge the pull request if everything is fine please ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-26 17:40:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2765#issuecomment-1565109816">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2765?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2765?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2765?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2765">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2765?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2765</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/9c974c562fabe0b5912a4511b77241fe1becf60d">9c974c5</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/383ab6d087549ab6d7b8244a349f15184ad65d5c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/383ab6d087549ab6d7b8244a349f15184ad65d5c?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/383ab6d087549ab6d7b8244a349f15184ad65d5c">383ab6d</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2765 +/- ##
=========================================
Coverage 84.98% 84.98%
Complexity 2725 2725
=========================================
Files 331 331
Lines 9537 9537
Branches 914 914
=========================================
Hits 8105 8105
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-30 18:32:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2766#issuecomment-1569360798">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-05-30 18:43:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2766#issuecomment-1569366778">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2766?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2766?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2766?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2766">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2766?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2766</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/312531bbc4aae27b2cf74721280aca8d5ebad353">312531b</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/0058baff62ba8910fccb9a8195bc18b6e1e938fc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/0058baff62ba8910fccb9a8195bc18b6e1e938fc?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/0058baff62ba8910fccb9a8195bc18b6e1e938fc">0058baf</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2766 +/- ##
=========================================
Coverage 84.98% 84.98%
Complexity 2725 2725
=========================================
Files 331 331
Lines 9537 9537
Branches 914 914
=========================================
Hits 8105 8105
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-02 05:01:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2557#issuecomment-1573623707">Comment</a> on issue by <a href="https://github.com/Auto81">Auto81</a>
<p>Is there any pointers/gotchas/starting points/advice for anybody that might pick this up for implementation?</p>
<p>I think it's a great feature, with a real upside for writing and trusting scenario steps are doing as the keywords imply.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-05 16:26:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2695#issuecomment-1577683066">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Additional idea. Consider adding a <code>--junit-platform</code> flag or subcommand to the regular CLI that will delegate to the JUnit Platform for reduced friction.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-05 22:46:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2767#issuecomment-1577952309">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2767?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2767?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2767">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2767?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2767</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/f1ae18d7cc37b7ea3579630e3dee9287e9092868">f1ae18d</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/f31009999fe76bc2dcf2f40542aab9086f6baa96?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/f31009999fe76bc2dcf2f40542aab9086f6baa96?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/f31009999fe76bc2dcf2f40542aab9086f6baa96">f310099</a>) will <strong>decrease</strong> coverage by <code>0.03%</code>.<br />
> The diff coverage is <code>n/a</code>.</p>
<p>> ❗ Current head <a href="https://github.com/cucumber/cucumber-jvm/commit/f1ae18d7cc37b7ea3579630e3dee9287e9092868">f1ae18d</a> differs from pull request most recent head <a href="https://github.com/cucumber/cucumber-jvm/commit/972858a4216ebe5d72e20975e89342e62828aa37">972858a</a>. Consider uploading reports for the commit <a href="https://github.com/cucumber/cucumber-jvm/commit/972858a4216ebe5d72e20975e89342e62828aa37">972858a</a> to get more accurate results</p>
<pre><code>@@ Coverage Diff @@
## main #2767 +/- ##
============================================
- Coverage 84.98% 84.96% -0.03%
+ Complexity 2725 2723 -2
============================================
Files 331 331
Lines 9537 9537
Branches 914 914
============================================
- Hits 8105 8103 -2
- Misses 1108 1109 +1
- Partials 324 325 +1
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2767/indirect-changes?src=pr&el=tree-more&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|see 1 file with indirect coverage changes></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-06 15:00:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2768#issuecomment-1579506262">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-06 15:10:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2768#issuecomment-1579522304">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2768?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2768?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2768?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2768">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2768?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2768</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/fd2f815ce67446be2b95b3de4d0f7ed53f6dac46">fd2f815</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/f31009999fe76bc2dcf2f40542aab9086f6baa96?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/f31009999fe76bc2dcf2f40542aab9086f6baa96?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/f31009999fe76bc2dcf2f40542aab9086f6baa96">f310099</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2768 +/- ##
=========================================
Coverage 84.98% 84.98%
Complexity 2725 2725
=========================================
Files 331 331
Lines 9537 9537
Branches 914 914
=========================================
Hits 8105 8105
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-09 04:45:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2078#issuecomment-1584446288">Comment</a> on issue by <a href="https://github.com/Nihnyoki">Nihnyoki</a>
<p>Hello <a href="https://github.com/mpkorstanje">@mpkorstanje</a> ,</p>
<p>I am also in support of <a href="https://github.com/DiptangshuS">@DiptangshuS</a> on this request, I have the need to extend Cucumber.class to listen to TestStepStarted.class and TestStepFinished.class so I can get stepDefs names to write in a report. I am using cucumber version "7.12.0". I am happy to try an ulternative method if you can propose one?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-16 00:17:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2078#issuecomment-1594225044">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/Nihnyoki">@Nihnyoki</a> listening to TestStepStarted/TestStepFinished and generating reports seems something to be done using a plugin.</p>
<p>You reference the custom plugin in your cucumber test class:</p>
<pre><code>@Suite
@IncludeEngines("cucumber")
@SelectClasspathResource("features")
@ConfigurationParameter(key = PLUGIN_PROPERTY_NAME, value="mypackage.MyPlugin")
public class RunCucumberTest {
}
</code></pre>
<p>Then you write a plugin:</p>
<pre><code>package mypackage;
import io.cucumber.plugin.EventListener;
import io.cucumber.plugin.Plugin;
import io.cucumber.plugin.event.EventHandler;
import io.cucumber.plugin.event.EventPublisher;
import io.cucumber.messages.types.Envelope;
public class MyPlugin implements EventListener, Plugin {
private final EventHandler&lt;Envelope&gt; testParameterTypeHandler = (event) -&gt; {
// do something with the envelope, e.g. collect the events (it contains TestStepStarted/TestStepFinished events and a lot of other stuff)
if (event.getTestRunFinished().isPresent()) {
// write the report
}
};
public void setEventPublisher(EventPublisher eventPublisher) {
eventPublisher.registerHandlerFor(Envelope.class, this.testParameterTypeHandler);
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-16 00:18:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2769#issuecomment-1594227158">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Duplicate of <a href="https://github.com/cucumber/cucumber-jvm/issues/2078">#2078</a> (this issue could be reopen if needed, but I think this is not needed as the plugin mechanism can be used to generate reports).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-22 23:55:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2770#issuecomment-1603766097">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Having a <code>DefaultDocTypeTransformer</code> is not very flexible because you can have only one. Would it make more sense to have instead a DocType transformer/converter which is able to convert more than one class ? Let's say a transformer which can convert classes <code>A</code> and <code>B</code>, and another transformer which could convert classes <code>C</code> and <code>D</code>. In terms of implementation, this transformer whould have a method to determine if a type can be converted:</p>
<pre><code>public boolean canConvert(Type type) {
return ...
}
</code></pre>
<p>For a transformer which can convert any JSON into a Java type, the <code>canConvert(Type)</code> method would return always true.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-01 14:26:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2770#issuecomment-1616141135">Comment</a> on issue by <a href="https://github.com/driver733">driver733</a>
<p><a href="https://github.com/jkronegg">@jkronegg</a><br />
What I meant is to have one transformer method for each <code>contentType</code> and a fallback transformer.</p>
<p>For example, you can have a transformer method for the <code>JSON</code> <code>contentType</code>.</p>
<pre><code>@DefaultDocStringTypeTransformer(contentType="json")
public Object convert(String json, Type toType) {
return objectMapper.readValue(json, objectMapper.constructType(toType));
}
</code></pre>
<p>And you can also have a transformer method for the <code>XML</code> <code>contentType</code>.</p>
<pre><code>@DefaultDocStringTypeTransformer(contentType="xml")
public Object convert(String xml, Type toType) {
return ...
}
</code></pre>
<p>Lastly, you can have a fallback transformer, which is used if no transformers have been found for the corresponding <code>contentType</code>.</p>
<pre><code>@DefaultDocStringTypeTransformer
public Object convert(String contentType, String docString, Type toType) {
return ...
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-02 14:23:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2770#issuecomment-1616823606">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/driver733">@driver733</a> yes, sorry, I was unclear. I was suggesting to add a doctype transformer interface such as:</p>
<pre><code> interface MultiDocTypeTransformer {
/****
Returns true if a content of the given contentType can be converted to toType.
**/
public boolean canConvert(String contentType, Type toType);
/****
** Converts a string content of the given contentType to the toType type. Throws an exception when not possible.
**/
public Object convert(String content, String contentType, Type toType);
}
</code></pre>
<p>Then your implementation would be:</p>
<pre><code> class MyMultiDocTypeTransformer implements MultiDocTypeTransformer {
public boolean canConvert(String contentType, Type toType) {
return "json".equals(contentType);
}
public Object convert(String json, String contentType, Type toType) {
return objectMapper.readValue(json, objectMapper.constructType(toType));
}
}
</code></pre>
<p>Wouldn't be this approach more flexible than the default doctype transformer you proposes ? (this is a simple question, not a proposal, because I didn't check the feasibility).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-04 03:39:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2770#issuecomment-1620002471">Comment</a> on issue by <a href="https://github.com/driver733">driver733</a>
<p><a href="https://github.com/jkronegg">@jkronegg</a><br />
I think that it can work (theoretically), but since <code>Cucumber-JVM</code> has transitioned from the <code>TypeRegistryConfigurer</code> interface to the <code>@ParameterType</code> and <code>@DocStringType</code> annotations, I believe it would be better to use the annotations here too.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-27 02:36:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2771#issuecomment-1609140420">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><a href="https://github.com/jkronegg">@jkronegg</a> I think it's worth reverting <a href="https://github.com/cucumber/cucumber-jvm/pull/2725">#2725</a> now.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-27 03:52:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2771#issuecomment-1609263629">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/mszalbach">@mszalbach</a> sorry for the issue. The code repository <a href="https://github.com/mszalbach/CucumberDisposable">https://github.com/mszalbach/CucumberDisposable</a> gives me a 404 not found. Can you make the project visible or correct the URL ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-27 07:11:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2771#issuecomment-1609591399">Comment</a> on issue by <a href="https://github.com/mszalbach">mszalbach</a>
<p><a href="https://github.com/jkronegg">@jkronegg</a> Sorry I thought the repo was already public. That should be fixed now.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-28 22:30:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2771#issuecomment-1612453153">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>> <a href="https://github.com/jkronegg">@jkronegg</a> I think it's worth reverting <a href="https://github.com/cucumber/cucumber-jvm/pull/2725">#2725</a> now.</p>
<p>As the issue is fixed by <a href="https://github.com/cucumber/cucumber-jvm/pull/2772">#2772</a>, I don't see any advantage to revert <a href="https://github.com/cucumber/cucumber-jvm/pull/2725">#2725</a>. With the original code, the test harness was insufficient: lifecycle events were tested only on the first test scenario, not when using multiple test scenarios.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-02 13:49:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2771#issuecomment-1616814008">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/mszalbach">@mszalbach</a> thanks for the detailed bug report. This should be corrected with the fresh new Cucumber <a href="https://github.com/cucumber/cucumber-jvm/releases/tag/v7.13.0">v7.13.0</a>. Please excuse me for the wasted time.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-03 00:13:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2771#issuecomment-1617504067">Comment</a> on issue by <a href="https://github.com/mszalbach">mszalbach</a>
<p>Thanks a lot. I am looking forward to use this as soon as the release hits Maven central.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-03 00:28:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2771#issuecomment-1617524827">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>That maybe take a minute. The key expired. <a href="https://github.com/cucumber/cucumber-jvm/actions/runs/5437899604/jobs/9888762794">https://github.com/cucumber/cucumber-jvm/actions/runs/5437899604/jobs/9888762794</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-07 02:28:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2771#issuecomment-1625127564">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Release has been made.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-07 03:43:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2771#issuecomment-1625220880">Comment</a> on issue by <a href="https://github.com/mszalbach">mszalbach</a>
<p>Thanks. Release works and my job is back in the green.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-28 00:26:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2772#issuecomment-1610907692">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2772?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2772?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2772?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2772">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2772?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2772</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b47961471f3f043ed9b6bbe6485883acdeaa24fc">b479614</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/45c524d4dc17e811807e0b54b3df15e9a43dfe36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/45c524d4dc17e811807e0b54b3df15e9a43dfe36?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/45c524d4dc17e811807e0b54b3df15e9a43dfe36">45c524d</a>) will <strong>increase</strong> coverage by <code>0.00%</code>.<br />
> The diff coverage is <code>100.00%</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2772 +/- ##
=========================================
Coverage 84.98% 84.99%
- Complexity 2725 2727 +2
=========================================
Files 331 331
Lines 9537 9542 +5
Branches 914 915 +1
=========================================
+ Hits 8105 8110 +5
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-30 07:04:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2772#discussion_r1247905206">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Performance wise, how do the different branches compare? If there still an appreciable performance gain?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-30 12:35:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2772#discussion_r1248223510">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Yes, performance is still good. JMH micro-benchmark shows:</p>
<p>The benchmark consists in instanciating a new PicoFactory ouside the benchmark, then adding 7 classes (containing 183 step defs in total), then start the factory, get one instance and stop the factory:</p>
<pre><code>public class PicoFactoryBenchmark {
@Benchmark
public List&lt;Object&gt; v7_11_1(PicoFactoryPlan plan) {
return benchmark(plan.picoFactory7_11_1);
}
@Benchmark
public List&lt;Object&gt; v7_12_1(PicoFactoryPlan plan) {
return benchmark(plan.picoFactory7_12_1);
}
@Benchmark
public List&lt;Object&gt; v7_13(PicoFactoryPlan plan) {
return benchmark(plan.picoFactory7_13);
}
private static List&lt;Object&gt; benchmark(ObjectFactory objectFactory) {
List&lt;Object&gt; instances = new ArrayList&lt;&gt;();
objectFactory.addClass(A.class);
objectFactory.addClass(B.class);
objectFactory.addClass(C.class);
objectFactory.addClass(D.class);
objectFactory.addClass(F.class);
objectFactory.addClass(F.class);
objectFactory.addClass(G.class);
objectFactory.start();
instances.add(objectFactory.getInstance(A.class));
objectFactory.stop();
return instances;
}
}
</code></pre>
<p>I think the version from Cucumber 7.12.1 is about 10% faster than the new code for 7.13 because the pico-container is started in the constructor (that is, outside the benchmark). But this code for 7.13 is still 30 times faster than in Cucumber 7.11.1.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-28 09:12:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2773#issuecomment-1611718119">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You've got the wrong version of Cucumber. Try with the latest. ;)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-28 10:01:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2773#issuecomment-1611781656">Comment</a> on issue by <a href="https://github.com/iamsethi">iamsethi</a>
<p>> You've got the wrong version of Cucumber. Try with the latest. ;)</p>
<p>which version i should use?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-15 11:11:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2773#issuecomment-1636846864">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Have a look around the repo. The latest version should be listed in a few places.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-29 23:01:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2774#issuecomment-1614168836">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/Djonathan-Kaiper-Carguero">@Djonathan-Kaiper-Carguero</a> It looks like you want to propose a new functionality in Cucumber. Could you please describe your proposition with greater details ?</p>
<p>Note that Github issues are not supposed to be a discussion channel (for discussions, we have the Cucumber Slack channel <a href="https://cucumber.io/docs/community/get-in-touch/">https://cucumber.io/docs/community/get-in-touch/</a>)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-30 03:48:13
*Thread Reply:*
New comment on issue by <a href="https://github.com/Djonathan-Kaiper-Carguero">Djonathan-Kaiper-Carguero</a>
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-30 03:56:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2774#issuecomment-1614488143">Comment</a> on issue by <a href="https://github.com/Djonathan-Kaiper-Carguero">Djonathan-Kaiper-Carguero</a>
<p><a href="https://github.com/jkronegg">@jkronegg</a> In this case, you need to run runner and then rerun in the same jenkins job and I'm having trouble getting it to run.</p>
<p>Thinking we have the halls.<br />
TestRunner - With all scenarios<br />
TestRunnerRerun- Only tests fail on first run</p>
<p>The command would be this, but do not run anything in the second runner even testing failed data, this in the jenkins job.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-02 11:30:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2774#issuecomment-1616766446">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>It sounds like you've got a problem with Jenkins. This is the issue tracker for Cucumber, we can't really with Jenkins problems.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-29 22:55:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2775#issuecomment-1614165189">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p><a href="https://github.com/Djonathan-Kaiper-Carguero">@Djonathan-Kaiper-Carguero</a> It looks like you would like a new functionality in Cucumber... Could you please explain with greater details what is your current issue and what should Cucumber do in the future to solve your issue ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-30 03:53:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2775#issuecomment-1614485020">Comment</a> on issue by <a href="https://github.com/Djonathan-Kaiper-Carguero">Djonathan-Kaiper-Carguero</a>
<p><a href="https://github.com/jkronegg">@jkronegg</a><br />
When we run cucumber vi runner scenarios it generates a cucucumber<em>report.json, however we have the possibility of creating another runner to run the failed tests of the first run, but it will generate a new json<br />
cucumber</em>report_rerun.json.</p>
<p>Would the proposal be to create a combination of all JSON, taking into account the re-execution?</p>
<p>Any doubt I am available</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-02 11:28:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2775#issuecomment-1616765913">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Unfortunately it is not possible to merge reports within Cucumber. The test run and the rerun are two separate executions of Cucumber. Because there no overarching session, Cucumber lacks the awareness needed to merge the results from multiple executions (<a href="https://github.com/cucumber/cucumber-jvm/issues/2672">#2672</a> is somewhat related).</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-30 09:30:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/1708#issuecomment-1614897439">Comment</a> on issue by <a href="https://github.com/Diego11914">Diego11914</a>
<p>i have the same issue<br />
<a href="https://user-images.githubusercontent.com/49316187/250145771-4192ea8c-3b19-4862-ad24-e9171cc72d73.png">imagen</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-06-30 09:44:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/1708#issuecomment-1614911888">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Do read all the warnings. You've got your imports mixed up.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-08 05:04:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2776#issuecomment-1627187211">Comment</a> on issue by <a href="https://github.com/shivam-sehgal">shivam-sehgal</a>
<p><a href="https://github.com/Prakash-QA">@Prakash-QA</a>, tags expect a logical operator between them. For example, if you pass "<a href="https://github.com/Set1">@Set1</a> or <a href="https://github.com/SET2">@SET2</a>", it will work as expected. The "beforeall" will be executed first, and "before" will be executed before each scenario. However, I noticed that if we use a comma (",") between two tags like you did, it doesn't give the expected error. Let's proceed with running it, and I will look into it further.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-08 06:11:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2776#issuecomment-1627260830">Comment</a> on issue by <a href="https://github.com/Prakash-QA">Prakash-QA</a>
<p>> <a href="https://github.com/Prakash-QA">@Prakash-QA</a>, tags expect a logical operator between them. For example, if you pass "<a href="https://github.com/Set1">@Set1</a> or <a href="https://github.com/SET2">@SET2</a>", it will work as expected. The "beforeall" will be executed first, and "before" will be executed before each scenario. However, I noticed that if we use a comma (",") between two tags like you did, it doesn't give the expected error. Let's proceed with running it, and I will look into it further.</p>
<p>Thank you <a href="https://github.com/shivam-sehgal">@shivam-sehgal</a> . When I use conditional operator it works.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-08 08:49:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2776#issuecomment-1627386299">Comment</a> on issue by <a href="https://github.com/shivam-sehgal">shivam-sehgal</a>
<p>Hello, <a href="https://github.com/mpkorstanje">@mpkorstanje</a> has submitted a pull request <a href="https://github.com/cucumber/tag-expressions/pull/107">PR</a> to address this issue. This PR aims to prevent others from encountering the same problem. I kindly request a review of the changes to ensure their effectiveness and potential integration into the project. Your assistance and feedback would be greatly appreciated.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-08 21:50:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2776#issuecomment-1627604221">Comment</a> on issue by <a href="https://github.com/Prakash-QA">Prakash-QA</a>
<p>> Hello, <a href="https://github.com/mpkorstanje">@mpkorstanje</a> has submitted a pull request <a href="https://github.com/cucumber/tag-expressions/pull/107">PR</a> to address this issue. This PR aims to prevent others from encountering the same problem. I kindly request a review of the changes to ensure their effectiveness and potential integration into the project. Your assistance and feedback would be greatly appreciated.</p>
<p>Thank you for the update</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-11 01:24:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2767#discussion_r1259382580">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Please try to avoid star imports.</p>
<p>We've got a checkstyle rule against it. Not sure why it didn't trigger.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/main/pom.xml#L448C1-L448C69">https://github.com/cucumber/cucumber-jvm/blob/main/pom.xml#L448C1-L448C69</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-24 14:03:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2767#discussion_r1272753896">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>The checkstyle plugin ran, but by default, the it does not verify test classes. To do that, we need to change the configuration, see <a href="https://stackoverflow.com/questions/55712919/checkstyle-does-not-pick-up-src-test-folder">https://stackoverflow.com/questions/55712919/checkstyle-does-not-pick-up-src-test-folder</a></p>
<pre><code>&lt;configuration&gt;
...
&lt;includeTestSourceDirectory&gt;true&lt;/includeTestSourceDirectory&gt;
&lt;/configuration&gt;
</code></pre>
<p>Should we also apply the checkstyle plugin on test classes ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-17 02:15:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2777#issuecomment-1637663510">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Neither Cucumber nor JUnit 5 does not support retrying tests. But you can use the JUnit Platform API to rerun the failed scenarios a second time.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine#rerunning-failed-scenarios">https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine#rerunning-failed-scenarios</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-18 20:50:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2778#issuecomment-1641372720">Comment</a> on issue by <a href="https://github.com/pabitra-qa">pabitra-qa</a>
<p>Hi <a href="https://github.com/mpkorstanje">@mpkorstanje</a>, Could you please help with this issue?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-18 00:55:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2588#issuecomment-1639702550">Comment</a> on issue by <a href="https://github.com/zinking">zinking</a>
<p>> Thanks for your feedback. It was indeed a packaging problem. I resolved the issue by using the Spring Boot Maven plugin for packaging and it works.
>
> <code>
&gt; &lt;plugin&gt;
&gt; &lt;groupId&gt;org.springframework.boot&lt;/groupId&gt;
&gt; &lt;artifactId&gt;spring-boot-maven-plugin&lt;/artifactId&gt;
&gt; &lt;version&gt;2.6.10&lt;/version&gt;
&gt; &lt;executions&gt;
&gt; &lt;execution&gt;
&gt; &lt;goals&gt;
&gt; &lt;goal&gt;repackage&lt;/goal&gt;
&gt; &lt;/goals&gt;
&gt; &lt;/execution&gt;
&gt; &lt;/executions&gt;
&gt; &lt;configuration&gt;
&gt; &lt;mainClass&gt;io.cucumber.core.cli.Main&lt;/mainClass&gt;
&gt; &lt;/configuration&gt;
&gt; &lt;/plugin&gt;
&gt;</code></p>
<p><a href="https://github.com/ebendal">@ebendal</a> spring-boot-maven-plugin typically doesn't include test classes, and my tests all reside on the test scope (which is typical I think), how do you resolve that.</p>
<p>do you mind sharing key pieces of pom.xml here?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-18 01:05:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2588#issuecomment-1639721268">Comment</a> on issue by <a href="https://github.com/ebendal">ebendal</a>
<p><a href="https://github.com/zinking">@zinking</a> see this <a href="https://github.com/ebendal/cucumber-spring-standalone">repo</a> for a working example, including <code>pom.xml</code>.</p>
<p>When your tests are running during the Maven build, then a <code>test</code> scope would be correct. But in my use case (and maybe yours), I want to run these tests from an executable jar somewhere else. Therefore you should see the test suite as <code>main</code> code that should be packaged in your executable jar.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-18 01:10:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2588#issuecomment-1639727840">Comment</a> on issue by <a href="https://github.com/zinking">zinking</a>
<p>> repo</p>
<p>thanks for the reply.</p>
<p>and in the spring-boot-maven-plugin repo, devs replied they won't support repackage test scopes as well.</p>
<p>so yeah, since I need to run it standalone, maybe it's no longer test scope anymore.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-23 08:11:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2779#issuecomment-1646865859">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-23 08:18:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2779#issuecomment-1646867449">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2779?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2779?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2779?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2779">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2779?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2779</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/b02bd21d74caa0a4e4143fc45f1a07fb65c7ae70">b02bd21</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/dc1b89a7c560232b252e698cf9b4ea6c9062d668?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/dc1b89a7c560232b252e698cf9b4ea6c9062d668?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/dc1b89a7c560232b252e698cf9b4ea6c9062d668">dc1b89a</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2779 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-08 09:24:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2779#issuecomment-1669930879">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-24 10:12:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2780#issuecomment-1648293224">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>With the <code>cucumber-junit-platform-engine</code> Cucumber supports the JUnit Platform. This means that through the JUnit Platform you can already discover, select and execute any or all Features, Scenarios and Example in files, directories, class path roots and resources, ect, ect. This should in theory be enough for any build tool or IDE to run anything from a single scenario in a file to every feature on the classpath.</p>
<p>Unfortunately Gradle uses a rather limited part of the JUnit Platform. The Suite class is a work around for this specific problem. And I don't see much value in a contribution that adds a workaround on top of another workaround. You should feel free of-course to publish this plugin on your own if you are inclined to do so.</p>
<p>But I do see that you are a software engineer at Gradle, perhaps you could direct your efforts towards improving support for the JUnit Platform in Gradle (<a href="https://github.com/gradle/gradle/issues/4773">gradle/gradle#4773</a>, <a href="https://github.com/gradle/gradle/issues/4912">gradle/gradle#4912</a>, <a href="https://github.com/gradle/gradle/issues/4252">gradle/gradle#4252</a>, <a href="https://github.com/gradle/gradle/issues/5678">gradle/gradle#5678</a>)? And while I don't know how Gradles predictive test selection works under the hood, I suspect that a similar effort could be made there.</p>
<p>For IDE's things are a bit trickier. The <a href="https://github.com/cucumber/cucumber-eclipse">cucumber-eclipse</a> plugin needs a lot of love. IDEA is stuck on using <code>io.cucumber.core.cli.Main</code> to run tests (<a href="https://youtrack.jetbrains.com/issue/IDEA-227508">https://youtrack.jetbrains.com/issue/IDEA-227508</a>). I don't know the state of the art on VSCode. But ideally they'd use the <code>FileSelector</code> and <code>ClasspathResourceSelector</code> for feature file to implement context sensitive run buttons/gutter icons.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-25 02:58:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2780#issuecomment-1649509424">Comment</a> on issue by <a href="https://github.com/leonard84">leonard84</a>
<p>I'm aware of the capabilities of the JUnit Platform and the current limited support it gets. This suggestion, while not the ideal solution, will improve the user experience across for Gradle and Maven, as well as the IDEs. It is several orders of magnitude simpler to implement than enhancing all the other tools. The reality is I only have a limited amount of time to spend on the topic of better cucumber support, and the alternative is to get no improvement at all.</p>
<p>If you are not interested in accepting these as contributions to the project, then we’ll consider publishing them as standalone plugins.</p>
<p>> But I do see that you are a software engineer at Gradle, perhaps you could direct your efforts towards improving support for the JUnit Platform in Gradle</p>
<p>Yes I work at Gradle, but not on the Gradle Build Tool.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-07-25 07:23:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2780#issuecomment-1649944699">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Ah. That is unfortunate. Perhaps you can flag this internally as a structural problem within Gradle. It is a rather sorry state of affairs that we have a common test platform but do not see it fully utilized in our build tools.</p>
<p>In the past there have been a few code generating plugins (e.g. <a href="https://github.com/temyers/cucumber-jvm-parallel-plugin/blob/master/readme_archive.md">temyers/cucumber-jvm-parallel-plugin</a>) that were used to generate runner classes for parallel execution. These tend to be quite feature rich to gracefully work around the consequences of running cucumber multiple times. This is more complexity than I'd care to support.</p>
<p>Now it does seems to me that the primary beneficiaries of this plugin are Gradle Enterprise users, who can use it to work around a limitation in Gradle. So it seems only fair that Gradle carries the maintenance burden for this plugin. So I reckon you should consider publishing a standalone plugin.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-01 02:22:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2754#issuecomment-1659920340">Comment</a> on issue by <a href="https://github.com/p-nikolaichik">p-nikolaichik</a>
<p>I decided to compare run using selenium instead of serenity to be totally sure and saw that selenium with junit5 and cucumber doesn't have such problems. I created ticket in serenity project: <a href="https://github.com/serenity-bdd/serenity-core/issues/3202">serenity-bdd/serenity-core#3202</a> and attached simple project reproducer there</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-01 03:52:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2754#issuecomment-1660069286">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers! Looks like the problem is caused by Serenity then. Should it still turnout to be a problem with Cucumber and JUnit 5 please do feel free to open a more specific issue.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-03 06:38:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2781#issuecomment-1664001985">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-08 10:07:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2781#issuecomment-1669996921">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2781?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2781?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2781?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2781">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2781?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2781</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/f06bca8c22cd54791bb1ecb782282180c38f58fc">f06bca8</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/394c2079996706e07d91ea3cfd8a18d6e98b5864?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/394c2079996706e07d91ea3cfd8a18d6e98b5864?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/394c2079996706e07d91ea3cfd8a18d6e98b5864">394c207</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2781 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-08 10:11:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2781#issuecomment-1670001208">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-05 12:25:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2782#issuecomment-1666586334">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Yeah, this was pretty intentional <a href="https://github.com/cucumber/cucumber-jvm/pull/2498">#2498</a>.</p>
<p>As the warning in the logs and documentation advices, when using <code>cucumber.features</code> any selectors from the JUnit Platform are ignored.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/508c7d6336a564ec35c3c54f3d718d04f4adda76/cucumber-junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/DiscoverySelectorResolver.java#L34-L44">cucumber-jvm/cucumber-junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/DiscoverySelectorResolver.java</a></p>
<p>Lines 34 to 44 in </cucumber/cucumber-jvm/commit/508c7d6336a564ec35c3c54f3d718d04f4adda76|508c7d6></p>
<p>If you are using the JUnit Platform API you should use the <code>DiscoverySelectors</code> from the JUnit Platform. If you are using the JUnit Platform Suite Engine, the dedicated <code>@Select**</code> annotations from the JUnit suite api.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-07 02:15:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2782#issuecomment-1667495403">Comment</a> on issue by <a href="https://github.com/orcunbalcilar">orcunbalcilar</a>
<p>Thank you for your response. Sorry, I did not see duplicate issues.</p>
<p>Note: To anyone who have the same issue (in Junit5 rerun cucumber scenarios), you can find my solution below ----></p>
<ol><li>Add testng and cucumber-testng dependencies in test scope to pom.xml
<pre><code> &lt;dependency&gt;
&lt;groupId&gt;org.testng&lt;/groupId&gt;
&lt;artifactId&gt;testng&lt;/artifactId&gt;
&lt;version&gt;7.7.1&lt;/version&gt;
&lt;scope&gt;test&lt;/scope&gt;
&lt;/dependency&gt;
&lt;dependency&gt;
&lt;groupId&gt;io.cucumber&lt;/groupId&gt;
&lt;artifactId&gt;cucumber-testng&lt;/artifactId&gt;
&lt;version&gt;7.11.1&lt;/version&gt;
&lt;scope&gt;test&lt;/scope&gt;
&lt;/dependency&gt;
</code></pre></li><li>Create an TestNG Cucumber Suite class
<pre><code> import io.cucumber.testng.AbstractTestNGCucumberTests;
import io.cucumber.testng.CucumberOptions;
import org.testng.annotations.DataProvider;
@CucumberOptions(features = "@rerun.txt", glue = {"(your glue)"}, plugin = {
"pretty"}, monochrome = true)
public class RerunCucumberScenarios extends AbstractTestNGCucumberTests {
@DataProvider(parallel = true)
@Override
public Object[][] scenarios() {
return super.scenarios();
}
}
</code></pre></li><li>Force maven surefire plugin to use TestNG auto detection provider by creating maven profiles.</li>
</ol>
<pre><code> &lt;profiles&gt;
&lt;profile&gt;
&lt;id&gt;default&lt;/id&gt;
&lt;activation&gt;
&lt;activeByDefault&gt;true&lt;/activeByDefault&gt;
&lt;/activation&gt;
&lt;build&gt;
&lt;plugins&gt;
&lt;plugin&gt;
&lt;groupId&gt;org.apache.maven.plugins&lt;/groupId&gt;
&lt;artifactId&gt;maven-surefire-plugin&lt;/artifactId&gt;
&lt;version&gt;3.1.2&lt;/version&gt;
&lt;/plugin&gt;
&lt;plugin&gt;
&lt;groupId&gt;org.apache.maven.plugins&lt;/groupId&gt;
&lt;artifactId&gt;maven-compiler-plugin&lt;/artifactId&gt;
&lt;configuration&gt;
&lt;source&gt;17&lt;/source&gt;
&lt;target&gt;17&lt;/target&gt;
&lt;/configuration&gt;
&lt;/plugin&gt;
&lt;/plugins&gt;
&lt;/build&gt;
&lt;/profile&gt;
&lt;profile&gt;
&lt;id&gt;rerun&lt;/id&gt;
&lt;build&gt;
&lt;plugins&gt;
&lt;plugin&gt;
&lt;groupId&gt;org.apache.maven.plugins&lt;/groupId&gt;
&lt;artifactId&gt;maven-surefire-plugin&lt;/artifactId&gt;
&lt;version&gt;3.1.2&lt;/version&gt;
&lt;dependencies&gt;
&lt;dependency&gt;
&lt;groupId&gt;org.apache.maven.surefire&lt;/groupId&gt;
&lt;artifactId&gt;surefire-testng&lt;/artifactId&gt;
&lt;version&gt;3.1.2&lt;/version&gt;
&lt;/dependency&gt;
&lt;/dependencies&gt;
&lt;configuration&gt;
&lt;properties&gt;
&lt;property&gt;
&lt;name&gt;dataproviderthreadcount&lt;/name&gt;
&lt;value&gt;${threadCount}&lt;/value&gt;
&lt;/property&gt;
&lt;/properties&gt;
&lt;/configuration&gt;
&lt;/plugin&gt;
&lt;plugin&gt;
&lt;groupId&gt;org.apache.maven.plugins&lt;/groupId&gt;
&lt;artifactId&gt;maven-compiler-plugin&lt;/artifactId&gt;
&lt;configuration&gt;
&lt;source&gt;11&lt;/source&gt;
&lt;target&gt;11&lt;/target&gt;
&lt;/configuration&gt;
&lt;/plugin&gt;
&lt;/plugins&gt;
&lt;/build&gt;
&lt;/profile&gt;
&lt;/profiles&gt;
</code></pre>
<ol start="4"><li><p>Execute maven goal</p>
<p>mvn clean test -Dtest=RerunCucumberScenarios -DthreadCount=3 -P rerun<br />
//You are free to set any value to threadCount property. But cucumber.execution.parallel.config.fixed.parallelism ( or<br />
any other property that specifies the thread count in junit-platform.properties file) property value is recommended.</p>
<p>mvn clean test -Dcucumber.features="path/to/features"<br />
//This goal is for running all cucumber scenarios in your project. After this execution, you can execute the goal above<br />
to run the failed scenarios again.</p></li>
</ol>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-08 10:24:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2783#issuecomment-1670019472">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2783?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2783?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2783?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2783">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2783?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2783</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/7fede36783d1c1764e9daae08fab16107dc7a970">7fede36</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/394c2079996706e07d91ea3cfd8a18d6e98b5864?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/394c2079996706e07d91ea3cfd8a18d6e98b5864?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/394c2079996706e07d91ea3cfd8a18d6e98b5864">394c207</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2783 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-16 08:53:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2784#issuecomment-1680868866">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I seem to have some trouble reproducing your problem. Could you make a minimal reproducer by cloning the <a href="https://github.com/cucumber/cucumber-java-skeleton">https://github.com/cucumber/cucumber-java-skeleton</a>?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-17 01:13:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2784#issuecomment-1681837612">Comment</a> on issue by <a href="https://github.com/KMariusz">KMariusz</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> I've checked with skeleton project and compared to my own - it looks like the issue is on my site.<br />
Thanks for help - issue can be closed :)</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-22 01:15:36
*Thread Reply:*
Review comment by <a href="https://github.com/mlvandijk">mlvandijk</a> on their pull request
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-22 01:15:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2785#discussion_r1301228722">Comment</a> on pull request by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>"a map a list" does not look right, but Idk if it should be "a map, a list" or possibly something else.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-22 01:22:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2785#issuecomment-1687710815">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2785?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2785?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>> Merging <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2785?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|#2785">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2785?src=pr&el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|#2785</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/d9dd088252f0350831926d0fd2dc1cc655d8b2fa">d9dd088</a>) into <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/fc2e4026d9ef1f0761b0ac42d0f1ca93a3c0c560?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|main">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/fc2e4026d9ef1f0761b0ac42d0f1ca93a3c0c560?el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|main</a> (<a href="https://github.com/cucumber/cucumber-jvm/commit/fc2e4026d9ef1f0761b0ac42d0f1ca93a3c0c560">fc2e402</a>) will <strong>not change</strong> coverage.<br />
> The diff coverage is <code>n/a</code>.</p>
<pre><code>@@ Coverage Diff @@
## main #2785 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-22 10:04:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/1543#issuecomment-1688594161">Comment</a> on issue by <a href="https://github.com/eitzenbe">eitzenbe</a>
<p>Is there any update on this? I would think that adding a language to the anotation would allow at least IDE plugins to deal with it maybe even the cucumber parser?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-23 16:11:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2786#issuecomment-1690760411">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Your impression is correct. As a test framework, Cucumber shouldn't interfere with the system under test. So Jackson is shaded in to avoid just that.</p>
<p>Unfortunately Jackson is a moving target, and rather quick at that. We've had comparable problems in the past e.g. <a href="https://github.com/cucumber/cucumber-jvm/issues/2620">#2620</a>.</p>
<p>I would welcome a PR that resolves this. Unfortunately I can't currently investigate the issue in more detail. The correct solution however would ensure that the shaded Jackson works for Cucumber -- which uses a rather limited feature set -- so excluding <code>META-INF/versions</code> could be a solution depending on the functionality provided by <code>META-INF/versions</code> .</p>
<p>It would also be nice if we could configure something to check this doesn't happen in the future.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-24 05:18:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2786#issuecomment-1691570252">Comment</a> on issue by <a href="https://github.com/nhojpatrick">nhojpatrick</a>
<p>I'm getting issues with Jackson v2.15.2 on another project, but v2.15.1 works fine.<br />
Can you try again with jackson v2.15.1 and see if that fixes the issues.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-30 09:34:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2787#issuecomment-1699504273">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-08-30 09:39:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2787#issuecomment-1699511655">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2787?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2787?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>Patch and project coverage have no change.</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/7c918ffcc95f0c8677b6c54c468cf52adb21b42f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/7c918ffcc95f0c8677b6c54c468cf52adb21b42f?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>7c918ff</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2787?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2787?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>2315eb0</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2787 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2787?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-02 17:42:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2788#issuecomment-1703974532">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Could you include the full exception message please. It's important to understand exactly which branch of the transformation logic your code went into.</p>
<p>Please also include any (default) parameter types you've defined.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-02 18:12:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2788#issuecomment-1703978380">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>That said, I would guess you are using a default table entry transformer.</p>
<p>Data tables are effectively unstructured data. And Cucumber tries to guess based on the table shape and the target type how the table should be interpeted. These heuristics become inaccurate when tables with a single row or column are involved.</p>
<p>For example:</p>
<pre><code>| a | b |
</code></pre>
<p>This table could represent a list containing <code>a</code> and <code>b</code> or a an empty list of beans with properties a and b. The former interpretation would suggest using the default table cell transformer, the latter the default table entry transformer.</p>
<p>The application of the default table entry transformer would always succeed for the empty list. This has the potential to hide errors in both the specification and implementation.</p>
<p>So Cucumber refuses to transform tables with a single row using the default table entry transformer.</p>
<p>I think the cleanest solution would be to single out the empty case with an explicit step definition. And it might even be worth making it explicit if an empty list is expected or if no list is expected.</p>
<p>You can of course also explicitly register data table type.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-03 04:14:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2788#issuecomment-1704208227">Comment</a> on issue by <a href="https://github.com/Raawaan">Raawaan</a>
<p>stacktrace:</p>
<pre><code>Step failed
io.cucumber.core.exception.CucumberException: Could not convert arguments for step [The following dials] defined at 'com.orange.cvm.bdd.stepdefs.StepDefs(java.util.List&lt;TestDial&gt;)'.
It appears you did not register a data table type.
at io.cucumber.core.runner.PickleStepDefinitionMatch.registerDataTableTypeInConfiguration(PickleStepDefinitionMatch.java:96)
at io.cucumber.core.runner.PickleStepDefinitionMatch.runStep(PickleStepDefinitionMatch.java:50)
at io.cucumber.core.runner.ExecutionMode$1.execute(ExecutionMode.java:10)
at io.cucumber.core.runner.TestStep.executeStep(TestStep.java:84)
at io.cucumber.core.runner.TestStep.run(TestStep.java:56)
at io.cucumber.core.runner.PickleStepTestStep.run(PickleStepTestStep.java:51)
at io.cucumber.core.runner.TestCase.run(TestCase.java:84)
at io.cucumber.core.runner.Runner.runPickle(Runner.java:75)
at io.cucumber.core.runtime.Runtime.lambda$executePickle$6(Runtime.java:107)
at io.cucumber.core.runtime.CucumberExecutionContext.lambda$runTestCase$5(CucumberExecutionContext.java:137)
at io.cucumber.core.runtime.RethrowingThrowableCollector.executeAndThrow(RethrowingThrowableCollector.java:23)
at io.cucumber.core.runtime.CucumberExecutionContext.runTestCase(CucumberExecutionContext.java:137)
at io.cucumber.core.runtime.Runtime.lambda$executePickle$7(Runtime.java:107)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at io.cucumber.core.runtime.Runtime$SameThreadExecutorService.execute(Runtime.java:235)
at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:123)
at io.cucumber.core.runtime.Runtime.lambda$runFeatures$3(Runtime.java:89)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.SliceOps$1$1.accept(SliceOps.java:200)
at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1602)
at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
at io.cucumber.core.runtime.Runtime.runFeatures(Runtime.java:90)
at io.cucumber.core.runtime.Runtime.lambda$run$0(Runtime.java:78)
at io.cucumber.core.runtime.CucumberExecutionContext.lambda$runFeatures$6(CucumberExecutionContext.java:148)
at io.cucumber.core.runtime.CucumberExecutionContext.execute(CucumberExecutionContext.java:163)
at io.cucumber.core.runtime.CucumberExecutionContext.runFeatures(CucumberExecutionContext.java:146)
at io.cucumber.core.runtime.Runtime.run(Runtime.java:78)
at io.cucumber.core.cli.Main.run(Main.java:87)
at io.cucumber.core.cli.Main.main(Main.java:30)
Caused by: io.cucumber.datatable.UndefinedDataTableTypeException: Can't convert DataTable to List&lt;TestDial&gt;.
Please review these problems:
</code></pre>
<p>I have registered data-table transformer explicitly and it's working now thank you.</p>
<pre><code> @DataTableType
public TestDial testDialTransformer(Map&lt;String, String&gt; fromValue) {
return mapper.convertValue(fromValue, TestDial.class);
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-06 11:00:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2791#issuecomment-1708849873">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Best I can tell you is to start over with the <code>cucumber-java-skeleton</code> and then build up step by step until you can reproduce your problem in a more controlled scenario.</p>
<p><a href="https://github.com/cucumber/cucumber-java-skeleton/">https://github.com/cucumber/cucumber-java-skeleton/</a></p>
<p>That said, since the class that couldn't be found is part of the JDK, it might also be worth trying a different JDK with an LTS version.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-09 03:39:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2792#issuecomment-1712480862">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<https://github.com/cucumber/cucumber-jvm/pull/2792|#2792 Update openwebbeans.version to v4 (major)>
<p><strong>Renovate Ignore Notification</strong></p>
<p>Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for <em>any</em> future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable <code>minor</code> and <code>patch</code> updates automatically.</p>
<p>If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-09 03:20:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2793#issuecomment-1712477220">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2793?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2793?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>Patch and project coverage have no change.</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b0a437398131e8ddda2e4df5f1b46e975a124bef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b0a437398131e8ddda2e4df5f1b46e975a124bef?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>b0a4373</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2793?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2793?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>33dcaf5</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2793 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2793?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-14 06:22:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2794#issuecomment-1719443442">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-14 06:30:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2794#issuecomment-1719457071">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2794?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2794?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>Patch and project coverage have no change.</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/18caaf92dccb2f5d0d95fa862f728c3c362e4454?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/18caaf92dccb2f5d0d95fa862f728c3c362e4454?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>18caaf9</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2794?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2794?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>7a858d1</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2794 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2794?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-15 10:29:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2796#issuecomment-1721617671">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2796?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2796?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>Patch and project coverage have no change.</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/18caaf92dccb2f5d0d95fa862f728c3c362e4454?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/18caaf92dccb2f5d0d95fa862f728c3c362e4454?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>18caaf9</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2796?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2796?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>48e3578</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2796 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2796?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-21 11:20:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2797#issuecomment-1730082409">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Would you be able to narrow down in which version specifically this behavior changed?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-22 12:34:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2797#issuecomment-1731944610">Comment</a> on issue by <a href="https://github.com/BenjaminTanguay">BenjaminTanguay</a>
<p>I believe the behavior change occured between version 7.1.0 and 7.2.0</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/compare/v7.1.0...v7.2.0">v7.1.0...v7.2.0</a></p>
<p>I'm not an expert on this codebase but from the PRs mentionned in the 7.2.0 changelog, this one could be the source of the changed behavior:</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/pull/2432/files">https://github.com/cucumber/cucumber-jvm/pull/2432/files</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-23 11:00:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2797#issuecomment-1732376967">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers! That helped!</p>
<p>The changes from <a href="https://github.com/cucumber/cucumber-jvm/pull/2432">#2432</a> moved the creation of the Injector. In v7.1.0 it used to be created in the constructor:</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/ba275bf41bf83ec69549025775624ca5ecf3429c/guice/src/main/java/io/cucumber/guice/GuiceFactory.java#L17-L19">cucumber-jvm/guice/src/main/java/io/cucumber/guice/GuiceFactory.java</a></p>
<p>Lines 17 to 19 in </cucumber/cucumber-jvm/commit/ba275bf41bf83ec69549025775624ca5ecf3429c|ba275bf></p>
<p>And since v7.2.0 it is created when the first test on a specific thread starts:</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/fd1d7f1b849584e15fae4b1e0d3701603b00640e/guice/src/main/java/io/cucumber/guice/GuiceFactory.java#L70-L76">cucumber-jvm/guice/src/main/java/io/cucumber/guice/GuiceFactory.java</a></p>
<p>Lines 70 to 76 in </cucumber/cucumber-jvm/commit/fd1d7f1b849584e15fae4b1e0d3701603b00640e|fd1d7f1></p>
<p>Unfortunately fixing this while retaining the functionality added in <a href="https://github.com/cucumber/cucumber-jvm/pull/2432">#2432</a> is rather difficult. <code>ObjectFactory</code> implementations are intended to create objects injected into scenarios and aren't designed to work out side of that scope. For example, each thread instantiates its own <code>ObjectFactory</code> instance. So there is no guarantee that injection of static fields happens only once or exclusively prior to test execution. This happens when executing in parallel on a ForkJoinPool.</p>
<p>One possible option would be to add implement something like the <https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/extension/BeforeAllCallback.html|<code>BeforeAllCallback</code><br />
>from JUnit 5. When implemented by the <code>GuiceFactory</code> this could be used to create the <code>Injector</code> exactly once. And I suppose each scenario could then use <code>Injector.createChildInjector()</code> to avoid conflicts with other scenarios. But that's stretching my knowledge of Guice a bit.</p>
<p>A complicating factor here is that Cucumbers internals and state management is all rather adhoc. So implementing anything like JUnit 5s <code>BeforeAllCallback</code> and by extension JUnit5s extension system is anything but trivial.</p>
<p>If you need a more immediate solution, you may be better of lifting the v7.2 implementation of the Guice factory into your own project instead.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-25 12:01:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2797#issuecomment-1734305280">Comment</a> on issue by <a href="https://github.com/BenjaminTanguay">BenjaminTanguay</a>
<p>I traced the code a little bit and I'm sure this is probably a naive take but I don't see why it's impossible restoring the old behavior. I'll try and detail what I understood to see if I got something wrong.</p>
<p>As far as I understand it, the start method of the ObjectFactory is responsible for starting the injection no matter the framework used.</p>
<p>The supplier that provides this ObjectFactory is created in the build method of the Runtime object, and invoked before the runtime is started. This is logical: we first parse things before we start our tests.</p>
<p>The supplier that provides the ObjectFactory is invoked in the <code>getRunner</code> method of the <code>CucumberExecutionContext</code> class. This getRunner is called before three methods: <code>beforeAllHooks</code>, <code>afterAllHooks</code>, and <code>runTestCase</code>. That is to say that the ObjectMapperProvider is available before <code>beforeAllHooks</code> is called. In my mind, that means that it would be possible to add some code in the <code>beforeAllHooks</code> method to start the ObjectFactory.</p>
<p>The Runner class currently only invokes the <code>start</code> method of the ObjectFactory in the <code>buildBackendWorlds</code> method, as part of the <code>runPickle</code> method. Wouldn't it possible to have the Runner class invoke <code>objectFactory.start()</code> in the <code>runBeforeAllHooks()</code> it exposes? If not, then it could alternatively expose an <code>inject</code> method that is called by the portion of the <code>CucumberExecutionContext</code> class resposible for handling beforeAllHooks.</p>
<p>Where did I go wrong?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-25 14:48:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2797#issuecomment-1734510763">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Fundamentally, I don't think it is impossible. But I do think the amount of work and complexity involved is significant. Especially for the time I'm currently able to dedicate to Cucumber.</p>
<p>To explain...</p>
<p>Currently the <code>Runner</code>, <code>Backend</code> and <code>ObjectFactory</code> implementations are effectively thread local.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/0a0f1730eded36c8367ea2e966acbf1fffdeb7dc/cucumber-junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/CucumberEngineExecutionContext.java#L58-L63">cucumber-jvm/cucumber-junit-platform-engine/src/main/java/io/cucumber/junit/platform/engine/CucumberEngineExecutionContext.java</a></p>
<p>Lines 58 to 63 in </cucumber/cucumber-jvm/commit/0a0f1730eded36c8367ea2e966acbf1fffdeb7dc|0a0f173></p>
<p>So for every thread, a new instance of the <code>ObjectFactory</code> is created. This means that the invocation of it's constructor isn't equivalent to a before all hook. It also means that there can be more than one <code>ObjectFactory</code>.</p>
<p>> Wouldn't it possible to have the Runner class invoke objectFactory.start() in the runBeforeAllHooks() it exposes? If not, then it could alternatively expose an inject method that is called by the portion of the CucumberExecutionContext class resposible for handling beforeAllHooks.</p>
<p>No. The start/stop methods are invoked around a scenario. These are essential to keep state from leaking between scenarios.</p>
<p>It would be possible to add a <code>startBeforeAll</code> method instead that is invoked prior to the before all hooks.</p>
<p>But...</p>
<p>This would then require a way to ensure the <code>Injector</code> is only created once. And while it would be possible to create the <code>Injector</code> as a static variable, expecting people to do as part of an API is asking for problems.</p>
<p>A solution to that would be to provide <code>startBeforeAll</code> and <code>start</code> with a context object that can be used to store the <code>Injector</code>. And at this point we have re-invented the <code>BeforeAllCallBack</code> from JUnit 5.</p>
<p>Written from my phone. Apologies for any brevity.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-25 15:00:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2797#issuecomment-1734523393">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>That said looking at the <code>GuiceFactory</code> I do think that it is possible to instantiate the <code>Injector</code> eagerly.</p>
<p>Either when the from property is set:</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/0a0f1730eded36c8367ea2e966acbf1fffdeb7dc/cucumber-guice/src/main/java/io/cucumber/guice/GuiceFactory.java#L31">cucumber-jvm/cucumber-guice/src/main/java/io/cucumber/guice/GuiceFactory.java</a></p>
<p>Line 31 in </cucumber/cucumber-jvm/commit/0a0f1730eded36c8367ea2e966acbf1fffdeb7dc|0a0f173></p>
<p>Or when the from class is set</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/0a0f1730eded36c8367ea2e966acbf1fffdeb7dc/cucumber-guice/src/main/java/io/cucumber/guice/GuiceFactory.java#L42">cucumber-jvm/cucumber-guice/src/main/java/io/cucumber/guice/GuiceFactory.java</a></p>
<p>Line 42 in </cucumber/cucumber-jvm/commit/0a0f1730eded36c8367ea2e966acbf1fffdeb7dc|0a0f173></p>
<p>It would not be perfect because of the problems mentioned above, but I think it would at least restore the v7.1 behavior.</p>
<p>Would you mind looking into that possibility further?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-22 04:14:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2798#issuecomment-1731243070">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<https://github.com/cucumber/cucumber-jvm/issues/2798|#2798 Allow Before/After Hooks to be renamed >
<p>Cucumber has a few different runners and reports. Where do you see the after hooks represented as <code>After</code>?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-24 22:13:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2798#issuecomment-1732925709">Comment</a> on issue by <a href="https://github.com/ll-cyan">ll-cyan</a>
<https://github.com/cucumber/cucumber-jvm/issues/2798|#2798 Allow Before/After Hooks to be renamed >
<p>Im running the features through IntelliJ's run dialogue as such<br />
<a href="https://user-images.githubusercontent.com/145762637/270234216-f43dca54-382d-426f-8c6c-e981c6c68a93.png">image</a><br />
<a href="https://user-images.githubusercontent.com/145762637/270234485-b76c7b5e-0d5c-4514-9bc3-dd61deb72089.png">image</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-22 12:18:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2799#issuecomment-1731928377">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<https://github.com/cucumber/cucumber-jvm/pull/2799|#2799 Update actions/checkout digest to 8ade135>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2799?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2799?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>Patch and project coverage have no change.</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/18caaf92dccb2f5d0d95fa862f728c3c362e4454?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/18caaf92dccb2f5d0d95fa862f728c3c362e4454?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>18caaf9</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2799?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2799?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>e7f8b17</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2799 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2799?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-23 15:49:43
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2801#issuecomment-1732426157">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2801?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2801?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>Patch and project coverage have no change.</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/1b633713d5189e09086b8846267e55d25d7b9132?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/1b633713d5189e09086b8846267e55d25d7b9132?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>1b63371</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2801?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2801?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>c6d3edd</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2801 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2801?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-25 15:44:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/1515#issuecomment-1734564252">Comment</a> on issue by <a href="https://github.com/fgolygo">fgolygo</a>
<p>hey <a href="https://github.com/timtebeek">@timtebeek</a> and <a href="https://github.com/mpkorstanje">@mpkorstanje</a><br />
4 years passed. Did anything change regarding displaying parallel test logs correctly?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-27 12:10:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2802#issuecomment-1737938543">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You don't appear to be using a data table in your feature file. Is that intentional?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-27 12:38:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2802#issuecomment-1737970748">Comment</a> on issue by <a href="https://github.com/Pancor">Pancor</a>
<p>Yup, I'm assuming that I can use <code>@DataTableType</code> with just a <code>String</code> in <code>**.feature</code> files. Or am I missing something from docs and I'm not supposed to do that?</p>
<p>EDIT.<br />
Ahhhhh I think I know where are You going with this. <code>@DataTableType</code> should be only used with data table in <code>**.feature</code> files and to accomplish what i meant to do is to use <code>@ParameterType</code> like in the second scenario in sample project I provided? If that's so, then maybe it's a little bit shame that it cannot be achieved with <code>@DataTableType</code>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-27 14:20:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2802#issuecomment-1738093863">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>That's correct.</p>
<p>They're fundamentally different systems. Parameter types have a name and pattern, data tables types don't. So using one for the other won't work.</p>
<p>But you can annotate a single method multiple times.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-30 00:05:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2804#discussion_r1341921190">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Missing 't' on line 149: "he" -> "the"</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-09-29 10:51:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2785#issuecomment-1741281038">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Thanks <a href="https://github.com/mlvandijk">@mlvandijk</a> . Took me a while to get around to this.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-11 09:27:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2806#issuecomment-1758065406">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2806?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2806?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b4c903ce03817919d2e5d9d001a785a9517c573f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b4c903ce03817919d2e5d9d001a785a9517c573f?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>b4c903c</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2806?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2806?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>568d172</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2806 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2806?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-10 17:18:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2807#issuecomment-1756494829">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-10 17:24:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2807#issuecomment-1756500989">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2807?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2807?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/8eab5c9a37b09117431700ca7ce94d3597097a76?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/8eab5c9a37b09117431700ca7ce94d3597097a76?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>8eab5c9</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2807?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2807?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>1f5b074</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2807 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2807?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-12 21:12:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2808#issuecomment-1760745907">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-12 21:20:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2808#issuecomment-1760758037">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2808?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2808?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/79b04be679d234fdac959e8a8fe1192b649063da?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/79b04be679d234fdac959e8a8fe1192b649063da?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>79b04be</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2808?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2808?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>c8182ec</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2808 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2808?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 04:46:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2809#issuecomment-1761382348">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers. Could you also add the <code>wrapperSha256Sum</code>?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 04:50:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2809#issuecomment-1761387166">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2809?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/79b04be679d234fdac959e8a8fe1192b649063da?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/79b04be679d234fdac959e8a8fe1192b649063da?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>79b04be</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2809?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2809?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>b8639fd</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2809 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2809?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 04:54:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2809#issuecomment-1761392879">Comment</a> on pull request by <a href="https://github.com/bmscomp">bmscomp</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> I'll give it and try and check the ci after that</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 05:19:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2809#issuecomment-1761423913">Comment</a> on pull request by <a href="https://github.com/bmscomp">bmscomp</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> I think there is an issue with the maven wrapper validation in Maven, better to roll back the last change the time that will be fixed on maven</p>
<pre><code>Get-FileHash : The term 'Get-FileHash' is not recognized as the name of a cmdlet, function, script file, or operable
program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:13
+ &amp;{ $hash = (Get-FileHash "D:\a\cucumber-jvm\cucumber-jvm\.mvn\wrapper ...
+ ~~~~~~~~~~~~
+ CategoryInfo : ObjectNotFound: (Get-FileHash:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException
Error: Failed to validate Maven wrapper SHA-256, your Maven wrapper might be compromised.
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 05:41:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2809#issuecomment-1761453984">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Where did you find the hash for <code>maven-wrapper.jar</code>?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 05:46:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2809#issuecomment-1761462244">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Ah. No, nevermind. It is the Windows builds that fail.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 05:49:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2809#issuecomment-1761466112">Comment</a> on pull request by <a href="https://github.com/bmscomp">bmscomp</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> it's the failure is related to windows build, it can be an issue of maven on windows or an issue of github actions when it comes to use a windows operating system to build</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 05:53:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2809#issuecomment-1761472541">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Reading these two</p>
<p>• <a href="https://github.com/actions/runner-images/issues/225">actions/runner-images#225</a>
• <a href="https://github.com/PowerShell/PowerShell/issues/18108">PowerShell/PowerShell#18108</a></p>
<p>It looks like Powershel broke it.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 05:56:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2809#issuecomment-1761476735">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Good enough for now. Cheers!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-13 09:55:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2810#issuecomment-1761821296">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2810?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2810?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/db1ba2ebdf014a0befedc3db19e788132d40cdf7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/db1ba2ebdf014a0befedc3db19e788132d40cdf7?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>db1ba2e</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2810?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2810?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>22330cc</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2810 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2810?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-16 14:31:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2811#issuecomment-1765309671">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-20 06:15:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2811#issuecomment-1772722174">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2811?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2811?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/bd9d39f3f0284fa52556edc8ebd981fea2759d08?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/bd9d39f3f0284fa52556edc8ebd981fea2759d08?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>bd9d39f</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2811?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2811?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>f10d64c</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2811 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2811?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-16 18:50:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2812#issuecomment-1765527852">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-16 18:56:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2812#issuecomment-1765532888">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2812?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2812?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/c82382e31d7b4c8ad2292a24cfbc153625b4d343?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/c82382e31d7b4c8ad2292a24cfbc153625b4d343?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>c82382e</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2812?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2812?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>6c26ab3</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2812 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2812?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-22 13:30:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2767#issuecomment-1774191657">Comment</a> on pull request by <a href="https://github.com/jkronegg">jkronegg</a>
<p>I removed all mockito usages. I'm happy with the performance improvement on interactive tests, but a bit puzzled by having the same build duration with or without mockito when doing a maven clean+install.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-25 09:12:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2813#issuecomment-1779617643">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers.</p>
<p>Both these affect the <code>timeline</code> plugin which produces a html report with a timeline. The html report uses the affected JavaScript files.</p>
<p>Looks like <a href="https://github.com/advisories/GHSA-8hfj-j24r-96c4">CVE-2022-24785</a> is only applicable to node.js. <a href="https://github.com/advisories/GHSA-wc69-rhjr-hc9g">CVE-2022-31129</a> applies to user supplied dates which isn't the case for the timeline plugin.</p>
<p>This issue may eventually be fixed but it doesn't look urgent.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-09 13:29:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2813#issuecomment-1804713584">Comment</a> on issue by <a href="https://github.com/jkronegg">jkronegg</a>
<p>Moreover, as Cucumber is mainly used as a test framework, it is not included in the production code. Thus it would be difficult to exploit these security flaws. And if it's affect the reports generated by the plugin, it's only when you use the plugin that you have security risks. So I agree, it's not very urgent.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-23 12:44:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2814#issuecomment-1775908450">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Unfortunately you haven't provided enough information to reproduce the problem. Perhaps you could clone the <a href="https://github.com/cucumber/cucumber-java-skeleton">https://github.com/cucumber/cucumber-java-skeleton</a> and create a minimal reproducer for your problem based of that.</p>
<p>That said, at a glance it looks like you are sharing your <code>Scenario</code> object between scenarios. If this is the case, it would be a programming error. An error that started to matter in Cucumber v4 with the introduction of parallel execution.</p>
<p>There are a few ways this might happen. One would be to assign the <code>Scenario</code> to a global variable. For example:</p>
<p><a href="https://github.com/cucumber/cucumber-java-skeleton">https://github.com/cucumber/cucumber-java-skeleton</a></p>
<pre><code>package io.cucumber.skeleton;
import io.cucumber.java.Before;
import io.cucumber.java.Scenario;
import io.cucumber.java.en.Given;
public class StepDefinitions {
private static Scenario scenario;
@Before
public void setup(Scenario scenario) {
if (StepDefinitions.scenario == null) {
StepDefinitions.scenario = scenario;
}
}
@Given("I have {int} cukes in my belly")
public void I_have_cukes_in_my_belly(int cukes) {
scenario.log("Hello world"); // This will throw when executing a second scenario
}
...
}
</code></pre>
<p>But if you're using a DI framework such as Spring or Guice you can do something similar by assigning the <code>Scenario</code> object to an object in the DI context that is shared between scenarios.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-26 01:59:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2814#issuecomment-1780700507">Comment</a> on issue by <a href="https://github.com/sanketparopate">sanketparopate</a>
<p>Thank you <a href="https://github.com/mpkorstanje">@mpkorstanje</a> for pointing out sharing of scenario object sharing. It was a programing error and I have implemented a suitable solution.<br />
Thank you,<br />
Sanket</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-23 18:43:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2815#issuecomment-1776332872">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-10-23 18:50:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2815#issuecomment-1776347250">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2815?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2815?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/785548532b0fbbb974aeab6e58c50bb717d7f67f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/785548532b0fbbb974aeab6e58c50bb717d7f67f?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>7855485</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2815?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2815?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>79f8227</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2815 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2815?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-15 17:12:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2816#issuecomment-1813562046">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-15 17:18:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2816#issuecomment-1813572823">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2816?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/dc1430ed07cada613e2ae51e42a531650f6b0cd1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/dc1430ed07cada613e2ae51e42a531650f6b0cd1?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>dc1430e</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2816?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>daa6790</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2816 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2816?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-16 13:36:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2817#issuecomment-1815353192">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-16 13:42:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2817#issuecomment-1815360103">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2817?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2817?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/5e24b1da51fe1fff6a277201340765f90cf39f16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/5e24b1da51fe1fff6a277201340765f90cf39f16?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>5e24b1d</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2817?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2817?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>8516745</code>)> 84.99%.<br />
> Report is 1 commits behind head on main.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2817 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2727 2727
=========================================
Files 331 331
Lines 9542 9542
Branches 915 915
=========================================
Hits 8110 8110
Misses 1108 1108
Partials 324 324
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2817?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-22 09:14:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2780#issuecomment-1823176479">Comment</a> on issue by <a href="https://github.com/leonard84">leonard84</a>
<p>If anyone is interested you can find the plugins over at <a href="https://github.com/gradle/cucumber-companion">https://github.com/gradle/cucumber-companion</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-25 09:07:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2796#issuecomment-1826378976">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Note to self. Currently these don't converge with their messages version. Also needs a new release of <a href="https://github.com/cucumber/cucumber-junit-xml-formatter">https://github.com/cucumber/cucumber-junit-xml-formatter</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-26 23:32:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2820#issuecomment-1827269408">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-26 23:38:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2820#issuecomment-1827276078">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2820?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2820?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/170c3d6eacf512505e03059faca2790ee61b34b6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/170c3d6eacf512505e03059faca2790ee61b34b6?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>170c3d6</code>)> 84.95% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2820?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2820?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>8430cd5</code>)> 84.95%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2820 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9539 9539
Branches 916 916
=========================================
Hits 8104 8104
Misses 1110 1110
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2820?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-11-29 09:30:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2821#issuecomment-1832390634">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2821?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2821?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/1a6c5a6052ce1354cb34731c75a29991b9d06818?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/1a6c5a6052ce1354cb34731c75a29991b9d06818?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>1a6c5a6</code>)> 84.95% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2821?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2821?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>56fc24e</code>)> 84.95%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2821 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9539 9539
Branches 916 916
=========================================
Hits 8104 8104
Misses 1110 1110
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2821?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-01 08:55:18
*Thread Reply:*
New comment on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-01 08:55:18
*Thread Reply:*
Reviewed and changes requested by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/RugvedB">RugvedB's</a> pull request
<p>Hi, thanks for discovering and offering to fix this.</p>
<p>The suggested fix is more complicated than needed and also incorrect. Json and Ndjson are different formats. See <a href="https://ndjson.org/">https://ndjson.org/</a> for more information.</p>
<p>As a general pointer I would suggest declaring the expected ndjson as an array of strings, and splitting the actual ndjson into an array of strings. You can then compare the elements of this array using <code>JSONAssert.assertEquals</code>.</p>
<p>Unfortunately I do not have more time available to coach you on a better solution.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-01 08:55:19
*Thread Reply:*
New comment on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-01 10:22:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2822#issuecomment-1836577372">Comment</a> on pull request by <a href="https://github.com/RugvedB">RugvedB</a>
<p>> Hi, thanks for discovering and offering to fix this.
>
> The suggested fix is more complicated than needed and also incorrect. Json and Ndjson are different formats. See <a href="https://ndjson.org/">https://ndjson.org/</a> for more information.
>
> As a general pointer I would suggest declaring the expected ndjson as an array of strings, and splitting the actual ndjson into an array of strings. You can then compare the elements of this array using <code>JSONAssert.assertEquals</code>.
>
> Unfortunately I do not have more time available to coach you on a better solution.</p>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> Thank you so much for your reply. Your comment helped me understand why my solution is more complicated than required. After going through your suggestion, I believe I have come up with a better solution as suggested. I may be wrong and thus, whenever you get time can you please take a look at the code before I push the changes to the PR?</p>
<p>Here, I converted both expectedJson and ndjson to arrays. Each element of array is JSON and I compare them using <code>JSONAssert.assertEquals</code>. Please feel free to let me know if its incorrect. I will surely work on fixing the solution if there are more issues with the it.</p>
<pre><code> String ndjson = new String(bytes.toByteArray(), UTF_8);
String expectedJson = "" +
"{\"testRunStarted\":{\"timestamp\":{\"seconds\":10,\"nanos\":0}}}\n" +
"{\"testRunFinished\":{\"success\":true,\"timestamp\":{\"seconds\":15,\"nanos\":0}}}\n";
String[] ndjsonArray = ndjson.split("\\n");
String[] expectedArray = expectedJson.split("\\n");
for (int i = 0; i &lt; ndjsonArray.length; i++) {
JSONAssert.assertEquals(expectedArray[i], ndjsonArray[i], JSONCompareMode.LENIENT);
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-01 12:45:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2822#issuecomment-1836752997">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>That looks reasonable but please provide your suggestions as a commit. Note that to improve readability you can use shortcut syntax to create and initialize an array for the expected ndjson.</p>
<p><a href="https://docs.oracle.com/javase/tutorial/java/nutsandbolts/arrays.html">https://docs.oracle.com/javase/tutorial/java/nutsandbolts/arrays.html</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-01 13:11:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2822#issuecomment-1836782934">Comment</a> on pull request by <a href="https://github.com/RugvedB">RugvedB</a>
<p>> That looks reasonable but please provide your suggestions as a commit. Note that to improve readability you can use shortcut syntax to create and initialize an array for the expected ndjson.
>
> <a href="https://docs.oracle.com/javase/tutorial/java/nutsandbolts/arrays.html">https://docs.oracle.com/javase/tutorial/java/nutsandbolts/arrays.html</a></p>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> Thanks you for your guidance. I have pushed the changes. Feel free to let me know if further steps need to be taken to make it perfect. Also, let me know if you want me to squash the commits into 1 commit. Thanks for your time.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-03 09:00:40
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/RugvedB">RugvedB's</a> pull request
<p>Cheers! This looks good. I've pushed a few cosmetic changes on your branch.</p>
<p>It's not necessary to to put the name of the type into a variable. The type is right in front of it. Also I used static imports to keep the code a bit more succinct. Also used the compare mode <code>STRICT</code>, I think you may have misinterpreted the documentation around <code>LENIENT</code> as it does not check field, but array ordering.</p>
<p>Squashing won't be necessary. It's the default mode for merging in this Git repo.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-03 09:02:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2822#issuecomment-1837539610">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2822?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2822?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/1a6c5a6052ce1354cb34731c75a29991b9d06818?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/1a6c5a6052ce1354cb34731c75a29991b9d06818?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>1a6c5a6</code>)> 84.95% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2822?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2822?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>f7b7fd0</code>)> 84.95%.<br />
> Report is 3 commits behind head on main.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2822 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9539 9539
Branches 916 916
=========================================
Hits 8104 8104
Misses 1110 1110
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2822?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-03 09:03:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2822#issuecomment-1837539897">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/RugvedB">@RugvedB</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-01 08:29:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2823#issuecomment-1836418832">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2823?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2823?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/1a6c5a6052ce1354cb34731c75a29991b9d06818?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/1a6c5a6052ce1354cb34731c75a29991b9d06818?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>1a6c5a6</code>)> 84.95% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2823?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2823?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>015f4b7</code>)> 84.95%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2823 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9539 9539
Branches 916 916
=========================================
Hits 8104 8104
Misses 1110 1110
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2823?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-01 08:29:50
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/skuzzle">skuzzle's</a> pull request
<p>Cheers!</p>
<p>I would consider this a full fledged alternative to using the Suite Engine and the Console Launcher - that it also happens to use the Suite Engine is an implementation detail. So I've moved the list of workarounds.</p>
<p>I'm happy to merge as is, I'll merge this if you are too.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-03 22:18:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2823#issuecomment-1837910608">Comment</a> on pull request by <a href="https://github.com/skuzzle">skuzzle</a>
<p>Like it! 🚀</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-04 05:11:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2823#issuecomment-1838617889">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/skuzzle">@skuzzle</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-01 08:43:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2824#issuecomment-1836440681">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-03 08:49:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2824#issuecomment-1837536085">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2824?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/acc785013a9e6b90b2d02ae92e8942ac193a9a02?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/acc785013a9e6b90b2d02ae92e8942ac193a9a02?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>acc7850</code>)> 84.95% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2824?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>b63459f</code>)> 84.95%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2824 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9539 9539
Branches 916 916
=========================================
Hits 8104 8104
Misses 1110 1110
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2824?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-03 08:54:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2825#issuecomment-1837537573">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2825?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2825?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/d53c2a6a8dd40980fce121496ed4f85c2ba7f1d4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/d53c2a6a8dd40980fce121496ed4f85c2ba7f1d4?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>d53c2a6</code>)> 84.95% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2825?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2825?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>99d24da</code>)> 84.95%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2825 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9539 9539
Branches 916 916
=========================================
Hits 8104 8104
Misses 1110 1110
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2825?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-03 09:08:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2826#issuecomment-1837541123">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2826?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2826?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/42dbaee6278ab173e1ed70638f95a7373581c7d3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/42dbaee6278ab173e1ed70638f95a7373581c7d3?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>42dbaee</code>)> 84.95% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2826?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2826?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>4ce22e9</code>)> 84.95%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2826 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9539 9539
Branches 916 916
=========================================
Hits 8104 8104
Misses 1110 1110
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2826?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-03 22:05:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-java-skeleton/issues/62#issuecomment-1837898593">Comment</a> on issue by <a href="https://github.com/jakkambusyqa">jakkambusyqa</a>
<p>> If you guys are getting message "0 Scenario 0 Steps" with "You are using deprecated Main class. Please use io.cucumber.core.cli.Main" , just check scenario syntax in the feature file such as Scenario: (colon without white space) and only one white space after Given, And, Then. It's not main class issue, just syntax of feature file issue.</p>
<p>GoodOne Helpful.</p>
<a href="https://github.com/cucumber/cucumber-java-skeleton">cucumber/cucumber-java-skeleton</a>
GitHub
2023-12-04 02:31:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2805#issuecomment-1838258773">Comment</a> on issue by <a href="https://github.com/emaks">emaks</a>
<p>is there any way to rerun failed tests with junit5?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-04 10:24:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2805#issuecomment-1839222441">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>To rerun failed scenarios please review <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine#rerunning-failed-scenarios">https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-junit-platform-engine#rerunning-failed-scenarios</a>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-04 10:41:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2805#issuecomment-1839251550">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>While it would be possible to implement a JUnit Engine that executes <code>rerun.txt</code> files, the JUnit 5 Platform does not support ordering test engines. So there is no guarantee that such a <code>cucumber-rerun</code> engine will be invoked after the <code>cucumber</code> engine.</p>
<p>Additionally JUnit 5 somewhat implicitly expects that test execution does not change the tests that could be discovered. While it may be possible with the current state of Surefire and Gradle to ignore that, it could cause all sorts of janky behavior when the JUnit API is used as intended.</p>
<p>More jank than I'm willing to accommodate for.</p>
<p>If this is a major impediment to you, I reckon that you or your company can either petition Gradle and/or Surefire for better JUnit 5 support or materially contribute to that support in some way.</p>
<p>Alternatively, if some one is able to convince the JUnit 5 team to accept a PR that makes it possible order test engines and and willing to commit to dealing with all the jank that comes from implementing <code>cucumber-rerun</code>, I would be willing to accept that too.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-05 00:00:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2827#issuecomment-1840201568">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2827?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/854394d31b2bc5f55c597cf0e6943760558a0356?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/854394d31b2bc5f55c597cf0e6943760558a0356?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>854394d</code>)> 84.95% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2827?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2827?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>46c0a3a</code>)> 84.95%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2827 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 2724 2724
=========================================
Files 331 331
Lines 9539 9539
Branches 916 916
=========================================
Hits 8104 8104
Misses 1110 1110
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2827?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-08 10:42:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2827#issuecomment-1847657910">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I can see how Cucable allows users to work around the lack of support for JUnit 5 in Maven by generating suite classes. But most examples use JUnit 4. Do you think you could update the documentation of Cucable to include how it works with JUnit 5?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-11 02:47:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2827#issuecomment-1849808881">Comment</a> on pull request by <a href="https://github.com/bischoffdev">bischoffdev</a>
<p>That makes sense, I will add this soon.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-11 11:12:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2827#issuecomment-1850718832">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers. Then lets not block this.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-10 10:47:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2828#issuecomment-1849047865">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Interesting. The changelog states that:</p>
<p>> The previous URL format of <code>jar:file:/dir/myjar.jar:BOOT-INF/lib/nested.jar!/com/example/MyClass.class</code> has been replaced with <code>jar:nested:/dir/myjar.jar/!BOOT-INF/lib/nested.jar!/com/example/MyClass.class</code>.</p>
<p>But looking at the tests I wrote for this, I would expect the original to be <code>jar:file:/dir/myjar.jar!/BOOT-INF/lib/nested.jar!/com/example/MyClass.class</code>. A typo?</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/blob/3ae7af56c92d970b5b240b2bbd81cea9c5125058/cucumber-core/src/test/java/io/cucumber/core/resource/ResourceScannerTest.java#L162C1-L186">https://github.com/cucumber/cucumber-jvm/blob/3ae7af56c92d970b5b240b2bbd81cea9c5125058/cucumber-core/src/test/java/io/cucumber/core/resource/ResourceScannerTest.java#L162C1-L186</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-10 11:04:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2828#issuecomment-1849052571">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Looking at this part of the stack trace</p>
<pre><code>Caused by: java.lang.IllegalArgumentException: 'path' must contain '/!'
at org.springframework.boot.loader.net.protocol.nested.NestedLocation.parse(NestedLocation.java:98) ~[cucumber-spring-boot-3.2.0-0.0.1-SNAPSHOT.jar:0.0.1-SNAPSHOT]
at org.springframework.boot.loader.net.protocol.nested.NestedLocation.fromUri(NestedLocation.java:89) ~[cucumber-spring-boot-3.2.0-0.0.1-SNAPSHOT.jar:0.0.1-SNAPSHOT]
at org.springframework.boot.loader.nio.file.NestedFileSystemProvider.getPath(NestedFileSystemProvider.java:88) ~[cucumber-spring-boot-3.2.0-0.0.1-SNAPSHOT.jar:0.0.1-SNAPSHOT]
</code></pre>
<p>It looks like Spring Boot 3.2 provides its own file system for handling <code>jar:nested</code> uris. So ideally we treated it as a "regular jar scheme" and come up with a better discriminator for Spring Boot < 2.3 and regular uris + Spring Boot >= 2.3.</p>
<p>Because I don't think the current check is very robust:</p>
<pre><code> String[] parts = uri.toString().split(JAR_URI_SEPARATOR);
// Regular jar schemes
if (parts.length &lt;= 2) {
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-10 11:30:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2828#issuecomment-1849059315">Comment</a> on issue by <a href="https://github.com/ljpengelen">ljpengelen</a>
<p>I'm using the following in <a href="https://github.com/cucumber/cucumber-jvm/pull/2829">#2829</a></p>
<pre><code>String uriAsString = uri.toString();
// Spring Boot jar scheme since 3.2.0
if (uriAsString.startsWith("jar:nested")) {
int indexOfLastSeparator = uriAsString.lastIndexOf(JAR_URI_SEPARATOR);
String jarUri = uriAsString.substring(0, indexOfLastSeparator);
String jarPath = uriAsString.substring(indexOfLastSeparator + 1);
return open(new URI(jarUri), fileSystem -&gt; fileSystem.getPath(jarPath));
}
</code></pre>
<p>It works, but I don't know if this is the robustness you're looking for.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-10 12:12:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2828#issuecomment-1849070075">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I was thinking about something more robust indeed.</p>
<p>Your pull request made me realize that the current URI parsing is incorrect. The jar uri format is:</p>
<pre><code>jar:&lt;url&gt;!/[&lt;entry&gt;]
</code></pre>
<p>And being a recursive format, the current implementation will never parse it correctly. So while checking for <code>"jar:nested"</code> would solve the case for Spring, it doesn't make the existing code correct. I would like to imagine that had I correctly implemented the the current url parsing and not implemented <a href="https://github.com/cucumber/cucumber-jvm/pull/1821">#1821</a>, this change from Spring could have gone unnoticed.</p>
<p>That said, I found this "specification" on <a href="https://www.iana.org/assignments/uri-schemes/prov/jar">https://www.iana.org/assignments/uri-schemes/prov/jar</a>, I'd really like a more authoritative specification. 😄</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-10 15:07:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2828#issuecomment-1849118120">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Okay. I think I've got something I'm reasonably happy with. I appreciate the reproducer, having that saved a lot of time.</p>
<p>Though it is nothing though that actually scanning nested jars in Spring still doesn't work. But that seems to be on Spring Boots end. Scanning regular files works with this fix.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-10 15:07:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2830#issuecomment-1849118152">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2830?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2830?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>Attention: <code>2 lines</code> in your changes are missing coverage. Please review.</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/3ae7af56c92d970b5b240b2bbd81cea9c5125058?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/3ae7af56c92d970b5b240b2bbd81cea9c5125058?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>3ae7af5</code>)> 84.95% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2830?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2830?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>bea8cca</code>)> 84.97%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2830 +/- ##
============================================
+ Coverage 84.95% 84.97% +0.01%
- Complexity 2724 2728 +4
============================================
Files 331 331
Lines 9539 9545 +6
Branches 916 917 +1
============================================
+ Hits 8104 8111 +7
+ Misses 1110 1109 -1
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2830?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-13 01:34:06
*Thread Reply:*
Review comment by <a href="https://github.com/mlvandijk">mlvandijk</a> on <a href="https://github.com/mpkorstanje">mpkorstanje's</a> pull request
<p>Small suggestions on the text.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-13 01:34:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2832#discussion_r1425084740">Comment</a> on pull request by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>Suggested change</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-13 01:34:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2832#discussion_r1425085772">Comment</a> on pull request by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>Suggested change</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-13 01:34:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2832#discussion_r1425085028">Comment</a> on pull request by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>Suggested change</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-13 01:34:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2832#discussion_r1425085448">Comment</a> on pull request by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>Suggested change</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-13 04:04:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2832#discussion_r1425260503">Comment</a> on pull request by <a href="https://github.com/mlvandijk">mlvandijk</a>
<p>If there is an issue logged with Maven, it might be good to mention (the link to) that here?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-15 15:07:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2832#issuecomment-1858592609">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Thanks Marit!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-14 05:58:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2833#issuecomment-1855903026">Comment</a> on issue by <a href="https://github.com/boaty82">boaty82</a>
<p>I can create a pull request if so desired as it is quite a simple change to do with the relevant tests too</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-14 06:30:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2833#issuecomment-1855956155">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> Having setup multiple scenarios, and having added cucumber.execution.threads=2 to properties file I expected tests to run in parallel</p>
<p>I think there is a mismatched expectation here.</p>
<p>The <code>--threads</code> option is only supported when running Cucumber through the CLI. The JUnit 4, JUnit 5, TestNG modules each do parallel execution differently. It only is a historical accident the that the CLI is included in the core module.</p>
<p>So I'm not sure what a <code>cucumber.execution.threads</code> property would accomplish. Besides making people wonder why it doesn't make their tests run in parallel when not using the CLI.</p>
<p>Could you elaborate on the benefit of using the property over the CLI option?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-14 07:12:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2833#issuecomment-1856031203">Comment</a> on issue by <a href="https://github.com/boaty82">boaty82</a>
<p>by having the properties file support it, then running via gradle and other build systems you can merely use <code>cucumber.properties</code> - whereas if you want to use this then you also have to put some stuff into CLI args</p>
<p>would be nice to use one of the other, and I know you can purely use CLI, but it just seems nicer to have this in properties files as then in spring boot you can use profile property files too</p>
<p>but as you state, and I did not consider, TestNG and others it would then be confusing</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-14 10:17:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2833#issuecomment-1856357326">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Okay that sounds reasonable. Please do feel free to send a pull request. The documentation should include a note that the property is only used by the CLI. Do note that the documentation for properties is duplicated in a few places.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-15 18:14:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2834#issuecomment-1858682261">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You've made a screenshot of your problem. Unfortunately, it's rather hard to copy text from a screenshot. Could you provide the text of your step definitions and feature files?</p>
<p>Please use <a href="https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax">Githubs Markdown formatting</a> code blocks to keep it readable.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-15 18:21:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2834#issuecomment-1858684205">Comment</a> on issue by <a href="https://github.com/Francisco-Brito">Francisco-Brito</a>
<p>My feature file</p>
<pre><code># language: es
# encoding: utf8
@Test
Característica: Estado de cuenta
Escenario: Descargar estado de cuenta
Cuando Se navega al módulo de estado de cuenta
Y Se selecciona el periodo actual
Entonces Se descarga el estado de cuenta
</code></pre>
<p>My step definition</p>
<pre><code>package steps;
import io.cucumber.java.es.**;
import pages.MenuPage;
import pages.PromotionsPage;
public class AccountStateSteps {
@Cuando("^Se navega al módulo de estado de cuenta$")
public void showPromotionDetails() {
}
@Y("^Se selecciona el periodo actual$")
public void showPromotionDetails2() {
}
@Entonces("^Se descarga el estado de cuenta$")
public void assertPromotionDetails() {
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-15 18:27:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2834#issuecomment-1858685574">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Mmmh. I can't reproduce the problem. Executing the scenario with that feature and those step definitions works fine.</p>
<p>Could you create a reproducer using the <a href="https://github.com/cucumber/cucumber-java-skeleton">https://github.com/cucumber/cucumber-java-skeleton</a> as a baseline?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-18 19:55:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2836#issuecomment-1862076415">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2836?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b931ac54ba3126b6f1445e7a9155e4fd7982295e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/b931ac54ba3126b6f1445e7a9155e4fd7982295e?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>b931ac5</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2836?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2836?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>ed4f9ba</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2836 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2732 2732
=========================================
Files 331 331
Lines 9554 9554
Branches 918 918
=========================================
Hits 8120 8120
Misses 1109 1109
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2836?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-20 06:32:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2343#issuecomment-1864575882">Comment</a> on issue by <a href="https://github.com/ntthaibk">ntthaibk</a>
<p>hi <a href="https://github.com/mpkorstanje">@mpkorstanje</a>, I'm just stumble upon this and find out we can indeed parse docstringtype into different object type, not just JsonNode, somehow, in our docs on typeregistry doesn't mention it, <a href="https://cucumber.io/docs/cucumber/configuration/?lang=java">https://cucumber.io/docs/cucumber/configuration/?lang=java</a>, do you think it's ok to add some documentation on it. I can try to update it if you are ok with it</p>
<p>Thanks and have a nice day</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-20 07:06:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2343#issuecomment-1864632305">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Sure! I'd be happy to look at a proposal.</p>
<p>Perhaps you could start with this page <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-java#docstring-type">https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-java#docstring-type</a> and then reference that from the docs site. It's a bit easier to keep the docs up to date if they're closer to the source code.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-23 23:41:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2838#issuecomment-1868454106">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-23 23:46:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2838#issuecomment-1868454702">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2838?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/55fbdee49d627d866bf91d3d7721749f0c136dfe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/55fbdee49d627d866bf91d3d7721749f0c136dfe?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>55fbdee</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2838?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2838?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>e04cae7</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2838 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2732 2732
=========================================
Files 331 331
Lines 9554 9554
Branches 918 918
=========================================
Hits 8120 8120
Misses 1109 1109
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2838?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-26 04:21:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2839#issuecomment-1869506174">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-26 04:25:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2839#issuecomment-1869509062">Comment</a> on pull request by <a href="https://github.com/apps/codecov">codecov[bot]</a>
<p><strong><a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|Codecov">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2839?src=pr&el=h1&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm_term=cucumber|Codecov</a> Report</strong></p>
<p>All modified and coverable lines are covered by tests ✅</p>
<p>> Comparison is base <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/9011c2291045aea88ce2208ce4fcc1157b9b663b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/commit/9011c2291045aea88ce2208ce4fcc1157b9b663b?el=desc&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|(<code</a>9011c22</code>)> 84.99% compared to head <a href="https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2839?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cucumber|(<code">https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2839?src=pr&el=desc&utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|(<code</a>a3595fd</code>)> 84.99%.</p>
<p>Additional details and impacted files</p>
<pre><code>@@ Coverage Diff @@
## main #2839 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2732 2732
=========================================
Files 331 331
Lines 9554 9554
Branches 918 918
=========================================
Hits 8120 8120
Misses 1109 1109
Partials 325 325
</code></pre>
<p><https://app.codecov.io/gh/cucumber/cucumber-jvm/pull/2839?src=pr&el=continue&utm<em>medium=referral&utm</em>source=github&utm<em>content=comment&utm</em>campaign=pr+comments&utm<em>term=cucumber|☔ View full report in Codecov by Sentry>.<br />
📢 Have feedback on the report? <https://about.codecov.io/codecov-pr-comment-feedback/?utm</em>medium=referral&utm<em>source=github&utm</em>content=comment&utm<em>campaign=pr+comments&utm</em>term=cucumber|Share it here>.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-04 04:48:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2839#issuecomment-1877044100">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-28 05:50:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2840#issuecomment-1871195746">Comment</a> on issue by <a href="https://github.com/sumitsg004">sumitsg004</a>
<p>Hi David, I am using CucumberJs only to run playwright scripts</p>
<pre><code>let runCucumber = [
tags,
parallelThreads,
features, // Specify our feature files
'--require-module ts-node/register', // Load TypeScript module
'--require app-services/****/**.ts', // Load step definitions
'--format progress-bar', // Load custom formatter
'--format json:../build/results/cucumberPlaywright/json_results/cucumber-report.json'
].join(' ');
</code></pre>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-28 06:12:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2840#issuecomment-1871213087">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>cucumber-js is not invoked with Gradle. Do you have a custom task that is triggering cucumber-js in a new process?</p>
<p>Can you run cucumber-js with debug enabled so we can see the final resolved configuration? <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/debugging.md">https://github.com/cucumber/cucumber-js/blob/main/docs/debugging.md</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2023-12-30 08:56:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2841#issuecomment-1872564573">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Based on the information provided I could not reproduce the problem. Could you please fork <a href="https://github.com/cucumber/cucumber-java-skeleton">https://github.com/cucumber/cucumber-java-skeleton</a> and create the reproducer in there?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-10 09:27:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2841#issuecomment-1885292103">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Please feel free to reopen/recreate this issue with a usable reproducer.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-04 11:09:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2842#issuecomment-1877623717">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Branch automerge failure</strong></p>
<p>This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.</p>
<hr />
<p>• Branch has one or more failed status checks</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-05 06:00:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2843#issuecomment-1878714474">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Duplicate of <a href="https://github.com/cucumber/cucumber-jvm/issues/2805">#2805</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-05 06:18:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2843#issuecomment-1878754345">Comment</a> on issue by <a href="https://github.com/gorakshasabnis">gorakshasabnis</a>
<p><a href="https://github.com/mpkorstanje">@mpkorstanje</a> is there is any different documention on how exactly to run this class along with '@ suite' ?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-05 07:06:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2843#issuecomment-1878819483">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>For Maven you could use the exec Maven plugin and bind it to the test phase. You would not use the suite in this case, you're programatically running JUnit.</p>
<p><a href="https://www.mojohaus.org/exec-maven-plugin/">https://www.mojohaus.org/exec-maven-plugin/</a></p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-10 01:29:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2844#issuecomment-1884483425">Comment</a> on pull request by <a href="https://github.com/orcunbalcilar">orcunbalcilar</a>
<p>Hi, could you please have a look at this pr?</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-10 09:30:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2844#issuecomment-1885297005">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/orcunbalcilar">@orcunbalcilar</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-10 09:31:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2844#issuecomment-1885298468">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Cheers!</p>
<p>> Hi, could you please have a look at this pr?</p>
<p>Please do do be patient. This isn't a job.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-10 09:42:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/pull/2844#issuecomment-1885327352">Comment</a> on pull request by <a href="https://github.com/orcunbalcilar">orcunbalcilar</a>
<p>Sorry for bothering. I would be glad to see it had been merged. 🙂</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-30 09:06:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2845#issuecomment-1917503557">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>You can use <code>--glue</code>. And <code>--help</code> for more documentation.</p>
<p>There is no equivalent of <code>extraGlue</code>, the java doc on <a href="https://github.com/cucumber/cucumber-jvm/blob/main/cucumber-junit/src/main/java/io/cucumber/junit/CucumberOptions.java">CucumberOptions</a> should be sufficient to explain that.</p>
<p>Leaving this open because it looks like the <https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-core|cucumber-core<br />
>read me is missing a section about the CLI.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-30 10:03:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2845#issuecomment-1917605048">Comment</a> on issue by <a href="https://github.com/cj19">cj19</a>
<p>> You can use <code>--glue</code>. And <code>--help</code> for more documentation.
>
> There is no equivalent of <code>extraGlue</code>, the java doc on <a href="https://github.com/cucumber/cucumber-jvm/blob/main/cucumber-junit/src/main/java/io/cucumber/junit/CucumberOptions.java">CucumberOptions</a> should be sufficient to explain that.
>
> Leaving this open because it looks like the <a href="https://github.com/cucumber/cucumber-jvm/tree/main/cucumber-core">cucumber-core</a> read me is missing a section about the CLI.</p>
<p>Thanks for the links. To add more context, my main class looks like this:</p>
<pre><code>@RunWith(Cucumber.class)
@CucumberContextConfiguration
@ContextConfiguration(classes = { CitrusSpringConfig.class, KafkaEndpointConfiguration.class,
EndpointConfiguration.class })
@CucumberOptions(tags = "not @ignore",
features = "src/test/resources/features",
extraGlue = "org.citrusframework.yaks.standard",
plugin = { "pretty", "json:target/cucumber/cucumber.json",
"org.citrusframework.cucumber.CitrusReporter" })
public class RunIntegrationTests {
}
</code></pre>
<p>And i have no steps configuration, because as you can see I use the yaks library and further steps configuration is not needed in this project. Obviously running the integration tests using the class cause no problems, but I need a gradle config as well.</p>
<p>I added the</p>
<pre><code>'--glue', 'org.citrusframework.yaks.standard',
</code></pre>
<p>into the gradle run config and this was the error I got:</p>
<pre><code>Exception in thread "main" io.cucumber.core.exception.CompositeCucumberException: There were 2 exceptions. The details are in the stacktrace below.
at io.cucumber.core.runtime.RethrowingThrowableCollector.getThrowable(RethrowingThrowableCollector.java:57)
at io.cucumber.core.runtime.CucumberExecutionContext.getThrowable(CucumberExecutionContext.java:109)
at io.cucumber.core.runtime.CucumberExecutionContext.runFeatures(CucumberExecutionContext.java:155)
at io.cucumber.core.runtime.Runtime.run(Runtime.java:78)
at io.cucumber.core.cli.Main.run(Main.java:87)
at io.cucumber.core.cli.Main.main(Main.java:30)
Suppressed: io.cucumber.core.backend.CucumberBackendException: Please annotate a glue class with some context configuration.
For example:
@CucumberContextConfiguration
@SpringBootTest(classes = TestConfig.class)
public class CucumberSpringConfiguration { }
Or:
@CucumberContextConfiguration
@ContextConfiguration( ... )
public class CucumberSpringConfiguration { }
at io.cucumber.spring.SpringFactory.start(SpringFactory.java:102)
at org.citrusframework.cucumber.backend.spring.CitrusSpringObjectFactory.start(CitrusSpringObjectFactory.java:66)
at io.cucumber.core.runner.Runner.buildBackendWorlds(Runner.java:134)
at io.cucumber.core.runner.Runner.runPickle(Runner.java:70)
at io.cucumber.core.runtime.Runtime.lambda$executePickle$6(Runtime.java:107)
at io.cucumber.core.runtime.CucumberExecutionContext.lambda$runTestCase$5(CucumberExecutionContext.java:137)
at io.cucumber.core.runtime.RethrowingThrowableCollector.executeAndThrow(RethrowingThrowableCollector.java:23)
at io.cucumber.core.runtime.CucumberExecutionContext.runTestCase(CucumberExecutionContext.java:137)
at io.cucumber.core.runtime.Runtime.lambda$executePickle$7(Runtime.java:107)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at io.cucumber.core.runtime.Runtime$SameThreadExecutorService.execute(Runtime.java:235)
at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:123)
at io.cucumber.core.runtime.Runtime.lambda$runFeatures$3(Runtime.java:89)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.SliceOps$1$1.accept(SliceOps.java:200)
at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1602)
at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
at io.cucumber.core.runtime.Runtime.runFeatures(Runtime.java:90)
at io.cucumber.core.runtime.Runtime.lambda$run$0(Runtime.java:78)
at io.cucumber.core.runtime.CucumberExecutionContext.lambda$runFeatures$6(CucumberExecutionContext.java:148)
at io.cucumber.core.runtime.CucumberExecutionContext.execute(CucumberExecutionContext.java:163)
at io.cucumber.core.runtime.CucumberExecutionContext.runFeatures(CucumberExecutionContext.java:146)
... 3 more
Suppressed: io.cucumber.core.backend.CucumberBackendException: Please annotate a glue class with some context configuration.
For example:
@CucumberContextConfiguration
@SpringBootTest(classes = TestConfig.class)
public class CucumberSpringConfiguration { }
Or:
@CucumberContextConfiguration
@ContextConfiguration( ... )
public class CucumberSpringConfiguration { }
</code></pre>
<p>I suppose the yaks standard library classes do not have the necessary annotations. I am not sure how can I tackle this problem. Any ideas are appreciated.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-30 11:18:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2845#issuecomment-1917725303">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>As the error explains, you'll need a class with these annotation somewhere on your glue path:</p>
<pre><code>@CucumberContextConfiguration
@ContextConfiguration(classes = { CitrusSpringConfig.class, KafkaEndpointConfiguration.class,
EndpointConfiguration.class })
</code></pre>
<p>Note that <code>--glue</code> can be repeated.</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>
GitHub
2024-01-30 11:32:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-jvm/issues/2845#issuecomment-1917745861">Comment</a> on issue by <a href="https://github.com/cj19">cj19</a>
<p>Understood. Now the task can be ran, but as I have no steps configuration (because I use yaks), thus the tests end with undefined step configuration results.</p>
<pre><code>2 Scenarios (2 undefined)
16 Steps (14 skipped, 2 undefined)
</code></pre>
<p>How can I integrate yaks steps into this task configuration in order to run the tests properly like I do it with the class config run?</p>
<p><strong>EDIT:</strong></p>
<p>I have figured it out:</p>
<pre><code>'--glue', my.project.library',
'--glue', 'org.citrusframework.yaks.standard',
</code></pre>
<p>Using multiple glue path configurations solved the problem. Thank you for help!</p>
<a href="https://github.com/cucumber/cucumber-jvm">cucumber/cucumber-jvm</a>